<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>212947</bug_id>
          
          <creation_ts>2020-06-08 19:13:36 -0700</creation_ts>
          <short_desc>[Win] ComplexTextControllerUniscribe: Retry ScriptShape with SCRIPT_UNDEFINED if it failed as USP_E_SCRIPT_NOT_IN_FONT</short_desc>
          <delta_ts>2020-06-09 12:55:20 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Text</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>achristensen</cc>
    
    <cc>bfulgham</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>mmaxfield</cc>
    
    <cc>pvollan</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1660544</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-06-08 19:13:36 -0700</bug_when>
    <thetext>[Win] ComplexTextControllerUniscribe: Retry ScriptShape with SCRIPT_UNDEFINED if it failed as USP_E_SCRIPT_NOT_IN_FONT

Displaying Text with Uniscribe
https://docs.microsoft.com/en-us/windows/win32/intl/displaying-text-with-uniscribe

&gt; 7. If ScriptShape returns the code USP_E_SCRIPT_NOT_IN_FONT or
&gt; S_OK with the output containing missing glyphs, select characters
&gt; from a different font. Either substitute another font or disable
&gt; shaping by setting the eScript member of the SCRIPT_ANALYSIS
&gt; structure passed to ScriptShape to SCRIPT_UNDEFINED. For more
&gt; information, see Using Font Fallback.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1660548</commentid>
    <comment_count>1</comment_count>
      <attachid>401410</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-06-08 19:25:58 -0700</bug_when>
    <thetext>Created attachment 401410
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1660550</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-06-08 19:27:21 -0700</bug_when>
    <thetext>It&apos;s easy to test this issue by opening a Tibetan page at the
moment because there is another bug in fallback font selection
for Tibetan characters (Bug 212688). However, if the bug is
fixed, I don&apos;t know how can this issue be tested.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1660806</commentid>
    <comment_count>3</comment_count>
      <attachid>401410</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-06-09 12:54:22 -0700</bug_when>
    <thetext>Comment on attachment 401410
Patch

Clearing flags on attachment: 401410

Committed r262804: &lt;https://trac.webkit.org/changeset/262804&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1660807</commentid>
    <comment_count>4</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-06-09 12:54:25 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1660809</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-06-09 12:55:18 -0700</bug_when>
    <thetext>&lt;rdar://problem/64175943&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1660810</commentid>
    <comment_count>6</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-06-09 12:55:20 -0700</bug_when>
    <thetext>&lt;rdar://problem/64175945&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>401410</attachid>
            <date>2020-06-08 19:25:58 -0700</date>
            <delta_ts>2020-06-09 12:54:22 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-212947-20200609112557.patch</filename>
            <type>text/plain</type>
            <size>2487</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTA4MjQ5NjdjZDY1OTk3
ZWE4NjlmNjBjMmVhYWEwMGMwYjY5ODU4NS4uZDI0MmJhNTYwNTQ1N2ZhZTFhMjIyZjkxZjAyNTVm
ZTA3MDI5YWJhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIwLTA2LTA4ICBGdWpp
aSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5dIENv
bXBsZXhUZXh0Q29udHJvbGxlclVuaXNjcmliZTogUmV0cnkgU2NyaXB0U2hhcGUgd2l0aCBTQ1JJ
UFRfVU5ERUZJTkVEIGlmIGl0IGZhaWxlZCBhcyBVU1BfRV9TQ1JJUFRfTk9UX0lOX0ZPTlQKKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjk0NworCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHRoZSBnaXZl
biBmb250IGRvZXNuJ3Qgc3VwcG9ydCB0aGUgZ2l2aW4gdGV4dCwgU2NyaXB0U2hhcGUgQVBJCisg
ICAgICAgIGZhaWxzIGFzIFVTUF9FX1NDUklQVF9OT1RfSU5fRk9OVC4gSW4gdGhlIGNhc2UsIHRo
ZSBjb21wbGV4IHJ1bgorICAgICAgICB3YXMgc2ltcGx5IGlnbm9yZWQgYW5kIG5vdGhpbmcgd2Fz
IGRyYXduIGZvciB0aGUgdGV4dC4KKworICAgICAgICBBY2NvcmRpbmcgdG8gVW5pc2NyaWJlIGRv
Y3VtZW50LCBXZSBzaG91bGQgcmV0cnkgU2NyaXB0U2hhcGUgd2l0aAorICAgICAgICBTQ1JJUFRf
VU5ERUZJTkVEIHRvIGdldCBtaXNzaW5nIGdseXBocy4KKyAgICAgICAgPGh0dHBzOi8vZG9jcy5t
aWNyb3NvZnQuY29tL2VuLXVzL3dpbmRvd3Mvd2luMzIvaW50bC9kaXNwbGF5aW5nLXRleHQtd2l0
aC11bmlzY3JpYmU+CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93aW4vQ29tcGxleFRl
eHRDb250cm9sbGVyVW5pc2NyaWJlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNoYXBlQnlVbmlz
Y3JpYmUpOgorCiAyMDIwLTA2LTA4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+
CiAKICAgICAgICAgW0lQQ10gQWRvcHQgZW51bSBjbGFzcyBmb3IgRHJhZ09wZXJhdGlvbgpkaWZm
IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvd2luL0NvbXBsZXhUZXh0
Q29udHJvbGxlclVuaXNjcmliZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj
cy93aW4vQ29tcGxleFRleHRDb250cm9sbGVyVW5pc2NyaWJlLmNwcAppbmRleCAxMmU2Mzk2ODNl
NDk4ZDE0NDExMDczMTg1NWVjYzY5ZjJjOTM5NzIxLi44MTIxYjkyYTk4OTMyNzg5ZTdlYTE4ZWY2
MTY0NjJmNDZlNTY5MTM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw
aGljcy93aW4vQ29tcGxleFRleHRDb250cm9sbGVyVW5pc2NyaWJlLmNwcAorKysgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vQ29tcGxleFRleHRDb250cm9sbGVyVW5pc2Ny
aWJlLmNwcApAQCAtMzQsNyArMzQsNyBAQAogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXN0YXRp
YyBib29sIHNoYXBlQnlVbmlzY3JpYmUoY29uc3QgVUNoYXIqIHN0ciwgaW50IGxlbiwgU0NSSVBU
X0lURU0gaXRlbSwgY29uc3QgRm9udCogZm9udERhdGEsCitzdGF0aWMgYm9vbCBzaGFwZUJ5VW5p
c2NyaWJlKGNvbnN0IFVDaGFyKiBzdHIsIGludCBsZW4sIFNDUklQVF9JVEVNJiBpdGVtLCBjb25z
dCBGb250KiBmb250RGF0YSwKICAgICBWZWN0b3I8V09SRD4mIGdseXBocywgVmVjdG9yPFdPUkQ+
JiBjbHVzdGVycywKICAgICBWZWN0b3I8U0NSSVBUX1ZJU0FUVFI+JiB2aXN1YWxBdHRyaWJ1dGVz
KQogewpAQCAtNjAsOCArNjAsMTEgQEAgc3RhdGljIGJvb2wgc2hhcGVCeVVuaXNjcmliZShjb25z
dCBVQ2hhciogc3RyLCBpbnQgbGVuLCBTQ1JJUFRfSVRFTSBpdGVtLCBjb25zdAogICAgICAgICAg
ICAgLy8gTmVlZCB0byByZXNpemUgb3VyIGJ1ZmZlcnMuCiAgICAgICAgICAgICBnbHlwaHMucmVz
aXplKGdseXBocy5zaXplKCkgKiAyKTsKICAgICAgICAgICAgIHZpc3VhbEF0dHJpYnV0ZXMucmVz
aXplKGdseXBocy5zaXplKCkpOwotICAgICAgICB9Ci0gICAgfSB3aGlsZSAoc2hhcGVSZXN1bHQg
PT0gRV9QRU5ESU5HIHx8IHNoYXBlUmVzdWx0ID09IEVfT1VUT0ZNRU1PUlkpOworICAgICAgICB9
IGVsc2UgaWYgKHNoYXBlUmVzdWx0ID09IFVTUF9FX1NDUklQVF9OT1RfSU5fRk9OVCkKKyAgICAg
ICAgICAgIGl0ZW0uYS5lU2NyaXB0ID0gU0NSSVBUX1VOREVGSU5FRDsKKyAgICAgICAgZWxzZQor
ICAgICAgICAgICAgYnJlYWs7CisgICAgfSB3aGlsZSAodHJ1ZSk7CiAKICAgICBpZiAoaGRjKQog
ICAgICAgICBTZWxlY3RPYmplY3QoaGRjLCBvbGRGb250KTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>