212942 2020-06-08 17:16:45 -0700 WebKitLegacy: Exclude NSURLConnectionSPI.h from watchOS 2020-07-06 13:48:56 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212718 https://bugs.webkit.org/show_bug.cgi?id=214004 InRadar P2 Normal --- 1 jbedard jbedard webkit-bug-importer wenson_hsieh oldest_to_newest 1660513 0 jbedard 2020-06-08 17:16:45 -0700 NSURLConnectionSPI.h is not needed to build watchOS. 1660514 1 webkit-bug-importer 2020-06-08 17:17:22 -0700 <rdar://problem/64141877> 1660519 2 401402 jbedard 2020-06-08 17:21:30 -0700 Created attachment 401402 Patch 1660557 3 ews-feeder 2020-06-08 20:24:38 -0700 Committed r262764: <https://trac.webkit.org/changeset/262764> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401402. 1667985 4 401402 wenson_hsieh 2020-07-01 10:07:23 -0700 Comment on attachment 401402 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401402&action=review > Source/WebKitLegacy/mac/Misc/WebDownload.h:36 > +#import <pal/spi/cocoa/NSURLConnectionSPI.h> Hm...is it safe to import PAL headers like this? I don't think PAL headers were intended to be imported by clients outside of WebKit, since they use WTF macros like USE(). However, this is an SPI header that could (in theory) be imported by any internal Apple clients... 1669140 5 401402 jbedard 2020-07-06 13:33:30 -0700 Comment on attachment 401402 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401402&action=review >> Source/WebKitLegacy/mac/Misc/WebDownload.h:36 >> +#import <pal/spi/cocoa/NSURLConnectionSPI.h> > > Hm...is it safe to import PAL headers like this? > > I don't think PAL headers were intended to be imported by clients outside of WebKit, since they use WTF macros like USE(). However, this is an SPI header that could (in theory) be imported by any internal Apple clients... I think your right. Verifying locally right now that we don't need this, I think I just needed to change the define guard. 401402 2020-06-08 17:21:30 -0700 2020-06-08 20:24:39 -0700 Patch bug-212942-20200608172129.patch text/plain 1427 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2Mjc1MSkKKysrIFNv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE0IEBACisyMDIwLTA2LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4K KworICAgICAgICBXZWJLaXRMZWdhY3k6IEV4Y2x1ZGUgTlNVUkxDb25uZWN0aW9uU1BJLmggZnJv bSB3YXRjaE9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTI5NDIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0MTQxODc3PgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWlzYy9XZWJEb3dubG9hZC5o OiBFeGNsdWRlIE5TVVJMQ29ubmVjdGlvblNQSS5oIGZyb20gd2F0Y2hPUywgcmVwbGFjZQorICAg ICAgICBDRk5TVVJMQ29ubmVjdGlvbi5oIHdpdGggTlNVUkxDb25uZWN0aW9uU1BJLmguCisKIDIw MjAtMDYtMDggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBb SVBDXSBBZG9wdCBlbnVtIGNsYXNzIGZvciBEcmFnT3BlcmF0aW9uCkluZGV4OiBTb3VyY2UvV2Vi S2l0TGVnYWN5L21hYy9NaXNjL1dlYkRvd25sb2FkLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdExlZ2FjeS9tYWMvTWlzYy9XZWJEb3dubG9hZC5oCShyZXZpc2lvbiAyNjI3MzcpCisrKyBT b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9NaXNjL1dlYkRvd25sb2FkLmgJKHdvcmtpbmcgY29weSkK QEAgLTMyLDggKzMyLDggQEAKICNpZm5kZWYgV2ViRG93bmxvYWRfaAogI2RlZmluZSBXZWJEb3du bG9hZF9oCiAKLSNpZiAoZGVmaW5lZCBUQVJHRVRfT1NfTUFDQ0FUQUxZU1QgJiYgVEFSR0VUX09T X01BQ0NBVEFMWVNUKSB8fCAoZGVmaW5lZChUQVJHRVRfT1NfV0FUQ0gpICYmIFRBUkdFVF9PU19X QVRDSCkKLSNpbXBvcnQgPENGTmV0d29yay9DRk5TVVJMQ29ubmVjdGlvbi5oPgorI2lmIChkZWZp bmVkIFRBUkdFVF9PU19NQUNDQVRBTFlTVCAmJiBUQVJHRVRfT1NfTUFDQ0FUQUxZU1QpCisjaW1w b3J0IDxwYWwvc3BpL2NvY29hL05TVVJMQ29ubmVjdGlvblNQSS5oPgogI2VsaWYgIVRBUkdFVF9P U19JUEhPTkUgfHwgKGRlZmluZWQgVVNFX0FQUExFX0lOVEVSTkFMX1NESyAmJiBVU0VfQVBQTEVf SU5URVJOQUxfU0RLKQogI2ltcG9ydCA8Rm91bmRhdGlvbi9OU1VSTERvd25sb2FkLmg+CiAjZWxz ZQo=