212940 2020-06-08 16:42:20 -0700 REGRESSION: [Safari Mojave for High Sierra] Accessing some of the featured pages on apple.com causes the webpage to crash 2020-06-09 14:20:08 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino webkit-unassigned dino thorton webkit-bug-importer oldest_to_newest 1660490 0 dino 2020-06-08 16:42:20 -0700 Seeing crashes on apple.com when using high-performance WebGL. 1660491 1 dino 2020-06-08 16:43:02 -0700 rdar://63839405 1660494 2 401399 dino 2020-06-08 16:49:31 -0700 Created attachment 401399 Patch Note: This patch is for the safari-609-branch, so won't apply cleanly here. 1660496 3 401399 thorton 2020-06-08 16:52:02 -0700 Comment on attachment 401399 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401399&action=review > Source/WebCore/platform/graphics/mac/SwitchingGPUClient.h:35 > + static bool hasSingleton() { return !!m_singleton; } The alternative is "singletonIfExists()" or whatever. I think we have a pattern for this. 1660500 4 401399 dino 2020-06-08 17:02:37 -0700 Comment on attachment 401399 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401399&action=review >> Source/WebCore/platform/graphics/mac/SwitchingGPUClient.h:35 >> + static bool hasSingleton() { return !!m_singleton; } > > The alternative is "singletonIfExists()" or whatever. I think we have a pattern for this. I'll do that on trunk. Thanks. 1660624 5 dino 2020-06-09 01:51:01 -0700 Committed r262783: <https://trac.webkit.org/changeset/262783> 1660863 6 dino 2020-06-09 14:20:08 -0700 Committed r262811: <https://trac.webkit.org/changeset/262811> 401399 2020-06-08 16:49:31 -0700 2020-06-08 16:52:02 -0700 Patch singleton.patch text/plain 4844 dino ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMzgwYmE1ZGUyOTguLjc4MmYwYTIxNTNjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIwIEBACisyMDIwLTA2LTA4ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAg ICAgICBSRUdSRVNTSU9OOiBbU2FmYXJpIE1vamF2ZSBmb3IgSGlnaCBTaWVycmFdIEFjY2Vzc2lu ZyBzb21lIG9mIHRoZSBmZWF0dXJlZCBwYWdlcyBvbiBhcHBsZS5jb20gY2F1c2VzIHRoZSB3ZWJw YWdlIHRvIGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTI5NDAKKyAgICAgICAgcmRhcjovLzYzODM5NDA1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGUgdG8gc2V0IHRoZSBzaW5nbGV0 b24gZm9yIGEgU3dpdGNoaW5nR1BVQ2xpZW50IHdhcyBhc3N1bWluZyBpdCBhbHdheXMKKyAgICAg ICAgZXhpc3RlZC4gSG93ZXZlciwgaXQgd2FzIG5vdCBiZWluZyBhc3NpZ25lZCBieSBXZWJLaXQg d2hlbgorICAgICAgICBFTkFCTEUoV0VCUFJPQ0VTU19XSU5ET1dTRVJWRVJfQkxPQ0tJTkcpIHdh cyBmYWxzZS4KKworICAgICAgICBOb3RlIHRoYXQgdGhpcyBwYXRjaCBpcyBhZ2FpbnN0IHRoZSBz YWZhcmktNjA5LWJyYW5jaCBicmFuY2ggYW5kIHdvbid0IGFwcGx5CisgICAgICAgIG9uIHRydW5r LiBUaGF0IHdpbGwgcmVxdWlyZSBhIGRpZmZlcmVudCBmaXguCisKKyAgICAgICAgKiBTb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tOiBBbHdheXMgYXNzaWdu IHRoZSBzaW5nbGV0b24gb24gTWFjLgorCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzMxY2ExODA4MDYuLjViZmI4 MzU1NTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMjAtMDYtMDggIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IFtTYWZhcmkgTW9q YXZlIGZvciBIaWdoIFNpZXJyYV0gQWNjZXNzaW5nIHNvbWUgb2YgdGhlIGZlYXR1cmVkIHBhZ2Vz IG9uIGFwcGxlLmNvbSBjYXVzZXMgdGhlIHdlYnBhZ2UgdG8gY3Jhc2gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjk0MAorICAgICAgICByZGFyOi8v NjM4Mzk0MDUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBUaGUgY29kZSB0byBzZXQgdGhlIHNpbmdsZXRvbiBmb3IgYSBTd2l0Y2hpbmdHUFVDbGllbnQg d2FzIGFzc3VtaW5nIGl0IGFsd2F5cworICAgICAgICBleGlzdGVkLiBIb3dldmVyLCBpdCB3YXMg bm90IGJlaW5nIGFzc2lnbmVkIGJ5IFdlYktpdCB3aGVuCisgICAgICAgIEVOQUJMRShXRUJQUk9D RVNTX1dJTkRPV1NFUlZFUl9CTE9DS0lORykgd2FzIGZhbHNlLgorCisgICAgICAgIE5vdGUgdGhh dCB0aGlzIHBhdGNoIGlzIGFnYWluc3QgdGhlIHNhZmFyaS02MDktYnJhbmNoIGJyYW5jaCBhbmQg d29uJ3QgYXBwbHkKKyAgICAgICAgb24gdHJ1bmsuIFRoYXQgd2lsbCByZXF1aXJlIGEgZGlmZmVy ZW50IGZpeC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNE TWFuYWdlci5jcHA6IENhbGwgaGFzU2luZ2xldG9uKCkgYmVmb3JlCisgICAgICAgIGFzc3VtaW5n IGl0IGV4aXN0cy4KKyAgICAgICAgKiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvU3dpdGNoaW5nR1BVQ2xpZW50Lmg6IEFkZCBhIGhhc1NpbmdsZXRvbigpCisgICAgICAgIHRl c3QuCisKIDIwMjAtMDYtMDggIFNhbSBXZWluaWcgIDx3ZWluaWdAYXBwbGUuY29tPgogCiAgICAg ICAgIEV4dGVuZGVkIENvbG9yOiBSZXBsYWNlIHVzZXMgb2YgZGlmZmVyZW5jZVNxdWFyZWQoKSB3 aXRoIGx1bWluYW5jZSBiYXNlZCBjb21wdXRhdGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNETWFuYWdlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRE1hbmFnZXIuY3Bw CmluZGV4IDYxODYxZGZiZWMxLi5lMTRiYjdkZmJiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0RNYW5hZ2VyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRE1hbmFnZXIu Y3BwCkBAIC0yMzYsNyArMjM2LDggQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRE1hbmFnZXI6OnVw ZGF0ZUhpZ2hQZXJmb3JtYW5jZVN0YXRlKCkKICAgICAgICAgICAgIExPRyhXZWJHTCwgIlJlcXVl c3QgdGhlIGhpZ2gtcGVyZm9ybWFuY2UgR1BVLiIpOwogICAgICAgICAgICAgbV9yZXF1ZXN0aW5n SGlnaFBlcmZvcm1hbmNlID0gdHJ1ZTsKICNpZiBQTEFURk9STShNQUMpCi0gICAgICAgICAgICBT d2l0Y2hpbmdHUFVDbGllbnQ6OnNpbmdsZXRvbigpLnJlcXVlc3RIaWdoUGVyZm9ybWFuY2VHUFUo KTsKKyAgICAgICAgICAgIGlmIChTd2l0Y2hpbmdHUFVDbGllbnQ6Omhhc1NpbmdsZXRvbigpKQor ICAgICAgICAgICAgICAgIFN3aXRjaGluZ0dQVUNsaWVudDo6c2luZ2xldG9uKCkucmVxdWVzdEhp Z2hQZXJmb3JtYW5jZUdQVSgpOwogI2VuZGlmCiAgICAgICAgIH0KIApAQCAtMjYyLDcgKzI2Myw4 IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0RNYW5hZ2VyOjpkaXNhYmxlSGlnaFBlcmZvcm1hbmNl R1BVVGltZXJGaXJlZCgpCiAKICAgICBtX3JlcXVlc3RpbmdIaWdoUGVyZm9ybWFuY2UgPSBmYWxz ZTsKICNpZiBQTEFURk9STShNQUMpICYmIChVU0UoT1BFTkdMKSB8fCBVU0UoQU5HTEUpKQotICAg IFN3aXRjaGluZ0dQVUNsaWVudDo6c2luZ2xldG9uKCkucmVsZWFzZUhpZ2hQZXJmb3JtYW5jZUdQ VSgpOworICAgIGlmIChTd2l0Y2hpbmdHUFVDbGllbnQ6Omhhc1NpbmdsZXRvbigpKQorICAgICAg ICBTd2l0Y2hpbmdHUFVDbGllbnQ6OnNpbmdsZXRvbigpLnJlbGVhc2VIaWdoUGVyZm9ybWFuY2VH UFUoKTsKICNlbmRpZgogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9tYWMvU3dpdGNoaW5nR1BVQ2xpZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9tYWMvU3dpdGNoaW5nR1BVQ2xpZW50LmgKaW5kZXggMzg1Y2I1MDMyNDguLjQx MDU3YmI3MGRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9t YWMvU3dpdGNoaW5nR1BVQ2xpZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvbWFjL1N3aXRjaGluZ0dQVUNsaWVudC5oCkBAIC0zMSw2ICszMSw4IEBAIGNsYXNzIFN3 aXRjaGluZ0dQVUNsaWVudCB7CiBwdWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIFN3 aXRjaGluZ0dQVUNsaWVudCYgc2luZ2xldG9uKCk7CiAgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGlj IHZvaWQgc2V0U2luZ2xldG9uKFN3aXRjaGluZ0dQVUNsaWVudCYpOworICAgIAorICAgIHN0YXRp YyBib29sIGhhc1NpbmdsZXRvbigpIHsgcmV0dXJuICEhbV9zaW5nbGV0b247IH0KIAogICAgIHZp cnR1YWwgflN3aXRjaGluZ0dQVUNsaWVudCgpID0gZGVmYXVsdDsKIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbSBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KaW5kZXggOGYzNGZiY2Qy NTIuLmJmZDQ1M2IwODNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29j b2EvV2ViUHJvY2Vzc0NvY29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2Nv YS9XZWJQcm9jZXNzQ29jb2EubW0KQEAgLTUwOCw4ICs1MDgsNiBAQCB2b2lkIFdlYlByb2Nlc3M6 OnBsYXRmb3JtSW5pdGlhbGl6ZVByb2Nlc3MoY29uc3QgQXV4aWxpYXJ5UHJvY2Vzc0luaXRpYWxp emF0aW9uUAogICAgIFJFTEVBU0VfQVNTRVJUKHJldHZhbCA9PSBrQ0dFcnJvclN1Y2Nlc3MpOwog ICAgIC8vIE1ha2Ugc3VyZSB0aGF0IHdlIGNsb3NlIGFueSBXaW5kb3dTZXJ2ZXIgY29ubmVjdGlv bnMgYWZ0ZXIgY2hlY2tpbmcgaW4gd2l0aCBMYXVuY2ggU2VydmljZXMuCiAgICAgQ0dTU2h1dGRv d25TZXJ2ZXJDb25uZWN0aW9ucygpOwotCi0gICAgU3dpdGNoaW5nR1BVQ2xpZW50OjpzZXRTaW5n bGV0b24oV2ViU3dpdGNoaW5nR1BVQ2xpZW50OjpzaW5nbGV0b24oKSk7CiAjZWxzZQogCiAgICAg aWYgKCFbTlNBcHAgaXNSdW5uaW5nXSkgewpAQCAtNTE5LDYgKzUxNyw4IEBAIHZvaWQgV2ViUHJv Y2Vzczo6cGxhdGZvcm1Jbml0aWFsaXplUHJvY2Vzcyhjb25zdCBBdXhpbGlhcnlQcm9jZXNzSW5p dGlhbGl6YXRpb25QCiAgICAgfQogI2VuZGlmIC8vIEVOQUJMRShXRUJQUk9DRVNTX1dJTkRPV1NF UlZFUl9CTE9DS0lORykKIAorICAgIFN3aXRjaGluZ0dQVUNsaWVudDo6c2V0U2luZ2xldG9uKFdl YlN3aXRjaGluZ0dQVUNsaWVudDo6c2luZ2xldG9uKCkpOworCiAgICAgbV91aVByb2Nlc3NOYW1l ID0gcGFyYW1ldGVycy51aVByb2Nlc3NOYW1lOwogI2VuZGlmIC8vIFBMQVRGT1JNKE1BQykKIAo=