<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>212935</bug_id>
          
          <creation_ts>2020-06-08 16:04:40 -0700</creation_ts>
          <short_desc>WebCore: Guard _preconnect declaration with ENABLE(SERVER_PRECONNECT)</short_desc>
          <delta_ts>2020-06-08 17:35:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.webkit.org/show_bug.cgi?id=212718</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jonathan Bedard">jbedard</reporter>
          <assigned_to name="Jonathan Bedard">jbedard</assigned_to>
          <cc>aestes</cc>
    
    <cc>ap</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wenson_hsieh</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1660457</commentid>
    <comment_count>0</comment_count>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2020-06-08 16:04:40 -0700</bug_when>
    <thetext>Since the usage of _preconnect is always guarded with ENABLE(SERVER_PRECONNECT), its declaration should be guarded with it as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1660460</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-06-08 16:05:21 -0700</bug_when>
    <thetext>&lt;rdar://problem/64139060&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1660475</commentid>
    <comment_count>2</comment_count>
      <attachid>401396</attachid>
    <who name="Jonathan Bedard">jbedard</who>
    <bug_when>2020-06-08 16:22:11 -0700</bug_when>
    <thetext>Created attachment 401396
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1660520</commentid>
    <comment_count>3</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-06-08 17:35:40 -0700</bug_when>
    <thetext>Committed r262756: &lt;https://trac.webkit.org/changeset/262756&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401396.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>401396</attachid>
            <date>2020-06-08 16:22:11 -0700</date>
            <delta_ts>2020-06-08 17:35:40 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-212935-20200608162210.patch</filename>
            <type>text/plain</type>
            <size>1221</size>
            <attacher name="Jonathan Bedard">jbedard</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl
L1dlYkNvcmUvUEFML0NoYW5nZUxvZwkocmV2aXNpb24gMjYyNzQ0KQorKysgU291cmNlL1dlYkNv
cmUvUEFML0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA2
LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJD
b3JlOiBHdWFyZCBfcHJlY29ubmVjdCBkZWNsYXJhdGlvbiB3aXRoIEVOQUJMRShTRVJWRVJfUFJF
Q09OTkVDVCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTIxMjkzNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjQxMzkwNjA+CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWwvc3BpL2NmL0NGTmV0d29y
a1NQSS5oOgorCiAyMDIwLTA2LTA4ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv
bT4KIAogICAgICAgICBXZWJDb3JlOiBBZGQgdHZPUyBhbmQgd2F0Y2hPUyBTUEkgaGVhZGVycwpJ
bmRleDogU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2YvQ0ZOZXR3b3JrU1BJLmgKPT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PQotLS0gU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2YvQ0ZOZXR3b3JrU1BJLmgJKHJl
dmlzaW9uIDI2MjczNykKKysrIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NmL0NGTmV0d29y
a1NQSS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNDAsNyArMjQwLDcgQEAgdHlwZWRlZiBOU19FTlVN
KE5TSW50ZWdlciwgTlNVUkxTZXNzaW9uQwogQHByb3BlcnR5IChudWxsYWJsZSwgcmVhZHdyaXRl
LCByZXRhaW4pIE5TVVJMICpfc2l0ZUZvckNvb2tpZXM7CiBAcHJvcGVydHkgKHJlYWR3cml0ZSkg
Qk9PTCBfaXNUb3BMZXZlbE5hdmlnYXRpb247CiAjZW5kaWYKLSNpZiBQTEFURk9STShDT0NPQSkg
JiYgIVBMQVRGT1JNKFdBVENIT1MpICYmICFQTEFURk9STShBUFBMRVRWKQorI2lmIEVOQUJMRShT
RVJWRVJfUFJFQ09OTkVDVCkKIEBwcm9wZXJ0eSAobm9uYXRvbWljLCBhc3NpZ24pIEJPT0wgX3By
ZWNvbm5lY3Q7CiAjZW5kaWYKIEBlbmQK
</data>

          </attachment>
      

    </bug>

</bugzilla>