212929 2020-06-08 15:42:39 -0700 Remove unnecessary variable in `WindowProxy::createJSWindowProxy` 2020-06-08 16:23:21 -0700 1 1 1 Unclassified WebKit Bindings WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi hi cdumez darin hi webkit-bug-importer oldest_to_newest 1660432 0 hi 2020-06-08 15:42:39 -0700 ``` Strong<JSWindowProxy> jsWindowProxy(vm, &JSWindowProxy::create(vm, *m_frame->window(), world)); Strong<JSWindowProxy> jsWindowProxy2(jsWindowProxy); ``` Nothing seems to use `jsWindowProxy2`, so it should be removed (or have a comment as to why it's needed). This was added in r78634 <https://webkit.org/b/54415> 🤯 1660433 1 401384 hi 2020-06-08 15:43:39 -0700 Created attachment 401384 Patch 1660476 2 ews-feeder 2020-06-08 16:23:00 -0700 Committed r262751: <https://trac.webkit.org/changeset/262751> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401384. 1660477 3 webkit-bug-importer 2020-06-08 16:23:21 -0700 <rdar://problem/64139773> 401384 2020-06-08 15:43:39 -0700 2020-06-08 16:23:01 -0700 Patch bug-212929-20200608154338.patch text/plain 1355 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmYzc1YWFiYzY1YWRhMzY5MDYwOWY4ZmRlYzJmY2ZjNDU1OTdiNTIwLi5i NTJmY2U2NmQ4NjBjZTUzNTg4NDc2NjFiZWI5NjM0YTkxYjI4ODgxIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMjAtMDYtMDggIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFJlbW92ZSB1bm5lY2Vzc2FyeSB2YXJpYWJsZSBpbiBgV2luZG93UHJveHk6 OmNyZWF0ZUpTV2luZG93UHJveHlgCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTI5MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL1dpbmRvd1Byb3h5LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OldpbmRvd1Byb3h5OjpjcmVhdGVKU1dpbmRvd1Byb3h5KToKKwogMjAyMC0wNi0wNiAg WmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdIEFkZCBzdXBw b3J0IGZvciB3aWR0aDogbWluL21heC1jb250ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9XaW5kb3dQcm94eS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9q cy9XaW5kb3dQcm94eS5jcHAKaW5kZXggNWM2OTVmZTk1ZWUxOGU1MDZjYjRmYTU0NWUyNmFkOThh YTY2ZTFjNC4uZTlmOTE2NzdkYjJiNzk2MTRmMDE5MGMxNTRmMjBjOTQ1YTFiOGFmYiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvV2luZG93UHJveHkuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1dpbmRvd1Byb3h5LmNwcApAQCAtOTgsNyArOTgsNiBA QCBKU1dpbmRvd1Byb3h5JiBXaW5kb3dQcm94eTo6Y3JlYXRlSlNXaW5kb3dQcm94eShET01XcmFw cGVyV29ybGQmIHdvcmxkKQogICAgIFZNJiB2bSA9IHdvcmxkLnZtKCk7CiAKICAgICBTdHJvbmc8 SlNXaW5kb3dQcm94eT4ganNXaW5kb3dQcm94eSh2bSwgJkpTV2luZG93UHJveHk6OmNyZWF0ZSh2 bSwgKm1fZnJhbWUtPndpbmRvdygpLCB3b3JsZCkpOwotICAgIFN0cm9uZzxKU1dpbmRvd1Byb3h5 PiBqc1dpbmRvd1Byb3h5Mihqc1dpbmRvd1Byb3h5KTsKICAgICBtX2pzV2luZG93UHJveGllcy0+ YWRkKCZ3b3JsZCwganNXaW5kb3dQcm94eSk7CiAgICAgd29ybGQuZGlkQ3JlYXRlV2luZG93UHJv eHkodGhpcyk7CiAgICAgcmV0dXJuICpqc1dpbmRvd1Byb3h5LmdldCgpOwo=