212927 2020-06-08 15:17:51 -0700 Removed unneeded POINTER_WIDTH macro from b3 2020-06-08 15:47:23 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller darin ews-watchlist mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1660422 0 keith_miller 2020-06-08 15:17:51 -0700 Removed unneeded POINTER_WIDTH macro from b3 1660424 1 401381 keith_miller 2020-06-08 15:19:08 -0700 Created attachment 401381 Patch 1660431 2 401381 darin 2020-06-08 15:42:00 -0700 Comment on attachment 401381 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401381&action=review > Source/JavaScriptCore/b3/B3Width.h:46 > +constexpr inline Width pointerWidth() constexpr implies inline, so we never have to say both https://en.cppreference.com/w/cpp/language/constexpr 1660434 3 401381 keith_miller 2020-06-08 15:45:02 -0700 Comment on attachment 401381 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401381&action=review >> Source/JavaScriptCore/b3/B3Width.h:46 >> +constexpr inline Width pointerWidth() > > constexpr implies inline, so we never have to say both > > https://en.cppreference.com/w/cpp/language/constexpr I was wondering if I needed both... I'll remove the inline. 1660436 4 keith_miller 2020-06-08 15:46:25 -0700 Committed r262746: <https://trac.webkit.org/changeset/262746> 1660437 5 webkit-bug-importer 2020-06-08 15:47:23 -0700 <rdar://problem/64138322> 401381 2020-06-08 15:19:08 -0700 2020-06-08 15:45:12 -0700 Patch bug-212927-20200608151907.patch text/plain 2053 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNzQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 YjI4ZjNiODI3ZTBmODhjMjk5YmFiMWRhODQwYTZmZmQ0OGFhNjA4Li5mNzI3NjJiZWRhYzMyMWI2 M2IwNmJlMDI2NzU2YzkwOWY4ZGZkOWJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAyMC0wNi0wOCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBSZW1vdmVkIHVubmVlZGVkIFBPSU5URVJfV0lEVEggbWFjcm8gZnJv bSBiMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEy OTI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQysr MjAgaGFzIHJlYWwgY29uc3RleHByIGZ1bmN0aW9ucyBzbyB3ZSBkb24ndCBuZWVkIHRoZQorICAg ICAgICBQT0lOVEVSX1dJRFRIIG1hY3JvIGFueW1vcmUuCisKKyAgICAgICAgKiBiMy9CM1dpZHRo Lmg6CisgICAgICAgIChKU0M6OkIzOjpwb2ludGVyV2lkdGgpOgorICAgICAgICAqIGIzL2Fpci9v cGNvZGVfZ2VuZXJhdG9yLnJiOgorCiAyMDIwLTA2LTA4ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFp a2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBKU09OLnN0cmluZ2lmeSBzaG91bGQgdGhyb3cg c3RhY2sgb3ZlcmZsb3cgZXJyb3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9i My9CM1dpZHRoLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNXaWR0aC5oCmluZGV4IGEw MjAyZDA5NDE3NTAwNWJlNzYzOWNmYjQwMTQwY2I4NWYyZDNjNDYuLjFjNzMwZDJhZGM2Y2I2MDhl YTQ0MjQ1Zjg3NzlkOTRkOWQ2NjEzMTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9iMy9CM1dpZHRoLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzV2lkdGguaApA QCAtNDMsMjAgKzQzLDEzIEBAIGVudW0gV2lkdGggOiBpbnQ4X3QgewogICAgIFdpZHRoNjQKIH07 CiAKLWlubGluZSBXaWR0aCBwb2ludGVyV2lkdGgoKQorY29uc3RleHByIGlubGluZSBXaWR0aCBw b2ludGVyV2lkdGgoKQogewogICAgIGlmIChzaXplb2Yodm9pZCopID09IDgpCiAgICAgICAgIHJl dHVybiBXaWR0aDY0OwogICAgIHJldHVybiBXaWR0aDMyOwogfQogCi0vLyBEb24ndCB1c2UgdGhp cyB1bmxlc3MgdGhlIGNvbXBpbGVyIGZvcmNlcyB5b3UgdG8uCi0jaWYgQ1BVKFg4Nl82NCkgfHwg Q1BVKEFSTTY0KQotI2RlZmluZSBQT0lOVEVSX1dJRFRIIFdpZHRoNjQKLSNlbHNlCi0jZGVmaW5l IFBPSU5URVJfV0lEVEggV2lkdGgzMgotI2VuZGlmCi0KIGlubGluZSBXaWR0aCB3aWR0aEZvclR5 cGUoVHlwZSB0eXBlKQogewogICAgIHN3aXRjaCAodHlwZS5raW5kKCkpIHsKZGlmZiAtLWdpdCBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvb3Bjb2RlX2dlbmVyYXRvci5yYiBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9iMy9haXIvb3Bjb2RlX2dlbmVyYXRvci5yYgppbmRleCAzMDY5ODIw YjQxZmEyNTI1Nzg5NjcwOWVjOThiMmJkNmFkZTk1ZjZlLi5mZGUwMTc5NmYwMTA1ZTQ3MmQ4NzQz Zjg2ODdhYzgzZGY1NTk5YmMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMv YWlyL29wY29kZV9nZW5lcmF0b3IucmIKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL2Fp ci9vcGNvZGVfZ2VuZXJhdG9yLnJiCkBAIC01NCw3ICs1NCw3IEBAIGNsYXNzIEFyZwogICAgIAog ICAgIGRlZiBzZWxmLndpZHRoQ29kZSh3aWR0aCkKICAgICAgICAgaWYgd2lkdGggPT0gIlB0ciIK LSAgICAgICAgICAgICJQT0lOVEVSX1dJRFRIIgorICAgICAgICAgICAgInBvaW50ZXJXaWR0aCgp IgogICAgICAgICBlbHNlCiAgICAgICAgICAgICAiV2lkdGgje3dpZHRofSIKICAgICAgICAgZW5k Cg==