212910 2020-06-08 12:33:00 -0700 All platforms should enable CFPrefs read only mode in the WebContent process 2020-06-09 12:58:15 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan benjamin bfulgham cdumez cmarcelo darin ews-watchlist thorton webkit-bug-importer oldest_to_newest 1660304 0 pvollan 2020-06-08 12:33:00 -0700 In https://bugs.webkit.org/show_bug.cgi?id=212411, CFPrefs read only mode was adopted, but not all platforms were included. 1660307 1 401358 pvollan 2020-06-08 12:34:32 -0700 Created attachment 401358 Patch 1660310 2 401358 thorton 2020-06-08 12:37:55 -0700 Comment on attachment 401358 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401358&action=review > Source/WTF/wtf/PlatformHave.h:646 > + || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ How certain are you that IPHONE_OS_VERSION is the right one to check in macCatalyst? (I think it's not, but I am not 100%) 1660531 3 thorton 2020-06-08 18:26:02 -0700 (In reply to Tim Horton from comment #2) > Comment on attachment 401358 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401358&action=review > > > Source/WTF/wtf/PlatformHave.h:646 > > + || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ > > How certain are you that IPHONE_OS_VERSION is the right one to check in > macCatalyst? (I think it's not, but I am not 100%) It is! Disregard me. 1660793 4 401358 pvollan 2020-06-09 12:33:10 -0700 Comment on attachment 401358 Patch Thanks for reviewing! 1660813 5 ews-feeder 2020-06-09 12:57:21 -0700 Committed r262805: <https://trac.webkit.org/changeset/262805> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401358. 1660815 6 webkit-bug-importer 2020-06-09 12:58:15 -0700 <rdar://problem/64176093> 401358 2020-06-08 12:34:32 -0700 2020-06-09 12:57:22 -0700 Patch bug-212910-20200608123431.patch text/plain 1389 pvollan SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjI3MzIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA2LTA4ICBQZXIgQXJuZSBWb2xsYW4gIDxw dm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBbGwgcGxhdGZvcm1zIHNob3VsZCBlbmFibGUg Q0ZQcmVmcyByZWFkIG9ubHkgbW9kZSBpbiB0aGUgV2ViQ29udGVudCBwcm9jZXNzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI5MTAKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNDExLCBDRlByZWZzIHJlYWQgb25seSBtb2Rl IHdhcyBhZG9wdGVkLCBidXQgbm90IGFsbCBwbGF0Zm9ybXMgd2VyZSBpbmNsdWRlZC4KKworICAg ICAgICAqIHd0Zi9QbGF0Zm9ybUhhdmUuaDoKKwogMjAyMC0wNi0wOCAgUGVyIEFybmUgVm9sbGFu ICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBBZG9wdCByZWFkLW9ubHkg bW9kZSBmb3IgcHJlZmVyZW5jZXMgaW4gdGhlIFdlYkNvbnRlbnQgcHJvY2VzcwpJbmRleDogU291 cmNlL1dURi93dGYvUGxhdGZvcm1IYXZlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYv UGxhdGZvcm1IYXZlLmgJKHJldmlzaW9uIDI2MjczMCkKKysrIFNvdXJjZS9XVEYvd3RmL1BsYXRm b3JtSGF2ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC02NDMsNyArNjQzLDcgQEAKICNlbmRpZgogCiAj aWYgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAx MDE2MDApIFwKLSAgICB8fCAoUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01J Tl9SRVFVSVJFRCA+PSAxNDAwMDApIFwKKyAgICB8fCAoKFBMQVRGT1JNKElPUykgfHwgUExBVEZP Uk0oTUFDQ0FUQUxZU1QpKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAx NDAwMDApIFwKICAgICB8fCAoUExBVEZPUk0oV0FUQ0hPUykgJiYgX19XQVRDSF9PU19WRVJTSU9O X01JTl9SRVFVSVJFRCA+PSA3MDAwMCkgXAogICAgIHx8IChQTEFURk9STShBUFBMRVRWKSAmJiBf X1RWX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDE0MDAwMCkKICNkZWZpbmUgSEFWRV9DRl9Q UkVGU19TRVRfUkVBRF9PTkxZIDEK