212906 2020-06-08 09:28:58 -0700 [webkitpy] Check 'bug-search' returns a non null result before parsing 2020-06-08 22:38:15 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dpino dpino ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1660243 0 dpino 2020-06-08 09:28:58 -0700 [webkitpy] Check 'bug-search' returns a non null result before parsing 1660245 1 401345 dpino 2020-06-08 09:33:17 -0700 Created attachment 401345 Patch 1660249 2 dpino 2020-06-08 09:41:13 -0700 For instance, the following query in master returns the following stacktrace: ``` $ Tools/Scripts/webkit-patch bug-search creator=dpino@igalia.com Logging in as dpino@igalia.com... Traceback (most recent call last): File "Tools/Scripts/webkit-patch", line 80, in <module> main() File "Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/home/dpino/workspace/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/home/dpino/workspace/webkit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/home/dpino/workspace/webkit/Tools/Scripts/webkitpy/tool/commands/bugsearch.py", line 45, in execute bugs = tool.bugs.queries.fetch_bugs_matching_quicksearch(search_string) File "/home/dpino/workspace/webkit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 238, in fetch_bugs_matching_quicksearch return self._fetch_bugs_from_advanced_query(quicksearch_url) File "/home/dpino/workspace/webkit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 169, in _fetch_bugs_from_advanced_query if not self._parse_result_count(results_page): File "/home/dpino/workspace/webkit/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py", line 143, in _parse_result_count result_count_text = BeautifulSoup(results_page).find(attrs={'class': 'bz_result_count'}).string AttributeError: 'NoneType' object has no attribute 'string' ``` The syntax of query is not valid (the 'creator' field doesn't exist). The same query with the patch applied returns: ``` $ Tools/Scripts/webkit-patch bug-search creator=dpino@igalia.com Logging in as dpino@igalia.com... BeautifulSoup returned None while finding class: bz_result_count in: <response_seek_wrapper at 0x7f5b712bda50 whose wrapped object = <closeable_response at 0x7f5b712df0f0 whose fp = <socket._fileobject object at 0x7f5b712dc1d0>>> Failed to find bugs for https://bugs.webkit.org/buglist.cgi?quicksearch=creator%3Ddpino%40igalia.com&list_id=5962028 No bugs found matching 'creator=dpino@igalia.com' ``` The correct query would be: ``` $ Tools/Scripts/webkit-patch bug-search reporter=dpino@igalia.com ``` A valid query that returns no results would be: ``` Tools/Scripts/webkit-patch bug-search reporter=xyz@igalia.com Logging in as dpino@igalia.com... BeautifulSoup returned None while finding class: bz_result_count in: <response_seek_wrapper at 0x7fb3dcaad9b0 whose wrapped object = <closeable_response at 0x7fb3dcab7050 whose fp = <socket._fileobject object at 0x7fb3dcab32d0>>> Failed to find bugs for https://bugs.webkit.org/buglist.cgi?quicksearch=reporter%3Dxyz%40igalia.com&list_id=5962045 No bugs found matching 'reporter=xyz@igalia.com' ``` 1660255 3 401349 dpino 2020-06-08 09:57:42 -0700 Created attachment 401349 Patch 1660582 4 ews-feeder 2020-06-08 22:37:24 -0700 Committed r262775: <https://trac.webkit.org/changeset/262775> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401349. 1660583 5 webkit-bug-importer 2020-06-08 22:38:15 -0700 <rdar://problem/64150351> 401345 2020-06-08 09:33:17 -0700 2020-06-08 09:57:39 -0700 Patch bug-212906-20200608183316.patch text/plain 2056 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNzE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDJhMTExNjlmNGNiNzQ1ZDBiZTUwMTM2Y2Y5YWQ4MjE4 MzFiMDA1My4uM2VkNzQ0ZTU1MGI3ODhiMDhmYTliNDBkZTI3OGJmMWNkNzcyOGE2NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA2LTA4ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW3dlYmtpdHB5XSBDaGVjayAnYnVnLXNlYXJjaCcgcmV0dXJucyBhIG5vbiBudWxs IHJlc3VsdCBiZWZvcmUgcGFyc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEyOTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVn emlsbGEucHk6CisgICAgICAgIChCdWd6aWxsYVF1ZXJpZXMuX3BhcnNlX3Jlc3VsdF9jb3VudCk6 IENoZWNrIHF1aWNrLXNlYXJjaCBxdWVyeQorICAgICAgICByZXNwb25zZSBpcyBub24tbnVsbCBh bmQgYSBub24tZW1wdHkgdGV4dC4KKwogMjAyMC0wNi0wOCAgRGllZ28gUGlubyBHYXJjaWEgIDxk cGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFt3ZWJraXRweV0gTWFrZSAnd2Via2l0LXBhdGgg cmViYXNlbGluZScgdG8gbm90IHVwZGF0ZSBleHBlY3RhdGlvbnMgZmlsZSBieSBkZWZhdWx0CmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVn emlsbGEucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVn emlsbGEucHkKaW5kZXggYTcxZjIzNmMxZjcyMGI4ZmYzYWZkN2VmOTAyNTg3NjIyNjI0MzM1Ni4u MTQ5MzY3OTQ3NGEzZTVhN2FkM2RhMWU1Y2Q1ODk0NDZmMmMxOTgzNCAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5weQpA QCAtMTQwLDExICsxNDAsMTEgQEAgY2xhc3MgQnVnemlsbGFRdWVyaWVzKG9iamVjdCk6CiAKICAg ICAjIFRoaXMgaXMga2luZGEgYSBoYWNrLiAgVGhlcmUgaXMgcHJvYmFibHkgYSBiZXR0ZXIgd2F5 IHRvIGdldCB0aGlzIGluZm9ybWF0aW9uIGZyb20gYnVnemlsbGEuCiAgICAgZGVmIF9wYXJzZV9y ZXN1bHRfY291bnQoc2VsZiwgcmVzdWx0c19wYWdlKToKLSAgICAgICAgcmVzdWx0X2NvdW50X3Rl eHQgPSBCZWF1dGlmdWxTb3VwKHJlc3VsdHNfcGFnZSkuZmluZChhdHRycz17J2NsYXNzJzogJ2J6 X3Jlc3VsdF9jb3VudCd9KS5zdHJpbmcKLSAgICAgICAgaWYgcmVzdWx0X2NvdW50X3RleHQgaXMg Tm9uZToKKyAgICAgICAgcmVzdWx0X2NvdW50X3RleHQgPSBCZWF1dGlmdWxTb3VwKHJlc3VsdHNf cGFnZSkuZmluZChhdHRycz17J2NsYXNzJzogJ2J6X3Jlc3VsdF9jb3VudCd9KQorICAgICAgICBp ZiByZXN1bHRfY291bnRfdGV4dCBpcyBOb25lIG9yIHJlc3VsdF9jb3VudF90ZXh0LnN0cmluZyBp cyBOb25lOgogICAgICAgICAgICAgX2xvZy53YXJuKCJCZWF1dGlmdWxTb3VwIHJldHVybmVkIE5v bmUgd2hpbGUgZmluZGluZyBjbGFzczogYnpfcmVzdWx0X2NvdW50IGluOlxue30iLmZvcm1hdChy ZXN1bHRzX3BhZ2UpKQogICAgICAgICAgICAgcmV0dXJuIDAKLSAgICAgICAgcmVzdWx0X2NvdW50 X3BhcnRzID0gcmVzdWx0X2NvdW50X3RleHQuc3RyaXAoKS5zcGxpdCgiICIpCisgICAgICAgIHJl c3VsdF9jb3VudF9wYXJ0cyA9IHJlc3VsdF9jb3VudF90ZXh0LnN0cmluZy5zdHJpcCgpLnNwbGl0 KCIgIikKICAgICAgICAgaWYgcmVzdWx0X2NvdW50X3BhcnRzWzBdID09ICJaYXJybyI6CiAgICAg ICAgICAgICByZXR1cm4gMAogICAgICAgICBpZiByZXN1bHRfY291bnRfcGFydHNbMF0gPT0gIk9u ZSI6Cg== 401349 2020-06-08 09:57:42 -0700 2020-06-08 22:37:25 -0700 Patch bug-212906-20200608185741.patch text/plain 3046 dpino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNzE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDJhMTExNjlmNGNiNzQ1ZDBiZTUwMTM2Y2Y5YWQ4MjE4 MzFiMDA1My4uM2VkNzQ0ZTU1MGI3ODhiMDhmYTliNDBkZTI3OGJmMWNkNzcyOGE2NiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIwLTA2LTA4ICBEaWVnbyBQaW5vIEdhcmNpYSAgPGRwaW5vQGlnYWxpYS5jb20+CisK KyAgICAgICAgW3dlYmtpdHB5XSBDaGVjayAnYnVnLXNlYXJjaCcgcmV0dXJucyBhIG5vbiBudWxs IHJlc3VsdCBiZWZvcmUgcGFyc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEyOTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVn emlsbGEucHk6CisgICAgICAgIChCdWd6aWxsYVF1ZXJpZXMuX3BhcnNlX3Jlc3VsdF9jb3VudCk6 IENoZWNrIHF1aWNrLXNlYXJjaCBxdWVyeQorICAgICAgICByZXNwb25zZSBpcyBub24tbnVsbCBh bmQgYSBub24tZW1wdHkgdGV4dC4KKwogMjAyMC0wNi0wOCAgRGllZ28gUGlubyBHYXJjaWEgIDxk cGlub0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFt3ZWJraXRweV0gTWFrZSAnd2Via2l0LXBhdGgg cmViYXNlbGluZScgdG8gbm90IHVwZGF0ZSBleHBlY3RhdGlvbnMgZmlsZSBieSBkZWZhdWx0CmRp ZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVn emlsbGEucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVn emlsbGEucHkKaW5kZXggYTcxZjIzNmMxZjcyMGI4ZmYzYWZkN2VmOTAyNTg3NjIyNjI0MzM1Ni4u MTQ5MzY3OTQ3NGEzZTVhN2FkM2RhMWU1Y2Q1ODk0NDZmMmMxOTgzNCAxMDA2NDQKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYS5weQpA QCAtMTQwLDExICsxNDAsMTEgQEAgY2xhc3MgQnVnemlsbGFRdWVyaWVzKG9iamVjdCk6CiAKICAg ICAjIFRoaXMgaXMga2luZGEgYSBoYWNrLiAgVGhlcmUgaXMgcHJvYmFibHkgYSBiZXR0ZXIgd2F5 IHRvIGdldCB0aGlzIGluZm9ybWF0aW9uIGZyb20gYnVnemlsbGEuCiAgICAgZGVmIF9wYXJzZV9y ZXN1bHRfY291bnQoc2VsZiwgcmVzdWx0c19wYWdlKToKLSAgICAgICAgcmVzdWx0X2NvdW50X3Rl eHQgPSBCZWF1dGlmdWxTb3VwKHJlc3VsdHNfcGFnZSkuZmluZChhdHRycz17J2NsYXNzJzogJ2J6 X3Jlc3VsdF9jb3VudCd9KS5zdHJpbmcKLSAgICAgICAgaWYgcmVzdWx0X2NvdW50X3RleHQgaXMg Tm9uZToKKyAgICAgICAgcmVzdWx0X2NvdW50X3RleHQgPSBCZWF1dGlmdWxTb3VwKHJlc3VsdHNf cGFnZSkuZmluZChhdHRycz17J2NsYXNzJzogJ2J6X3Jlc3VsdF9jb3VudCd9KQorICAgICAgICBp ZiByZXN1bHRfY291bnRfdGV4dCBpcyBOb25lIG9yIHJlc3VsdF9jb3VudF90ZXh0LnN0cmluZyBp cyBOb25lOgogICAgICAgICAgICAgX2xvZy53YXJuKCJCZWF1dGlmdWxTb3VwIHJldHVybmVkIE5v bmUgd2hpbGUgZmluZGluZyBjbGFzczogYnpfcmVzdWx0X2NvdW50IGluOlxue30iLmZvcm1hdChy ZXN1bHRzX3BhZ2UpKQogICAgICAgICAgICAgcmV0dXJuIDAKLSAgICAgICAgcmVzdWx0X2NvdW50 X3BhcnRzID0gcmVzdWx0X2NvdW50X3RleHQuc3RyaXAoKS5zcGxpdCgiICIpCisgICAgICAgIHJl c3VsdF9jb3VudF9wYXJ0cyA9IHJlc3VsdF9jb3VudF90ZXh0LnN0cmluZy5zdHJpcCgpLnNwbGl0 KCIgIikKICAgICAgICAgaWYgcmVzdWx0X2NvdW50X3BhcnRzWzBdID09ICJaYXJybyI6CiAgICAg ICAgICAgICByZXR1cm4gMAogICAgICAgICBpZiByZXN1bHRfY291bnRfcGFydHNbMF0gPT0gIk9u ZSI6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemls bGEvYnVnemlsbGFfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u ZXQvYnVnemlsbGEvYnVnemlsbGFfdW5pdHRlc3QucHkKaW5kZXggMjUwZDRiNWIxZDdkMDY2MzE0 MjlhMTE3YmEwMzUzZTc5NTRiNzk0Zi4uNTc0ZjM1MmJiZGJjMmIyYTM3Y2ExN2NiMzhmYzBkMGM3 MzcyMjNkNSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1 Z3ppbGxhL2J1Z3ppbGxhX3VuaXR0ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxsYV91bml0dGVzdC5weQpAQCAtNDMzLDYgKzQzMyw3 IEBAIGNsYXNzIEJ1Z3ppbGxhUXVlcmllc1Rlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAg ICBzZWxmLl9hc3NlcnRfcmVzdWx0X2NvdW50KHF1ZXJpZXMsICc8c3BhbiBjbGFzcz0iYnpfcmVz dWx0X2NvdW50Ij4zMTQgYnVncyBmb3VuZC48L3NwYW4+PHNwYW4gY2xhc3M9ImJ6X3Jlc3VsdF9j b3VudCI+MzE0IGJ1Z3MgZm91bmQuPC9zcGFuPicsIDMxNCkKICAgICAgICAgc2VsZi5fYXNzZXJ0 X3Jlc3VsdF9jb3VudChxdWVyaWVzLCAnPHNwYW4gY2xhc3M9ImJ6X3Jlc3VsdF9jb3VudCI+WmFy cm8gQm9vZ3MgZm91bmQuPC9zcGFuPicsIDApCiAgICAgICAgIHNlbGYuX2Fzc2VydF9yZXN1bHRf Y291bnQocXVlcmllcywgJzxzcGFuIGNsYXNzPSJiel9yZXN1bHRfY291bnQiPlxuIFxuT25lIGJ1 ZyBmb3VuZC48L3NwYW4+JywgMSkKKyAgICAgICAgc2VsZi5fYXNzZXJ0X3Jlc3VsdF9jb3VudChx dWVyaWVzLCAnJywgMCkKICAgICAgICAgc2VsZi5hc3NlcnRSYWlzZXMoRXhjZXB0aW9uLCBxdWVy aWVzLl9wYXJzZV9yZXN1bHRfY291bnQsIFsnSW52YWxpZCddKQogCiAgICAgZGVmIHRlc3RfcmVx dWVzdF9wYWdlX3BhcnNpbmcoc2VsZik6Cg==