212905 2020-06-08 08:57:55 -0700 [Flatpak][GStreamer] enhance GST_ environment variable passing 2020-06-09 01:34:16 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 vjaquez vjaquez pnormand webkit-bug-importer zan oldest_to_newest 1660227 0 vjaquez 2020-06-08 08:57:55 -0700 Particulary GST_DEBUG is passed twice, and the used one is quoted, which avoids the correct parsing in GStreamer. 1660247 1 401346 vjaquez 2020-06-08 09:36:51 -0700 Created attachment 401346 Patch 1660266 2 401346 pnormand 2020-06-08 11:05:04 -0700 Comment on attachment 401346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401346&action=review > Tools/ChangeLog:10 > + quotes, but they break the parsing in GStreamer. Break what? GST_DEBUG="foo*:5" is expanded to something else? 1660286 3 401346 vjaquez 2020-06-08 11:49:00 -0700 Comment on attachment 401346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401346&action=review >> Tools/ChangeLog:10 >> + quotes, but they break the parsing in GStreamer. > > Break what? GST_DEBUG="foo*:5" is expanded to something else? as if * were escaped and considered as a letter. 1660615 4 pnormand 2020-06-09 01:24:04 -0700 env GST_DEBUG="webkit*:6" run-minibrowser --gtk LayoutTests/media/content/test.mp4 Works as expected here. 1660618 5 ews-feeder 2020-06-09 01:34:00 -0700 Committed r262782: <https://trac.webkit.org/changeset/262782> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401346. 1660619 6 webkit-bug-importer 2020-06-09 01:34:15 -0700 <rdar://problem/64154995> 1660620 7 webkit-bug-importer 2020-06-09 01:34:16 -0700 <rdar://problem/64154996> 401346 2020-06-08 09:36:51 -0700 2020-06-09 01:34:01 -0700 Patch bug-212905-20200608183649.patch text/plain 3321 vjaquez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNzE1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDJhMTExNjlmNGNiNzQ1ZDBiZTUwMTM2Y2Y5YWQ4MjE4 MzFiMDA1My4uZDBhMWZjYjg1MDRlMDIxYjkyMWZlYWU5OTU0YzNiYTc4YTAxYjk0ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIz IEBACisyMDIwLTA2LTA4ICBWw61jdG9yIE1hbnVlbCBKw6FxdWV6IExlYWwgIDx2amFxdWV6QGln YWxpYS5jb20+CisKKyAgICAgICAgW0ZsYXRwYWtdW0dTdHJlYW1lcl0gZW5oYW5jZSBHU1RfIGVu dmlyb25tZW50IHZhcmlhYmxlIHBhc3NpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMjkwNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEhhbmRsZSB0aGUgcGFzc2luZyBvZiBzZXZlcmFsIEdTVCBlbnZp cm9ubWVudCB2YXJpYWJsZXMsCisgICAgICAgIHBhcnRpY3VsYXJseSBHU1RfREVCVUcsIHdoaWNo LCB3aGVuIHVzaW5nICogc3ltYm9sLCBweXRob24gYWRkcworICAgICAgICBxdW90ZXMsIGJ1dCB0 aGV5IGJyZWFrIHRoZSBwYXJzaW5nIGluIEdTdHJlYW1lci4KKworICAgICAgICBBbHNvIHRoZSB2 YXJpYWJsZXMgYXJlIGhhbmRsZWQgYnkgZ3N0LWVudi5weSB3aGVuIHVzaW5nCisgICAgICAgIEdT VF9CVUlMRF9QQVRILCBzbyB0aGV5IGFyZSBmaWx0ZXJlZCBvdXQgd2hlbiBpdCdzIGV4cG9ydGVk LAorICAgICAgICBhdm9pZGluZyBkdXBsaWNhdGlvbi4gQnV0IGl0IEdTVF9CVUlMRF9QQVRIIGlz IG5vdCBkZWZpbmVkLCB0aGUKKyAgICAgICAgdmFyaWFibGVzIGFyZSBwYXNzZWQgdG8gZmxhdHBh ay4KKworICAgICAgICAqIGZsYXRwYWsvZmxhdHBha3V0aWxzLnB5OgorICAgICAgICAoV2Via2l0 RmxhdHBhay5zZXR1cF9nc3RidWlsZCk6CisgICAgICAgIChXZWJraXRGbGF0cGFrLnJ1bl9pbl9z YW5kYm94KToKKwogMjAyMC0wNi0wOCAgRGllZ28gUGlubyBHYXJjaWEgIDxkcGlub0BpZ2FsaWEu Y29tPgogCiAgICAgICAgIFt3ZWJraXRweV0gTWFrZSAnd2Via2l0LXBhdGggcmViYXNlbGluZScg dG8gbm90IHVwZGF0ZSBleHBlY3RhdGlvbnMgZmlsZSBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9U b29scy9mbGF0cGFrL2ZsYXRwYWt1dGlscy5weSBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxz LnB5CmluZGV4IDIwMTRlNzcxNmIxZGZmODA1OTYwNzI5YmNkZTEyODEzYjU0YjE0YmIuLmExMjNj YjNkMTU4YTY2NTFlOGFlZmMxZDU0ZmExOTNjNjcyNTYwMDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL2Zs YXRwYWsvZmxhdHBha3V0aWxzLnB5CisrKyBiL1Rvb2xzL2ZsYXRwYWsvZmxhdHBha3V0aWxzLnB5 CkBAIC01OTQsMTMgKzU5NCwxNyBAQCBjbGFzcyBXZWJraXRGbGF0cGFrOgogICAgICAgICBjb21t YW5kID0gW29zLnBhdGguam9pbihnc3RfZGlyLCAnZ3N0LWVudi5weScpLCAnLS1idWlsZGRpcics IGdzdF9idWlsZGRpciwgJy0tc3JjZGlyJywgZ3N0X2RpciwgIi0tb25seS1lbnZpcm9ubWVudCJd CiAgICAgICAgIGdzdF9lbnYgPSBydW5fc2FuaXRpemVkKGNvbW1hbmQsIGdhdGhlcl9vdXRwdXQ9 VHJ1ZSkKICAgICAgICAgd2hpdGVsaXN0ID0gKCJMRF9MSUJSQVJZX1BBVEgiLCAiUEFUSCIsICJQ S0dfQ09ORklHX1BBVEgiKQorICAgICAgICBub3BhdGhsaXN0ID0gKCJHU1RfREVCVUciLCAiR1NU X1ZFUlNJT04iLCAiR1NUX0VOViIpCiAgICAgICAgIGVudiA9IFtdCiAgICAgICAgIGZvciBsaW5l IGluIFtsaW5lIGZvciBsaW5lIGluIGdzdF9lbnYuc3BsaXRsaW5lcygpIGlmIG5vdCBsaW5lLnN0 YXJ0c3dpdGgoImV4cG9ydCIpXToKICAgICAgICAgICAgIHRva2VucyA9IGxpbmUuc3BsaXQoIj0i KQogICAgICAgICAgICAgdmFyX25hbWUsIGNvbnRlbnRzID0gdG9rZW5zWzBdLCAiPSIuam9pbih0 b2tlbnNbMTpdKQogICAgICAgICAgICAgaWYgbm90IHZhcl9uYW1lLnN0YXJ0c3dpdGgoIkdTVF8i KSBhbmQgdmFyX25hbWUgbm90IGluIHdoaXRlbGlzdDoKICAgICAgICAgICAgICAgICBjb250aW51 ZQotICAgICAgICAgICAgbmV3X2NvbnRlbnRzID0gJzonLmpvaW4oW3NlbGYuaG9zdF9wYXRoX3Rv X3NhbmRib3hfcGF0aChwKSBmb3IgcCBpbiBjb250ZW50cy5zcGxpdCgiOiIpXSkKKyAgICAgICAg ICAgIGlmIHZhcl9uYW1lIG5vdCBpbiBub3BhdGhsaXN0OgorICAgICAgICAgICAgICAgIG5ld19j b250ZW50cyA9ICc6Jy5qb2luKFtzZWxmLmhvc3RfcGF0aF90b19zYW5kYm94X3BhdGgocCkgZm9y IHAgaW4gY29udGVudHMuc3BsaXQoIjoiKV0pCisgICAgICAgICAgICBlbHNlOgorICAgICAgICAg ICAgICAgIG5ld19jb250ZW50cyA9IGNvbnRlbnRzLnJlcGxhY2UoIiciLCAiIikKICAgICAgICAg ICAgIGVudi5hcHBlbmQoIi0tZW52PSVzPSVzIiAlICh2YXJfbmFtZSwgbmV3X2NvbnRlbnRzKSkK ICAgICAgICAgcmV0dXJuIGVudgogCkBAIC03MDAsNyArNzA0LDYgQEAgY2xhc3MgV2Via2l0Rmxh dHBhazoKICAgICAgICAgICAgICJHIiwKICAgICAgICAgICAgICJDQ0FDSEUiLAogICAgICAgICAg ICAgIkdJR0FDQUdFIiwKLSAgICAgICAgICAgICJHU1QiLAogICAgICAgICAgICAgIkdUSyIsCiAg ICAgICAgICAgICAiSUNFQ0MiLAogICAgICAgICAgICAgIkpTQyIsCkBAIC03NDUsNyArNzQ4LDcg QEAgY2xhc3MgV2Via2l0RmxhdHBhazoKICAgICAgICAgZW52X3ZhcnMudXBkYXRlKGV4dHJhX2Vu dl92YXJzKQogICAgICAgICBmb3IgZW52dmFyLCB2YWx1ZSBpbiBlbnZfdmFycy5pdGVtcygpOgog ICAgICAgICAgICAgdmFyX3Rva2VucyA9IGVudnZhci5zcGxpdCgiXyIpCi0gICAgICAgICAgICBp ZiB2YXJfdG9rZW5zWzBdIGluIGVudl92YXJfcHJlZml4ZXNfdG9fa2VlcCBvciBlbnZ2YXIgaW4g ZW52X3ZhcnNfdG9fa2VlcCBvciBlbnZ2YXJfaW5fc3VmZml4ZXNfdG9fa2VlcChlbnZ2YXIpOgor ICAgICAgICAgICAgaWYgdmFyX3Rva2Vuc1swXSBpbiBlbnZfdmFyX3ByZWZpeGVzX3RvX2tlZXAg b3IgZW52dmFyIGluIGVudl92YXJzX3RvX2tlZXAgb3IgZW52dmFyX2luX3N1ZmZpeGVzX3RvX2tl ZXAoZW52dmFyKSBvciAobm90IG9zLmVudmlyb24uZ2V0KCdHU1RfQlVJTERfUEFUSCcpIGFuZCB2 YXJfdG9rZW5zWzBdID09ICJHU1QiKToKICAgICAgICAgICAgICAgICBzYW5kYm94X2Vudmlyb25t ZW50W2VudnZhcl0gPSB2YWx1ZQogCiAgICAgICAgIHNoYXJlX25ldHdvcmtfb3B0aW9uID0gIi0t c2hhcmU9bmV0d29yayIK