212855 2020-06-05 16:16:10 -0700 WebKitLegacy: Link to framework stubs for watchOS and tvOS 2020-06-09 10:49:48 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212718 InRadar P2 Normal --- 1 jbedard jbedard aestes ap thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1659850 0 jbedard 2020-06-05 16:16:10 -0700 WebKitLegacy should link to framework stubs for watchOS and tvOS. 1659851 1 webkit-bug-importer 2020-06-05 16:16:29 -0700 <rdar://problem/64049486> 1659853 2 401214 jbedard 2020-06-05 16:26:19 -0700 Created attachment 401214 Patch 1659858 3 401214 thorton 2020-06-05 16:41:13 -0700 Comment on attachment 401214 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401214&action=review > Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:42 > +FRAMEWORK_SEARCH_PATHS[sdk=embedded*] = $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR); > +FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) "$(UMBRELLA_FRAMEWORKS_DIR)"; I think you're changing macCatalyst here (macCatalyst being "Cocoa Touch" but also sdk=macosx* is the reason I removed all the SDK conditionals back in the day). Maybe it's OK? 1659948 4 jbedard 2020-06-06 06:41:45 -0700 (In reply to Tim Horton from comment #3) > Comment on attachment 401214 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401214&action=review > > > Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:42 > > +FRAMEWORK_SEARCH_PATHS[sdk=embedded*] = $(BUILT_PRODUCTS_DIR) $(WK_PRIVATE_FRAMEWORKS_DIR); > > +FRAMEWORK_SEARCH_PATHS[sdk=macosx*] = $(WK_QUOTED_OVERRIDE_FRAMEWORKS_DIR) "$(UMBRELLA_FRAMEWORKS_DIR)"; > > I think you're changing macCatalyst here (macCatalyst being "Cocoa Touch" > but also sdk=macosx* is the reason I removed all the SDK conditionals back > in the day). Maybe it's OK? I plan on look at getting Catalyst building next. It seems to me that Catalyst should be using Mac framework stubs, although that's something we'll need to decide. 1659950 5 ews-feeder 2020-06-06 06:53:44 -0700 Committed r262676: <https://trac.webkit.org/changeset/262676> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401214. 401214 2020-06-05 16:26:19 -0700 2020-06-06 06:53:44 -0700 Patch bug-212855-20200605162618.patch text/plain 3700 jbedard SW5kZXg6IFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MjY2MykKKysrIFNv dXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsx LDE0IEBACisyMDIwLTA2LTA1ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4K KworICAgICAgICBXZWJLaXRMZWdhY3k6IExpbmsgdG8gZnJhbWV3b3JrIHN0dWJzIGZvciB3YXRj aE9TIGFuZCB0dk9TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMTI4NTUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzY0MDQ5NDg2PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMv QmFzZS54Y2NvbmZpZzogRGVmaW5lIHR2T1MgYW5kIHdhdGNoT1MgbWFqb3IgdmVyc2lvbiBtYWNy b3MuCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5LnhjY29uZmlnOiBMaW5r IHRvIGZyYW1ld29yayBzdHVicyBmb3Igd2F0Y2hPUyBhbmQgdHZPUy4KKwogMjAyMC0wNi0wNSAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtJUENdIEFkb3B0 IGVudW0gY2xhc3MgZm9yIFBsdWdpbkxvYWRDbGllbnRQb2xpY3kKSW5kZXg6IFNvdXJjZS9XZWJL aXRMZWdhY3kvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZwkocmV2 aXNpb24gMjYyNjU0KQorKysgU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ29uZmlndXJhdGlvbnMv QmFzZS54Y2NvbmZpZwkod29ya2luZyBjb3B5KQpAQCAtOTcsNyArOTcsOSBAQCBUQVJHRVRfTUFD X09TX1hfVkVSU0lPTl9NQUpPUl8xNSA9IDEwMTUwCiBUQVJHRVRfTUFDX09TX1hfVkVSU0lPTl9N QUpPUl8xNiA9IDEwMTYwMDsKIFRBUkdFVF9NQUNfT1NfWF9WRVJTSU9OX01BSk9SXzE3ID0gMTAx NzAwOwogCi1XS19UQVJHRVRfSU9TX1ZFUlNJT05fTUFKT1IgPSAkKElQSE9ORU9TX0RFUExPWU1F TlRfVEFSR0VUOmJhc2UpOyAvLyBpT1MgOS4zID0+IDkKK1dLX1RBUkdFVF9JT1NfVkVSU0lPTl9N QUpPUiA9ICQoSVBIT05FT1NfREVQTE9ZTUVOVF9UQVJHRVQ6YmFzZSk7IC8vIGUuZy4gaU9TIDku MyA9PiA5CitXS19UQVJHRVRfVFZPU19WRVJTSU9OX01BSk9SID0gJChUVk9TX0RFUExPWU1FTlRf VEFSR0VUOmJhc2UpOworV0tfVEFSR0VUX1dBVENIT1NfVkVSU0lPTl9NQUpPUiA9ICQoV0FUQ0hP U19ERVBMT1lNRU5UX1RBUkdFVDpiYXNlKTsKIAogLy8gREVCVUdfREVGSU5FUywgR0NDX09QVElN SVpBVElPTl9MRVZFTCwgU1RSSVBfSU5TVEFMTEVEX1BST0RVQ1QgYW5kIERFQURfQ09ERV9TVFJJ UFBJTkcgdmFyeSBiZXR3ZWVuIHRoZSBkZWJ1ZyBhbmQgbm9ybWFsIHZhcmlhbnRzLgogLy8gV2Ug c2V0IHVwIHRoZSB2YWx1ZXMgZm9yIGVhY2ggdmFyaWFudCBoZXJlLCBhbmQgaGF2ZSB0aGUgRGVi dWcgY29uZmlndXJhdGlvbiBpbiB0aGUgWGNvZGUgcHJvamVjdCB1c2UgdGhlIF9kZWJ1ZyB2YXJp YW50LgpJbmRleDogU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ29uZmlndXJhdGlvbnMvV2ViS2l0 TGVnYWN5LnhjY29uZmlnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0Nv bmZpZ3VyYXRpb25zL1dlYktpdExlZ2FjeS54Y2NvbmZpZwkocmV2aXNpb24gMjYyNjU0KQorKysg U291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ29uZmlndXJhdGlvbnMvV2ViS2l0TGVnYWN5LnhjY29u ZmlnCSh3b3JraW5nIGNvcHkpCkBAIC0zMywxMyArMzMsMTMgQEAgRVhDTFVERURfU09VUkNFX0ZJ TEVfTkFNRVNfID0gKklPUy5tbSBXZQogRVhQT1JURURfU1lNQk9MU19GSUxFID0gJChCVUlMVF9Q Uk9EVUNUU19ESVIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdExlZ2FjeS9XZWJLaXRMZWdhY3kuZ2Vu ZXJhdGVkLmV4cDsKIAogV0tfUFJJVkFURV9GUkFNRVdPUktTX0RJUiA9ICQoV0tfUFJJVkFURV9G UkFNRVdPUktTX0RJUl8kKFVTRV9JTlRFUk5BTF9TREspKTsKK1dLX1BSSVZBVEVfRlJBTUVXT1JL U19ESVJfW3Nkaz1tYWNvcypdID0gJChQUk9KRUNUX0RJUikvLi4vLi4vV2ViS2l0TGlicmFyaWVz L1dlYktpdFByaXZhdGVGcmFtZXdvcmtTdHVicy9NYWMvJChUQVJHRVRfTUFDX09TX1hfVkVSU0lP Tl9NQUpPUik7CiBXS19QUklWQVRFX0ZSQU1FV09SS1NfRElSX1tzZGs9aXBob25lKl0gPSAkKFBS T0pFQ1RfRElSKS8uLi8uLi9XZWJLaXRMaWJyYXJpZXMvV2ViS2l0UHJpdmF0ZUZyYW1ld29ya1N0 dWJzL2lPUy8kKFdLX1RBUkdFVF9JT1NfVkVSU0lPTl9NQUpPUik7CitXS19QUklWQVRFX0ZSQU1F V09SS1NfRElSX1tzZGs9YXBwbGV0dipdID0gJChQUk9KRUNUX0RJUikvLi4vLi4vV2ViS2l0TGli cmFyaWVzL1dlYktpdFByaXZhdGVGcmFtZXdvcmtTdHVicy9hcHBsZXR2b3MvJChXS19UQVJHRVRf VFZPU19WRVJTSU9OX01BSk9SKTsKK1dLX1BSSVZBVEVfRlJBTUVXT1JLU19ESVJfW3Nkaz13YXRj aCpdID0gJChQUk9KRUNUX0RJUikvLi4vLi4vV2ViS2l0TGlicmFyaWVzL1dlYktpdFByaXZhdGVG cmFtZXdvcmtTdHVicy93YXRjaG9zLyQoV0tfVEFSR0VUX1dBVENIT1NfVkVSU0lPTl9NQUpPUik7 CiAKLUZSQU1FV09SS19TRUFSQ0hfUEFUSFMgPSAkKEZSQU1FV09SS19TRUFSQ0hfUEFUSFNfQ09D T0FfVE9VQ0hfJChXS19JU19DT0NPQV9UT1VDSCkpOwotRlJBTUVXT1JLX1NFQVJDSF9QQVRIU19D T0NPQV9UT1VDSF9ZRVMgPSAkKEZSQU1FV09SS19TRUFSQ0hfUEFUSFNfaW9zXyQoQ09ORklHVVJB VElPTikpOwotRlJBTUVXT1JLX1NFQVJDSF9QQVRIU19pb3NfRGVidWcgPSAkKEJVSUxUX1BST0RV Q1RTX0RJUikgJChXS19QUklWQVRFX0ZSQU1FV09SS1NfRElSKTsKLUZSQU1FV09SS19TRUFSQ0hf UEFUSFNfaW9zX1JlbGVhc2UgPSAkKEZSQU1FV09SS19TRUFSQ0hfUEFUSFNfaW9zX0RlYnVnKTsK LUZSQU1FV09SS19TRUFSQ0hfUEFUSFNfQ09DT0FfVE9VQ0hfTk8gPSAkKFdLX1FVT1RFRF9PVkVS UklERV9GUkFNRVdPUktTX0RJUikgIiQoVU1CUkVMTEFfRlJBTUVXT1JLU19ESVIpIjsKK0ZSQU1F V09SS19TRUFSQ0hfUEFUSFNbc2RrPWVtYmVkZGVkKl0gPSAkKEJVSUxUX1BST0RVQ1RTX0RJUikg JChXS19QUklWQVRFX0ZSQU1FV09SS1NfRElSKTsKK0ZSQU1FV09SS19TRUFSQ0hfUEFUSFNbc2Rr PW1hY29zeCpdID0gJChXS19RVU9URURfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVIpICIkKFVNQlJF TExBX0ZSQU1FV09SS1NfRElSKSI7CiAKIFNZU1RFTV9GUkFNRVdPUktfU0VBUkNIX1BBVEhTID0g JChpbmhlcml0ZWQpICQoU0RLUk9PVCkkKFNZU1RFTV9MSUJSQVJZX0RJUikvUHJpdmF0ZUZyYW1l d29ya3MgJChTREtST09UKSQoU1lTVEVNX0xJQlJBUllfRElSKS9GcmFtZXdvcmtzOwogCg==