212831 2020-06-05 09:52:12 -0700 WebCore: Guard variable declarations on ENABLE(VIDEO_PRESENTATION_MODE) 2020-06-05 14:22:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212718 InRadar P2 Normal --- 1 jbedard jbedard aestes ap cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim jer.noble peng.liu6 philipj sergio thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1659633 0 jbedard 2020-06-05 09:52:12 -0700 m_isEnteringOrExitingPictureInPicture and m_isWaitingForPictureInPictureWindowFrame are only used if VIDEO_PRESENTATION_MODE is enabled, no reason to declare these variable on platforms with VIDEO_PRESENTATION_MODE disabled. 1659634 1 webkit-bug-importer 2020-06-05 09:52:35 -0700 <rdar://problem/64033028> 1659659 2 401166 jbedard 2020-06-05 10:00:00 -0700 Created attachment 401166 Patch 1659678 3 thorton 2020-06-05 10:29:01 -0700 IMO you can land things like this as "build fixes" without review if you want. 1659686 4 jbedard 2020-06-05 10:38:06 -0700 (In reply to Tim Horton from comment #3) > IMO you can land things like this as "build fixes" without review if you > want. There aren't many this trivial, I'm trying separate these into small enough changes that roll-outs for breaking other builds won't be too painful. 1659693 5 ews-feeder 2020-06-05 10:56:02 -0700 Committed r262633: <https://trac.webkit.org/changeset/262633> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401166. 1659694 6 401166 peng.liu6 2020-06-05 11:00:18 -0700 Comment on attachment 401166 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401166&action=review > Source/WebCore/html/HTMLVideoElement.h:136 > bool m_isChangingPresentationMode { false }; And this variable as well :-) 1659784 7 401166 jbedard 2020-06-05 14:07:38 -0700 Comment on attachment 401166 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401166&action=review >> Source/WebCore/html/HTMLVideoElement.h:136 >> bool m_isChangingPresentationMode { false }; > > And this variable as well :-) Actually, m_isChangingPresentationMode is used in webkitDisplayingFullscreen, which isn't guarded by ENABLE(VIDEO_PRESENTATION_MODE). 1659787 8 401166 peng.liu6 2020-06-05 14:22:00 -0700 Comment on attachment 401166 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401166&action=review >>> Source/WebCore/html/HTMLVideoElement.h:136 >>> bool m_isChangingPresentationMode { false }; >> >> And this variable as well :-) > > Actually, m_isChangingPresentationMode is used in webkitDisplayingFullscreen, which isn't guarded by ENABLE(VIDEO_PRESENTATION_MODE). Oh right! 401166 2020-06-05 10:00:00 -0700 2020-06-05 10:56:03 -0700 Patch bug-212831-20200605095959.patch text/plain 1373 jbedard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MjYyNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDIwLTA2LTA1ICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJDb3JlOiBHdWFyZCB2 YXJpYWJsZSBkZWNsYXJhdGlvbnMgb24gRU5BQkxFKFZJREVPX1BSRVNFTlRBVElPTl9NT0RFKQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyODMxCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS82NDAzMzAyOD4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIGJlaGF2aW9yIGNoYW5n ZWQuCisKKyAgICAgICAgKiBodG1sL0hUTUxWaWRlb0VsZW1lbnQuaDoKKwogMjAyMC0wNi0wNSAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgW0NvY29hXSBVc2Ug QVZBc3NldFdyaXRlckRlbGVnYXRlIHRvIGltcGxlbWVudCBNZWRpYVJlY29yZGVyCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxWaWRlb0VsZW1lbnQuaAkocmV2aXNpb24gMjYyNTk0KQorKysg U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MVmlkZW9FbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAg LTEzMywxMCArMTMzLDEzIEBAIHByaXZhdGU6CiAKICAgICB1bnNpZ25lZCBtX2xhc3RSZXBvcnRl ZFZpZGVvV2lkdGggeyAwIH07CiAgICAgdW5zaWduZWQgbV9sYXN0UmVwb3J0ZWRWaWRlb0hlaWdo dCB7IDAgfTsKLQogICAgIGJvb2wgbV9pc0NoYW5naW5nUHJlc2VudGF0aW9uTW9kZSB7IGZhbHNl IH07CisKKyNpZiBFTkFCTEUoVklERU9fUFJFU0VOVEFUSU9OX01PREUpCiAgICAgYm9vbCBtX2lz RW50ZXJpbmdPckV4aXRpbmdQaWN0dXJlSW5QaWN0dXJlIHsgZmFsc2UgfTsKICAgICBib29sIG1f aXNXYWl0aW5nRm9yUGljdHVyZUluUGljdHVyZVdpbmRvd0ZyYW1lIHsgZmFsc2UgfTsKKyNlbmRp ZgorCiAjaWYgRU5BQkxFKFBJQ1RVUkVfSU5fUElDVFVSRV9BUEkpCiAgICAgUGljdHVyZUluUGlj dHVyZU9ic2VydmVyKiBtX3BpY3R1cmVJblBpY3R1cmVPYnNlcnZlciB7IG51bGxwdHIgfTsKICNl bmRpZgo=