212829 2020-06-05 09:31:11 -0700 Accessibility isolated tree mode: crashes when navigating websites, com.apple.AppKit: ConvertOutgoingValueForAttribute. 2020-06-05 11:06:04 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white oldest_to_newest 1659622 0 andresg_22 2020-06-05 09:31:11 -0700 Accessibility isolated tree mode: crashes when navigating websites, com.apple.AppKit: ConvertOutgoingValueForAttribute. 1659626 1 401164 andresg_22 2020-06-05 09:40:49 -0700 Created attachment 401164 Patch 1659627 2 andresg_22 2020-06-05 09:43:04 -0700 <rdar://problem/63756267> 1659698 3 ews-feeder 2020-06-05 11:06:03 -0700 Committed r262635: <https://trac.webkit.org/changeset/262635> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401164. 401164 2020-06-05 09:40:49 -0700 2020-06-05 11:06:03 -0700 Patch bug-212829-20200605124048.patch text/plain 5833 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNDYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWViNGQ3ODBiMGRiNDUw NTMzMTA2MTM1YWQzMTRhYmRkYzMxOTUwZi4uZWUzNmQ5ZjgwNTgxMTBmNzgxNmMwM2Y3ZDQzZDJi MTAzNmVjMzcyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA2LTA1ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBY2Nlc3NpYmls aXR5IGlzb2xhdGVkIHRyZWUgbW9kZTogY3Jhc2hlcyB3aGVuIG5hdmlnYXRpbmcgd2Vic2l0ZXMs IGNvbS5hcHBsZS5BcHBLaXQ6IENvbnZlcnRPdXRnb2luZ1ZhbHVlRm9yQXR0cmlidXRlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyODI5CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS82Mzc1NjI2Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAtIFtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlciB0 ZXh0TWFya2VyUmFuZ2VGcm9tVmlzaWJsZVBvc2l0aW9uc10gbXVzdAorICAgICAgICByZXRyaWV2 ZSBhbiBhdXRvcmVsZWFzZWQgaWQgZnJvbSB0aGUgbWFpbiB0aHJlYWQuCisgICAgICAgIC0gW1dl YkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyIHRleHRNYXJrZXJSYW5nZUZvclNlbGVjdGlvbl0g bXVzdCBhbHNvCisgICAgICAgIHJldHJpZXZlIGFuIGF1dG9yZWxlYXNlZCBpZCBmcm9tIHRoZSBt YWluIHRocmVhZC4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvbWFjL1dlYkFjY2Vzc2liaWxp dHlPYmplY3RXcmFwcGVyTWFjLm1tOgorICAgICAgICAoLVtXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0 V3JhcHBlciB0ZXh0TWFya2VyUmFuZ2VGcm9tVmlzaWJsZVBvc2l0aW9uczplbmRQb3NpdGlvbjpd KToKKyAgICAgICAgKC1bV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXIgdGV4dE1hcmtlclJh bmdlRm9yU2VsZWN0aW9uXSk6CisgICAgICAgICgtW1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFw cGVyIGFjY2Vzc2liaWxpdHlBdHRyaWJ1dGVWYWx1ZTpdKToKKyAgICAgICAgKC1bV2ViQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXIgYWNjZXNzaWJpbGl0eUF0dHJpYnV0ZVZhbHVlOmZvclBhcmFt ZXRlcjpdKToKKwogMjAyMC0wNi0wMiAgQW5kcmVzIEdvbnphbGV6ICA8YW5kcmVzZ18yMkBhcHBs ZS5jb20+CiAKICAgICAgICAgQVhJc29sYXRlZFRyZWU6OnVwZGF0ZU5vZGUgc2hvdWxkIG5vdCBj YWxsIG5vZGVGb3JJRC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv bWFjL1dlYkFjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVyTWFjLm1tIGIvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0KaW5k ZXggMDg3MmE0MDg3NTFjY2M4ZTE0NDJlNTU0NjVlNzUyZDhiODdmYzBhZC4uMjFiMDFjN2Q1YTEz M2NmNGNhMTg5ODkwMDc2M2MzYjJlNDZjN2FmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJNYWMubW0KKysr IGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9tYWMvV2ViQWNjZXNzaWJpbGl0eU9iamVj dFdyYXBwZXJNYWMubW0KQEAgLTEyODQsNyArMTI4NCw3IEBAIHN0YXRpYyBOU1N0cmluZyogbnNT dHJpbmdGb3JSZXBsYWNlZE5vZGUoTm9kZSogcmVwbGFjZWROb2RlKQogCiAtIChpZCl0ZXh0TWFy a2VyUmFuZ2VGcm9tVmlzaWJsZVBvc2l0aW9uczooY29uc3QgVmlzaWJsZVBvc2l0aW9uJilzdGFy dFBvc2l0aW9uIGVuZFBvc2l0aW9uOihjb25zdCBWaXNpYmxlUG9zaXRpb24mKWVuZFBvc2l0aW9u CiB7Ci0gICAgcmV0dXJuIEFjY2Vzc2liaWxpdHk6OnJldHJpZXZlVmFsdWVGcm9tTWFpblRocmVh ZDxOU0F0dHJpYnV0ZWRTdHJpbmcgKj4oWyZzdGFydFBvc2l0aW9uLCAmZW5kUG9zaXRpb24sIHBy b3RlY3RlZFNlbGYgPSByZXRhaW5QdHIoc2VsZildICgpIC0+IGlkIHsKKyAgICByZXR1cm4gQWNj ZXNzaWJpbGl0eTo6cmV0cmlldmVBdXRvcmVsZWFzZWRWYWx1ZUZyb21NYWluVGhyZWFkPGlkPihb JnN0YXJ0UG9zaXRpb24sICZlbmRQb3NpdGlvbiwgcHJvdGVjdGVkU2VsZiA9IHJldGFpblB0cihz ZWxmKV0gKCkgLT4gUmV0YWluUHRyPGlkPiB7CiAgICAgICAgIGF1dG8qIGJhY2tpbmdPYmplY3Qg PSBwcm90ZWN0ZWRTZWxmLmdldCgpLmF4QmFja2luZ09iamVjdDsKICAgICAgICAgaWYgKCFiYWNr aW5nT2JqZWN0KQogICAgICAgICAgICAgcmV0dXJuIG5pbDsKQEAgLTE4ODEsMTAgKzE4ODEsMTYg QEAgc3RhdGljIHZvaWQgY29udmVydFRvVmVjdG9yKE5TQXJyYXkqIGFycmF5LCBBY2Nlc3NpYmls aXR5T2JqZWN0OjpBY2Nlc3NpYmlsaXR5Q2gKIAogLSAoaWQpdGV4dE1hcmtlclJhbmdlRm9yU2Vs ZWN0aW9uCiB7Ci0gICAgVmlzaWJsZVNlbGVjdGlvbiBzZWxlY3Rpb24gPSBzZWxmLmF4QmFja2lu Z09iamVjdC0+c2VsZWN0aW9uKCk7Ci0gICAgaWYgKHNlbGVjdGlvbi5pc05vbmUoKSkKLSAgICAg ICAgcmV0dXJuIG5pbDsKLSAgICByZXR1cm4gW3NlbGYgdGV4dE1hcmtlclJhbmdlRnJvbVZpc2li bGVQb3NpdGlvbnM6c2VsZWN0aW9uLnZpc2libGVTdGFydCgpIGVuZFBvc2l0aW9uOnNlbGVjdGlv bi52aXNpYmxlRW5kKCldOworICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5OjpyZXRyaWV2ZUF1dG9y ZWxlYXNlZFZhbHVlRnJvbU1haW5UaHJlYWQ8aWQ+KFtwcm90ZWN0ZWRTZWxmID0gcmV0YWluUHRy KHNlbGYpXSAoKSAtPiBSZXRhaW5QdHI8aWQ+IHsKKyAgICAgICAgYXV0byogYmFja2luZ09iamVj dCA9IHByb3RlY3RlZFNlbGYuZ2V0KCkuYXhCYWNraW5nT2JqZWN0OworICAgICAgICBpZiAoIWJh Y2tpbmdPYmplY3QpCisgICAgICAgICAgICByZXR1cm4gbmlsOworCisgICAgICAgIFZpc2libGVT ZWxlY3Rpb24gc2VsZWN0aW9uID0gYmFja2luZ09iamVjdC0+c2VsZWN0aW9uKCk7CisgICAgICAg IGlmIChzZWxlY3Rpb24uaXNOb25lKCkpCisgICAgICAgICAgICByZXR1cm4gbmlsOworICAgICAg ICByZXR1cm4gdGV4dE1hcmtlclJhbmdlRnJvbVZpc2libGVQb3NpdGlvbnMoYmFja2luZ09iamVj dC0+YXhPYmplY3RDYWNoZSgpLCBzZWxlY3Rpb24udmlzaWJsZVN0YXJ0KCksIHNlbGVjdGlvbi52 aXNpYmxlRW5kKCkpOworICAgIH0pOwogfQogCiAtIChpZClhc3NvY2lhdGVkUGx1Z2luUGFyZW50 CkBAIC0yODA1LDExICsyODExLDggQEAgQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1FTlRBVElPTlNf RU5ECiAgICAgaWYgKGJhY2tpbmdPYmplY3QtPmlzTGlzdCgpICYmIFthdHRyaWJ1dGVOYW1lIGlz RXF1YWxUb1N0cmluZzpOU0FjY2Vzc2liaWxpdHlPcmllbnRhdGlvbkF0dHJpYnV0ZV0pCiAgICAg ICAgIHJldHVybiBOU0FjY2Vzc2liaWxpdHlWZXJ0aWNhbE9yaWVudGF0aW9uVmFsdWU7CiAKLSAg ICBpZiAoW2F0dHJpYnV0ZU5hbWUgaXNFcXVhbFRvU3RyaW5nOkAiQVhTZWxlY3RlZFRleHRNYXJr ZXJSYW5nZSJdKSB7Ci0gICAgICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5OjpyZXRyaWV2ZUF1dG9y ZWxlYXNlZFZhbHVlRnJvbU1haW5UaHJlYWQ8aWQ+KFtwcm90ZWN0ZWRTZWxmID0gcmV0YWluUHRy KHNlbGYpXSAoKSAtPiBSZXRhaW5QdHI8aWQ+IHsKLSAgICAgICAgICAgIHJldHVybiBbcHJvdGVj dGVkU2VsZiB0ZXh0TWFya2VyUmFuZ2VGb3JTZWxlY3Rpb25dOwotICAgICAgICB9KTsKLSAgICB9 CisgICAgaWYgKFthdHRyaWJ1dGVOYW1lIGlzRXF1YWxUb1N0cmluZzpAIkFYU2VsZWN0ZWRUZXh0 TWFya2VyUmFuZ2UiXSkKKyAgICAgICAgcmV0dXJuIFtzZWxmIHRleHRNYXJrZXJSYW5nZUZvclNl bGVjdGlvbl07CiAKICAgICBpZiAoW2F0dHJpYnV0ZU5hbWUgaXNFcXVhbFRvU3RyaW5nOkAiQVhT dGFydFRleHRNYXJrZXIiXSkgewogICAgICAgICByZXR1cm4gQWNjZXNzaWJpbGl0eTo6cmV0cmll dmVBdXRvcmVsZWFzZWRWYWx1ZUZyb21NYWluVGhyZWFkPGlkPihbcHJvdGVjdGVkU2VsZiA9IHJl dGFpblB0cihzZWxmKV0gKCkgLT4gUmV0YWluUHRyPGlkPiB7CkBAIC00MDg4LDEwICs0MDkxLDEz IEBAIEFMTE9XX0RFUFJFQ0FURURfSU1QTEVNRU5UQVRJT05TX0VORAogICAgIGlmIChbYXR0cmli dXRlIGlzRXF1YWxUb1N0cmluZzpAIkFYVGV4dE1hcmtlclJhbmdlRm9yTGluZSJdKSB7CiAgICAg ICAgIHJldHVybiBBY2Nlc3NpYmlsaXR5OjpyZXRyaWV2ZUF1dG9yZWxlYXNlZFZhbHVlRnJvbU1h aW5UaHJlYWQ8aWQ+KFsmbnVtYmVyLCBwcm90ZWN0ZWRTZWxmID0gcmV0YWluUHRyKHNlbGYpXSAo KSAtPiBSZXRhaW5QdHI8aWQ+IHsKICAgICAgICAgICAgIGF1dG8qIGJhY2tpbmdPYmplY3QgPSBw cm90ZWN0ZWRTZWxmLmdldCgpLmF4QmFja2luZ09iamVjdDsKKyAgICAgICAgICAgIGlmICghYmFj a2luZ09iamVjdCkKKyAgICAgICAgICAgICAgICByZXR1cm4gbmlsOworCiAgICAgICAgICAgICBW aXNpYmxlUG9zaXRpb25SYW5nZSB2cFJhbmdlOwotICAgICAgICAgICAgaWYgKGJhY2tpbmdPYmpl Y3QgJiYgW251bWJlciB1bnNpZ25lZEludGVnZXJWYWx1ZV0gIT0gTlNOb3RGb3VuZCkKKyAgICAg ICAgICAgIGlmIChbbnVtYmVyIHVuc2lnbmVkSW50ZWdlclZhbHVlXSAhPSBOU05vdEZvdW5kKQog ICAgICAgICAgICAgICAgIHZwUmFuZ2UgPSBiYWNraW5nT2JqZWN0LT52aXNpYmxlUG9zaXRpb25S YW5nZUZvckxpbmUoW251bWJlciB1bnNpZ25lZEludFZhbHVlXSk7Ci0gICAgICAgICAgICByZXR1 cm4gW3Byb3RlY3RlZFNlbGYgdGV4dE1hcmtlclJhbmdlRnJvbVZpc2libGVQb3NpdGlvbnM6dnBS YW5nZS5zdGFydCBlbmRQb3NpdGlvbjp2cFJhbmdlLmVuZF07CisgICAgICAgICAgICByZXR1cm4g dGV4dE1hcmtlclJhbmdlRnJvbVZpc2libGVQb3NpdGlvbnMoYmFja2luZ09iamVjdC0+YXhPYmpl Y3RDYWNoZSgpLCB2cFJhbmdlLnN0YXJ0LCB2cFJhbmdlLmVuZCk7CiAgICAgICAgIH0pOwogICAg IH0KIApAQCAtNDI5Myw5ICs0Mjk5LDkgQEAgQUxMT1dfREVQUkVDQVRFRF9JTVBMRU1FTlRBVElP TlNfRU5ECiAgICAgICAgICAgICBpZiAoIWNhY2hlKQogICAgICAgICAgICAgICAgIHJldHVybiBu aWw7CiAKLSAgICAgICAgVmlzaWJsZVBvc2l0aW9uIHZpc2libGVQb3MgPSB2aXNpYmxlUG9zaXRp b25Gb3JUZXh0TWFya2VyKGNhY2hlLCB0ZXh0TWFya2VyKTsKLSAgICAgICAgVmlzaWJsZVBvc2l0 aW9uUmFuZ2UgdnBSYW5nZSA9IGJhY2tpbmdPYmplY3QtPnN0eWxlUmFuZ2VGb3JQb3NpdGlvbih2 aXNpYmxlUG9zKTsKLSAgICAgICAgcmV0dXJuIFtwcm90ZWN0ZWRTZWxmIHRleHRNYXJrZXJSYW5n ZUZyb21WaXNpYmxlUG9zaXRpb25zOnZwUmFuZ2Uuc3RhcnQgZW5kUG9zaXRpb246dnBSYW5nZS5l bmRdOworICAgICAgICAgICAgVmlzaWJsZVBvc2l0aW9uIHZpc2libGVQb3MgPSB2aXNpYmxlUG9z aXRpb25Gb3JUZXh0TWFya2VyKGNhY2hlLCB0ZXh0TWFya2VyKTsKKyAgICAgICAgICAgIFZpc2li bGVQb3NpdGlvblJhbmdlIHZwUmFuZ2UgPSBiYWNraW5nT2JqZWN0LT5zdHlsZVJhbmdlRm9yUG9z aXRpb24odmlzaWJsZVBvcyk7CisgICAgICAgICAgICByZXR1cm4gdGV4dE1hcmtlclJhbmdlRnJv bVZpc2libGVQb3NpdGlvbnMoY2FjaGUsIHZwUmFuZ2Uuc3RhcnQsIHZwUmFuZ2UuZW5kKTsKICAg ICAgICAgfSk7CiAgICAgfQogCg==