212823 2020-06-05 08:23:10 -0700 Unused parameter warnings in EventRegion.cpp and RenderLayerBacking.cpp 2020-06-05 09:25:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro mcatanzaro webkit-bug-importer oldest_to_newest 1659591 0 mcatanzaro 2020-06-05 08:23:10 -0700 [1339/1877] Building CXX object Source/WebCore/CMakeFiles...es/WebCore/unified-sources/UnifiedSource-043dd90b-2.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-2.cpp:3: /home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/EventRegion.cpp: In member function ‘void WebCore::EventRegion::unite(const WebCore::Region&, const WebCore::RenderStyle&, bool)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/EventRegion.cpp:120:66: warning: unused parameter ‘style’ [-Wunused-parameter] 120 | void EventRegion::unite(const Region& region, const RenderStyle& style, bool overrideUserModifyIsEditable) | ~~~~~~~~~~~~~~~~~~~^~~~~ [1392/1877] Building CXX object Source/WebCore/CMakeFiles...es/WebCore/unified-sources/UnifiedSource-043dd90b-9.cpp.o In file included from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-9.cpp:2: /home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/RenderLayerBacking.cpp: In member function ‘void WebCore::RenderLayerBacking::paintDebugOverlays(const WebCore::GraphicsLayer*, WebCore::GraphicsContext&)’: /home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/RenderLayerBacking.cpp:3203:10: warning: unused variable ‘visibleDebugOverlayRegions’ [-Wunused-variable] 3203 | auto visibleDebugOverlayRegions = renderer().settings().visibleDebugOverlayRegions(); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ /home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/RenderLayerBacking.cpp: At global scope: /home/mcatanzaro/Projects/WebKit/Source/WebCore/rendering/RenderLayerBacking.cpp:3094:24: warning: ‘WTF::RefPtr<WebCore::Pattern> WebCore::patternForDescription(WebCore::PatternDescription, WebCore::FloatSize, WebCore::GraphicsContext&)’ defined but not used [-Wunused-function] 3094 | static RefPtr<Pattern> patternForDescription(PatternDescription description, FloatSize contentOffset, GraphicsContext& destContext) | ^~~~~~~~~~~~~~~~~~~~~ 1659592 1 401156 mcatanzaro 2020-06-05 08:23:52 -0700 Created attachment 401156 Patch for landing 1659608 2 ews-feeder 2020-06-05 09:10:24 -0700 Committed r262623: <https://trac.webkit.org/changeset/262623> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401156. 1659614 3 webkit-bug-importer 2020-06-05 09:25:14 -0700 <rdar://problem/64031883> 1659615 4 webkit-bug-importer 2020-06-05 09:25:14 -0700 <rdar://problem/64031882> 401156 2020-06-05 08:23:52 -0700 2020-06-05 09:10:24 -0700 Patch for landing bug-212823-20200605102352.patch text/plain 2818 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNjE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE0NTA0ZjBlODE4NWQx MDJmYmNmZTE2ZDhiYjdmM2M1MTRkMzg5NC4uZmIyMjU3MzUzZDA3YjQxOGFiYThkMmJhY2E2OTJl NTQ2NzY3ZDFiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA2LTA1ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AZ25vbWUub3JnPgorCisgICAgICAgIFVucmV2aWV3 ZWQsIGZpeCB1bnVzZWQgcGFyYW1ldGVyIHdhcm5pbmdzIGluIEV2ZW50UmVnaW9uLmNwcCBhbmQg UmVuZGVyTGF5ZXJCYWNraW5nLmNwcAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjEyODIzCisKKyAgICAgICAgKiByZW5kZXJpbmcvRXZlbnRSZWdpb24u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RXZlbnRSZWdpb246OnVuaXRlKToKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckxheWVyQmFja2luZzo6cGFpbnREZWJ1Z092ZXJsYXlzKToKKwogMjAyMC0wNi0wNSAgQW50dGkg S29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI1Mzg3 NT8pOiBFbGVtZW50IHN0eWxlcyBpbmNvcnJlY3QgYWZ0ZXIgbWVkaWEgcXVlcnkgZXZhbHVhdGlv biBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRXZlbnRSZWdp b24uY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0V2ZW50UmVnaW9uLmNwcAppbmRleCBm MTU3OTYzNDFmMzRhYzAwZWU5NTUyMzAzZjQzMjA4NGQyZmIxNTkyLi42M2NiMjNkN2ZlOWQwN2Q0 Yjg0ZWQ0YTE4MmY4ZGMxZTJiOWY0MzMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvRXZlbnRSZWdpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9FdmVu dFJlZ2lvbi5jcHAKQEAgLTEzNSw2ICsxMzUsMTAgQEAgdm9pZCBFdmVudFJlZ2lvbjo6dW5pdGUo Y29uc3QgUmVnaW9uJiByZWdpb24sIGNvbnN0IFJlbmRlclN0eWxlJiBzdHlsZSwgYm9vbCBvdmUK ICNlbHNlCiAgICAgVU5VU0VEX1BBUkFNKG92ZXJyaWRlVXNlck1vZGlmeUlzRWRpdGFibGUpOwog I2VuZGlmCisKKyNpZiAhRU5BQkxFKFRPVUNIX0FDVElPTl9SRUdJT05TKSAmJiAhRU5BQkxFKFdI RUVMX0VWRU5UX1JFR0lPTlMpICYmICFFTkFCTEUoRURJVEFCTEVfUkVHSU9OKQorICAgIFVOVVNF RF9QQVJBTShzdHlsZSk7CisjZW5kaWYKIH0KIAogdm9pZCBFdmVudFJlZ2lvbjo6dHJhbnNsYXRl KGNvbnN0IEludFNpemUmIG9mZnNldCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckxheWVyQmFja2luZy5jcHAKaW5kZXggNDY1MTE5YTcyODFkNDYwYmY3YTFmYzQyMjExMmQw OTNiY2ExODRmNS4uOTZlZmUwYjBkNmZhYjcyOTRhMzU5NGI2ODIyMGZlODRlZmVmZmZiMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAKQEAg LTMwODUsNiArMzA4NSw3IEBAIE9wdGlvblNldDxSZW5kZXJMYXllcjo6UGFpbnRMYXllckZsYWc+ IFJlbmRlckxheWVyQmFja2luZzo6cGFpbnRGbGFnc0ZvckxheWVyKGNvCiAgICAgcmV0dXJuIHBh aW50RmxhZ3M7CiB9CiAKKyNpZiBFTkFCTEUoVE9VQ0hfQUNUSU9OX1JFR0lPTlMpIHx8IEVOQUJM RShXSEVFTF9FVkVOVF9SRUdJT05TKQogc3RydWN0IFBhdHRlcm5EZXNjcmlwdGlvbiB7CiAgICAg QVNDSUlMaXRlcmFsIG5hbWU7CiAgICAgRmxvYXRTaXplIHBoYXNlOwpAQCAtMzEyNyw2ICszMTI4 LDcgQEAgc3RhdGljIFJlZlB0cjxQYXR0ZXJuPiBwYXR0ZXJuRm9yRGVzY3JpcHRpb24oUGF0dGVy bkRlc2NyaXB0aW9uIGRlc2NyaXB0aW9uLCBGbG8KIAogICAgIHJldHVybiBmaWxsUGF0dGVybjsK IH07CisjZW5kaWYKIAogI2lmIEVOQUJMRShUT1VDSF9BQ1RJT05fUkVHSU9OUykKIHN0YXRpYyBS ZWZQdHI8UGF0dGVybj4gcGF0dGVybkZvclRvdWNoQWN0aW9uKFRvdWNoQWN0aW9uIHRvdWNoQWN0 aW9uLCBGbG9hdFNpemUgY29udGVudE9mZnNldCwgR3JhcGhpY3NDb250ZXh0JiBkZXN0Q29udGV4 dCkKQEAgLTMyMDAsNyArMzIwMiw5IEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5nOjpwYWludERl YnVnT3ZlcmxheXMoY29uc3QgR3JhcGhpY3NMYXllciogZ3JhcGhpY3NMYXllciwKICAgICBhdXRv IGNvbnRlbnRPZmZzZXQgPSByb3VuZGVkSW50U2l6ZShjb250ZW50T2Zmc2V0SW5Db21wb3NpdGlu Z0xheWVyKCkpOwogICAgIGNvbnRleHQudHJhbnNsYXRlKC1jb250ZW50T2Zmc2V0KTsKIAorI2lm IEVOQUJMRShUT1VDSF9BQ1RJT05fUkVHSU9OUykgfHwgRU5BQkxFKFdIRUVMX0VWRU5UX1JFR0lP TlMpIHx8IEVOQUJMRShFRElUQUJMRV9SRUdJT04pCiAgICAgYXV0byB2aXNpYmxlRGVidWdPdmVy bGF5UmVnaW9ucyA9IHJlbmRlcmVyKCkuc2V0dGluZ3MoKS52aXNpYmxlRGVidWdPdmVybGF5UmVn aW9ucygpOworI2VuZGlmCiAKICAgICAvLyBUaGUgaW50ZXJhY3RpdmUgcGFydC4KICNpZiBFTkFC TEUoVE9VQ0hfQUNUSU9OX1JFR0lPTlMpCg==