212797 2020-06-04 21:03:15 -0700 [WPE] Behave like GDK_CURRENT_TIME when the timestamp is zero 2020-06-07 17:16:45 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lmoura lmoura aperez bugs-noreply cgarcia oldest_to_newest 1659469 0 lmoura 2020-06-04 21:03:15 -0700 When the timestamp is zero, use WallTime::now() as the event time. Zero timestamps can happen in the WebDriver tests. Follow up to bug212338. 1659470 1 401115 lmoura 2020-06-04 21:06:53 -0700 Created attachment 401115 Patch 1659802 2 401115 aperez 2020-06-05 14:41:15 -0700 Comment on attachment 401115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401115&action=review > Source/WebKit/Shared/libwpe/WebEventFactory.cpp:68 > + return WallTime::now(); I *think* that this is right, but I would prefer that Carlos García confirms =) 1659939 3 401115 cgarcia 2020-06-06 05:12:13 -0700 Comment on attachment 401115 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401115&action=review > Source/WebKit/Shared/libwpe/WebEventFactory.cpp:66 > + // Behave like GDK_CURRENT_TIME I would remove this comment, it might be confusing. Or I would say something like 0 means current time. 1660114 4 lmoura 2020-06-07 17:16:45 -0700 Committed r262702: <https://trac.webkit.org/changeset/262702> 401115 2020-06-04 21:06:53 -0700 2020-06-06 05:12:13 -0700 Patch bug-212797-20200605010651.patch text/plain 1562 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDllNWU1MDIyNTk4MTE5OWNl NGRjMDIwYjM2ZmQ2OGYyZDQ5NGVhYWMuLmEyM2FjMGRmYzY2NjZjZDc5ZTFhY2NhZmYyNzY0ZTA3 ODM5NjhhYzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDYtMDQgIExhdXJvIE1v dXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV0gQmVoYXZlIGxpa2UgR0RL X0NVUlJFTlRfVElNRSB3aGVuIHRoZSB0aW1lc3RhbXAgaXMgemVybworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNzk3CisKKyAgICAgICAgV2ViRHJp dmVyIHRlc3RzIGNvbWUgd2l0aCB6ZXJvIHRpbWVzdGFtcC4gU28gYmVoYXZlIGxpa2UKKyAgICAg ICAgR0RLX0NVUlJFTlRfVElNRSBhbmQgYXNzdW1lIHplcm8gdGltZXN0YW1wID09IFdhbGxUaW1l Ojpub3coKS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogU2hhcmVkL2xpYndwZS9X ZWJFdmVudEZhY3RvcnkuY3BwOgorICAgICAgICAoV2ViS2l0Ojp3YWxsVGltZUZvckV2ZW50VGlt ZSk6CisKIDIwMjAtMDYtMDQgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAg ICAgICBVSVByb2Nlc3MgbWF5IGNyYXNoIGFmdGVyIGl0cyBwcmV3YXJtZWQgV2ViUHJvY2VzcyBn ZXRzIHRlcm1pbmF0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2xpYndwZS9X ZWJFdmVudEZhY3RvcnkuY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvbGlid3BlL1dlYkV2ZW50 RmFjdG9yeS5jcHAKaW5kZXggNTlmY2IwYWU5OTFmMmE0NThhOWFlOTUzNTliMGM3YTU4MDJhZmZj YS4uMzQ1ZTJjMmMwYmUyMGI5NmNlZTJlMWE4NzAxYTExNWMxYzM4YjBhNSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9TaGFyZWQvbGlid3BlL1dlYkV2ZW50RmFjdG9yeS5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9TaGFyZWQvbGlid3BlL1dlYkV2ZW50RmFjdG9yeS5jcHAKQEAgLTYzLDYgKzYz LDEwIEBAIFdhbGxUaW1lIHdhbGxUaW1lRm9yRXZlbnRUaW1lKHVpbnQ2NF90IG1zVGltZVN0YW1w KQogICAgIHN0YXRpYyBXYWxsVGltZSBmaXJzdEV2ZW50V2FsbFRpbWU7CiAgICAgc3RhdGljIHN0 ZDo6b25jZV9mbGFnIG9uY2U7CiAKKyAgICAvLyBCZWhhdmUgbGlrZSBHREtfQ1VSUkVOVF9USU1F CisgICAgaWYgKCFtc1RpbWVTdGFtcCkKKyAgICAgICAgcmV0dXJuIFdhbGxUaW1lOjpub3coKTsK KwogICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2UsIFttc1RpbWVTdGFtcF0oKSB7CiAgICAgICAgIGZp cnN0RXZlbnRUaW1lU3RhbXAgPSBtc1RpbWVTdGFtcDsKICAgICAgICAgZmlyc3RFdmVudFdhbGxU aW1lID0gV2FsbFRpbWU6Om5vdygpOwo=