212796 2020-06-04 19:58:53 -0700 WTF: Exclude MachExceptions.defs from all embedded builds 2020-06-05 09:58:24 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212718 InRadar P2 Normal --- 1 jbedard jbedard aestes ap thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1659454 0 jbedard 2020-06-04 19:58:53 -0700 MachExceptions.defs is excluded from OpenSource iPhone builds, and should also be excluded from other OpenSource embedded builds. 1659460 1 401113 jbedard 2020-06-04 20:11:09 -0700 Created attachment 401113 Patch 1659465 2 401113 ap 2020-06-04 20:48:00 -0700 Comment on attachment 401113 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401113&action=review > Source/WTF/ChangeLog:10 > +2020-06-04 Jonathan Bedard <jbedard@apple.com> Extra change log. > Source/WTF/Configurations/WTF.xcconfig:-35 > -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks This seems unrelated. > Source/WTF/Configurations/WTF.xcconfig:32 > +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK)); This includes simulator, correct? 1659472 3 401117 jbedard 2020-06-04 21:18:19 -0700 Created attachment 401117 Patch 1659483 4 jbedard 2020-06-04 22:02:58 -0700 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 401113 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401113&action=review > > > Source/WTF/ChangeLog:10 > > +2020-06-04 Jonathan Bedard <jbedard@apple.com> > > Extra change log. > > > Source/WTF/Configurations/WTF.xcconfig:-35 > > -SYSTEM_FRAMEWORK_SEARCH_PATHS = $(inherited) $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks > > This seems unrelated. > > > Source/WTF/Configurations/WTF.xcconfig:32 > > +EXCLUDED_SOURCE_FILE_NAMES[sdk=embedded*] = $(EXCLUDED_SOURCE_FILE_NAMES_$(USE_INTERNAL_SDK)); > > This includes simulator, correct? It does, this same pattern will show up a few more times in other xcconfig files. 1659485 5 ews-feeder 2020-06-04 22:29:10 -0700 Committed r262597: <https://trac.webkit.org/changeset/262597> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401117. 1659650 6 webkit-bug-importer 2020-06-05 09:58:24 -0700 <rdar://problem/64033297> 401113 2020-06-04 20:11:09 -0700 2020-06-04 21:18:17 -0700 Patch bug-212796-20200604201108.patch text/plain 1732 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjI1OTEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA2LTA0ICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXVEY6IEV4Y2x1ZGUgTWFjaEV4Y2VwdGlvbnMu ZGVmcyBmcm9tIGFsbCBlbWJlZGRlZCBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjc5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvV1RGLnhjY29uZmlnOgorCisy MDIwLTA2LTA0ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAg ICB0dk9TIGFuZCB3YXRjaE9TIHNob3VsZCBidWlsZCB3aXRoIHRoZSBwdWJsaWMgU0RLCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI3MTgKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzU2NDc3NDk0PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1hc3RlciBwYXRjaCBmb3IgdW1icmVsbGEgYnVnLgorCisg ICAgICAgICogQ29uZmlndXJhdGlvbnMvQmFzZS54Y2NvbmZpZzoKKyAgICAgICAgKiBDb25maWd1 cmF0aW9ucy9XVEYueGNjb25maWc6CisKIDIwMjAtMDYtMDQgIFdlbnNvbiBIc2llaCAgPHdlbnNv bl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW21hY09TXSBBZGQgYSB3YXkgdG8gb3ZlcnJp ZGUgdGhlIGNvbnRhY3QgQXV0b0ZpbGwgYnV0dG9uIGltYWdlCkluZGV4OiBTb3VyY2UvV1RGL0Nv bmZpZ3VyYXRpb25zL1dURi54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NvbmZp Z3VyYXRpb25zL1dURi54Y2NvbmZpZwkocmV2aXNpb24gMjYyNTgyKQorKysgU291cmNlL1dURi9D b25maWd1cmF0aW9ucy9XVEYueGNjb25maWcJKHdvcmtpbmcgY29weSkKQEAgLTI4LDggKzI4LDUg QEAgUFJPRFVDVF9OQU1FID0gV1RGOwogR0NDX1NZTUJPTFNfUFJJVkFURV9FWFRFUk4gPSBZRVM7 CiBTVFJJUF9JTlNUQUxMRURfUFJPRFVDVCA9IE5POwogCi1FWENMVURFRF9TT1VSQ0VfRklMRV9O QU1FU18gPSBNYWNoRXhjZXB0aW9ucy5kZWZzCi1FWENMVURFRF9TT1VSQ0VfRklMRV9OQU1FU1tz ZGs9aXBob25lKl0gPSAkKEVYQ0xVREVEX1NPVVJDRV9GSUxFX05BTUVTXyQoVVNFX0lOVEVSTkFM X1NESykpCi1FWENMVURFRF9TT1VSQ0VfRklMRV9OQU1FU1tzZGs9aXBob25lc2ltdWxhdG9yMTAq XSA9Ci0KLVNZU1RFTV9GUkFNRVdPUktfU0VBUkNIX1BBVEhTID0gJChpbmhlcml0ZWQpICQoU0RL Uk9PVCkkKFNZU1RFTV9MSUJSQVJZX0RJUikvUHJpdmF0ZUZyYW1ld29ya3MKK0VYQ0xVREVEX1NP VVJDRV9GSUxFX05BTUVTXyA9IE1hY2hFeGNlcHRpb25zLmRlZnM7CitFWENMVURFRF9TT1VSQ0Vf RklMRV9OQU1FU1tzZGs9ZW1iZWRkZWQqXSA9ICQoRVhDTFVERURfU09VUkNFX0ZJTEVfTkFNRVNf JChVU0VfSU5URVJOQUxfU0RLKSk7Cg== 401117 2020-06-04 21:18:19 -0700 2020-06-04 22:29:10 -0700 Patch bug-212796-20200604211818.patch text/plain 1369 jbedard SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyNjI1OTQpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDIwLTA2LTA0ICBKb25hdGhhbiBCZWRhcmQgIDxq YmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXVEY6IEV4Y2x1ZGUgTWFjaEV4Y2VwdGlvbnMu ZGVmcyBmcm9tIGFsbCBlbWJlZGRlZCBidWlsZHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjc5NgorCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhl eSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XVEYueGNjb25maWc6 CisKIDIwMjAtMDYtMDQgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAK ICAgICAgICAgW21hY09TXSBBZGQgYSB3YXkgdG8gb3ZlcnJpZGUgdGhlIGNvbnRhY3QgQXV0b0Zp bGwgYnV0dG9uIGltYWdlCkluZGV4OiBTb3VyY2UvV1RGL0NvbmZpZ3VyYXRpb25zL1dURi54Y2Nv bmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NvbmZpZ3VyYXRpb25zL1dURi54Y2NvbmZp ZwkocmV2aXNpb24gMjYyNTk0KQorKysgU291cmNlL1dURi9Db25maWd1cmF0aW9ucy9XVEYueGNj b25maWcJKHdvcmtpbmcgY29weSkKQEAgLTI4LDggKzI4LDcgQEAgUFJPRFVDVF9OQU1FID0gV1RG OwogR0NDX1NZTUJPTFNfUFJJVkFURV9FWFRFUk4gPSBZRVM7CiBTVFJJUF9JTlNUQUxMRURfUFJP RFVDVCA9IE5POwogCi1FWENMVURFRF9TT1VSQ0VfRklMRV9OQU1FU18gPSBNYWNoRXhjZXB0aW9u cy5kZWZzCi1FWENMVURFRF9TT1VSQ0VfRklMRV9OQU1FU1tzZGs9aXBob25lKl0gPSAkKEVYQ0xV REVEX1NPVVJDRV9GSUxFX05BTUVTXyQoVVNFX0lOVEVSTkFMX1NESykpCi1FWENMVURFRF9TT1VS Q0VfRklMRV9OQU1FU1tzZGs9aXBob25lc2ltdWxhdG9yMTAqXSA9CitFWENMVURFRF9TT1VSQ0Vf RklMRV9OQU1FU18gPSBNYWNoRXhjZXB0aW9ucy5kZWZzOworRVhDTFVERURfU09VUkNFX0ZJTEVf TkFNRVNbc2RrPWVtYmVkZGVkKl0gPSAkKEVYQ0xVREVEX1NPVVJDRV9GSUxFX05BTUVTXyQoVVNF X0lOVEVSTkFMX1NESykpOwogCiBTWVNURU1fRlJBTUVXT1JLX1NFQVJDSF9QQVRIUyA9ICQoaW5o ZXJpdGVkKSAkKFNES1JPT1QpJChTWVNURU1fTElCUkFSWV9ESVIpL1ByaXZhdGVGcmFtZXdvcmtz Cg==