212791 2020-06-04 16:38:26 -0700 REGRESSION(r262523): Fix testb3 2020-06-08 13:00:37 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tzagallo tzagallo ews-watchlist keith_miller mark.lam msaboff saam webkit-bug-importer ysuzuki oldest_to_newest 1659403 0 tzagallo 2020-06-04 16:38:26 -0700 ... 1659406 1 401093 tzagallo 2020-06-04 16:41:00 -0700 Created attachment 401093 Patch 1659407 2 401093 mark.lam 2020-06-04 16:47:57 -0700 Comment on attachment 401093 Patch r=me 1659408 3 401093 ysuzuki 2020-06-04 16:48:07 -0700 Comment on attachment 401093 Patch Can you add FIXME with URL to enable these tests? 1659409 4 401093 saam 2020-06-04 16:50:43 -0700 Comment on attachment 401093 Patch Why not just turn on Options::useB3HoistLoopInvariantValues? 1659419 5 401097 tzagallo 2020-06-04 17:06:09 -0700 Created attachment 401097 Patch 1659876 6 ews-feeder 2020-06-05 18:26:21 -0700 Committed r262666: <https://trac.webkit.org/changeset/262666> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401097. 1659877 7 webkit-bug-importer 2020-06-05 18:27:16 -0700 <rdar://problem/64054082> 1660121 8 401097 saam 2020-06-07 21:04:03 -0700 Comment on attachment 401097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401097&action=review > Source/JavaScriptCore/b3/testb3_1.cpp:783 > + Options::useB3HoistLoopInvariantValues() = true; You probably want to set this back to false after running LICM tests, right? I guess thinking about it there is definitely some weird raciness here since these tests are all run on another thread. Makes me think the most comprehensive solution is to have a bit on procedure that determines if LICM runs. 1660125 9 401097 mark.lam 2020-06-07 21:30:00 -0700 Comment on attachment 401097 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401097&action=review >> Source/JavaScriptCore/b3/testb3_1.cpp:783 >> + Options::useB3HoistLoopInvariantValues() = true; > > You probably want to set this back to false after running LICM tests, right? I guess thinking about it there is definitely some weird raciness here since these tests are all run on another thread. Makes me think the most comprehensive solution is to have a bit on procedure that determines if LICM runs. Good point. Maybe the tests should just turn LICM all the time instead of just here. Is there any reason why we won't want to do that? 1660324 10 saam 2020-06-08 13:00:37 -0700 (In reply to Mark Lam from comment #9) > Comment on attachment 401097 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401097&action=review > > >> Source/JavaScriptCore/b3/testb3_1.cpp:783 > >> + Options::useB3HoistLoopInvariantValues() = true; > > > > You probably want to set this back to false after running LICM tests, right? I guess thinking about it there is definitely some weird raciness here since these tests are all run on another thread. Makes me think the most comprehensive solution is to have a bit on procedure that determines if LICM runs. > > Good point. Maybe the tests should just turn LICM all the time instead of > just here. Is there any reason why we won't want to do that? Yeah but note that setting Options means you will affect other tests too since they’re run concurrently 401093 2020-06-04 16:41:00 -0700 2020-06-04 17:06:08 -0700 Patch bug-212791-20200604164059.patch text/plain 4337 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MTk3NDMzZjI3MjdkMGRiZjIwY2U0MTI4MTRlOWJjOGY3NzdhNmQ3Li5lMzlhMWI0MTFhNDJiOTg1 M2IxNmVlMzhmZGM3MmQyZTI0NGMyMGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMyBAQAorMjAyMC0wNi0wNCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNjI1MjMpOiBGaXggdGVzdGIzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI3OTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGIzL3Rlc3RiM183LmNwcDoK KyAgICAgICAgKHRlc3RMSUNNUHVyZSk6CisgICAgICAgICh0ZXN0TElDTVB1cmVTaWRlRXhpdHMp OgorICAgICAgICAodGVzdExJQ01QdXJlV3JpdGVzUGlubmVkKToKKyAgICAgICAgKHRlc3RMSUNN UHVyZVdyaXRlcyk6CisgICAgICAgICh0ZXN0TElDTVJlYWRzUGlubmVkKToKKyAgICAgICAgKHRl c3RMSUNNUmVhZHMpOgorICAgICAgICAodGVzdExJQ01QdXJlTm90QmFja3dhcmRzRG9taW5hbnQp OgorICAgICAgICAodGVzdExJQ01QdXJlTm90QmFja3dhcmRzRG9taW5hbnRGb2lsZWRCeUNoaWxk KToKKyAgICAgICAgKHRlc3RMSUNNQ29udHJvbERlcGVuZGVudCk6CisgICAgICAgICh0ZXN0TElD TUNvbnRyb2xEZXBlbmRlbnROb3RCYWNrd2FyZHNEb21pbmFudCk6CisgICAgICAgICh0ZXN0TElD TVJlYWRzV3JpdGVzRGlmZmVyZW50SGVhcHMpOgorCiAyMDIwLTA2LTA0ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgT3B0aW9uczo6dmFsaWRhdGVEb2VzR0Mo KSBmb3IgdHVybmluZyBEb2VzR0MgdmFsaWRhdGlvbiBvbi9vZmYuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzXzcuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L2IzL3Rlc3RiM183LmNwcAppbmRleCBkZWE0MDllZmRiMWEwYzMyMDAwOTJlZDFlYzU1MDJkOWZh MDYwMjc5Li4xZDg4NDJmOGVjNWE2NDM1MTg0MTI3ZmRhOWEyOWIyZjJhODJiMjkxIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzXzcuY3BwCisrKyBiL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9iMy90ZXN0YjNfNy5jcHAKQEAgLTU2Myw3ICs1NjMsNyBAQCB2b2lkIHRl c3RMSUNNUHVyZSgpCiB7CiAgICAgUHJvY2VkdXJlIHByb2M7CiAKLSAgICBpZiAocHJvYy5vcHRM ZXZlbCgpIDwgMikKKyAgICBpZiAoIU9wdGlvbnM6OnVzZUIzSG9pc3RMb29wSW52YXJpYW50VmFs dWVzKCkgfHwgcHJvYy5vcHRMZXZlbCgpIDwgMikKICAgICAgICAgcmV0dXJuOwogCiAgICAgZ2Vu ZXJhdGVMb29wKApAQCAtNTgzLDcgKzU4Myw3IEBAIHZvaWQgdGVzdExJQ01QdXJlKCkKIHZvaWQg dGVzdExJQ01QdXJlU2lkZUV4aXRzKCkKIHsKICAgICBQcm9jZWR1cmUgcHJvYzsKLSAgICBpZiAo cHJvYy5vcHRMZXZlbCgpIDwgMikKKyAgICBpZiAoIU9wdGlvbnM6OnVzZUIzSG9pc3RMb29wSW52 YXJpYW50VmFsdWVzKCkgfHwgcHJvYy5vcHRMZXZlbCgpIDwgMikKICAgICAgICAgcmV0dXJuOwog ICAgIGdlbmVyYXRlTG9vcCgKICAgICAgICAgcHJvYywKQEAgLTYwOCw3ICs2MDgsNyBAQCB2b2lk IHRlc3RMSUNNUHVyZVNpZGVFeGl0cygpCiB2b2lkIHRlc3RMSUNNUHVyZVdyaXRlc1Bpbm5lZCgp CiB7CiAgICAgUHJvY2VkdXJlIHByb2M7Ci0gICAgaWYgKHByb2Mub3B0TGV2ZWwoKSA8IDIpCisg ICAgaWYgKCFPcHRpb25zOjp1c2VCM0hvaXN0TG9vcEludmFyaWFudFZhbHVlcygpIHx8IHByb2Mu b3B0TGV2ZWwoKSA8IDIpCiAgICAgICAgIHJldHVybjsKICAgICBnZW5lcmF0ZUxvb3AoCiAgICAg ICAgIHByb2MsCkBAIC02MzMsNyArNjMzLDcgQEAgdm9pZCB0ZXN0TElDTVB1cmVXcml0ZXNQaW5u ZWQoKQogdm9pZCB0ZXN0TElDTVB1cmVXcml0ZXMoKQogewogICAgIFByb2NlZHVyZSBwcm9jOwot ICAgIGlmIChwcm9jLm9wdExldmVsKCkgPCAyKQorICAgIGlmICghT3B0aW9uczo6dXNlQjNIb2lz dExvb3BJbnZhcmlhbnRWYWx1ZXMoKSB8fCBwcm9jLm9wdExldmVsKCkgPCAyKQogICAgICAgICBy ZXR1cm47CiAgICAgZ2VuZXJhdGVMb29wKAogICAgICAgICBwcm9jLApAQCAtNjc3LDcgKzY3Nyw3 IEBAIHZvaWQgdGVzdExJQ01SZWFkc0xvY2FsU3RhdGUoKQogdm9pZCB0ZXN0TElDTVJlYWRzUGlu bmVkKCkKIHsKICAgICBQcm9jZWR1cmUgcHJvYzsKLSAgICBpZiAocHJvYy5vcHRMZXZlbCgpIDwg MikKKyAgICBpZiAoIU9wdGlvbnM6OnVzZUIzSG9pc3RMb29wSW52YXJpYW50VmFsdWVzKCkgfHwg cHJvYy5vcHRMZXZlbCgpIDwgMikKICAgICAgICAgcmV0dXJuOwogICAgIGdlbmVyYXRlTG9vcCgK ICAgICAgICAgcHJvYywKQEAgLTY5OCw3ICs2OTgsNyBAQCB2b2lkIHRlc3RMSUNNUmVhZHNQaW5u ZWQoKQogdm9pZCB0ZXN0TElDTVJlYWRzKCkKIHsKICAgICBQcm9jZWR1cmUgcHJvYzsKLSAgICBp ZiAocHJvYy5vcHRMZXZlbCgpIDwgMikKKyAgICBpZiAoIU9wdGlvbnM6OnVzZUIzSG9pc3RMb29w SW52YXJpYW50VmFsdWVzKCkgfHwgcHJvYy5vcHRMZXZlbCgpIDwgMikKICAgICAgICAgcmV0dXJu OwogICAgIGdlbmVyYXRlTG9vcCgKICAgICAgICAgcHJvYywKQEAgLTcxOSw3ICs3MTksNyBAQCB2 b2lkIHRlc3RMSUNNUmVhZHMoKQogdm9pZCB0ZXN0TElDTVB1cmVOb3RCYWNrd2FyZHNEb21pbmFu dCgpCiB7CiAgICAgUHJvY2VkdXJlIHByb2M7Ci0gICAgaWYgKHByb2Mub3B0TGV2ZWwoKSA8IDIp CisgICAgaWYgKCFPcHRpb25zOjp1c2VCM0hvaXN0TG9vcEludmFyaWFudFZhbHVlcygpIHx8IHBy b2Mub3B0TGV2ZWwoKSA8IDIpCiAgICAgICAgIHJldHVybjsKICAgICBhdXRvIGFycmF5ID0gbWFr ZUFycmF5Rm9yTG9vcHMoKTsKICAgICBnZW5lcmF0ZUxvb3BOb3RCYWNrd2FyZHNEb21pbmFudCgK QEAgLTc1Nyw3ICs3NTcsNyBAQCB2b2lkIHRlc3RMSUNNUHVyZUZvaWxlZEJ5Q2hpbGQoKQogdm9p ZCB0ZXN0TElDTVB1cmVOb3RCYWNrd2FyZHNEb21pbmFudEZvaWxlZEJ5Q2hpbGQoKQogewogICAg IFByb2NlZHVyZSBwcm9jOwotICAgIGlmIChwcm9jLm9wdExldmVsKCkgPCAyKQorICAgIGlmICgh T3B0aW9uczo6dXNlQjNIb2lzdExvb3BJbnZhcmlhbnRWYWx1ZXMoKSB8fCBwcm9jLm9wdExldmVs KCkgPCAyKQogICAgICAgICByZXR1cm47CiAgICAgYXV0byBhcnJheSA9IG1ha2VBcnJheUZvckxv b3BzKCk7CiAgICAgZ2VuZXJhdGVMb29wTm90QmFja3dhcmRzRG9taW5hbnQoCkBAIC04NzMsNyAr ODczLDcgQEAgdm9pZCB0ZXN0TElDTVdyaXRlc1Bpbm5lZCgpCiB2b2lkIHRlc3RMSUNNQ29udHJv bERlcGVuZGVudCgpCiB7CiAgICAgUHJvY2VkdXJlIHByb2M7Ci0gICAgaWYgKHByb2Mub3B0TGV2 ZWwoKSA8IDIpCisgICAgaWYgKCFPcHRpb25zOjp1c2VCM0hvaXN0TG9vcEludmFyaWFudFZhbHVl cygpIHx8IHByb2Mub3B0TGV2ZWwoKSA8IDIpCiAgICAgICAgIHJldHVybjsKICAgICBnZW5lcmF0 ZUxvb3AoCiAgICAgICAgIHByb2MsCkBAIC04OTQsNyArODk0LDcgQEAgdm9pZCB0ZXN0TElDTUNv bnRyb2xEZXBlbmRlbnQoKQogdm9pZCB0ZXN0TElDTUNvbnRyb2xEZXBlbmRlbnROb3RCYWNrd2Fy ZHNEb21pbmFudCgpCiB7CiAgICAgUHJvY2VkdXJlIHByb2M7Ci0gICAgaWYgKHByb2Mub3B0TGV2 ZWwoKSA8IDIpCisgICAgaWYgKCFPcHRpb25zOjp1c2VCM0hvaXN0TG9vcEludmFyaWFudFZhbHVl cygpIHx8IHByb2Mub3B0TGV2ZWwoKSA8IDIpCiAgICAgICAgIHJldHVybjsKICAgICBhdXRvIGFy cmF5ID0gbWFrZUFycmF5Rm9yTG9vcHMoKTsKICAgICBnZW5lcmF0ZUxvb3BOb3RCYWNrd2FyZHNE b21pbmFudCgKQEAgLTk2Niw3ICs5NjYsNyBAQCB2b2lkIHRlc3RMSUNNUmVhZHNQaW5uZWRXcml0 ZXNQaW5uZWQoKQogdm9pZCB0ZXN0TElDTVJlYWRzV3JpdGVzRGlmZmVyZW50SGVhcHMoKQogewog ICAgIFByb2NlZHVyZSBwcm9jOwotICAgIGlmIChwcm9jLm9wdExldmVsKCkgPCAyKQorICAgIGlm ICghT3B0aW9uczo6dXNlQjNIb2lzdExvb3BJbnZhcmlhbnRWYWx1ZXMoKSB8fCBwcm9jLm9wdExl dmVsKCkgPCAyKQogICAgICAgICByZXR1cm47CiAgICAgZ2VuZXJhdGVMb29wKAogICAgICAgICBw cm9jLAo= 401097 2020-06-04 17:06:09 -0700 2020-06-05 18:26:21 -0700 Patch bug-212791-20200604170609.patch text/plain 1570 tzagallo U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNTgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MTk3NDMzZjI3MjdkMGRiZjIwY2U0MTI4MTRlOWJjOGY3NzdhNmQ3Li5lMGVmNjUyYzM2MmNmMjI5 YmFhNjY5MmI0ZGNiODIxYjQ3NjFmZWI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMC0wNi0wNCAgVGFkZXUgWmFnYWxsbyAgPHR6YWdhbGxvQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNjI1MjMpOiBGaXggdGVzdGIzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI3OTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGIzL3Rlc3RiM18xLmNwcDoK KyAgICAgICAgKHJ1bik6CisgICAgICAgIChtYWluKToKKwogMjAyMC0wNi0wNCAgTWFyayBMYW0g IDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIE9wdGlvbnM6OnZhbGlkYXRlRG9l c0dDKCkgZm9yIHR1cm5pbmcgRG9lc0dDIHZhbGlkYXRpb24gb24vb2ZmLgpkaWZmIC0tZ2l0IGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiM18xLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9iMy90ZXN0YjNfMS5jcHAKaW5kZXggODhjMjk1NDgwMmY3MjkxOGU2Zjc5ZmM0ODM3N2M4 YTIxMzE3MmQ4My4uNmQ0ZWE2N2EyODQ0NzUwNWI4Nzc0ODFlNjRjYjY1ZDE1MWNmNDljYyAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL3Rlc3RiM18xLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzXzEuY3BwCkBAIC03NzcsNiArNzc3LDExIEBAIHZv aWQgcnVuKGNvbnN0IGNoYXIqIGZpbHRlcikKICAgICBSVU4odGVzdExvYWRCYXNlSW5kZXhTaGlm dDIoKSk7CiAgICAgUlVOKHRlc3RMb2FkQmFzZUluZGV4U2hpZnQzMigpKTsKICAgICBSVU4odGVz dE9wdGltaXplTWF0ZXJpYWxpemF0aW9uKCkpOworCisgICAgLy8gRklYTUU6IFJlLWVuYWJsZSBC MyBob2lzdExvb3BJbnZhcmlhbnRWYWx1ZXMKKyAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNjUxCisgICAgT3B0aW9uczo6dXNlQjNIb2lzdExvb3BJbnZh cmlhbnRWYWx1ZXMoKSA9IHRydWU7CisKICAgICBSVU4odGVzdExJQ01QdXJlKCkpOwogICAgIFJV Tih0ZXN0TElDTVB1cmVTaWRlRXhpdHMoKSk7CiAgICAgUlVOKHRlc3RMSUNNUHVyZVdyaXRlc1Bp bm5lZCgpKTsKQEAgLTkxMCw2ICs5MTUsOCBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFy Z3YpCiAgICAgICAgIGJyZWFrOwogICAgIH0KIAorICAgIEpTQzo6Q29uZmlnOjpjb25maWd1cmVG b3JUZXN0aW5nKCk7CisKICAgICBXVEY6OmluaXRpYWxpemVNYWluVGhyZWFkKCk7CiAgICAgSlND Ojppbml0aWFsaXplVGhyZWFkaW5nKCk7CiAgICAgCg==