212790 2020-06-04 16:04:24 -0700 UIProcess may crash after its prewarmed WebProcess gets terminated 2020-06-04 17:04:20 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen darin ggaren megan_gardner webkit-bug-importer oldest_to_newest 1659378 0 cdumez 2020-06-04 16:04:24 -0700 UIProcess may crash after its prewarmed WebProcess gets terminated: ASSERTION FAILED: m_websiteDataStore Source/WebKit/UIProcess/WebProcessProxy.cpp(1610) : PAL::SessionID WebKit::WebProcessProxy::sessionID() const 1 0x1021b9a9c WTFCrash 2 0x108cb2f14 WTF::DumbPtrTraits<WTF::StringImpl>::unwrap(WTF::StringImpl* const&) 3 0x109b7f708 WebKit::WebProcessProxy::sessionID() const 4 0x109b7f478 WebKit::WebProcessPool::disconnectProcess(WebKit::WebProcessProxy*) 5 0x109b756f0 WebKit::WebProcessProxy::shutDown() 6 0x109b8e87c WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch() 7 0x109b8e614 WebKit::WebProcessProxy::didClose(IPC::Connection&) 8 0x108d4bad4 IPC::Connection::connectionDidClose()::$_6::operator()() 9 0x108d4b9c0 WTF::Detail::CallableWrapper<IPC::Connection::connectionDidClose()::$_6, void>::call() 10 0x10397e8dc WTF::Function<void ()>::operator()() const 11 0x102244d70 WTF::RunLoop::performWork() 12 0x1022457d0 WTF::RunLoop::performWork(void*) 1659379 1 cdumez 2020-06-04 16:04:37 -0700 <rdar://problem/63696191> 1659380 2 401086 cdumez 2020-06-04 16:06:43 -0700 Created attachment 401086 Patch 1659388 3 401086 ggaren 2020-06-04 16:12:57 -0700 Comment on attachment 401086 Patch r=me 1659392 4 401086 darin 2020-06-04 16:18:16 -0700 Comment on attachment 401086 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401086&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:1200 > + auto removedProcess = m_dummyProcessProxies.take(process->sessionID()); > + ASSERT_UNUSED(removedProcess, removedProcess == process); Could also write this: ASSERT(m_dummyProcessProxies.get(process->sessionID()) == process); m_dummyProcessProxies.remove(process->sessionID()); 1659416 5 ews-feeder 2020-06-04 17:04:18 -0700 Committed r262588: <https://trac.webkit.org/changeset/262588> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401086. 401086 2020-06-04 16:06:43 -0700 2020-06-04 17:04:19 -0700 Patch bug-212790-20200604160642.patch text/plain 4503 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNTc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE0YTJhNTBkMzRhMGYxMmFi NWIzODBhOTc0OGNmN2VjYmVmY2FiMzYuLmJhYTRkMWY3ODIxYjg3M2RhZTNhZWJiZmRiMDVlZDI3 ZDZkNjkxMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDYtMDQgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBVSVByb2Nlc3MgbWF5IGNyYXNoIGFm dGVyIGl0cyBwcmV3YXJtZWQgV2ViUHJvY2VzcyBnZXRzIHRlcm1pbmF0ZWQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjc5MAorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNjM2OTYxOTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUXVlcnkgV2ViUHJvY2Vzc1Byb3h5Ojppc0R1bW15UHJvY2Vzc1Byb3h5 KCkgYmVjYXVzZSB0cnlpbmcgdG8gbG9vayB1cCB0aGUgcHJvY2VzcworICAgICAgICBpbiBtX2R1 bW15UHJvY2Vzc1Byb3hpZXMuIFRoZSBrZXkgZm9yIG1fZHVtbXlQcm9jZXNzUHJveGllcyBpcyBh IHNlc3Npb25JRCBidXQKKyAgICAgICAgbm90IGFsbCBwcm9jZXNzZXMgaGF2ZSBhIHNlc3Npb25J RC4gSW4gcGFydGljdWxhciwgcHJld2FybWVkIHdlYiBwcm9jZXNzZXMgaGF2ZQorICAgICAgICBu byBhc3NvY2lhdGVkIFdlYnNpdGVEYXRhU3RvcmUgYW5kIHRodXMgbm90IHNlc3Npb25JRC4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHA6CisgICAgICAgIChXZWJLaXQ6 OldlYlByb2Nlc3NQb29sOjpkaXNjb25uZWN0UHJvY2Vzcyk6CisKIDIwMjAtMDYtMDQgIEJyZW50 IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgUmVkdWNlIHRlbGVtZXRy eSBhbmQgcmVwb3J0IGdlbmVyYXRpb24gZm9yIE5ldHdvcmsgUHJvY2VzcyBzYW5kYm94CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKaW5kZXggMjY5ODJmMzRjYzFj NWRjZDJhNWJhNjYwMDhmNjc0NmJkNzdjMWRmNS4uZTI3YTc3ODliNGY1MDIxOGYzOTlkNGZmMDli YWYzZmI2NzRiNTYzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJv Y2Vzc1Bvb2wuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29s LmNwcApAQCAtMTE5NSwxMCArMTE5NSw5IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OmRpc2Nvbm5l Y3RQcm9jZXNzKFdlYlByb2Nlc3NQcm94eSogcHJvY2VzcykKICAgICBpZiAobV9wcmV3YXJtZWRQ cm9jZXNzID09IHByb2Nlc3MpIHsKICAgICAgICAgQVNTRVJUKG1fcHJld2FybWVkUHJvY2Vzcy0+ aXNQcmV3YXJtZWQoKSk7CiAgICAgICAgIG1fcHJld2FybWVkUHJvY2VzcyA9IG51bGxwdHI7Ci0g ICAgfSBlbHNlIHsKLSAgICAgICAgYXV0byBkdW1teVByb2Nlc3NJdGVyYXRvciA9IG1fZHVtbXlQ cm9jZXNzUHJveGllcy5maW5kKHByb2Nlc3MtPnNlc3Npb25JRCgpKTsKLSAgICAgICAgaWYgKGR1 bW15UHJvY2Vzc0l0ZXJhdG9yICE9IG1fZHVtbXlQcm9jZXNzUHJveGllcy5lbmQoKSAmJiBkdW1t eVByb2Nlc3NJdGVyYXRvci0+dmFsdWUgPT0gcHJvY2VzcykKLSAgICAgICAgICAgIG1fZHVtbXlQ cm9jZXNzUHJveGllcy5yZW1vdmUoZHVtbXlQcm9jZXNzSXRlcmF0b3IpOworICAgIH0gZWxzZSBp ZiAocHJvY2Vzcy0+aXNEdW1teVByb2Nlc3NQcm94eSgpKSB7CisgICAgICAgIGF1dG8gcmVtb3Zl ZFByb2Nlc3MgPSBtX2R1bW15UHJvY2Vzc1Byb3hpZXMudGFrZShwcm9jZXNzLT5zZXNzaW9uSUQo KSk7CisgICAgICAgIEFTU0VSVF9VTlVTRUQocmVtb3ZlZFByb2Nlc3MsIHJlbW92ZWRQcm9jZXNz ID09IHByb2Nlc3MpOwogICAgIH0KIAogICAgIC8vIEZJWE1FIChNdWx0aS1XZWJQcm9jZXNzKTog PHJkYXI6Ly9wcm9ibGVtLzEyMjM5NzY1PiBTb21lIG9mIHRoZSBpbnZhbGlkYXRpb24gY2FsbHMg b2YgdGhlIG90aGVyIHN1cHBsZW1lbnRzIGFyZSBzdGlsbCBuZWNlc3NhcnkgaW4gbXVsdGktcHJv Y2VzcyBtb2RlLCBidXQgdGhleSBzaG91bGQgb25seSBhZmZlY3QgZGF0YSBzdHJ1Y3R1cmVzIHBl cnRhaW5pbmcgdG8gdGhlIHByb2Nlc3MgYmVpbmcgZGlzY29ubmVjdGVkLgpkaWZmIC0tZ2l0IGEv VG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDhjMjk2ZTk2OGNkMGQ5MzI0 MTBjNTIxYTM5MzkwNTc2ZmYwZjRjZjkuLjg1YTMwMDQ1NjEzZTIxYWQ3MTg2ZWYwMTY5YWQ0ODcz NDlhMTBhY2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMC0wNi0wNCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBw bGUuY29tPgorCisgICAgICAgIFVJUHJvY2VzcyBtYXkgY3Jhc2ggYWZ0ZXIgaXRzIHByZXdhcm1l ZCBXZWJQcm9jZXNzIGdldHMgdGVybWluYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNzkwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82MzY5 NjE5MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgQVBJIHRlc3QgY292ZXJhZ2UuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdENvY29hL1Byb2Nlc3NQcmVXYXJtaW5nLm1tOgorICAgICAgICAoVEVTVCk6CisKIDIwMjAt MDYtMDQgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAK ICAgICAgICAgSW1wcm92ZSB3YXRjaGxpc3QgbG9naWMgZm9yIGNvbW1lbnRzIG9uIHBhdGNoZXMg dG91Y2hpbmcgaW1wb3J0ZWQgV1BUIHRlc3RzLgpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp dEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzUHJlV2FybWluZy5tbSBiL1Rvb2xzL1Rlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvUHJvY2Vzc1ByZVdhcm1pbmcubW0KaW5kZXggMDE3 NzhmNDkwYzdlNmZlMWMyNzFlMGU1MTY5NzczNTA5MDU3N2ZlYy4uNWRkNGQ3NmI5MjU2MTMyODk1 MDk4YzhhNGU1YWFiYTE0ZmIzOGU4MCAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XZWJLaXRDb2NvYS9Qcm9jZXNzUHJlV2FybWluZy5tbQorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1Byb2Nlc3NQcmVXYXJtaW5nLm1tCkBAIC0xNDEsMyAr MTQxLDI3IEBAIFRFU1QoV0tQcm9jZXNzUG9vbCwgUHJld2FybWVkUHJvY2Vzc0NyYXNoKQogICAg IHdoaWxlIChbcG9vbCBfaGFzUHJld2FybWVkV2ViUHJvY2Vzc10pCiAgICAgICAgIFRlc3RXZWJL aXRBUEk6OlV0aWw6OnNsZWVwKDAuMDEpOwogfQorCitURVNUKFdlYktpdCwgVHJ5VXNpbmdQcmV3 YXJtZWRQcm9jZXNzVGhhdEp1c3RDcmFzaGVkKQoreworICAgIGF1dG8gcG9vbCA9IGFkb3B0TlMo W1tXS1Byb2Nlc3NQb29sIGFsbG9jXSBpbml0XSk7CisKKyAgICBFWFBFQ1RfRkFMU0UoW3Bvb2wg X2hhc1ByZXdhcm1lZFdlYlByb2Nlc3NdKTsKKworICAgIFtwb29sIF93YXJtSW5pdGlhbFByb2Nl c3NdOworICAgIEVYUEVDVF9UUlVFKFtwb29sIF9oYXNQcmV3YXJtZWRXZWJQcm9jZXNzXSk7CisK KyAgICAvLyBXYWl0IGZvciBwcmV3YXJtZWQgcHJvY2VzcyB0byBmaW5pc2ggbGF1bmNoaW5nLgor ICAgIHdoaWxlICghW3Bvb2wgX3ByZXdhcm1lZFByb2Nlc3NJZGVudGlmaWVyXSkKKyAgICAgICAg VGVzdFdlYktpdEFQSTo6VXRpbDo6c2xlZXAoMC4wMSk7CisKKyAgICAvLyBLaWxsIHRoZSBwcmV3 YXJtZWQgcHJvY2Vzcy4KKyAgICBraWxsKFtwb29sIF9wcmV3YXJtZWRQcm9jZXNzSWRlbnRpZmll cl0sIDkpOworCisgICAgLy8gVHJ5IHVzaW5nIHRoZSBwcmV3YXJtZWQgcHJvY2VzcyByaWdodCBh d2F5LgorICAgIGF1dG8gY29uZmlndXJhdGlvbiA9IGFkb3B0TlMoW1tXS1dlYlZpZXdDb25maWd1 cmF0aW9uIGFsbG9jXSBpbml0XSk7CisgICAgY29uZmlndXJhdGlvbi5nZXQoKS5wcm9jZXNzUG9v bCA9IHBvb2wuZ2V0KCk7CisgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbW1dLV2ViVmlldyBh bGxvY10gaW5pdFdpdGhGcmFtZTpOU01ha2VSZWN0KDAsIDAsIDgwMCwgNjAwKSBjb25maWd1cmF0 aW9uOmNvbmZpZ3VyYXRpb24uZ2V0KCldKTsKKyAgICBbd2ViVmlldyBsb2FkUmVxdWVzdDpbTlNV UkxSZXF1ZXN0IHJlcXVlc3RXaXRoVVJMOltOU1VSTCBVUkxXaXRoU3RyaW5nOmxvYWRhYmxlVVJM XV1dOworICAgIFt3ZWJWaWV3IF90ZXN0X3dhaXRGb3JEaWRGaW5pc2hOYXZpZ2F0aW9uXTsKK30K