212787 2020-06-04 15:44:40 -0700 Disable CFNetwork AppSSO interception for Mac Catalyst 2020-06-04 17:09:46 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jiewen_tan jiewen_tan cdumez jiewen_tan thorton webkit-bug-importer oldest_to_newest 1659359 0 jiewen_tan 2020-06-04 15:44:40 -0700 Disable CFNetwork AppSSO interception for Mac Catalyst. 1659360 1 jiewen_tan 2020-06-04 15:45:01 -0700 <rdar://problem/63738783> 1659364 2 401082 jiewen_tan 2020-06-04 15:48:28 -0700 Created attachment 401082 Patch 1659367 3 jiewen_tan 2020-06-04 15:51:48 -0700 The current patch only disable CFNetwork interception per network session. Let me use the global switch to do it for other processes. 1659371 4 401083 jiewen_tan 2020-06-04 15:58:13 -0700 Created attachment 401083 Patch 1659372 5 401082 cdumez 2020-06-04 15:58:33 -0700 Comment on attachment 401082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401082&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. 1659373 6 401083 cdumez 2020-06-04 15:59:04 -0700 Comment on attachment 401083 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401083&action=review > Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. 1659391 7 401083 jiewen_tan 2020-06-04 16:16:49 -0700 Comment on attachment 401083 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401083&action=review Thanks Chris for the r+. >> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 >> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) > > What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. 1659404 8 401083 thorton 2020-06-04 16:39:02 -0700 Comment on attachment 401083 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401083&action=review >>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 >>> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) >> >> What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. > > The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. Is the NSURLSessionConfiguration property available on all platforms? It might be nice to just remove this ifdef for future-proofing 🤷‍♂️ 1659405 9 cdumez 2020-06-04 16:39:54 -0700 (In reply to Tim Horton from comment #8) > Comment on attachment 401083 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401083&action=review > > >>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > >>> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) > >> > >> What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. > > > > The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. > > Is the NSURLSessionConfiguration property available on all platforms? It > might be nice to just remove this ifdef for future-proofing 🤷‍♂️ Yes, it is available on all platform, merely a no-op on platform that don't support AppSSO. 1659411 10 ews-feeder 2020-06-04 16:54:06 -0700 Committed r262585: <https://trac.webkit.org/changeset/262585> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401083. 1659420 11 jiewen_tan 2020-06-04 17:09:46 -0700 (In reply to Chris Dumez from comment #9) > (In reply to Tim Horton from comment #8) > > Comment on attachment 401083 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=401083&action=review > > > > >>> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:1148 > > >>> +#if HAVE(APP_SSO) || PLATFORM(MACCATALYST) > > >> > > >> What about TVOS and WatchOS? It looks like APP_SSO is 1 on macOS and iOS only. > > > > > > The AppSSO framework is only available for iOS, macOS and Catalyst. So we are good for the other two platforms. > > > > Is the NSURLSessionConfiguration property available on all platforms? It > > might be nice to just remove this ifdef for future-proofing 🤷‍♂️ > > Yes, it is available on all platform, merely a no-op on platform that don't > support AppSSO. I think we need to support -2 macOS. Therefore, we can't do that now. 401082 2020-06-04 15:48:28 -0700 2020-06-04 15:59:16 -0700 Patch bug-212787-20200604154827.patch text/plain 1395 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUwYTVlZjU1MmQ5ZGEyMDc5 YzRiYzQ3MDY5ZTlmOTBkMDBlNTE3NzMuLmUxZGY0NjQxZTdlNGZjMjcwMjQyYmRlZmY5NzNjOTQ0 MDQxMmM3YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDYtMDQgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBEaXNhYmxlIENGTmV0d29yayBB cHBTU08gaW50ZXJjZXB0aW9uIGZvciBNYWMgQ2F0YWx5c3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjc4NworICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjM3Mzg3ODM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tOgorICAg ICAgICAoV2ViS2l0OjpOZXR3b3JrU2Vzc2lvbkNvY29hOjpOZXR3b3JrU2Vzc2lvbkNvY29hKToK KwogMjAyMC0wNS0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gTW92ZSB0byBuZXcgUGFzdGVib2FyZCBBUEkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5t bSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2Nv YS5tbQppbmRleCBmOWY4YjM3ZGUxNTBkZGJhNTk1NzhjNWFmNTI5MzI3OGFlNjExZjZmLi40OWU5 ZDA3MDhlMWVhOGVlY2Y2MDQwOWFlN2ZmMWNjNjVkYTJiY2E3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1t CkBAIC0xMTQ1LDcgKzExNDUsNyBAQCBOZXR3b3JrU2Vzc2lvbkNvY29hOjpOZXR3b3JrU2Vzc2lv bkNvY29hKE5ldHdvcmtQcm9jZXNzJiBuZXR3b3JrUHJvY2VzcywgTmV0d29yawogCiAgICAgTlNV UkxTZXNzaW9uQ29uZmlndXJhdGlvbiAqY29uZmlndXJhdGlvbiA9IGNvbmZpZ3VyYXRpb25Gb3JT ZXNzaW9uSUQobV9zZXNzaW9uSUQpOwogCi0jaWYgSEFWRShBUFBfU1NPKQorI2lmIEhBVkUoQVBQ X1NTTykgfHwgUExBVEZPUk0oTUFDQ0FUQUxZU1QpCiAgICAgY29uZmlndXJhdGlvbi5fcHJldmVu dHNBcHBTU08gPSB0cnVlOwogI2VuZGlmCiAK 401083 2020-06-04 15:58:13 -0700 2020-06-04 16:54:06 -0700 Patch bug-212787-20200604155813.patch text/plain 2669 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjYxNzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDUwYTVlZjU1MmQ5ZGEyMDc5 YzRiYzQ3MDY5ZTlmOTBkMDBlNTE3NzMuLmUxZGY0NjQxZTdlNGZjMjcwMjQyYmRlZmY5NzNjOTQ0 MDQxMmM3YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDYtMDQgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBEaXNhYmxlIENGTmV0d29yayBB cHBTU08gaW50ZXJjZXB0aW9uIGZvciBNYWMgQ2F0YWx5c3QKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjc4NworICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjM3Mzg3ODM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1tOgorICAg ICAgICAoV2ViS2l0OjpOZXR3b3JrU2Vzc2lvbkNvY29hOjpOZXR3b3JrU2Vzc2lvbkNvY29hKToK KwogMjAyMC0wNS0xNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+ CiAKICAgICAgICAgW0dUS10gTW92ZSB0byBuZXcgUGFzdGVib2FyZCBBUEkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2NvYS5t bSBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3MvY29jb2EvTmV0d29ya1Nlc3Npb25Db2Nv YS5tbQppbmRleCBmOWY4YjM3ZGUxNTBkZGJhNTk1NzhjNWFmNTI5MzI3OGFlNjExZjZmLi40OWU5 ZDA3MDhlMWVhOGVlY2Y2MDQwOWFlN2ZmMWNjNjVkYTJiY2E3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL2NvY29hL05ldHdvcmtTZXNzaW9uQ29jb2EubW0KKysrIGIv U291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9jb2NvYS9OZXR3b3JrU2Vzc2lvbkNvY29hLm1t CkBAIC0xMTQ1LDcgKzExNDUsNyBAQCBOZXR3b3JrU2Vzc2lvbkNvY29hOjpOZXR3b3JrU2Vzc2lv bkNvY29hKE5ldHdvcmtQcm9jZXNzJiBuZXR3b3JrUHJvY2VzcywgTmV0d29yawogCiAgICAgTlNV UkxTZXNzaW9uQ29uZmlndXJhdGlvbiAqY29uZmlndXJhdGlvbiA9IGNvbmZpZ3VyYXRpb25Gb3JT ZXNzaW9uSUQobV9zZXNzaW9uSUQpOwogCi0jaWYgSEFWRShBUFBfU1NPKQorI2lmIEhBVkUoQVBQ X1NTTykgfHwgUExBVEZPUk0oTUFDQ0FUQUxZU1QpCiAgICAgY29uZmlndXJhdGlvbi5fcHJldmVu dHNBcHBTU08gPSB0cnVlOwogI2VuZGlmCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGx1 Z2luUHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5tbSBiL1NvdXJjZS9XZWJLaXQvUGx1Z2lu UHJvY2Vzcy9tYWMvUGx1Z2luUHJvY2Vzc01hYy5tbQppbmRleCAwZjhhYTMxZmNiYzE3ODhlY2Ix MjEzOGE2YmI0ZTgzZWYxN2EyMTYwLi5kNjUwOTUxYWY5MDZiYTE0YWZlZDg1MGRjY2I5N2MyY2E4 YmMxMDk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsdWdpblByb2Nlc3MvbWFjL1BsdWdp blByb2Nlc3NNYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9QbHVnaW5Qcm9jZXNzL21hYy9QbHVn aW5Qcm9jZXNzTWFjLm1tCkBAIC0zOTUsNyArMzk1LDcgQEAgdm9pZCBQbHVnaW5Qcm9jZXNzOjpw bGF0Zm9ybUluaXRpYWxpemVQbHVnaW5Qcm9jZXNzKFBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFt ZXQKICAgICAvLyBEaXNhYmxlIERhcmsgTW9kZSBpbiB0aGUgcGx1Z2luIHByb2Nlc3MgdG8gYXZv aWQgcmVuZGVyaW5nIGlzc3Vlcy4KICAgICBbTlNBcHAgc2V0QXBwZWFyYW5jZTpbTlNBcHBlYXJh bmNlIGFwcGVhcmFuY2VOYW1lZDpOU0FwcGVhcmFuY2VOYW1lQXF1YV1dOwogCi0jaWYgSEFWRShB UFBfU1NPKQorI2lmIEhBVkUoQVBQX1NTTykgfHwgUExBVEZPUk0oTUFDQ0FUQUxZU1QpCiAgICAg W05TVVJMU2Vzc2lvbiBfZGlzYWJsZUFwcFNTT107CiAjZW5kaWYKIH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0gYi9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCmluZGV4IGY2ODhmY2M1 ZDQyMDRjNThiOGYxMTkzMzc3NWQ2Y2YwODUzY2JmNTAuLmQ1MGJhMWM1OWMxZTYyZTJiMzJjN2I4 NDQ3YjkwNzFlYWIzZjg0YzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9j b2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2Nv Y29hL1dlYlByb2Nlc3NDb2NvYS5tbQpAQCAtNTg0LDcgKzU4NCw3IEBAIHZvaWQgV2ViUHJvY2Vz czo6cGxhdGZvcm1Jbml0aWFsaXplUHJvY2Vzcyhjb25zdCBBdXhpbGlhcnlQcm9jZXNzSW5pdGlh bGl6YXRpb25QCiAgICAgcmVnaXN0ZXJXaXRoU3RhdGVEdW1wZXIoKTsKICNlbmRpZgogCi0jaWYg SEFWRShBUFBfU1NPKQorI2lmIEhBVkUoQVBQX1NTTykgfHwgUExBVEZPUk0oTUFDQ0FUQUxZU1Qp CiAgICAgW05TVVJMU2Vzc2lvbiBfZGlzYWJsZUFwcFNTT107CiAjZW5kaWYKIAo=