212785 2020-06-04 15:06:05 -0700 REGRESSION: (r262398) Text manipulation crashes when content is added 2020-06-04 16:58:37 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu ews-watchlist mifenton rniwa webkit-bug-importer wenson_hsieh oldest_to_newest 1659345 0 sihui_liu 2020-06-04 15:06:05 -0700 ... 1659352 1 401080 sihui_liu 2020-06-04 15:15:48 -0700 Created attachment 401080 Patch 1659361 2 sihui_liu 2020-06-04 15:45:37 -0700 <rdar://problem/63981472> 1659362 3 sihui_liu 2020-06-04 15:46:19 -0700 Thanks for the review! Will commit after bots are green. 1659414 4 ews-feeder 2020-06-04 16:58:37 -0700 Committed r262587: <https://trac.webkit.org/changeset/262587> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401080. 401080 2020-06-04 15:15:48 -0700 2020-06-04 16:58:37 -0700 Patch bug-212785-20200604151545.patch text/plain 5574 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNTAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGY3MzQ1YWYxMDE2YzBj NTA2M2ZjMDM2ODBiNjEwNDhkNzAyNjc4NC4uMWRjMTg0NTc0MjUzYWI5ZWUzNWZjZTJkNzYyNGQ1 ZmM3YTUzZjY4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA2LTA0ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046KHIyNjIz OTgpIFRleHQgbWFuaXB1bGF0aW9uIGNyYXNoZXMgd2hlbiBjb250ZW50IGlzIGFkZGVkCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI3ODUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjYyMzk4IGFjY2lk ZW50YWxseSByZW1vdmVkIHRoZSBib3VuZCBjaGVjayBvbiBhcnJheSBpbmRleCBhbmQgd2FzIG5v dCBjYXVnaHQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgVGVzdDogVGV4dE1hbmlwdWxh dGlvbi5Db21wbGV0ZVRleHRNYW5pcHVsYXRpb25GYWlsV2hlbkNvbnRlbnRJc0FkZGVkCisKKyAg ICAgICAgKiBlZGl0aW5nL1RleHRNYW5pcHVsYXRpb25Db250cm9sbGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlRleHRNYW5pcHVsYXRpb25Db250cm9sbGVyOjpyZXBsYWNlKToKKwogMjAyMC0w Ni0wMyAgQW5kcmVzIEdvbnphbGV6ICA8YW5kcmVzZ18yMkBhcHBsZS5jb20+CiAKICAgICAgICAg QVg6IFNWRyB0ZXh0IG5vZGUgd2l0aCBjb250ZW50IGlzIGRlc2NyaWJlZCBhcyAiZW1wdHkgZ3Jv dXAiIGV2ZW4gaWYgaXQncyBub3QgZW1wdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Vk aXRpbmcvVGV4dE1hbmlwdWxhdGlvbkNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRp dGluZy9UZXh0TWFuaXB1bGF0aW9uQ29udHJvbGxlci5jcHAKaW5kZXggMzhiMGU0NDJlNjE5Njk2 MGI2YzYzZTBkYWQ2NzE2ZGRhMTI5MDMyYS4uMWIxN2UwMGY3MWYxNDJjMDIxODUyMTlkNzkyOWJi YzM4YjIwNzQ1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0TWFuaXB1 bGF0aW9uQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9UZXh0TWFu aXB1bGF0aW9uQ29udHJvbGxlci5jcHAKQEAgLTYzOSwxNiArNjM5LDE5IEBAIGF1dG8gVGV4dE1h bmlwdWxhdGlvbkNvbnRyb2xsZXI6OnJlcGxhY2UoY29uc3QgTWFuaXB1bGF0aW9uSXRlbURhdGEm IGl0ZW0sIGNvbnN0CiAgICAgICAgICAgICBjb250aW51ZTsKIAogICAgICAgICBWZWN0b3I8TWFu aXB1bGF0aW9uVG9rZW4+IHRva2Vuc0luQ3VycmVudE5vZGU7Ci0gICAgICAgIGlmIChjb250ZW50 LmlzUmVwbGFjZWRDb250ZW50KQorICAgICAgICBpZiAoY29udGVudC5pc1JlcGxhY2VkQ29udGVu dCkgeworICAgICAgICAgICAgaWYgKGN1cnJlbnRUb2tlbkluZGV4ID49IGl0ZW0udG9rZW5zLnNp emUoKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gTWFuaXB1bGF0aW9uRmFpbHVyZVR5cGU6OkNv bnRlbnRDaGFuZ2VkOworCiAgICAgICAgICAgICB0b2tlbnNJbkN1cnJlbnROb2RlLmFwcGVuZChp dGVtLnRva2Vuc1tjdXJyZW50VG9rZW5JbmRleF0pOwotICAgICAgICBlbHNlCisgICAgICAgIH0g ZWxzZQogICAgICAgICAgICAgdG9rZW5zSW5DdXJyZW50Tm9kZSA9IHBhcnNlKGNvbnRlbnQudGV4 dCwgY29udGVudC5ub2RlLmdldCgpKS50b2tlbnM7CiAKICAgICAgICAgYm9vbCBpc05vZGVJbmNs dWRlZCA9IFdURjo6YW55T2YodG9rZW5zSW5DdXJyZW50Tm9kZSwgW10gKGF1dG8mIHRva2VuKSB7 CiAgICAgICAgICAgICByZXR1cm4gIXRva2VuLmlzRXhjbHVkZWQ7CiAgICAgICAgIH0pOwogICAg ICAgICBmb3IgKGF1dG8mIHRva2VuIDogdG9rZW5zSW5DdXJyZW50Tm9kZSkgewotICAgICAgICAg ICAgaWYgKGN1cnJlbnRUb2tlbkluZGV4ID4gaXRlbS50b2tlbnMuc2l6ZSgpKQorICAgICAgICAg ICAgaWYgKGN1cnJlbnRUb2tlbkluZGV4ID49IGl0ZW0udG9rZW5zLnNpemUoKSkKICAgICAgICAg ICAgICAgICByZXR1cm4gTWFuaXB1bGF0aW9uRmFpbHVyZVR5cGU6OkNvbnRlbnRDaGFuZ2VkOwog CiAgICAgICAgICAgICBhdXRvJiBjdXJyZW50VG9rZW4gPSBpdGVtLnRva2Vuc1tjdXJyZW50VG9r ZW5JbmRleCsrXTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxv ZwppbmRleCBlY2RhNjVlYmY1M2UyYjU3YmEwYWU4MDA4YmRjYTYxYzU4OGNkMzIxLi44OTgxODA5 NzU3Njk3NDM1MDA2NjU2YjM5MjNlOTkwY2IxNjExMmFiIDEwMDY0NAotLS0gYS9Ub29scy9DaGFu Z2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjAtMDYtMDQg IFNpaHVpIExpdSAgPHNpaHVpX2xpdUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjog KHIyNjIzOTgpIFRleHQgbWFuaXB1bGF0aW9uIGNyYXNoZXMgd2hlbiBjb250ZW50IGlzIGFkZGVk CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI3ODUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RX ZWJLaXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvVGV4dE1hbmlwdWxhdGlvbi5tbToKKyAgICAgICAg KFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAyMDIwLTA2LTAzICBTaWh1aSBMaXUgIDxzaWh1aV9s aXVAYXBwbGUuY29tPgogCiAgICAgICAgIFRleHQgbWFuaXB1bGF0aW9uIHNvbWV0aW1lcyBmYWls cyB0byByZXBsYWNlIHRleHQgaW4gYXR0cmlidXRlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9UZXh0TWFuaXB1bGF0aW9uLm1tIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9UZXh0TWFuaXB1bGF0aW9uLm1tCmluZGV4IDQ1 N2E3MGM2NWQ3NGI1MTVhYzEwZWQwNjAxOTI3ZTBiNTE2MTc3NjMuLjBjYTI4YzcwZjY1ZTRiMWI5 NDhmNzYzMWU5ZGE2YmQ0NDZiMjBjMTggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViS2l0Q29jb2EvVGV4dE1hbmlwdWxhdGlvbi5tbQorKysgYi9Ub29scy9UZXN0V2Vi S2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1RleHRNYW5pcHVsYXRpb24ubW0KQEAgLTE3OTMsNiAr MTc5Myw0OCBAQCBURVNUKFRleHRNYW5pcHVsYXRpb24sIENvbXBsZXRlVGV4dE1hbmlwdWxhdGlv bkZhaWxXaGVuQ29udGVudElzUmVtb3ZlZCkKICAgICBFWFBFQ1RfV0tfU1RSRVEoIm5ldyBjb250 ZW50IiwgW3dlYlZpZXcgc3RyaW5nQnlFdmFsdWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LmJv ZHkuaW5uZXJIVE1MIl0pOwogfQogCitURVNUKFRleHRNYW5pcHVsYXRpb24sIENvbXBsZXRlVGV4 dE1hbmlwdWxhdGlvbkZhaWxXaGVuQ29udGVudElzQWRkZWQpCit7CisgICAgYXV0byBkZWxlZ2F0 ZSA9IGFkb3B0TlMoW1tUZXh0TWFuaXB1bGF0aW9uRGVsZWdhdGUgYWxsb2NdIGluaXRdKTsKKyAg ICBhdXRvIHdlYlZpZXcgPSBhZG9wdE5TKFtbVGVzdFdLV2ViVmlldyBhbGxvY10gaW5pdFdpdGhG cmFtZTpOU01ha2VSZWN0KDAsIDAsIDQwMCwgNDAwKV0pOworICAgIFt3ZWJWaWV3IF9zZXRUZXh0 TWFuaXB1bGF0aW9uRGVsZWdhdGU6ZGVsZWdhdGUuZ2V0KCldOworCisgICAgW3dlYlZpZXcgc3lu Y2hyb25vdXNseUxvYWRIVE1MU3RyaW5nOkAiPCFET0NUWVBFIGh0bWw+PGh0bWw+PGJvZHk+PHA+ aGVsbG8sIHdvcmxkPC9wPjwvYm9keT48L2h0bWw+Il07CisKKyAgICBkb25lID0gZmFsc2U7Cisg ICAgW3dlYlZpZXcgX3N0YXJ0VGV4dE1hbmlwdWxhdGlvbnNXaXRoQ29uZmlndXJhdGlvbjpuaWwg Y29tcGxldGlvbjpeeworICAgICAgICBkb25lID0gdHJ1ZTsKKyAgICB9XTsKKyAgICBUZXN0V2Vi S2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOworCisgICAgYXV0byAqaXRlbXMgPSBbZGVsZWdhdGUg aXRlbXNdOworICAgIEVYUEVDVF9FUShpdGVtcy5jb3VudCwgMVVMKTsKKyAgICBFWFBFQ1RfRVEo aXRlbXNbMF0udG9rZW5zLmNvdW50LCAxVUwpOworICAgIEVYUEVDVF9TVFJFUSgiaGVsbG8sIHdv cmxkIiwgaXRlbXNbMF0udG9rZW5zWzBdLmNvbnRlbnQuVVRGOFN0cmluZyk7CisKKyAgICBkb25l ID0gZmFsc2U7CisgICAgZGVsZWdhdGUuZ2V0KCkuaXRlbUNhbGxiYWNrID0gXihfV0tUZXh0TWFu aXB1bGF0aW9uSXRlbSAqaXRlbSkgeworICAgICAgICBpZiAoaXRlbXMuY291bnQgPT0gMikKKyAg ICAgICAgICAgIGRvbmUgPSB0cnVlOworICAgIH07CisgICAgW3dlYlZpZXcgc3RyaW5nQnlFdmFs dWF0aW5nSmF2YVNjcmlwdDpAImRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJ3AnKS5pbm5lckhUTUwg PSAnaGVsbG8sIHdvcmxkICYjMTA7IGJ5ZSc7IgorICAgICAgICAiZG9jdW1lbnQuYm9keS5hcHBl bmRDaGlsZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKSkuaW5uZXJIVE1MID0gJ2VuZCci XTsKKyAgICBUZXN0V2ViS2l0QVBJOjpVdGlsOjpydW4oJmRvbmUpOworCisgICAgZG9uZSA9IGZh bHNlOworICAgIF9fYmxvY2sgYXV0byBpdGVtID0gY3JlYXRlSXRlbShpdGVtc1swXS5pZGVudGlm aWVyLCB7eyBpdGVtc1swXS50b2tlbnNbMF0uaWRlbnRpZmllciwgQCJIZWxsbywgV29ybGQiIH19 KTsKKyAgICBbd2ViVmlldyBfY29tcGxldGVUZXh0TWFuaXB1bGF0aW9uRm9ySXRlbXM6QFtpdGVt LmdldCgpXSBjb21wbGV0aW9uOl4oTlNBcnJheTxOU0Vycm9yICo+ICplcnJvcnMpIHsKKyAgICAg ICAgRVhQRUNUX0VRKGVycm9ycy5jb3VudCwgMVVMKTsKKyAgICAgICAgRVhQRUNUX0VRKGVycm9y cy5maXJzdE9iamVjdC5kb21haW4sIF9XS1RleHRNYW5pcHVsYXRpb25JdGVtRXJyb3JEb21haW4p OworICAgICAgICBFWFBFQ1RfRVEoZXJyb3JzLmZpcnN0T2JqZWN0LmNvZGUsIF9XS1RleHRNYW5p cHVsYXRpb25JdGVtRXJyb3JDb250ZW50Q2hhbmdlZCk7CisgICAgICAgIEVYUEVDVF9FUShlcnJv cnMuZmlyc3RPYmplY3QudXNlckluZm9bX1dLVGV4dE1hbmlwdWxhdGlvbkl0ZW1FcnJvckl0ZW1L ZXldLCBpdGVtLmdldCgpKTsKKyAgICAgICAgZG9uZSA9IHRydWU7CisgICAgfV07CisgICAgVGVz dFdlYktpdEFQSTo6VXRpbDo6cnVuKCZkb25lKTsKKworICAgIEVYUEVDVF9XS19TVFJFUSgiPHA+ aGVsbG8sIHdvcmxkIFxuIGJ5ZTwvcD48ZGl2PmVuZDwvZGl2PiIsIFt3ZWJWaWV3IHN0cmluZ0J5 RXZhbHVhdGluZ0phdmFTY3JpcHQ6QCJkb2N1bWVudC5ib2R5LmlubmVySFRNTCJdKTsKK30KKwog VEVTVChUZXh0TWFuaXB1bGF0aW9uLCBDb21wbGV0ZVRleHRNYW5pcHVsYXRpb25GYWlsV2hlbkRv Y3VtZW50SGFzQmVlbk5hdmlnYXRlZEF3YXkpCiB7CiAgICAgYXV0byBkZWxlZ2F0ZSA9IGFkb3B0 TlMoW1tUZXh0TWFuaXB1bGF0aW9uRGVsZWdhdGUgYWxsb2NdIGluaXRdKTsK