212778 2020-06-04 13:54:35 -0700 Reduce telemetry and report generation for Network Process sandbox 2020-06-04 14:31:05 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham bfulgham pvollan oldest_to_newest 1659306 0 bfulgham 2020-06-04 13:54:35 -0700 This patch cleans up a set of telemetry and reports generated during normal WebKit operation. Now that we understand the uses of these XPC services, we can reduce the logging traffic. 1659307 1 bfulgham 2020-06-04 13:55:48 -0700 <rdar://problem/63891745> 1659308 2 401076 bfulgham 2020-06-04 13:57:30 -0700 Created attachment 401076 Patch 1659309 3 401076 bfulgham 2020-06-04 13:59:32 -0700 Comment on attachment 401076 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401076&action=review > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:-641 > - (global-name "com.apple.AppSSO.service-xpc")) This looks like I removed AppSSO here, but it's actually also present on line 131, so this was an unnecessary dupe. 1659312 4 401076 pvollan 2020-06-04 14:02:18 -0700 Comment on attachment 401076 Patch R=me. 1659329 5 ews-feeder 2020-06-04 14:31:05 -0700 Committed r262572: <https://trac.webkit.org/changeset/262572> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401076. 401076 2020-06-04 13:57:30 -0700 2020-06-04 14:31:05 -0700 Patch bug-212778-20200604135729.patch text/plain 4918 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDMzMmY1NTVjM2FiMzI1NTM1 OGJmYjJkYzc5YjM1ZWEwMDJmMGNjN2MuLmI0N2NkYmQ2YWJhZTM4ODRiYTM3MDdkNTVkNjlhMzZk YWZiZWFkMWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjAtMDYtMDQgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVkdWNlIHRlbGVtZXRyeSBh bmQgcmVwb3J0IGdlbmVyYXRpb24gZm9yIE5ldHdvcmsgUHJvY2VzcyBzYW5kYm94CisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI3NzgKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzYzODkxNzQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggY2xlYW5zIHVwIGEgc2V0IG9mIHRlbGVtZXRy eSBhbmQgcmVwb3J0cyBnZW5lcmF0ZWQgZHVyaW5nIG5vcm1hbAorICAgICAgICBXZWJLaXQgb3Bl cmF0aW9uLiBOb3cgdGhhdCB3ZSB1bmRlcnN0YW5kIHRoZSB1c2VzIG9mIHRoZXNlIFhQQyBzZXJ2 aWNlcywgd2UKKyAgICAgICAgY2FuIHJlZHVjZSB0aGUgbG9nZ2luZyB0cmFmZmljLgorCisgICAg ICAgIFRoaXMgaXMgaW1wb3J0YW50IHRvIGRvIG5vdywgc2luY2UgdGVsZW1ldHJ5IGFuZCByZXBv cnQgZ2VuZXJhdGlvbiBoYXMKKyAgICAgICAgYmF0dGVyeSBsaWZlIGFuZCBwZXJmb3JtYW5jZSBp bXBhY3QuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldlYktpdC5O ZXR3b3JrUHJvY2Vzcy5zYi5pbjoKKyAgICAgICAgKiBSZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVz L2lvcy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtpbmcuc2I6CisKIDIwMjAtMDYtMDQgIENocmlz IER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBEcm9wIERlcGVuZGVu dFByb2Nlc3NMaW5rIFByb2Nlc3NBc3NlcnRpb24gYXMgaXQgY3JlYXRlcyBwb3dlciBsZWFrcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vzcy9tYWMvY29tLmFwcGxlLldl YktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbiBiL1NvdXJjZS9XZWJLaXQvTmV0d29ya1Byb2Nlc3Mv bWFjL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya1Byb2Nlc3Muc2IuaW4KaW5kZXggNGI0NzVmOThm OTRkMjg3ZjdkMWIzMDY2MWM3OGQzMDQwYmE0NTM3Yi4uZGNkMmJmMGUwZWEyYWVlNGY2MjhkM2Fl YzljODhmOTM0YWUyNzc0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9OZXR3b3JrUHJvY2Vz cy9tYWMvY29tLmFwcGxlLldlYktpdC5OZXR3b3JrUHJvY2Vzcy5zYi5pbgorKysgYi9Tb3VyY2Uv V2ViS2l0L05ldHdvcmtQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0Lk5ldHdvcmtQcm9jZXNz LnNiLmluCkBAIC0xMTAsMTUgKzExMCwxMiBAQAogICAgICAgIChpcGMtcG9zaXgtbmFtZS1wcmVm aXggImFwcGxlLmNmcHJlZnMuIikpCiAKIChhbGxvdyBtYWNoLWxvb2t1cCAod2l0aCByZXBvcnQp ICh3aXRoIHRlbGVtZXRyeSkKLSAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hbmFseXRp Y3NkIikKICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hbmFseXRpY3NkLm1lc3NhZ2V0 cmFjZXIiKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmFwcHNsZWVwIikKICAgICAg ICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5ic2QuZGlyaGVscGVyIikKICAgICAgICAoZ2xvYmFs LW5hbWUgImNvbS5hcHBsZS5jZnByZWZzZC5hZ2VudCIpCiAgICAgICAgKGdsb2JhbC1uYW1lICJj b20uYXBwbGUuY2ZwcmVmc2QuZGFlbW9uIikKICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBs ZS5lc3BkIikKLSAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5sb2dkIikKLSAgICAgICAo Z2xvYmFsLW5hbWUgImNvbS5hcHBsZS5sb2dkLmV2ZW50cyIpCiAgICAgICAgKGdsb2JhbC1uYW1l ICJjb20uYXBwbGUuc2VjaW5pdGQiKQogICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLnN5 c3RlbS5EaXJlY3RvcnlTZXJ2aWNlLmxpYmluZm9fdjEiKQogICAgICAgIChnbG9iYWwtbmFtZSAi Y29tLmFwcGxlLnN5c3RlbS5sb2dnZXIiKQpAQCAtMzA0LDYgKzMwMSw4IEBACiAgICAgKGdsb2Jh bC1uYW1lICJjb20uYXBwbGUuY2ZuZXR3b3JrLmNmbmV0d29ya2FnZW50IikKICAgICAoZ2xvYmFs LW5hbWUgImNvbS5hcHBsZS5kaWFnbm9zdGljZCIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBw bGUuaXN0LmRzLmFwcGxlY29ubmVjdDIuc2VydmljZS5rZGN0dW5uZWxjb250cm9sbGVyIikKKyAg ICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5sb2dkIikKKyAgICAoZ2xvYmFsLW5hbWUgImNvbS5h cHBsZS5sb2dkLmV2ZW50cyIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubHNkLm1hcGRi IikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5uZXNlc3Npb25tYW5hZ2VyLmZsb3ctZGl2 ZXJ0LXRva2VuIikKICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5uZXNlc3Npb25tYW5hZ2Vy LmNvbnRlbnQtZmlsdGVyIikgOzsgPHJkYXI6Ly9wcm9ibGVtLzQ3NTk4NzU4PgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUu V2ViS2l0Lk5ldHdvcmtpbmcuc2IgYi9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJv ZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYgppbmRleCBlZjE2MmNmOWE0 ZjMwMjhkYWFiNTE4YTJkY2M4Y2E2YzUyYjRiNGUwLi5lNzMxNzcwMmMzZWE3YTRlMDUzMjRiZWU5 MzNlMGYyMWE3ZjZiNjJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5k Ym94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZy5zYgorKysgYi9Tb3Vy Y2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQu TmV0d29ya2luZy5zYgpAQCAtNDA5LDcgKzQwOSw3IEBACiAgICAgcmVxdWlyZWQtZXRjLWZpbGVz CiAgICAgKGxpdGVyYWwgIi8iKSkKIAotKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHJlcG9ydCkg KHdpdGggdGVsZW1ldHJ5KQorKGFsbG93IG1hY2gtbG9va3VwCiAgICAgKGdsb2JhbC1uYW1lICJj b20uYXBwbGUubG9nZCIpCiAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUubG9nZC5ldmVudHMi KSkKIApAQCAtNDE4LDE0ICs0MTgsMTQgQEAKICAgICAobG9jYWwtbmFtZSAiY29tLmFwcGxlLmNm cHJlZnNkLmFnZW50IikKICkKIAotKGFsbG93IG1hY2gtbG9va3VwICh3aXRoIHRlbGVtZXRyeSkK KyhhbGxvdyBtYWNoLWxvb2t1cAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNmcHJlZnNk LmRhZW1vbiIpIDs7IE5lZWRlZCBieSBfQ0ZQcmVmZXJlbmNlc0dldEFwcEJvb2xlYW5WYWx1ZVdp dGhDb250YWluZXIgYW5kIG90aGVycy4KICkKIAogKGFsbG93IGlwYy1wb3NpeC1zaG0tcmVhZCoK ICAgICAoaXBjLXBvc2l4LW5hbWUtcHJlZml4ICJhcHBsZS5jZnByZWZzLiIpKQogCi0oYWxsb3cg bWFjaC1sb29rdXAgKHdpdGggdGVsZW1ldHJ5KQorKGFsbG93IG1hY2gtbG9va3VwCiAgICAgKGds b2JhbC1uYW1lICJjb20uYXBwbGUucnVubmluZ2JvYXJkIikpIDs7IE5lZWRlZCBieSBwcm9jZXNz IGFzc2VydGlvbiBjb2RlIChQcm9jZXNzVGFza1N0YXRlT2JzZXJ2ZXIpLgogCiAoYWxsb3ctbXVs dGktaW5zdGFuY2UteHBjLXNlcnZpY2VzKQpAQCAtNTM2LDkgKzUzNiw2IEBACiAoYWxsb3cgcHJv Y2Vzcy1pbmZvLXJ1c2FnZSAodGFyZ2V0IHNlbGYpKQogKGFsbG93IHByb2Nlc3MtaW5mby1jb2Rl c2lnbmF0dXJlICh0YXJnZXQgc2VsZikpCiAKLShhbGxvdyBtYWNoLWxvb2t1cCAod2l0aCByZXBv cnQpICh3aXRoIHRlbGVtZXRyeSkKLSAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5hbmFseXRp Y3NkIikpCi0KIDs7OwogOzs7IEVuZCBydWxlcyBvcmlnaW5hbGx5IGNvcGllZCBmcm9tICdjb21t b24uc2InCiA7OzsKQEAgLTYxMCw3ICs2MDcsNyBAQAogICAgIChnbG9iYWwtbmFtZSAiY29tLmFw cGxlLnNlY3VyaXR5ZCIpKQogCiA7OyBQYXNzS2l0IGZyYW1ld29yawotKGFsbG93IG1hY2gtbG9v a3VwICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5KQorKGFsbG93IG1hY2gtbG9va3VwCiAg ICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUucGFzc2QuaW4tYXBwLXBheW1lbnQiKQogICAgIChn bG9iYWwtbmFtZSAiY29tLmFwcGxlLnBhc3NkLmxpYnJhcnkiKSkKIApAQCAtNjM1LDEwICs2MzIs OSBAQAogICAgICAgKHJlbW90ZSB0Y3AgImxvY2FsaG9zdDo2MjA3OCIpKQogCiA7OyBWYXJpb3Vz IHNlcnZpY2VzIHJlcXVpcmVkIGJ5IHN5c3RlbSBmcmFtZXdvcmtzCi0oYWxsb3cgbWFjaC1sb29r dXAgKHdpdGggcmVwb3J0KSAod2l0aCB0ZWxlbWV0cnkpCisoYWxsb3cgbWFjaC1sb29rdXAKICAg ICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5sc2QubWFwZGIiKQotICAgIChnbG9iYWwtbmFtZSAi Y29tLmFwcGxlLmFuYWx5dGljc2QiKQotICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLkFwcFNT Ty5zZXJ2aWNlLXhwYyIpKQorICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmFuYWx5dGljc2Qi KSkKIAogOzsgRm9yIHJlcG9ydGluZyBwcm9ncmVzcyBmb3IgYWN0aXZlIGRvd25sb2FkcyA8cmRh cjovL3Byb2JsZW0vNDQ0MDU2NjE+CiAoYWxsb3cgbWFjaC1sb29rdXAgKHdpdGggcmVwb3J0KSAo d2l0aCB0ZWxlbWV0cnkpCg==