212704 2020-06-03 09:44:43 -0700 HAVE(ACCESSIBILITY_BUNDLES_PATH) is defined in terms of PLATFORM(IOS_FAMILY) but only checks the version of __IPHONE_OS_VERSION_MIN_REQUIRED 2020-06-08 21:34:39 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=207828 InRadar P2 Normal --- 1 aestes cfleizach aestes benjamin cdumez cfleizach cmarcelo darin ericliang ews-watchlist thorton webkit-bug-importer oldest_to_newest 1658742 0 aestes 2020-06-03 09:44:43 -0700 HAVE_ACCESSIBILITY_BUNDLES_PATH is defined like so: >#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000 >#define HAVE_ACCESSIBILITY_BUNDLES_PATH 1 >#endif The use of PLATFORM(IOS_FAMILY) suggests we should enable this HAVE() on some tvOS and watchOS platforms, but __IPHONE_OS_VERSION_MIN_REQUIRED will never be >= 140000 on these platforms. If we only intend to support iOS, we should change PLATFORM(IOS_FAMILY) to PLATFORM(IOS). Otherwise, we need to add a version check for each platform we intend to support, e.g.: >(PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) \ > || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 60000) \ > || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000) 1658745 1 webkit-bug-importer 2020-06-03 09:48:06 -0700 <rdar://problem/63931340> 1660423 2 401380 cfleizach 2020-06-08 15:18:19 -0700 Created attachment 401380 patch 1660440 3 401380 darin 2020-06-08 15:49:08 -0700 Comment on attachment 401380 patch View in context: https://bugs.webkit.org/attachment.cgi?id=401380&action=review > Source/WTF/wtf/PlatformHave.h:388 > -#if PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000 > +#if (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) \ > + || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 70000) \ > + || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 140000) Seems like an improvement. Also note that in IOS_FAMILY, besides iOS, watchOS, and tvOS, there is Mac Catalyst. 1660442 4 401380 cfleizach 2020-06-08 15:50:56 -0700 Comment on attachment 401380 patch View in context: https://bugs.webkit.org/attachment.cgi?id=401380&action=review >> Source/WTF/wtf/PlatformHave.h:388 >> + || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 140000) > > Seems like an improvement. Also note that in IOS_FAMILY, besides iOS, watchOS, and tvOS, there is Mac Catalyst. yes good point. we should also add that 1660444 5 401388 cfleizach 2020-06-08 15:54:27 -0700 Created attachment 401388 patch 1660451 6 401388 darin 2020-06-08 16:01:54 -0700 Comment on attachment 401388 patch View in context: https://bugs.webkit.org/attachment.cgi?id=401388&action=review > Source/WTF/wtf/PlatformHave.h:389 > + || (PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) Tim Horton asked earlier if __IPHONE_OS_VERSION_MIN_REQUIRED was the correct macro to check for MACCATALYST. He was pretty sure it was not. 1660458 7 cfleizach 2020-06-08 16:04:42 -0700 (In reply to Darin Adler from comment #6) > Comment on attachment 401388 [details] > patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=401388&action=review > > > Source/WTF/wtf/PlatformHave.h:389 > > + || (PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) > > Tim Horton asked earlier if __IPHONE_OS_VERSION_MIN_REQUIRED was the correct > macro to check for MACCATALYST. He was pretty sure it was not. I think it works I don't know if it's the best one. I saw this was already being used #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600) || (PLATFORM(MACCATALYST) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 140000) #define HAVE_MEDIA_USAGE_FRAMEWORK 1 #endif 1660478 8 darin 2020-06-08 16:26:01 -0700 OK. maybe HAVE(MEDIA_USAGE_FRAMEWORK) is right and Tim is wrong. Or maybe ... the other way around? Sure would be nice to confirm. 1660530 9 thorton 2020-06-08 18:25:31 -0700 (In reply to Darin Adler from comment #8) > OK. maybe HAVE(MEDIA_USAGE_FRAMEWORK) is right and Tim is wrong. Or maybe > ... the other way around? Sure would be nice to confirm. It looks like I was wrong! (or am wrong now, anyway!) 1660566 10 ews-feeder 2020-06-08 21:34:39 -0700 Committed r262765: <https://trac.webkit.org/changeset/262765> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401388. 401380 2020-06-08 15:18:19 -0700 2020-06-08 15:54:27 -0700 patch file_212704.txt text/plain 1338 cfleizach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cN CmluZGV4IDAwZDg1YmM3NDczLi40MzFiNDc5NDY1NCAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZw0KQEAgLTEsMyArMSwxNSBAQA0K KzIwMjAtMDYtMDggIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4NCisNCisg ICAgICAgIEhBVkUoQUNDRVNTSUJJTElUWV9CVU5ETEVTX1BBVEgpIGlzIGRlZmluZWQgaW4gdGVy bXMgb2YgUExBVEZPUk0oSU9TX0ZBTUlMWSkgYnV0IG9ubHkgY2hlY2tzIHRoZSB2ZXJzaW9uIG9m IF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEDQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNzA0DQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjM5MzEzNDA+DQorDQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4NCisN CisgICAgICAgIEVuc3VyZSB0aGF0IHRoaXMgd29ya3MgZm9yIGFsbCBpT1MgZmFtaWxlcy4NCisN CisgICAgICAgICogd3RmL1BsYXRmb3JtSGF2ZS5oOg0KKw0KIDIwMjAtMDYtMDQgIFBlciBBcm5l IFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPg0KIA0KICAgICAgICAgW0NvY29hXSBBZG9wdCBy ZWFkLW9ubHkgbW9kZSBmb3IgcHJlZmVyZW5jZXMgaW4gdGhlIFdlYkNvbnRlbnQgcHJvY2Vzcw0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oIGIvU291cmNlL1dURi93 dGYvUGxhdGZvcm1IYXZlLmgNCmluZGV4IDFmZGVkNmJhMWY3Li42OTlmNWQ5Yzc2NiAxMDA2NDQN Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oDQorKysgYi9Tb3VyY2UvV1RGL3d0 Zi9QbGF0Zm9ybUhhdmUuaA0KQEAgLTM4Myw3ICszODMsOSBAQA0KICNkZWZpbmUgSEFWRV9MSU5L X1BSRVZJRVcgMQ0KICNlbmRpZg0KIA0KLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQ SE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxNDAwMDANCisjaWYgKFBMQVRGT1JNKElP UykgJiYgX19JUEhPTkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTQwMDAwKSBcDQorICAg IHx8IChQTEFURk9STShXQVRDSE9TKSAmJiBfX1dBVENIX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVE ID49IDcwMDAwKSBcDQorICAgIHx8IChQTEFURk9STShBUFBMRVRWKSAmJiBfX1RWX09TX1ZFUlNJ T05fTUlOX1JFUVVJUkVEID49IDE0MDAwMCkNCiAjZGVmaW5lIEhBVkVfQUNDRVNTSUJJTElUWV9C VU5ETEVTX1BBVEggMQ0KICNlbmRpZg0KIA0K 401388 2020-06-08 15:54:27 -0700 2020-06-08 21:34:39 -0700 patch file_212704.txt text/plain 1417 cfleizach ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cN CmluZGV4IDAwZDg1YmM3NDczLi40Y2M3YmVmZjFhOCAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XVEYv Q2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZw0KQEAgLTEsMyArMSwxNSBAQA0K KzIwMjAtMDYtMDggIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4NCisNCisg ICAgICAgIEhBVkUoQUNDRVNTSUJJTElUWV9CVU5ETEVTX1BBVEgpIGlzIGRlZmluZWQgaW4gdGVy bXMgb2YgUExBVEZPUk0oSU9TX0ZBTUlMWSkgYnV0IG9ubHkgY2hlY2tzIHRoZSB2ZXJzaW9uIG9m IF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEDQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNzA0DQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNjM5MzEzNDA+DQorDQorICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4NCisNCisg ICAgICAgIEVuc3VyZSB0aGF0IHRoaXMgd29ya3MgZm9yIGFsbCBpT1MgZmFtaWxlcy4NCisNCisg ICAgICAgICogd3RmL1BsYXRmb3JtSGF2ZS5oOg0KKw0KIDIwMjAtMDYtMDQgIFBlciBBcm5lIFZv bGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPg0KIA0KICAgICAgICAgW0NvY29hXSBBZG9wdCByZWFk LW9ubHkgbW9kZSBmb3IgcHJlZmVyZW5jZXMgaW4gdGhlIFdlYkNvbnRlbnQgcHJvY2Vzcw0KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oIGIvU291cmNlL1dURi93dGYv UGxhdGZvcm1IYXZlLmgNCmluZGV4IDFmZGVkNmJhMWY3Li4wODNkODUwYmVhZSAxMDA2NDQNCi0t LSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtSGF2ZS5oDQorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybUhhdmUuaA0KQEAgLTM4Myw3ICszODMsMTAgQEANCiAjZGVmaW5lIEhBVkVfTElOS19Q UkVWSUVXIDENCiAjZW5kaWYNCiANCi0jaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkgJiYgX19JUEhP TkVfT1NfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTQwMDAwDQorI2lmIChQTEFURk9STShJT1Mp ICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDE0MDAwMCkgXA0KKyAgICB8 fCAoUExBVEZPUk0oV0FUQ0hPUykgJiYgX19XQVRDSF9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+ PSA3MDAwMCkgXA0KKyAgICB8fCAoUExBVEZPUk0oQVBQTEVUVikgJiYgX19UVl9PU19WRVJTSU9O X01JTl9SRVFVSVJFRCA+PSAxNDAwMDApIFwNCisgICAgfHwgKFBMQVRGT1JNKE1BQ0NBVEFMWVNU KSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxNDAwMDApDQogI2RlZmlu ZSBIQVZFX0FDQ0VTU0lCSUxJVFlfQlVORExFU19QQVRIIDENCiAjZW5kaWYNCiANCg==