212696 2020-06-03 08:38:10 -0700 REGRESSION: (r262432): [ iOS wk2 ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html is flaky failing. 2020-06-25 07:29:57 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build iPhone / iPad iOS 13 RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=212464 InRadar P2 Normal --- 1 Lawrence.j webkit-unassigned webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1658702 0 Lawrence.j 2020-06-03 08:38:10 -0700 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html Description: This test is flaky failing on iOS wk2. The test was passing consistently until 06/2/2020. History: https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Ffetch-request-no-freshness-headers.https.html&platform=ios&limit=50000 Diff: --- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https-expected.txt +++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https-actual.txt @@ -1,3 +1,3 @@ -FAIL The headers of FetchEvent shouldn't contain freshness headers. assert_false: if-none-match header must not be set in the FetchEvent's request. (url = https://localhost:9443/service-workers/service-worker/resources/fetch-request-no-freshness-headers-script.py) expected false got true +PASS The headers of FetchEvent shouldn't contain freshness headers. 1658704 1 webkit-bug-importer 2020-06-03 08:38:34 -0700 <rdar://problem/63928394> 1658710 2 Lawrence.j 2020-06-03 08:55:39 -0700 I can reproduce this issue with r262432, but I cannot reproduce it with r262431. Command: run-webkit-tests --ios-simulator --iterations 99 --exit-after-n-failures 3 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html r262432 results: [1/99] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html failed unexpectedly (text diff) [2/99] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html failed unexpectedly (text diff) [3/99] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html failed unexpectedly (text diff) Exiting early after 3 failures. 3 tests run. 0 tests ran as expected, 3 didn't (96 didn't run): r262431 results: All 99 tests ran as expected. 1658713 3 Lawrence.j 2020-06-03 09:00:29 -0700 I have marked this test as flaky failing while this issue is investigated. https://trac.webkit.org/changeset/262489/webkit 1658719 4 youennf 2020-06-03 09:07:53 -0700 https://trac.webkit.org/changeset/262489/webkit is most probably ensuring that the service worker is run in the same process as the page, thus potentially reusing the memory cache. It seems strange though that this is iOS sim only. 1658722 5 youennf 2020-06-03 09:12:28 -0700 Or maybe this is due to timing, and the reuse of the existing process makes the test run a bit faster. I do not think we are breaking behavior. 1666030 6 Lawrence.j 2020-06-25 07:29:21 -0700 I have removed the expectations because the test no longer appears to be failing: https://trac.webkit.org/changeset/263507/webkit