212693 2020-06-03 06:46:21 -0700 Read MediaPlayerPrivateMediaStreamAVFObjC::m_canEnqueueDisplayLayer after the lock 2020-06-04 06:02:17 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1658674 0 youennf 2020-06-03 06:46:21 -0700 Read MediaPlayerPrivateMediaStreamAVFObjC::m_canEnqueueDisplayLayer after the lock. As spotted by Eric, there might be an edge case where m_canEnqueueDisplayLayer check would be bypassed: - enqueueVideoSample is called in a background thread, checks m_canEnqueueDisplayLayer which is true and pauses just after the check. - destroyLayers is called, which sets m_canEnqueueDisplayLayer to false. - ensureLayers recreates the display layer which is then not yet initialized - enqueueVideoSample continues and will try to enqueue the sample while m_canEnqueueDisplayLayer is false. 1658677 1 400915 youennf 2020-06-03 06:49:40 -0700 Created attachment 400915 Patch 1659058 2 ews-feeder 2020-06-04 06:01:40 -0700 Committed r262532: <https://trac.webkit.org/changeset/262532> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400915. 1659059 3 webkit-bug-importer 2020-06-04 06:02:17 -0700 <rdar://problem/63975063> 400915 2020-06-03 06:49:40 -0700 2020-06-04 06:01:40 -0700 Patch bug-212693-20200603154939.patch text/plain 2789 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNDgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTRjZDhjNzk0NzNmMjRi ODdkNzJmYzEzYTJiNjk3N2NiMGI0MWM5Ny4uZjAxYTlkOWExNzE5YjU1Y2YyNTU2NGJlMzQwMzA3 MGM0YThiOTdhOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTA2LTAzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBSZWFkIE1lZGlhUGxheWVy UHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQzo6bV9jYW5FbnF1ZXVlRGlzcGxheUxheWVyIGFmdGVy IHRoZSBsb2NrCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMTI2OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbiBjYXNlIGRlc3Ryb3lMYXllcnMgaXMgY2FsbGVkIGFuZCBzaG9ydGx5IGFmdGVyIGVuc3Vy ZUxheWVycyBpcyBhbHNvIGNhbGxlZCwgdGhlIG1fY2FuRW5xdWV1ZURpc3BsYXlMYXllciBjaGVj ayBpbiBlbnF1ZXVlVmlkZW9TYW1wbGUKKyAgICAgICAgbWlnaHQgYmUgYnlwYXNzZWQuIE1ha2Ug c3VyZSB0byBsb2NrIGJlZm9yZSBjaGVja2luZyBtX2NhbkVucXVldWVEaXNwbGF5TGF5ZXIgaW4g ZW5xdWV1ZVZpZGVvU2FtcGxlLgorICAgICAgICBGb3IgZ29vZCBtZWFzdXJlLCBzZXQgbV9jYW5F bnF1ZXVlRGlzcGxheUxheWVyIHRvIGZhbHNlIGFmdGVyIGxvY2tpbmcgaW4gZGVzdHJveUxheWVy cy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlh UGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1l ZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQzo6ZW5xdWV1ZVZpZGVvU2FtcGxlKToK KyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQzo6 ZGVzdHJveUxheWVycyk6CisKIDIwMjAtMDYtMDMgIEphdmllciBGZXJuYW5kZXogIDxqZmVybmFu ZGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1ncmlkXSBEeW5hbWljYWxseSBzZXR0aW5n ICJwb3NpdGlvbjogYWJzb2x1dGUiIGluIGEgZ3JpZCBpdGVtIGRvZXNuJ3QgdHJpZ2dlciBhIHJl bGF5b3V0IG9mIHRoYXQgZWxlbWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJl YW1BVkZPYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL29iamMvTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDLm1tCmluZGV4IDFh MGNhYzZhYzkzNmY5NTg5ODdiMGU4OTQ3YzBkYzgwNTNjNmYxYmQuLjI5YjBjNTcwNTQwMmZlN2Q3 MTQxNzM0MzZmYWJmZjg0YjdiY2IxNmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhUGxheWVyUHJpdmF0ZU1lZGlhU3Ry ZWFtQVZGT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZv dW5kYXRpb24vb2JqYy9NZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakMubW0KQEAg LTI1MiwxNCArMjUyLDExIEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZP YmpDOjp2aWRlb1NhbXBsZUF2YWlsYWJsZShNZWRpYVNhbXBsZSYgc2FtCiAKIHZvaWQgTWVkaWFQ bGF5ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjplbnF1ZXVlVmlkZW9TYW1wbGUoTWVkaWFT YW1wbGUmIHNhbXBsZSkKIHsKLSAgICBpZiAoIW1fY2FuRW5xdWV1ZURpc3BsYXlMYXllcikKLSAg ICAgICAgcmV0dXJuOwotCiAgICAgYXV0byBsb2NrZXIgPSB0cnlIb2xkTG9jayhtX3NhbXBsZUJ1 ZmZlckRpc3BsYXlMYXllckxvY2spOwogICAgIGlmICghbG9ja2VyKQogICAgICAgICByZXR1cm47 CiAKLSAgICBpZiAoIW1fc2FtcGxlQnVmZmVyRGlzcGxheUxheWVyIHx8IG1fc2FtcGxlQnVmZmVy RGlzcGxheUxheWVyLT5kaWRGYWlsKCkpCisgICAgaWYgKCFtX2NhbkVucXVldWVEaXNwbGF5TGF5 ZXIgfHwgIW1fc2FtcGxlQnVmZmVyRGlzcGxheUxheWVyIHx8IG1fc2FtcGxlQnVmZmVyRGlzcGxh eUxheWVyLT5kaWRGYWlsKCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmIChzYW1wbGUudmlk ZW9Sb3RhdGlvbigpICE9IG1fdmlkZW9Sb3RhdGlvbiB8fCBzYW1wbGUudmlkZW9NaXJyb3JlZCgp ICE9IG1fdmlkZW9NaXJyb3JlZCkgewpAQCAtMzc3LDkgKzM3NCw5IEBAIHZvaWQgTWVkaWFQbGF5 ZXJQcml2YXRlTWVkaWFTdHJlYW1BVkZPYmpDOjplbnN1cmVMYXllcnMoKQogCiB2b2lkIE1lZGlh UGxheWVyUHJpdmF0ZU1lZGlhU3RyZWFtQVZGT2JqQzo6ZGVzdHJveUxheWVycygpCiB7Ci0gICAg bV9jYW5FbnF1ZXVlRGlzcGxheUxheWVyID0gZmFsc2U7Ci0KICAgICBhdXRvIGxvY2tlciA9IGhv bGRMb2NrKG1fc2FtcGxlQnVmZmVyRGlzcGxheUxheWVyTG9jayk7CisKKyAgICBtX2NhbkVucXVl dWVEaXNwbGF5TGF5ZXIgPSBmYWxzZTsKICAgICBpZiAobV9zYW1wbGVCdWZmZXJEaXNwbGF5TGF5 ZXIpCiAgICAgICAgIG1fc2FtcGxlQnVmZmVyRGlzcGxheUxheWVyID0gbnVsbHB0cjsKIAo=