212690 2020-06-03 05:15:24 -0700 [GTK4] WTR: Forward key events to the active popup menu 2020-06-03 06:48:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 210100 1 cgarcia webkit-unassigned aperez berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1658665 0 cgarcia 2020-06-03 05:15:24 -0700 I forgot to remove the ifdefs when added support for popup menus in r262414 1658666 1 400912 cgarcia 2020-06-03 05:17:59 -0700 Created attachment 400912 Patch 1658667 2 ews-watchlist 2020-06-03 05:18:36 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1658676 3 cgarcia 2020-06-03 06:48:12 -0700 Committed r262485: <https://trac.webkit.org/changeset/262485> 400912 2020-06-03 05:17:59 -0700 2020-06-03 05:29:59 -0700 Patch wkgtk4-wtr-menu.diff text/plain 1981 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNWI4NGQyYmMxNDY1Li45MTUzYjkzNmFiMzMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTUgQEAKKzIwMjAtMDYtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEs0XSBXVFI6IEZvcndhcmQga2V5IGV2ZW50cyB0byB0aGUg YWN0aXZlIHBvcHVwIG1lbnUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIxMjY5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEkgZm9yZ290IHRvIHJlbW92ZSB0aGUgaWZkZWZzIHdoZW4gYWRkZWQgc3VwcG9y dCBmb3IgcG9wdXAgbWVudXMgaW4gcjI2MjQxNC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcDoKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdCYXNlU3lu dGhlc2l6ZUtleUV2ZW50KToKKwogMjAyMC0wNi0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUSzRdIEltcGxlbWVudCBlbW9qaSBjaG9v c2VyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdl YlZpZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlld0Jhc2UuY3BwCmluZGV4IDI4Yzc1ZDRmNDRiZS4uMWU0ZTFhMmM4MTc0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNw cApAQCAtMjU4NCw3ICsyNTg0LDYgQEAgdm9pZCB3ZWJraXRXZWJWaWV3QmFzZVN5bnRoZXNpemVL ZXlFdmVudChXZWJLaXRXZWJWaWV3QmFzZSogd2ViVmlld0Jhc2UsIEtleUV2ZW4KICAgICAgICAg cmV0dXJuOwogCiAgICAgaWYgKHR5cGUgIT0gS2V5RXZlbnRUeXBlOjpSZWxlYXNlKSB7Ci0jaWYg IVVTRShHVEs0KQogICAgICAgICBpZiAoYXV0byogcG9wdXBNZW51ID0gcHJpdi0+cGFnZVByb3h5 LT5hY3RpdmVQb3B1cE1lbnUoKSkgewogICAgICAgICAgICAgYXV0byogZ3RrUG9wdXBNZW51ID0g c3RhdGljX2Nhc3Q8V2ViUG9wdXBNZW51UHJveHlHdGsqPihwb3B1cE1lbnUpOwogICAgICAgICAg ICAgaWYgKGd0a1BvcHVwTWVudS0+aGFuZGxlS2V5UHJlc3Moa2V5dmFsLCBHREtfQ1VSUkVOVF9U SU1FKSkKQEAgLTI1OTUsNyArMjU5NCw2IEBAIHZvaWQgd2Via2l0V2ViVmlld0Jhc2VTeW50aGVz aXplS2V5RXZlbnQoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlLCBLZXlFdmVuCiAgICAg ICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgfQogICAgICAgICB9Ci0jZW5kaWYKIAog I2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKICAgICAgICAgaWYgKHByaXYtPmZ1bGxTY3JlZW5N b2RlQWN0aXZlKSB7CkBAIC0yNjExLDEyICsyNjA5LDEwIEBAIHZvaWQgd2Via2l0V2ViVmlld0Jh c2VTeW50aGVzaXplS2V5RXZlbnQoV2ViS2l0V2ViVmlld0Jhc2UqIHdlYlZpZXdCYXNlLCBLZXlF dmVuCiAgICAgICAgIH0KICNlbmRpZgogCi0jaWYgIVVTRShHVEs0KQogICAgICAgICBpZiAoa2V5 dmFsID09IEdES19LRVlfTWVudSkgewogICAgICAgICAgICAgd2Via2l0V2ViVmlld0Jhc2VQb3B1 cE1lbnUoR1RLX1dJREdFVCh3ZWJWaWV3QmFzZSkpOwogICAgICAgICAgICAgcmV0dXJuOwogICAg ICAgICB9Ci0jZW5kaWYKICAgICB9CiAKICAgICBhdXRvIGtleWNvZGUgPSB3aWRnZXRLZXl2YWxU b0tleWNvZGUoR1RLX1dJREdFVCh3ZWJWaWV3QmFzZSksIGtleXZhbCk7Cg==