21268 2008-09-30 22:17:25 -0700 CSS file line numbers should be displayed on styles pane 2010-03-23 00:52:49 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Enhancement --- 36414 1 henkka webkit-unassigned aroben bweinstein cell.jason eric greg hyatt joepeck me pfeldman timothy oldest_to_newest 93506 0 henkka 2008-09-30 22:17:25 -0700 This useful feature is present in Firebug and missing from WebKit inspector, which I'm really missing. 93652 1 timothy 2008-10-01 20:05:46 -0700 <rdar://problem/6116072> 93864 2 timothy 2008-10-03 00:23:59 -0700 *** Bug 21324 has been marked as a duplicate of this bug. *** 132567 3 timothy 2009-07-17 07:18:15 -0700 *** Bug 27362 has been marked as a duplicate of this bug. *** 166200 4 cell.jason 2009-11-24 11:34:09 -0800 I also would love this to be implemented. +5 166201 5 43793 cell.jason 2009-11-24 11:36:47 -0800 Created attachment 43793 Example of CSS Line numbers implementation [screenshot] 166203 6 43793 cell.jason 2009-11-24 11:37:43 -0800 Comment on attachment 43793 Example of CSS Line numbers implementation [screenshot] http://img.skitch.com/20091124-rxtwi85rw2um1xiw88ft4be5r8.jpg 166237 7 timothy 2009-11-24 12:19:05 -0800 Out style is file:line. So: imac.css:144 166248 8 cell.jason 2009-11-24 12:32:24 -0800 That format sounds spectacular. 182095 9 joepeck 2010-01-18 18:58:45 -0800 It seems this is a very common request. So I looked things over. A few thoughts out loud: 1. The Web Inspector currently gets all its style info through public DOM methods. As far as I know, everything is available, up to the filename (taken from the href) of the Stylesheet. Line numbers however aren't available. Would exposing them through the DOM, say in an IDL like CSSStyleRule be taboo? I'd like to know the process on creating non-standard, but public properties. 2. Grammar Changes. Currently whitespace is breezed over: - css/tokenizer.flex has > [ \t\r\n\f]+ {yyTok = WHITESPACE; return yyTok;} - css/CSSGrammar.y has > %token WHITESPACE SGML_CD - css/CSSParser.cpp in CSSParser::lex(void* yylvalWithoutType) > switch (token()) { > case WHITESPACE: > case SGML_CD: > case INCLUDES: > case DASHMATCH: > break; If we were to quickly add this, we could just have a counter, and increment the counter in the lexer however many newlines we see in the WHITESPACE (and SGML_CD?) tokens. I have a feeling that would probably have an impact performance. (Reparsing a string that was already parsed into a token). An alternative would be breaking WHITESPACE up in the tokenizer/grammar. Counting newlines there, and ignoring other whitespace as usual. This would (hopefully) ensure the text is parsed just once, keeping the performance about the same. Assuming a developer were to try out these approaches, are there tools for testing the performance of the CSS parser? I noticed some recent work on the JavaScript grammar had some tooling for just testing parsing: https://bugs.webkit.org/show_bug.cgi?id=32722#c17 182318 10 me 2010-01-19 10:50:52 -0800 Line numbering provides an efficient way to identify adjustments and errors in CSS. 202956 11 pfeldman 2010-03-23 00:52:49 -0700 Fixed as a part of 36414 43793 2009-11-24 11:36:47 -0800 2009-11-24 11:37:43 -0800 Example of CSS Line numbers implementation [screenshot] url.txt text/plain 61 cell.jason aHR0cDovL2ltZy5za2l0Y2guY29tLzIwMDkxMTI0LXJ4dHdpODVydzJ1bTF4aXc4OGZ0NGJlNXI4 LmpwZw==