<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>212650</bug_id>
          
          <creation_ts>2020-06-02 12:30:47 -0700</creation_ts>
          <short_desc>ASSERTION FAILED: isCell() under WebCore::JSDOMConstructor seen with webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html</short_desc>
          <delta_ts>2020-06-03 08:19:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ryan Haddad">ryanhaddad</reporter>
          <assigned_to name="Yusuke Suzuki">ysuzuki</assigned_to>
          <cc>cdumez</cc>
    
    <cc>mark.lam</cc>
    
    <cc>rniwa</cc>
    
    <cc>webkit-bot-watchers-bugzilla</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
    
    <cc>ysuzuki</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1658414</commentid>
    <comment_count>0</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-06-02 12:30:47 -0700</bug_when>
    <thetext>imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html, imported with https://trac.webkit.org/changeset/262405/webkit, is consistently crashing on debug bots with the following:

ASSERTION FAILED: isCell()
/Volumes/Data/slave/catalina-debug/build/WebKitBuild/Debug/JavaScriptCore.framework/PrivateHeaders/JSCJSValueInlines.h(557) : JSC::JSCell *JSC::JSValue::asCell() const
1   0x3e5a304d9 WTFCrash
2   0x3c800296b WTFCrashWithInfo(int, char const*, char const*, int)
3   0x3c80eda7b JSC::JSValue::asCell() const
4   0x3c831dd65 JSC::asObject(JSC::JSValue)
5   0x3c861e52b WebCore::JSDOMConstructor&lt;WebCore::JSAudioContext&gt;::construct(JSC::JSGlobalObject*, JSC::CallFrame*)
6   0x3e6e99c45 JSC::NativeFunction::operator()(JSC::JSGlobalObject*, JSC::CallFrame*)
7   0x3e6e99b22 JSC::TaggedNativeFunction::operator()(JSC::JSGlobalObject*, JSC::CallFrame*)
8   0x3e6f10c43 JSC::LLInt::handleHostCall(JSC::CallFrame*, JSC::JSValue, JSC::CodeSpecializationKind)
9   0x3e6f0fdd1 JSC::LLInt::setUpCall(JSC::CallFrame*, JSC::CodeSpecializationKind, JSC::JSValue, JSC::LLIntCallLinkInfo*)
10  0x3e6f01763 JSC::SlowPathReturnType JSC::LLInt::genericCall&lt;JSC::OpConstruct&gt;(JSC::CodeBlock*, JSC::CallFrame*, JSC::OpConstruct&amp;&amp;, JSC::CodeSpecializationKind, unsigned int)
11  0x3e6f015ff llint_slow_path_construct
12  0x3e5fb69cc llint_entry
13  0x3e5fb5b32 llint_entry
14  0x3e5fb5b32 llint_entry
15  0x3e5fb5b32 llint_entry
16  0x3e5fb5b32 llint_entry
17  0x3e5fb693b llint_entry
18  0x3e5fb6e4b llint_entry
19  0x3e5fb5a8f llint_entry
20  0x3e5fb5b32 llint_entry
21  0x3e5fb693b llint_entry
22  0x3e5fb5b32 llint_entry
23  0x3e5f95d33 vmEntryToJavaScript
24  0x3e6dc9d8b JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
25  0x3e6dca54f JSC::Interpreter::executeCall(JSC::JSGlobalObject*, JSC::JSObject*, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;)
26  0x3e7146a7d JSC::call(JSC::JSGlobalObject*, JSC::JSValue, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;)
27  0x3e7146d53 JSC::profiledCall(JSC::JSGlobalObject*, JSC::ProfilingReason, JSC::JSValue, JSC::CallData const&amp;, JSC::JSValue, JSC::ArgList const&amp;)
28  0x3e7323482 JSC::JSMicrotask::run(JSC::JSGlobalObject*)
29  0x3ca5140ce WebCore::JSExecState::runTask(JSC::JSGlobalObject*, JSC::Microtask&amp;)
30  0x3ca51b27b WebCore::JSMicrotaskCallback::call()
31  0x3ca51b0fd WebCore::JSDOMWindowBase::queueMicrotaskToEventLoop(JSC::JSGlobalObject&amp;, WTF::Ref&lt;JSC::Microtask, WTF::DumbPtrTraits&lt;JSC::Microtask&gt; &gt;&amp;&amp;)::$_35::operator()()
LEAK: 1 WebPageProxy

https://results.webkit.org/?suite=layout-tests&amp;test=imported%2Fw3c%2Fweb-platform-tests%2Fwebaudio%2Fthe-audio-api%2Fthe-audiocontext-interface%2Faudiocontextoptions.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658415</commentid>
    <comment_count>1</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-06-02 12:30:59 -0700</bug_when>
    <thetext>&lt;rdar://63886202&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658416</commentid>
    <comment_count>2</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-06-02 12:31:23 -0700</bug_when>
    <thetext>&lt;rdar://problem/63887102&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658521</commentid>
    <comment_count>3</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2020-06-02 17:47:26 -0700</bug_when>
    <thetext>Skipped the test for macOS/iOS debug in r262464 and r262465.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658618</commentid>
    <comment_count>4</comment_count>
      <attachid>400895</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-06-02 22:10:28 -0700</bug_when>
    <thetext>Created attachment 400895
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658619</commentid>
    <comment_count>5</comment_count>
      <attachid>400896</attachid>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-06-02 22:11:33 -0700</bug_when>
    <thetext>Created attachment 400896
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658621</commentid>
    <comment_count>6</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-06-02 22:16:33 -0700</bug_when>
    <thetext>I&apos;ll update binding tests results.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658622</commentid>
    <comment_count>7</comment_count>
      <attachid>400896</attachid>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2020-06-02 22:17:49 -0700</bug_when>
    <thetext>Comment on attachment 400896
Patch

r=me.  Please rebase the bindings test results.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658636</commentid>
    <comment_count>8</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-06-02 23:49:56 -0700</bug_when>
    <thetext>imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-no-freshness-headers.https.html is failing on iOS without this. https://results.webkit.org/?suite=layout-tests&amp;test=imported%2Fw3c%2Fweb-platform-tests%2Fservice-workers%2Fservice-worker%2Ffetch-request-no-freshness-headers.https.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658637</commentid>
    <comment_count>9</comment_count>
    <who name="Yusuke Suzuki">ysuzuki</who>
    <bug_when>2020-06-02 23:53:23 -0700</bug_when>
    <thetext>Committed r262479: &lt;https://trac.webkit.org/changeset/262479&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658696</commentid>
    <comment_count>10</comment_count>
      <attachid>400896</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2020-06-03 08:19:31 -0700</bug_when>
    <thetext>Comment on attachment 400896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=400896&amp;action=review

&gt; Source/WebCore/ChangeLog:8
&gt; +        Some DOM constructor can return jsNull. For example, AudioContext constructor can return jsNull when it exceeds # of hardware audio contexts.

This looks like a bug in the AudioContext implementation. This is not the specified behavior:
https://www.w3.org/TR/webaudio/#AudioContext-constructors

&quot;If the AudioContext is not allowed to start, abort these steps.&quot;

So we&apos;re supposed to construct an AudioContext but it is not supposed to start playing.

I can understand if you don&apos;t want to fix the WebAudio implementation. But then why not simply add a new WebIDL attribute like [ConstructorMayReturnNull], and then the bindings generator would use toJS() instead of toJSNewlyCreated() in this case?

&gt; Source/WebCore/ChangeLog:9
&gt; +        However CodeGeneratorJS assumes that DOM constructor always returns an object, or throws an exception.

Yes, this was the whole idea behind toJSNewlyCreated() vs toJS(). This was an optimization to avoid the null check when the object was just constructed. It seems like this change is reverting the optimization.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>400895</attachid>
            <date>2020-06-02 22:10:28 -0700</date>
            <delta_ts>2020-06-02 22:11:32 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-212650-20200602221027.patch</filename>
            <type>text/plain</type>
            <size>5351</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmJkNjUwZjNhOThjZWUy
ZDEyOTcyZTkzMjU5YWY0ZThhM2MwMjllZC4uZDg0ZDRiMjk4OGYxNWEyZTIxNmY5OWM0N2FmODYx
Y2I0NmE2YmIzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA2LTAyICBZdXN1
a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxF
RDogaXNDZWxsKCkgdW5kZXIgV2ViQ29yZTo6SlNET01Db25zdHJ1Y3RvciBzZWVuIHdpdGggd2Vi
YXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYXVkaW9jb250ZXh0LWludGVyZmFjZS9hdWRpb2NvbnRl
eHRvcHRpb25zLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIxMjY1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFNvbWUgRE9NIGNvbnN0cnVjdG9yIGNhbiByZXR1cm4ganNOdWxsLiBGb3IgZXhhbXBs
ZSwgQXVkaW9Db250ZXh0IGNvbnN0cnVjdG9yIGNhbiByZXR1cm4ganNOdWxsIHdoZW4gaXQgZXhj
ZWVkcyAjIG9mIGhhcmR3YXJlIGF1ZGlvIGNvbnRleHRzLgorICAgICAgICBIb3dldmVyIENvZGVH
ZW5lcmF0b3JKUyBhc3N1bWVzIHRoYXQgRE9NIGNvbnN0cnVjdG9yIGFsd2F5cyByZXR1cm5zIGFu
IG9iamVjdCwgb3IgdGhyb3dzIGFuIGV4Y2VwdGlvbi4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRz
IGBpc09iamVjdCgpYCBjaGVjayBhZnRlciBET00gY29uc3RydWN0b3IgY2FsbCB0byBoYW5kbGUg
dGhlIGpzTnVsbCBjYXNlIHdoaWxlIGl0IGRvZXMgbm90IGNoYW5nZSB0aGUgZXhpc3Rpbmcgc2Vt
YW50aWNzLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06
CisgICAgICAgIChHZW5lcmF0ZUNvbnN0cnVjdG9yRGVmaW5pdGlvbik6CisKIDIwMjAtMDYtMDIg
IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEg
aGVscGVyIG1ldGhvZCB0byBwb3B1bGF0ZSBhIERhdGFUcmFuc2ZlciBiZWZvcmUgZGlzcGF0Y2hp
bmcgYSAiZHJhZ3N0YXJ0IiBldmVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu
Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9z
Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCA3NWExNGEwMzQ1M2U1YmI3MGNhNjI0ZTBi
MzNkMzcxODhjOTMzOGY5Li45ODBiOTI5YTEyYzBlZjM2NDE5ZjgxNWIwMDZjYmI1MzZiNzE0YjA4
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0
b3JKUy5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0
b3JKUy5wbQpAQCAtNzQ3NiwxMCArNzQ3NiwxMyBAQCBzdWIgR2VuZXJhdGVDb25zdHJ1Y3RvckRl
ZmluaXRpb24KICAgICAgICAgICAgIHB1c2goQGNvbnN0cnVjdGlvbkNvbnZlcnNpb25Bcmd1bWVu
dHMsICJXVEZNb3ZlKG9iamVjdCkiKTsKIAogICAgICAgICAgICAgIyBGSVhNRTogdG9KU05ld2x5
Q3JlYXRlZCBzaG91bGQgcmV0dXJuIEpTT2JqZWN0KiBpbnN0ZWFkIG9mIEpTVmFsdWUuCisgICAg
ICAgICAgICAjIEJ1dCBjZXJ0YWluIGNvbnN0cnVjdG9yIGNhbiByZXR1cm4ganNOdWxsKCkgZS5n
LiBBdWRpb0NvbnRleHQuCiAgICAgICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIgICAgYXV0
byBqc1ZhbHVlID0gdG9KU05ld2x5Q3JlYXRlZDwke0lETFR5cGV9PigiIC4gam9pbigiLCAiLCBA
Y29uc3RydWN0aW9uQ29udmVyc2lvbkFyZ3VtZW50cykgLiAiKTtcbiIpOwogICAgICAgICAgICAg
cHVzaChAJG91dHB1dEFycmF5LCAiICAgIFJFVFVSTl9JRl9FWENFUFRJT04odGhyb3dTY29wZSwg
eyB9KTtcbiIpIGlmICRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+e0NvbnN0cnVjdG9y
TWF5VGhyb3dFeGNlcHRpb259OwotICAgICAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAg
IHNldFN1YmNsYXNzU3RydWN0dXJlSWZOZWVkZWQ8JHtpbXBsVHlwZX0+KGxleGljYWxHbG9iYWxP
YmplY3QsIGNhbGxGcmFtZSwgYXNPYmplY3QoanNWYWx1ZSkpO1xuIik7Ci0gICAgICAgICAgICBw
dXNoKEAkb3V0cHV0QXJyYXksICIgICAgUkVUVVJOX0lGX0VYQ0VQVElPTih0aHJvd1Njb3BlLCB7
IH0pO1xuIik7CisgICAgICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIgICAgaWYgKGF1dG8q
IG9iamVjdCA9IGpzRHluYW1pY0Nhc3Q8SlNPYmplY3QqPih2bSwganNWYWx1ZSkpIHtcbiIpOwor
ICAgICAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgICAgICBzZXRTdWJjbGFzc1N0cnVj
dHVyZUlmTmVlZGVkPCR7aW1wbFR5cGV9PihsZXhpY2FsR2xvYmFsT2JqZWN0LCBjYWxsRnJhbWUs
IG9iamVjdCk7XG4iKTsKKyAgICAgICAgICAgIHB1c2goQCRvdXRwdXRBcnJheSwgIiAgICAgICAg
UkVUVVJOX0lGX0VYQ0VQVElPTih0aHJvd1Njb3BlLCB7IH0pO1xuIik7CisgICAgICAgICAgICBw
dXNoKEAkb3V0cHV0QXJyYXksICIgICAgfVxuIik7CiAgICAgICAgICAgICBwdXNoKEAkb3V0cHV0
QXJyYXksICIgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1ZhbHVlKTtcbiIpOwogICAgICAg
ICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAifVxuXG4iKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0
IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUy
M2VhNTY1OTlhMmRlZmJlMDAzYTMzZDNhODZjNWZkOGVkNWMyNGQuLmFlNTA5ZDVlYjBlYjYwYThl
OGRkYjcwMGY1NGQwMDllMTc3NzI3YTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv
ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wNi0w
MiAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVElP
TiBGQUlMRUQ6IGlzQ2VsbCgpIHVuZGVyIFdlYkNvcmU6OkpTRE9NQ29uc3RydWN0b3Igc2VlbiB3
aXRoIHdlYmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWF1ZGlvY29udGV4dC1pbnRlcmZhY2UvYXVk
aW9jb250ZXh0b3B0aW9ucy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yMTI2NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAq
IHBsYXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIwLTA2LTAyICBQZW5nIExpdSAg
PHBlbmcubGl1NkBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IHRlc3QgZmFpbHVyZXM6IG1l
ZGlhL3ZpZGVvLWNyZWF0ZS13aXRoLXVzZXItZ2VzdHVyZS5odG1sIGFuZCBtZWRpYS92aWRlby1y
ZXN0cmljdGVkLW5vLXByZWxvYWQtYXV0by5odG1sCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9w
bGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9U
ZXN0RXhwZWN0YXRpb25zCmluZGV4IDM5Mzg2MzRkNmUyZjc1Y2I1MGU0NDJmOTU3MjM1ZWJkY2U3
OWRiMDAuLjYwOGJiNmY4Nzk5ZGQ0ZmZjOThkN2NhYWFhYzYwNmZhYTU2MDYyYTYgMTAwNjQ0Ci0t
LSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91
dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCkBAIC0zNTI5LDcgKzM1MjksNSBA
QCB3ZWJraXQub3JnL2IvMjEyMjI3IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3Nz
L2Nzcy1ncmlkL2FsaWdubWVudC9zZWxmLQogCiB3ZWJraXQub3JnL2IvMjEyNDkzIGltcG9ydGVk
L3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2dyaWQtaXRlbXMvZ3JpZC1pdGVt
cy1zaXppbmctYWxpZ25tZW50LTAwMS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtp
dC5vcmcvYi8yMTI2NTAgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMv
d2ViYXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYXVkaW9jb250ZXh0LWludGVyZmFjZS9hdWRpb2Nv
bnRleHRvcHRpb25zLmh0bWwgWyBTa2lwIF0KLQogIyBUaGlzIHRlc3QgcmVxdWlyZXMgYW4gdXBk
YXRlIHRvIHN5c3RlbSBkZWNvZGVycwogd2Via2l0Lm9yZy9iLzIxMjU2NSBpbXBvcnRlZC93M2Mv
d2ViLXBsYXRmb3JtLXRlc3RzL2VuY29kaW5nL3NpbmdsZS1ieXRlLWRlY29kZXIuaHRtbCBbIEZh
aWx1cmUgXQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3Rh
dGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAx
NmJlMzY3MWFiMWU0NjIxOWJhNzBjMWZkZmFmYTkxZTM0M2E2YjcwLi40N2E3NmQ0MmJiMGZhODhi
OTg5N2ZlMmFlODUzNGFiNWFkODY4NTFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9y
bS9tYWMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVz
dEV4cGVjdGF0aW9ucwpAQCAtMTk3MCw3ICsxOTcwLDUgQEAgd2Via2l0Lm9yZy9iLzIxMjQ4OCBb
IENhdGFsaW5hIF0gbWVkaWEvdmlkZW8tcGxheS1hdWRpby1yZXF1aXJlLXVzZXItZ2VzdHVyZS5o
dG0KIHdlYmtpdC5vcmcvYi8yMTI1OTQgd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UvY2FudmFzL2J1
ZmZlci1vZmZzY3JlZW4tdGVzdC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjEyNTk0
IHdlYmdsLzEuMC4zL2NvbmZvcm1hbmNlL2NhbnZhcy9idWZmZXItb2Zmc2NyZWVuLXRlc3QuaHRt
bCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMjEyNjUwIFsgRGVidWcgXSBpbXBvcnRlZC93
M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3dlYmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWF1ZGlvY29u
dGV4dC1pbnRlcmZhY2UvYXVkaW9jb250ZXh0b3B0aW9ucy5odG1sIFsgU2tpcCBdCi0KICMgVGhp
cyB0ZXN0IHJlcXVpcmVzIGFuIHVwZGF0ZSB0byBzeXN0ZW0gZGVjb2RlcnMKIHdlYmtpdC5vcmcv
Yi8yMTI1NjUgWyBDYXRhbGluYSBNb2phdmUgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl
c3RzL2VuY29kaW5nL3NpbmdsZS1ieXRlLWRlY29kZXIuaHRtbCBbIEZhaWx1cmUgXQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>400896</attachid>
            <date>2020-06-02 22:11:33 -0700</date>
            <delta_ts>2020-06-02 22:17:49 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-212650-20200602221132.patch</filename>
            <type>text/plain</type>
            <size>5345</size>
            <attacher name="Yusuke Suzuki">ysuzuki</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmJkNjUwZjNhOThjZWUy
ZDEyOTcyZTkzMjU5YWY0ZThhM2MwMjllZC4uZGM5NGI2ZjliMmI5Yzk1YWE1Yjg0YWMxYjJjOWNk
ZDk0ZGExNzFhNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTA2LTAyICBZdXN1
a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxF
RDogaXNDZWxsKCkgdW5kZXIgV2ViQ29yZTo6SlNET01Db25zdHJ1Y3RvciBzZWVuIHdpdGggd2Vi
YXVkaW8vdGhlLWF1ZGlvLWFwaS90aGUtYXVkaW9jb250ZXh0LWludGVyZmFjZS9hdWRpb2NvbnRl
eHRvcHRpb25zLmh0bWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTIxMjY1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg
ICAgICAgIFNvbWUgRE9NIGNvbnN0cnVjdG9yIGNhbiByZXR1cm4ganNOdWxsLiBGb3IgZXhhbXBs
ZSwgQXVkaW9Db250ZXh0IGNvbnN0cnVjdG9yIGNhbiByZXR1cm4ganNOdWxsIHdoZW4gaXQgZXhj
ZWVkcyAjIG9mIGhhcmR3YXJlIGF1ZGlvIGNvbnRleHRzLgorICAgICAgICBIb3dldmVyIENvZGVH
ZW5lcmF0b3JKUyBhc3N1bWVzIHRoYXQgRE9NIGNvbnN0cnVjdG9yIGFsd2F5cyByZXR1cm5zIGFu
IG9iamVjdCwgb3IgdGhyb3dzIGFuIGV4Y2VwdGlvbi4KKyAgICAgICAgVGhpcyBwYXRjaCBhZGRz
IG9iamVjdCBjaGVjayBhZnRlciBET00gY29uc3RydWN0b3IgY2FsbCB0byBoYW5kbGUgdGhlIGpz
TnVsbCBjYXNlIHdoaWxlIGl0IGRvZXMgbm90IGNoYW5nZSB0aGUgZXhpc3Rpbmcgc2VtYW50aWNz
LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG06CisgICAg
ICAgIChHZW5lcmF0ZUNvbnN0cnVjdG9yRGVmaW5pdGlvbik6CisKIDIwMjAtMDYtMDIgIFdlbnNv
biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIGEgaGVscGVy
IG1ldGhvZCB0byBwb3B1bGF0ZSBhIERhdGFUcmFuc2ZlciBiZWZvcmUgZGlzcGF0Y2hpbmcgYSAi
ZHJhZ3N0YXJ0IiBldmVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2Ny
aXB0cy9Db2RlR2VuZXJhdG9ySlMucG0gYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz
L0NvZGVHZW5lcmF0b3JKUy5wbQppbmRleCA3NWExNGEwMzQ1M2U1YmI3MGNhNjI0ZTBiMzNkMzcx
ODhjOTMzOGY5Li45ODBiOTI5YTEyYzBlZjM2NDE5ZjgxNWIwMDZjYmI1MzZiNzE0YjA4IDEwMDY0
NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w
bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5w
bQpAQCAtNzQ3NiwxMCArNzQ3NiwxMyBAQCBzdWIgR2VuZXJhdGVDb25zdHJ1Y3RvckRlZmluaXRp
b24KICAgICAgICAgICAgIHB1c2goQGNvbnN0cnVjdGlvbkNvbnZlcnNpb25Bcmd1bWVudHMsICJX
VEZNb3ZlKG9iamVjdCkiKTsKIAogICAgICAgICAgICAgIyBGSVhNRTogdG9KU05ld2x5Q3JlYXRl
ZCBzaG91bGQgcmV0dXJuIEpTT2JqZWN0KiBpbnN0ZWFkIG9mIEpTVmFsdWUuCisgICAgICAgICAg
ICAjIEJ1dCBjZXJ0YWluIGNvbnN0cnVjdG9yIGNhbiByZXR1cm4ganNOdWxsKCkgZS5nLiBBdWRp
b0NvbnRleHQuCiAgICAgICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIgICAgYXV0byBqc1Zh
bHVlID0gdG9KU05ld2x5Q3JlYXRlZDwke0lETFR5cGV9PigiIC4gam9pbigiLCAiLCBAY29uc3Ry
dWN0aW9uQ29udmVyc2lvbkFyZ3VtZW50cykgLiAiKTtcbiIpOwogICAgICAgICAgICAgcHVzaChA
JG91dHB1dEFycmF5LCAiICAgIFJFVFVSTl9JRl9FWENFUFRJT04odGhyb3dTY29wZSwgeyB9KTtc
biIpIGlmICRpbnRlcmZhY2UtPmV4dGVuZGVkQXR0cmlidXRlcy0+e0NvbnN0cnVjdG9yTWF5VGhy
b3dFeGNlcHRpb259OwotICAgICAgICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgIHNldFN1
YmNsYXNzU3RydWN0dXJlSWZOZWVkZWQ8JHtpbXBsVHlwZX0+KGxleGljYWxHbG9iYWxPYmplY3Qs
IGNhbGxGcmFtZSwgYXNPYmplY3QoanNWYWx1ZSkpO1xuIik7Ci0gICAgICAgICAgICBwdXNoKEAk
b3V0cHV0QXJyYXksICIgICAgUkVUVVJOX0lGX0VYQ0VQVElPTih0aHJvd1Njb3BlLCB7IH0pO1xu
Iik7CisgICAgICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXksICIgICAgaWYgKGF1dG8qIG9iamVj
dCA9IGpzRHluYW1pY0Nhc3Q8SlNPYmplY3QqPih2bSwganNWYWx1ZSkpIHtcbiIpOworICAgICAg
ICAgICAgcHVzaChAJG91dHB1dEFycmF5LCAiICAgICAgICBzZXRTdWJjbGFzc1N0cnVjdHVyZUlm
TmVlZGVkPCR7aW1wbFR5cGV9PihsZXhpY2FsR2xvYmFsT2JqZWN0LCBjYWxsRnJhbWUsIG9iamVj
dCk7XG4iKTsKKyAgICAgICAgICAgIHB1c2goQCRvdXRwdXRBcnJheSwgIiAgICAgICAgUkVUVVJO
X0lGX0VYQ0VQVElPTih0aHJvd1Njb3BlLCB7IH0pO1xuIik7CisgICAgICAgICAgICBwdXNoKEAk
b3V0cHV0QXJyYXksICIgICAgfVxuIik7CiAgICAgICAgICAgICBwdXNoKEAkb3V0cHV0QXJyYXks
ICIgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShqc1ZhbHVlKTtcbiIpOwogICAgICAgICAgICAg
cHVzaChAJG91dHB1dEFycmF5LCAifVxuXG4iKTsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5
b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDUyM2VhNTY1
OTlhMmRlZmJlMDAzYTMzZDNhODZjNWZkOGVkNWMyNGQuLmFlNTA5ZDVlYjBlYjYwYThlOGRkYjcw
MGY1NGQwMDllMTc3NzI3YTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg
Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wNi0wMiAgWXVz
dWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgorCisgICAgICAgIEFTU0VSVElPTiBGQUlM
RUQ6IGlzQ2VsbCgpIHVuZGVyIFdlYkNvcmU6OkpTRE9NQ29uc3RydWN0b3Igc2VlbiB3aXRoIHdl
YmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWF1ZGlvY29udGV4dC1pbnRlcmZhY2UvYXVkaW9jb250
ZXh0b3B0aW9ucy5odG1sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0yMTI2NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICAqIHBsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRm
b3JtL21hYy9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIwLTA2LTAyICBQZW5nIExpdSAgPHBlbmcu
bGl1NkBhcHBsZS5jb20+CiAKICAgICAgICAgTGF5b3V0IHRlc3QgZmFpbHVyZXM6IG1lZGlhL3Zp
ZGVvLWNyZWF0ZS13aXRoLXVzZXItZ2VzdHVyZS5odG1sIGFuZCBtZWRpYS92aWRlby1yZXN0cmlj
dGVkLW5vLXByZWxvYWQtYXV0by5odG1sCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9y
bS9pb3MvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhw
ZWN0YXRpb25zCmluZGV4IDM5Mzg2MzRkNmUyZjc1Y2I1MGU0NDJmOTU3MjM1ZWJkY2U3OWRiMDAu
LjYwOGJiNmY4Nzk5ZGQ0ZmZjOThkN2NhYWFhYzYwNmZhYTU2MDYyYTYgMTAwNjQ0Ci0tLSBhL0xh
eW91dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3Rz
L3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCkBAIC0zNTI5LDcgKzM1MjksNSBAQCB3ZWJr
aXQub3JnL2IvMjEyMjI3IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1n
cmlkL2FsaWdubWVudC9zZWxmLQogCiB3ZWJraXQub3JnL2IvMjEyNDkzIGltcG9ydGVkL3czYy93
ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2dyaWQtaXRlbXMvZ3JpZC1pdGVtcy1zaXpp
bmctYWxpZ25tZW50LTAwMS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcv
Yi8yMTI2NTAgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvd2ViYXVk
aW8vdGhlLWF1ZGlvLWFwaS90aGUtYXVkaW9jb250ZXh0LWludGVyZmFjZS9hdWRpb2NvbnRleHRv
cHRpb25zLmh0bWwgWyBTa2lwIF0KLQogIyBUaGlzIHRlc3QgcmVxdWlyZXMgYW4gdXBkYXRlIHRv
IHN5c3RlbSBkZWNvZGVycwogd2Via2l0Lm9yZy9iLzIxMjU2NSBpbXBvcnRlZC93M2Mvd2ViLXBs
YXRmb3JtLXRlc3RzL2VuY29kaW5nL3NpbmdsZS1ieXRlLWRlY29kZXIuaHRtbCBbIEZhaWx1cmUg
XQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1Rlc3RFeHBlY3RhdGlvbnMg
Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAxNmJlMzY3
MWFiMWU0NjIxOWJhNzBjMWZkZmFmYTkxZTM0M2E2YjcwLi40N2E3NmQ0MmJiMGZhODhiOTg5N2Zl
MmFlODUzNGFiNWFkODY4NTFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv
VGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvVGVzdEV4cGVj
dGF0aW9ucwpAQCAtMTk3MCw3ICsxOTcwLDUgQEAgd2Via2l0Lm9yZy9iLzIxMjQ4OCBbIENhdGFs
aW5hIF0gbWVkaWEvdmlkZW8tcGxheS1hdWRpby1yZXF1aXJlLXVzZXItZ2VzdHVyZS5odG0KIHdl
YmtpdC5vcmcvYi8yMTI1OTQgd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UvY2FudmFzL2J1ZmZlci1v
ZmZzY3JlZW4tdGVzdC5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjEyNTk0IHdlYmds
LzEuMC4zL2NvbmZvcm1hbmNlL2NhbnZhcy9idWZmZXItb2Zmc2NyZWVuLXRlc3QuaHRtbCBbIEZh
aWx1cmUgXQogCi13ZWJraXQub3JnL2IvMjEyNjUwIFsgRGVidWcgXSBpbXBvcnRlZC93M2Mvd2Vi
LXBsYXRmb3JtLXRlc3RzL3dlYmF1ZGlvL3RoZS1hdWRpby1hcGkvdGhlLWF1ZGlvY29udGV4dC1p
bnRlcmZhY2UvYXVkaW9jb250ZXh0b3B0aW9ucy5odG1sIFsgU2tpcCBdCi0KICMgVGhpcyB0ZXN0
IHJlcXVpcmVzIGFuIHVwZGF0ZSB0byBzeXN0ZW0gZGVjb2RlcnMKIHdlYmtpdC5vcmcvYi8yMTI1
NjUgWyBDYXRhbGluYSBNb2phdmUgXSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Vu
Y29kaW5nL3NpbmdsZS1ieXRlLWRlY29kZXIuaHRtbCBbIEZhaWx1cmUgXQo=
</data>
<flag name="review"
          id="416285"
          type_id="1"
          status="+"
          setter="mark.lam"
    />
    <flag name="commit-queue"
          id="416286"
          type_id="3"
          status="-"
          setter="mark.lam"
    />
          </attachment>
      

    </bug>

</bugzilla>