212633 2020-06-02 06:53:10 -0700 Fix broken Windows build. 2020-06-02 07:19:15 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam cdumez changseok dino esprehn+autocc ews-watchlist gyuyoung.kim webkit-bug-importer ysuzuki oldest_to_newest 1658274 0 mark.lam 2020-06-02 06:53:10 -0700 See https://ews-build.webkit.org/#/builders/10/builds/19884. 1658276 1 400815 mark.lam 2020-06-02 07:01:22 -0700 Created attachment 400815 speculative fix. 1658279 2 400815 ysuzuki 2020-06-02 07:11:02 -0700 Comment on attachment 400815 speculative fix. View in context: https://bugs.webkit.org/attachment.cgi?id=400815&action=review r=me > Source/WebCore/html/HTMLCanvasElement.cpp:1022 > Is needsPreparationForDisplay OK? It also includes WebGLRenderingContextBase 1658280 3 mark.lam 2020-06-02 07:13:14 -0700 (In reply to Yusuke Suzuki from comment #2) > Comment on attachment 400815 [details] > speculative fix. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400815&action=review > > r=me > > > Source/WebCore/html/HTMLCanvasElement.cpp:1022 > > > > Is needsPreparationForDisplay OK? It also includes WebGLRenderingContextBase Thanks for catching that. It's strange that the bot didn't complain about it. I'll add the WEBGL guard around it too. 1658282 4 mark.lam 2020-06-02 07:18:05 -0700 Landed in r262418: <http://trac.webkit.org/r262418>. 1658284 5 webkit-bug-importer 2020-06-02 07:19:15 -0700 <rdar://problem/63873861> 400815 2020-06-02 07:01:22 -0700 2020-06-02 07:11:02 -0700 speculative fix. bug-212633.patch text/plain 1202 mark.lam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI2MjQxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTA2LTAyICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggYnJva2VuIFdpbmRvd3MgYnVp bGQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI2 MzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0 bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENhbnZhc0Vs ZW1lbnQ6OnByZXBhcmVGb3JEaXNwbGF5KToKKwogMjAyMC0wNi0wMiAgWW91ZW5uIEZhYmxldCAg PHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHNvbWUgbG9nZ2luZyB0byBTZXJ2aWNl V29ya2VyVGhyZWFkIHRvIHRyYWNrIGluc3RhbGwvYWN0aXZhdGUgZXZlbnQgaGFuZGxpbmcKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCShyZXZpc2lvbiAy NjI0MDIpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMTAyMiwxMCArMTAyMiwxMiBAQCBib29sIEhUTUxDYW52YXNFbGVtZW50 OjpuZWVkc1ByZXBhcmF0aW9uCiAKIHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6OnByZXBhcmVGb3JE aXNwbGF5KCkKIHsKKyNpZiBFTkFCTEUoV0VCR0wpCiAgICAgQVNTRVJUKG5lZWRzUHJlcGFyYXRp b25Gb3JEaXNwbGF5KCkpOwogCiAgICAgaWYgKGlzPFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U+ KG1fY29udGV4dC5nZXQoKSkpCiAgICAgICAgIGRvd25jYXN0PFdlYkdMUmVuZGVyaW5nQ29udGV4 dEJhc2U+KG1fY29udGV4dC5nZXQoKSktPnByZXBhcmVGb3JEaXNwbGF5KCk7CisjZW5kaWYKIH0K IAogfQo=