212631 2020-06-02 01:59:14 -0700 UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors 2020-06-02 10:12:03 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca sam simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1658215 0 thorton 2020-06-02 01:59:14 -0700 UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors 1658216 1 400798 thorton 2020-06-02 01:59:36 -0700 Created attachment 400798 Patch 1658217 2 webkit-bug-importer 2020-06-02 01:59:58 -0700 <rdar://problem/63865676> 1658290 3 400798 andersca 2020-06-02 07:28:14 -0700 Comment on attachment 400798 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400798&action=review > Source/WebCore/platform/graphics/mac/ColorMac.mm:98 > + return Color(); Can probably just return { } here. > Source/WebCore/platform/graphics/mac/ColorMac.mm:108 > + return Color(); Same. > Source/WebCore/platform/ios/ColorIOS.mm:38 > + return Color(); Same. 1658355 4 thorton 2020-06-02 10:10:37 -0700 True! 1658356 5 thorton 2020-06-02 10:12:03 -0700 https://trac.webkit.org/changeset/262428/webkit 400798 2020-06-02 01:59:36 -0700 2020-06-02 07:28:14 -0700 Patch bug-212631-20200602015936.patch text/plain 2748 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmUxNWE3NWZhYmUxOTY3 Y2Y3ZTQ1ZjAwMGZjNjUxNzdhOGRmYTFlMi4uYzQxMWMxODk2MDIzNmM3MWY4ZWM2ZGQxNjE4ZGM1 Yzk4Y2I1ODIwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIwLTA2LTAyICBUaW0g SG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFVJQ29sb3IgYW5k IE5TQ29sb3IgV2ViQ29yZTo6Q29sb3IgZmFjdG9yaWVzIHNob3VsZCByZXR1cm4gaW52YWxpZCBj b2xvcnMgZm9yIG5pbCBpbnB1dCBjb2xvcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMjYzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbG9yTWFjLm1tOgor ICAgICAgICAoV2ViQ29yZTo6Y29sb3JGcm9tTlNDb2xvcik6CisgICAgICAgIChXZWJDb3JlOjpz ZW1hbnRpY0NvbG9yRnJvbU5TQ29sb3IpOgorICAgICAgICAqIHBsYXRmb3JtL2lvcy9Db2xvcklP Uy5tbToKKyAgICAgICAgKFdlYkNvcmU6OmNvbG9yRnJvbVVJQ29sb3IpOgorICAgICAgICBUaGlz IGRvZXNuJ3QgYWZmZWN0IGFueSBjb2RlIGN1cnJlbnRseSBpbiBXZWJLaXQsIGJ1dCBpdCBpcyB2 ZXJ5LCB2ZXJ5IHN1cnByaXNpbmcKKyAgICAgICAgdGhhdCB0aGVzZSBmdW5jdGlvbnMgaGFwcGls eSBhY2NlcHQgYSBudWxsIGNvbG9yLCBhc3NlcnQgaW4gZGVidWcsIGJ1dCBpbiByZWxlYXNlCisg ICAgICAgIGRvIGNyYXp5IHRoaW5ncyBsaWtlIHRyeSB0byBwYWludCB0aGUgbnVsbCBjb2xvciBp bnRvIGEgc21hbGwgYml0bWFwIHRvIGZpZ3VyZSBvdXQKKyAgICAgICAgd2hhdCBpdCByZWFsbHkg aXMuCisKKyAgICAgICAgQWxzbywgdGhpcyBtYXRjaGVzIHRoZSBiZWhhdmlvciBvZiB0aGUgQ29s b3IgY29uc3RydWN0b3JzIHRoYXQgdGFrZSBDR0NvbG9yUmVmLgorCiAyMDIwLTA1LTI5ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtFTUVdIG5hdmlnYXRvci5y ZXF1ZXN0TWVkaWFLZXlTeXN0ZW1BY2Nlc3MoKSBzaG91bGQgcmVqZWN0IFBVUiBzZXNzaW9uVHlw ZXMgaW4gcHJpdmF0ZSBicm93c2luZyBtb2RlLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0NvbG9yTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvbWFjL0NvbG9yTWFjLm1tCmluZGV4IDhhYmM0NjczN2M5YmZhZWI1OWRjZjMy NWE0MzZiYzJhNGYwYmFiYjguLjAxYjM0MGE5OTk2YTBmOTM3NWJmOWM0OGQwYTc0ZjNhZDk1NWYx ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9Db2xv ck1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvQ29sb3JN YWMubW0KQEAgLTk0LDYgKzk0LDkgQEAgc3RhdGljIFNpbXBsZUNvbG9yIG1ha2VTaW1wbGVDb2xv ckZyb21OU0NvbG9yKE5TQ29sb3IgKmNvbG9yKQogCiBDb2xvciBjb2xvckZyb21OU0NvbG9yKE5T Q29sb3IgKmNvbG9yKQogeworICAgIGlmICghY29sb3IpCisgICAgICAgIHJldHVybiBDb2xvcigp OworCiAgICAgLy8gRklYTUU6IEV4dGVuZGVkQ29sb3IgLSBuZWVkcyB0byBoYW5kbGUgY29sb3Ig c3BhY2VzLgogCiAgICAgcmV0dXJuIENvbG9yKG1ha2VTaW1wbGVDb2xvckZyb21OU0NvbG9yKGNv bG9yKSk7CkBAIC0xMDEsNiArMTA0LDkgQEAgQ29sb3IgY29sb3JGcm9tTlNDb2xvcihOU0NvbG9y ICpjb2xvcikKIAogQ29sb3Igc2VtYW50aWNDb2xvckZyb21OU0NvbG9yKE5TQ29sb3IgKmNvbG9y KQogeworICAgIGlmICghY29sb3IpCisgICAgICAgIHJldHVybiBDb2xvcigpOworCiAgICAgLy8g RklYTUU6IEV4dGVuZGVkQ29sb3IgLSBuZWVkcyB0byBoYW5kbGUgY29sb3Igc3BhY2VzLgogCiAg ICAgcmV0dXJuIENvbG9yKG1ha2VTaW1wbGVDb2xvckZyb21OU0NvbG9yKGNvbG9yKSwgQ29sb3I6 OlNlbWFudGljKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9Db2xv cklPUy5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9Db2xvcklPUy5tbQppbmRleCA0 YThjY2M3NTZmZGFiYmE4MTg4ZGNmMTA5MjRmZGRhNGI0ZDhhZTI1Li4wNjFmN2M3MTFiYjEzMjYz NmFkZTY1MmJmZWQxMDllOTE2ZWExMjgwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvQ29sb3JJT1MubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL0Nv bG9ySU9TLm1tCkBAIC0zNCw2ICszNCw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogQ29sb3Ig Y29sb3JGcm9tVUlDb2xvcihVSUNvbG9yICpjb2xvcikKIHsKKyAgICBpZiAoIWNvbG9yKQorICAg ICAgICByZXR1cm4gQ29sb3IoKTsKKwogICAgIC8vIEZJWE1FOiBFeHRlbmRlZENvbG9yIC0gbmVl ZHMgdG8gaGFuZGxlIGNvbG9yIHNwYWNlcy4KIAogICAgIC8vIEZJWE1FOiBNYWtlIHRoaXMgd29y ayBmb3IgYSBVSUNvbG9yIHRoYXQgd2FzIGNyZWF0ZWQgZnJvbSBhIHBhdHRlcm4gb3IgYSBEaXNw YXlQMyBjb2xvci4K