212622 2020-06-01 18:30:19 -0700 REGRESSION(r217572): run-webkit-tests should abort if the TCP ports for the servers are already in use. 2020-07-24 09:58:05 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=182360 https://bugs.webkit.org/show_bug.cgi?id=172176 P2 Normal --- 1 clopez clopez ap cgarcia dbates ews-watchlist glenn gsnedders jbedard jonlee lforschler simon.fraser slewis youennf oldest_to_newest 1658148 0 clopez 2020-06-01 18:30:19 -0700 It seems run-webkit-tests not longer (since r217572) aborts if there is any other process (for example, from other user) already listening on the TCP port the http/websocket/wpt helper servers needs. If the TCP port is already listening it simply assumes those servers are already running (perhaps from a previous run-webkit-test iteration). This can cause hard-to-diagnose problems, for example if the user is running other service than the webkit-test servers on this ports. I think it should abort if it can't start itself the server on the designed TCP port. 1658151 1 400776 clopez 2020-06-01 18:46:00 -0700 Created attachment 400776 Patch 1658410 2 400776 jbedard 2020-06-02 12:04:37 -0700 Comment on attachment 400776 Patch I'm not against this, but I'm curious what people who make more use of these servers than myself things. Does Youenn have an opinion? 1658640 3 youennf 2020-06-03 00:20:31 -0700 I sometimes have the HTTP servers up and running so that I can debug in a browser. I find it useful that WTR can run in parallel. But I can see why this could cause issues. @Carlos, can you detail a bit the problems you encountered? 1658680 4 jbedard 2020-06-03 07:07:33 -0700 Another possibility is that we save a sort of status file (much like Postgres does) so we can keep track of our own web servers, but not generic ones running on the same ports. 1658693 5 clopez 2020-06-03 08:12:51 -0700 (In reply to youenn fablet from comment #3) > @Carlos, can you detail a bit the problems you encountered? We have some shared remote servers for building, developing and testing and I found random timeouts and failures when running WebKit layout tests on them. Investigating the issue, I found that it was because I was running the layout tests at the same time than other mate. Previously if this situation happened, run-webkit-tests aborted with a loud warning (so it was easy to spot the issue). 1658752 6 youennf 2020-06-03 09:51:40 -0700 (In reply to Carlos Alberto Lopez Perez from comment #5) > (In reply to youenn fablet from comment #3) > > @Carlos, can you detail a bit the problems you encountered? > > We have some shared remote servers for building, developing and testing and > I found random timeouts and failures when running WebKit layout tests on > them. Investigating the issue, I found that it was because I was running the > layout tests at the same time than other mate. > Previously if this situation happened, run-webkit-tests aborted with a loud > warning (so it was easy to spot the issue). I see, so multiple checkouts but a single server actually running. Would a console message warning stating that servers are already running be sufficient? 1658765 7 clopez 2020-06-03 10:16:34 -0700 (In reply to youenn fablet from comment #6) > (In reply to Carlos Alberto Lopez Perez from comment #5) > > (In reply to youenn fablet from comment #3) > > > @Carlos, can you detail a bit the problems you encountered? > > > > We have some shared remote servers for building, developing and testing and > > I found random timeouts and failures when running WebKit layout tests on > > them. Investigating the issue, I found that it was because I was running the > > layout tests at the same time than other mate. > > Previously if this situation happened, run-webkit-tests aborted with a loud > > warning (so it was easy to spot the issue). > > I see, so multiple checkouts but a single server actually running. > Would a console message warning stating that servers are already running be > sufficient? Yes, I guess it will be sufficient. 400776 2020-06-01 18:46:00 -0700 2020-06-01 18:46:00 -0700 Patch bug-212622-20200602034559.patch text/plain 2857 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyNDA0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTI0NzUxMjY0YjA2M2U1NTE2MWY4MmExMDBlN2YwZTlj OTkyZjI4NC4uZmZlNTFkZWJhNWU4YjZjNzc2NDlmMjliNDBjZWQ0OGYzOWFiNjU3OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIwLTA2LTAxICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIxNzU3Mik6IHJ1bi13ZWJraXQtdGVzdHMg c2hvdWxkIGFib3J0IGlmIHRoZSBUQ1AgcG9ydHMgZm9yIHRoZSBzZXJ2ZXJzIGFyZSBhbHJlYWR5 IGluIHVzZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMjYyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IElmIHdlIGhhdmVuJ3Qgc3RhcnRlZCB0aGUgc2VydmVycyB0aGVuIGVuc3VyZSB0aGF0IHdlIGRv IGl0IChhcyBjdXJyZW50bHkKKyAgICAgICAgd2Ugd2VyZSBza2lwcGluZyBzdGFydGluZyB0aGVt IGlmIHRoZSBUQ1AgcG9ydCB3YXMgYWxyZWFkeSBsaXN0ZW5pbmcpLgorICAgICAgICBUaGUgc3Rh cnQoKSBtZXRob2Qgb2YgdGhlIHNlcnZlciB3aWxsIGNoZWNrIGlmIHRoZSBUQ1AgcG9ydCBpcyBm cmVlLAorICAgICAgICBhbmQgYWJvcnQgaWYgaXQgaXMgaW4gdXNlIGJlZm9yZSBzdGFydGluZyB0 aGUgc2VydmVyIChpdCBkb2VzIHRoYXQgYnkKKyAgICAgICAgY2FsbGluZyBIdHRwU2VydmVyQmFz ZS5fY2hlY2tfdGhhdF9hbGxfcG9ydHNfYXJlX2F2YWlsYWJsZSgpKQorCisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbGF5b3V0X3Rlc3RfcnVubmVy LnB5OgorICAgICAgICAoTGF5b3V0VGVzdFJ1bm5lci5zdGFydF9zZXJ2ZXJzKToKKwogMjAyMC0w Ni0wMSAgU2lodWkgTGl1ICA8c2lodWlfbGl1QGFwcGxlLmNvbT4KIAogICAgICAgICBUZXh0TWFu aXB1bGF0aW9uQ29udHJvbGxlciBzaG91bGQgcHV0IG9uZSBOb2RlIGluIG9ubHkgb25lIHBhcmFn cmFwaApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29u dHJvbGxlcnMvbGF5b3V0X3Rlc3RfcnVubmVyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbGF5b3V0X3Rlc3RfcnVubmVyLnB5CmluZGV4IDFmZTYw YjhjMGQxY2VmNWU0MWZiYWU5ODRjM2Q2MzAyZjZiNTk3MjcuLmJkNTdlMzkxYzQxOWU4MWZkMTlj NjcyZDUyMjIwYTNhOTdjMWE5ODEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL2xheW91dF90ZXN0X3J1bm5lci5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9sYXlvdXRfdGVzdF9y dW5uZXIucHkKQEAgLTIxMSwxNSArMjExLDE1IEBAIGNsYXNzIExheW91dFRlc3RSdW5uZXIob2Jq ZWN0KToKICAgICAgICAgICAgICAgICBydW5fcmVzdWx0cy5jaGFuZ2VfcmVzdWx0X3RvX2ZhaWx1 cmUoZXhpc3RpbmdfcmVzdWx0LCBuZXdfcmVzdWx0LCB3YXNfZXhwZWN0ZWQsIG5vd19leHBlY3Rl ZCkKIAogICAgIGRlZiBzdGFydF9zZXJ2ZXJzKHNlbGYpOgotICAgICAgICBpZiBzZWxmLl9uZWVk c19odHRwIGFuZCBub3Qgc2VsZi5fZGlkX3N0YXJ0X2h0dHBfc2VydmVyIGFuZCBub3Qgc2VsZi5f cG9ydC5pc19odHRwX3NlcnZlcl9ydW5uaW5nKCk6CisgICAgICAgIGlmIHNlbGYuX25lZWRzX2h0 dHAgYW5kIG5vdCBzZWxmLl9kaWRfc3RhcnRfaHR0cF9zZXJ2ZXI6CiAgICAgICAgICAgICBzZWxm Ll9wcmludGVyLndyaXRlX3VwZGF0ZSgnU3RhcnRpbmcgSFRUUCBzZXJ2ZXIgLi4uJykKICAgICAg ICAgICAgIHNlbGYuX3BvcnQuc3RhcnRfaHR0cF9zZXJ2ZXIoKQogICAgICAgICAgICAgc2VsZi5f ZGlkX3N0YXJ0X2h0dHBfc2VydmVyID0gVHJ1ZQotICAgICAgICBpZiBzZWxmLl9uZWVkc193ZWJz b2NrZXRzIGFuZCBub3Qgc2VsZi5fZGlkX3N0YXJ0X3dlYnNvY2tldF9zZXJ2ZXIgYW5kIG5vdCBz ZWxmLl9wb3J0LmlzX3dlYnNvY2tldF9zZXJ2ZXJfcnVubmluZygpOgorICAgICAgICBpZiBzZWxm Ll9uZWVkc193ZWJzb2NrZXRzIGFuZCBub3Qgc2VsZi5fZGlkX3N0YXJ0X3dlYnNvY2tldF9zZXJ2 ZXI6CiAgICAgICAgICAgICBzZWxmLl9wcmludGVyLndyaXRlX3VwZGF0ZSgnU3RhcnRpbmcgV2Vi U29ja2V0IHNlcnZlciAuLi4nKQogICAgICAgICAgICAgc2VsZi5fcG9ydC5zdGFydF93ZWJzb2Nr ZXRfc2VydmVyKCkKICAgICAgICAgICAgIHNlbGYuX2RpZF9zdGFydF93ZWJzb2NrZXRfc2VydmVy ID0gVHJ1ZQotICAgICAgICBpZiBzZWxmLl9uZWVkc193ZWJfcGxhdGZvcm1fdGVzdF9zZXJ2ZXIg YW5kIG5vdCBzZWxmLl9kaWRfc3RhcnRfd3B0X3NlcnZlciBhbmQgbm90IHNlbGYuX3BvcnQuaXNf d3B0X3NlcnZlcl9ydW5uaW5nKCk6CisgICAgICAgIGlmIHNlbGYuX25lZWRzX3dlYl9wbGF0Zm9y bV90ZXN0X3NlcnZlciBhbmQgbm90IHNlbGYuX2RpZF9zdGFydF93cHRfc2VydmVyOgogICAgICAg ICAgICAgc2VsZi5fcHJpbnRlci53cml0ZV91cGRhdGUoJ1N0YXJ0aW5nIFdlYiBQbGF0Zm9ybSBU ZXN0IHNlcnZlciAuLi4nKQogICAgICAgICAgICAgc2VsZi5fcG9ydC5zdGFydF93ZWJfcGxhdGZv cm1fdGVzdF9zZXJ2ZXIoKQogICAgICAgICAgICAgc2VsZi5fZGlkX3N0YXJ0X3dwdF9zZXJ2ZXIg PSBUcnVlCg==