212621 2020-06-01 17:26:43 -0700 MultiDeleteByOffset should not always def 2020-06-02 09:55:20 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ross.kirsling ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1658123 0 saam 2020-06-01 17:26:43 -0700 Because it doesn't actually always def, it depends on its cases 1658124 1 saam 2020-06-01 17:27:02 -0700 <rdar://problem/63824182> 1658126 2 400774 saam 2020-06-01 17:36:13 -0700 Created attachment 400774 patch 1658127 3 400774 saam 2020-06-01 17:36:47 -0700 Comment on attachment 400774 patch View in context: https://bugs.webkit.org/attachment.cgi?id=400774&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:-8474 > - if (variant.newStructure()) { this is a refactoring, since above, we have the code: if (!variant.newStructure()) continue; 1658338 4 400774 ysuzuki 2020-06-02 09:27:53 -0700 Comment on attachment 400774 patch r=me 1658345 5 ews-feeder 2020-06-02 09:55:19 -0700 Committed r262425: <https://trac.webkit.org/changeset/262425> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400774. 400774 2020-06-01 17:36:13 -0700 2020-06-02 09:55:19 -0700 patch b-backup.diff text/plain 7131 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNjI0MDApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE3IEBACisyMDIwLTA2LTAxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIE11bHRpRGVsZXRlQnlPZmZzZXQgc2hvdWxkIG5vdCBhbHdheXMgZGVm CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI2MjEK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzYzODI0MTgyPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL211bHRpLWRlbC1ieS1vZmZzZXQt ZG9lc250LWFsd2F5cy1kZWYtb3NyLWVudHJ5LmpzOiBBZGRlZC4KKyAgICAgICAgKGZvbyk6Cisg ICAgICAgICogc3RyZXNzL211bHRpLWRlbC1ieS1vZmZzZXQtZG9lc250LWFsd2F5cy1kZWYuanM6 IEFkZGVkLgorICAgICAgICAoZm9vKToKKyAgICAgICAgKGxldC5wLnNldCB1bmRlZmluZWQpOgor CiAyMDIwLTA2LTAxICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAg ICAgW0pTQ10gSlNCaWdJbnQ6OnJpZ2h0VHJpbSBjYW4gbWlzcyB8dGhpc3wgcG9pbnRlciBhbmQg bGVhZHMgdG8gaW5jb3JyZWN0IEdDIGNvbGxlY3Rpb24KSW5kZXg6IEpTVGVzdHMvc3RyZXNzL211 bHRpLWRlbC1ieS1vZmZzZXQtZG9lc250LWFsd2F5cy1kZWYtb3NyLWVudHJ5LmpzCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIEpTVGVzdHMvc3RyZXNzL211bHRpLWRlbC1ieS1vZmZzZXQtZG9lc250LWFsd2F5cy1k ZWYtb3NyLWVudHJ5LmpzCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvc3RyZXNzL211bHRpLWRl bC1ieS1vZmZzZXQtZG9lc250LWFsd2F5cy1kZWYtb3NyLWVudHJ5LmpzCSh3b3JraW5nIGNvcHkp CkBAIC0wLDAgKzEsMTMgQEAKK2xldCBwID0geyBnZXQ6IHVuZGVmaW5lZCwgc2V0OiB1bmRlZmlu ZWQsIH07CisKK2Z1bmN0aW9uIGZvbygpIHsKKyAgICBsZXQgbyA9IHt9OworICAgIGZvciAobGV0 IGkgPSAwOyBpIDwgMTAwOyBpKyspIHsKKyAgICAgICAgZm9yIChsZXQgaiA9IDA7IGogPCA1OyBq KyspCisgICAgICAgICAgICBkZWxldGUgby54OworICAgICAgICBvLng7CisgICAgICAgIE9iamVj dC5kZWZpbmVQcm9wZXJ0eShvLCAneCcsIHApOworICAgIH0KK30KKworZm9vKCkKSW5kZXg6IEpT VGVzdHMvc3RyZXNzL211bHRpLWRlbC1ieS1vZmZzZXQtZG9lc250LWFsd2F5cy1kZWYuanMKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gSlNUZXN0cy9zdHJlc3MvbXVsdGktZGVsLWJ5LW9mZnNldC1kb2VzbnQtYWx3 YXlzLWRlZi5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9tdWx0aS1kZWwtYnkt b2Zmc2V0LWRvZXNudC1hbHdheXMtZGVmLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTQg QEAKK2xldCBwID0geyBnZXQ6IHVuZGVmaW5lZCwgc2V0OiB1bmRlZmluZWQsIH07CitsZXQgbzEg PSB7fTsKK09iamVjdC5kZWZpbmVQcm9wZXJ0eShvMSwgJ3gnLCBwKTsKKworZnVuY3Rpb24gZm9v KG8pIHsKKyAgICBpZiAoIShkZWxldGUgby54KSkKKyAgICAgICAgby54OworfQorbm9JbmxpbmUo Zm9vKTsKKworZm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDsgKytpKSB7CisgICAgZm9vKG8xKTsK KyAgICBmb28oe3ggOiA0Mn0pOworfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZp c2lvbiAyNjI0MDApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjAtMDYtMDEgIFNhYW0gQmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CisKKyAgICAgICAgTXVsdGlEZWxldGVCeU9mZnNldCBzaG91bGQgbm90IGFs d2F5cyBkZWYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMjYyMQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNjM4MjQxODI+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xvYmJlcml6ZSB1c2VkIHRvIGNs YWltIHRoYXQgTXVsdGlEZWxldGVCeU9mZnNldCBhbHdheXMgZGVmZCBhIHZhbHVlLgorICAgICAg ICBUaGF0J3MgYW4gaW5jb3JyZWN0IG1vZGVsaW5nIG9mIE11bHRpRGVsZXRlQnlPZmZzZXQgdGhv dWdoLCBzaW5jZSBpdCBtaWdodAorICAgICAgICBoYXZlIGRlbGV0ZSBtaXNzZXMgaW4gaXRzIHZh cmlhbnQgbGlzdC4gVGhpcyB3b3VsZCBsZWFkIHVzIHRvIGluY29ycmVjdGx5CisgICAgICAgIENT RSB3aGVuIHdlIHNob3VsZG4ndC4gVGhpcyBwYXRjaCBmaXhlcyB0aGlzIGJ5IHNheWluZyBNdWx0 aURlbGV0ZUJ5T2Zmc2V0CisgICAgICAgIG9ubHkgZGVmcyB3aGVuIGFsbCBpdHMgY2FzZXMgd3Jp dGUgb3V0IGEgdmFsdWUgKGFyZSBoaXRzKS4KKworICAgICAgICAqIGRmZy9ERkdDbG9iYmVyaXpl Lmg6CisgICAgICAgIChKU0M6OkRGRzo6Y2xvYmJlcml6ZSk6CisgICAgICAgICogZGZnL0RGR05v ZGUuY3BwOgorICAgICAgICAoSlNDOjpERkc6Ok11bHRpRGVsZXRlQnlPZmZzZXREYXRhOjphbGxW YXJpYW50c1N0b3JlRW1wdHkgY29uc3QpOgorICAgICAgICAqIGRmZy9ERkdOb2RlLmg6CisgICAg ICAgICogZnRsL0ZUTExvd2VyREZHVG9CMy5jcHA6CisgICAgICAgIChKU0M6OkZUTDo6REZHOjpM b3dlckRGR1RvQjM6OmNvbXBpbGVNdWx0aURlbGV0ZUJ5T2Zmc2V0KToKKwogMjAyMC0wNi0wMSAg WXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IGZpeCBidWlsZCBmYWlsdXJlIGluIEFSTXY3awpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdDbG9iYmVyaXplLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3Jl L2RmZy9ERkdDbG9iYmVyaXplLmgJKHJldmlzaW9uIDI2MjM5NykKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZmcvREZHQ2xvYmJlcml6ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xMzM4LDcgKzEz MzgsOCBAQCB2b2lkIGNsb2JiZXJpemUoR3JhcGgmIGdyYXBoLCBOb2RlKiBub2RlCiAgICAgICAg ICAgICAvLyBhbGlhcyBhbmFseXNpcy4KICAgICAgICAgICAgIHdyaXRlKE5hbWVkUHJvcGVydGll cyk7CiAgICAgICAgIH0KLSAgICAgICAgZGVmKEhlYXBMb2NhdGlvbihOYW1lZFByb3BlcnR5TG9j LCBoZWFwLCBub2RlLT5jaGlsZDEoKSksIExhenlOb2RlKGdyYXBoLmZyZWV6ZVN0cm9uZyhKU1Zh bHVlKCkpKSk7CisgICAgICAgIGlmIChub2RlLT5tdWx0aURlbGV0ZUJ5T2Zmc2V0RGF0YSgpLmFs bFZhcmlhbnRzU3RvcmVFbXB0eSgpKQorICAgICAgICAgICAgZGVmKEhlYXBMb2NhdGlvbihOYW1l ZFByb3BlcnR5TG9jLCBoZWFwLCBub2RlLT5jaGlsZDEoKSksIExhenlOb2RlKGdyYXBoLmZyZWV6 ZVN0cm9uZyhKU1ZhbHVlKCkpKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgICAgIApJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2RlLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUuY3BwCShyZXZpc2lvbiAyNjIzOTcp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR05vZGUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC02Niw2ICs2NiwxNSBAQCBib29sIE11bHRpRGVsZXRlQnlPZmZzZXREYXRhOjp3cml0ZXNT dHJ1CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitib29sIE11bHRpRGVsZXRlQnlPZmZzZXREYXRh OjphbGxWYXJpYW50c1N0b3JlRW1wdHkoKSBjb25zdAoreworICAgIGZvciAodW5zaWduZWQgaSA9 IHZhcmlhbnRzLnNpemUoKTsgaS0tOykgeworICAgICAgICBpZiAoIXZhcmlhbnRzW2ldLm5ld1N0 cnVjdHVyZSgpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIH0KKyAgICByZXR1cm4g dHJ1ZTsKK30KKwogdm9pZCBCcmFuY2hUYXJnZXQ6OmR1bXAoUHJpbnRTdHJlYW0mIG91dCkgY29u c3QKIHsKICAgICBpZiAoIWJsb2NrKQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9E RkdOb2RlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdOb2Rl LmgJKHJldmlzaW9uIDI2MjM5NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHTm9k ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC05OCw2ICs5OCw3IEBAIHN0cnVjdCBNdWx0aURlbGV0ZUJ5 T2Zmc2V0RGF0YSB7CiAgICAgVmVjdG9yPERlbGV0ZUJ5SWRWYXJpYW50LCAyPiB2YXJpYW50czsK IAogICAgIGJvb2wgd3JpdGVzU3RydWN0dXJlcygpIGNvbnN0OworICAgIGJvb2wgYWxsVmFyaWFu dHNTdG9yZUVtcHR5KCkgY29uc3Q7CiB9OwogCiBzdHJ1Y3QgTWF0Y2hTdHJ1Y3R1cmVWYXJpYW50 IHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93ZXJERkdUb0IzLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZnRsL0ZUTExvd2VyREZHVG9CMy5j cHAJKHJldmlzaW9uIDI2MjM5NykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9mdGwvRlRMTG93 ZXJERkdUb0IzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODQ3MSwyMiArODQ3MSwyMCBAQCBwcml2 YXRlOgogCiAgICAgICAgICAgICBtX291dC5hcHBlbmRUbyhibG9ja3NbYmxvY2tdLCBibG9jayAr IDEgPCBibG9ja3Muc2l6ZSgpID8gYmxvY2tzW2Jsb2NrICsgMV0gOiBleGl0KTsKIAotICAgICAg ICAgICAgaWYgKHZhcmlhbnQubmV3U3RydWN0dXJlKCkpIHsKLSAgICAgICAgICAgICAgICBMVmFs dWUgc3RvcmFnZTsKKyAgICAgICAgICAgIExWYWx1ZSBzdG9yYWdlOwogCi0gICAgICAgICAgICAg ICAgaWYgKGlzSW5saW5lT2Zmc2V0KHZhcmlhbnQub2Zmc2V0KCkpKQotICAgICAgICAgICAgICAg ICAgICBzdG9yYWdlID0gYmFzZTsKLSAgICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAg ICAgICAgIHN0b3JhZ2UgPSBtX291dC5sb2FkUHRyKGJhc2UsIG1faGVhcHMuSlNPYmplY3RfYnV0 dGVyZmx5KTsKKyAgICAgICAgICAgIGlmIChpc0lubGluZU9mZnNldCh2YXJpYW50Lm9mZnNldCgp KSkKKyAgICAgICAgICAgICAgICBzdG9yYWdlID0gYmFzZTsKKyAgICAgICAgICAgIGVsc2UKKyAg ICAgICAgICAgICAgICBzdG9yYWdlID0gbV9vdXQubG9hZFB0cihiYXNlLCBtX2hlYXBzLkpTT2Jq ZWN0X2J1dHRlcmZseSk7CiAKLSAgICAgICAgICAgICAgICBzdG9yZVByb3BlcnR5KG1fb3V0Lmlu dDY0WmVybywgc3RvcmFnZSwgZGF0YS5pZGVudGlmaWVyTnVtYmVyLCB2YXJpYW50Lm9mZnNldCgp KTsKKyAgICAgICAgICAgIHN0b3JlUHJvcGVydHkobV9vdXQuaW50NjRaZXJvLCBzdG9yYWdlLCBk YXRhLmlkZW50aWZpZXJOdW1iZXIsIHZhcmlhbnQub2Zmc2V0KCkpOwogCi0gICAgICAgICAgICAg ICAgQVNTRVJUKHZhcmlhbnQub2xkU3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgpID09IHZhcmlh bnQubmV3U3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgpKTsKLSAgICAgICAgICAgICAgICBBU1NF UlQodmFyaWFudC5vbGRTdHJ1Y3R1cmUoKS0+dHlwZUluZm8oKS5pbmxpbmVUeXBlRmxhZ3MoKSA9 PSB2YXJpYW50Lm5ld1N0cnVjdHVyZSgpLT50eXBlSW5mbygpLmlubGluZVR5cGVGbGFncygpKTsK LSAgICAgICAgICAgICAgICBBU1NFUlQodmFyaWFudC5vbGRTdHJ1Y3R1cmUoKS0+dHlwZUluZm8o KS50eXBlKCkgPT0gdmFyaWFudC5uZXdTdHJ1Y3R1cmUoKS0+dHlwZUluZm8oKS50eXBlKCkpOwot ICAgICAgICAgICAgICAgIG1fb3V0LnN0b3JlMzIoCi0gICAgICAgICAgICAgICAgICAgIHdlYWtT dHJ1Y3R1cmVJRChtX2dyYXBoLnJlZ2lzdGVyU3RydWN0dXJlKHZhcmlhbnQubmV3U3RydWN0dXJl KCkpKSwgYmFzZSwgbV9oZWFwcy5KU0NlbGxfc3RydWN0dXJlSUQpOwotICAgICAgICAgICAgfQor ICAgICAgICAgICAgQVNTRVJUKHZhcmlhbnQub2xkU3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgp ID09IHZhcmlhbnQubmV3U3RydWN0dXJlKCktPmluZGV4aW5nVHlwZSgpKTsKKyAgICAgICAgICAg IEFTU0VSVCh2YXJpYW50Lm9sZFN0cnVjdHVyZSgpLT50eXBlSW5mbygpLmlubGluZVR5cGVGbGFn cygpID09IHZhcmlhbnQubmV3U3RydWN0dXJlKCktPnR5cGVJbmZvKCkuaW5saW5lVHlwZUZsYWdz KCkpOworICAgICAgICAgICAgQVNTRVJUKHZhcmlhbnQub2xkU3RydWN0dXJlKCktPnR5cGVJbmZv KCkudHlwZSgpID09IHZhcmlhbnQubmV3U3RydWN0dXJlKCktPnR5cGVJbmZvKCkudHlwZSgpKTsK KyAgICAgICAgICAgIG1fb3V0LnN0b3JlMzIoCisgICAgICAgICAgICAgICAgd2Vha1N0cnVjdHVy ZUlEKG1fZ3JhcGgucmVnaXN0ZXJTdHJ1Y3R1cmUodmFyaWFudC5uZXdTdHJ1Y3R1cmUoKSkpLCBi YXNlLCBtX2hlYXBzLkpTQ2VsbF9zdHJ1Y3R1cmVJRCk7CiAKICAgICAgICAgICAgIHJlc3VsdHMu YXBwZW5kKG1fb3V0LmFuY2hvcih2YXJpYW50LnJlc3VsdCgpID8gbV9vdXQuYm9vbGVhblRydWUg OiBtX291dC5ib29sZWFuRmFsc2UpKTsKICAgICAgICAgICAgIG1fb3V0Lmp1bXAoY29udGludWF0 aW9uKTsK