212616 2020-06-01 15:07:52 -0700 Correct misunderstandings on how ThreadSpecific work 2020-06-01 17:52:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov guijemont keith_miller mark.lam msaboff rmorisset ross.kirsling ticaiolima tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1658083 0 saam 2020-06-01 15:07:52 -0700 We have some redundant code in JSC 1658087 1 400764 saam 2020-06-01 15:17:52 -0700 Created attachment 400764 patch 1658091 2 400764 msaboff 2020-06-01 15:25:17 -0700 Comment on attachment 400764 patch r=me. Thanks. 1658138 3 ews-feeder 2020-06-01 17:51:57 -0700 Committed r262402: <https://trac.webkit.org/changeset/262402> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400764. 1658139 4 webkit-bug-importer 2020-06-01 17:52:14 -0700 <rdar://problem/63851905> 400764 2020-06-01 15:17:52 -0700 2020-06-01 17:51:58 -0700 patch b-backup.diff text/plain 7588 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYyMzk1KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDQwIEBA CisyMDIwLTA2LTAxICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IENvcnJlY3QgbWlzdW5kZXJzdGFuZGluZ3Mgb24gaG93IFRocmVhZFNwZWNpZmljIHdvcmsKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjYxNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZXJlIHdlcmUg dHdvIG1pc3VuZGVyc3RhbmRpbmdzIEkgaGFkIHdoZW4gd3JpdGluZyBjb2RlIHVzaW5nIFRocmVh ZFNwZWNpZmljCisgICAgICAgIHdoZW4gZG9pbmcgTExJbnQgYnl0ZWNvZGUgYnVmZmVyIGNhY2hp bmcgaW4gV2FzbS4KKyAgICAgICAgCisgICAgICAgIDEuIEZvciBUaHJlYWRTcGVjaWZpYzxWZWN0 b3I+LCBJIHdhcyBjYWxsaW5nIFZlY3RvcidzIGNvbnN0cnVjdG9yIHR3aWNlCisgICAgICAgIHVu bmVjZXNzYXJpbHksIGFuZCBpbmNvcnJlY3RseSwgc2luY2Ugd2UgZW5kZWQgdXAgY29uc3RydWN0 aW5nIG92ZXIgYW4KKyAgICAgICAgYWxyZWFkeSBjb25zdHJ1Y3RlZCBWZWN0b3IgZm9yIHRoZSBz ZWNvbmQgY2FsbC4gV2hlbiBkb2luZyBvcGVyYXRvciogb3IKKyAgICAgICAgb3BlcmF0b3ItPiBv biBhIFRocmVhZFNwZWNpZmljPFQ+LCBUKCkgaXMgY2FsbGVkIGlmIGl0IGhhcyBub3QgYmVlbgor ICAgICAgICBpbml0aWFsaXplZCB5ZXQuIFNvIHRoZXJlIGlzIG5vIG5lZWQgdG8gZG8gbWFudWFs bHkgY2FsbCB0aGUgY29uc3RydWN0b3IKKyAgICAgICAgdGhlIHNlY29uZCB0aW1lLgorICAgICAg ICAKKyAgICAgICAgMi4gVGhlcmUgaXMgbm8gbmVlZCB0byB0cnkgdG8gZGVzdHJveSBlbnRyaWVz IGZvciBUaHJlYWRTcGVjaWZpYyBtYW51YWxseQorICAgICAgICBzaW5jZSB3ZSBhbHJlYWR5IHJ1 biBkZXN0cnVjdG9ycyB3aGVuIHRoZSB0aHJlYWQgZ29lcyBhd2F5LgorICAgICAgICAKKyAgICAg ICAgVGhpcyBwYXRjaCByZW1vdmVzIGNvZGUgZm9yICgxKSBhbmQgKDIpIGJvdGggZnJvbSB0aGUg V2FzbSBieXRlY29kZQorICAgICAgICBidWZmZXIgYW5kIGZyb20gQXNzZW1ibGVyRGF0YS4KKwor ICAgICAgICAqIGFzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXIuY3BwOgorICAgICAgICAoSlNDOjpj bGVhckFzc2VtYmxlRGF0YVRocmVhZFNwZWNpZmljQ2FjaGUpOiBEZWxldGVkLgorICAgICAgICAq IGFzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXIuaDoKKyAgICAgICAgKEpTQzo6QXNzZW1ibGVyQnVm ZmVyOjpBc3NlbWJsZXJCdWZmZXIpOgorICAgICAgICAoSlNDOjpBc3NlbWJsZXJCdWZmZXI6On5B c3NlbWJsZXJCdWZmZXIpOgorICAgICAgICAoSlNDOjpBc3NlbWJsZXJCdWZmZXI6OmdldFRocmVh ZFNwZWNpZmljQXNzZW1ibGVyRGF0YSk6IERlbGV0ZWQuCisgICAgICAgICogZGZnL0RGR1dvcmts aXN0LmNwcDoKKyAgICAgICAgKiBqaXQvSklUV29ya2xpc3QuY3BwOgorICAgICAgICAqIHdhc20v V2FzbUxMSW50R2VuZXJhdG9yLmNwcDoKKyAgICAgICAgKEpTQzo6V2FzbTo6TExJbnRHZW5lcmF0 b3I6OkxMSW50R2VuZXJhdG9yKToKKyAgICAgICAgKEpTQzo6V2FzbTo6Y2xlYXJMTEludFRocmVh ZFNwZWNpZmljQ2FjaGUpOiBEZWxldGVkLgorICAgICAgICAqIHdhc20vV2FzbUxMSW50R2VuZXJh dG9yLmg6CisgICAgICAgICogd2FzbS9XYXNtV29ya2xpc3QuY3BwOgorCiAyMDIwLTA2LTAxICBZ dXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwg Zml4IGJ1aWxkIGZhaWx1cmUgaW4gQVJNdjdrCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL0Fzc2VtYmxlckJ1ZmZlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2Fzc2VtYmxlci9Bc3NlbWJsZXJCdWZmZXIuY3BwCShyZXZpc2lvbiAyNjIzODIp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fzc2VtYmxlckJ1ZmZlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ1LDEzICs0NSw2IEBAIFRocmVhZFNwZWNpZmljQXNzZW1ibGVy RGF0YSYgdGhyZWFkU3BlY2kKICAgICByZXR1cm4gKnRocmVhZFNwZWNpZmljQXNzZW1ibGVyRGF0 YVB0cjsKIH0KIAotdm9pZCBjbGVhckFzc2VtYmxlRGF0YVRocmVhZFNwZWNpZmljQ2FjaGUoKQot ewotICAgIGF1dG8mIHRocmVhZFNwZWNpZmljID0gdGhyZWFkU3BlY2lmaWNBc3NlbWJsZXJEYXRh KCk7Ci0gICAgaWYgKHRocmVhZFNwZWNpZmljLmlzU2V0KCkpCi0gICAgICAgIHRocmVhZFNwZWNp ZmljLT5jbGVhcigpOwotfQotCiAjZW5kaWYgLy8gRU5BQkxFKEFTU0VNQkxFUikKIAogfSAvLyBu YW1lc3BhY2UgSlNDCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0Fzc2Vt YmxlckJ1ZmZlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJs ZXIvQXNzZW1ibGVyQnVmZmVyLmgJKHJldmlzaW9uIDI2MjM4MikKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9hc3NlbWJsZXIvQXNzZW1ibGVyQnVmZmVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ2 LDcgKzQ2LDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgdHlwZWRlZiBUaHJlYWRTcGVjaWZpYzxB c3NlbWJsZXJEYXRhLCBXVEY6OkNhbkJlR0NUaHJlYWQ6OlRydWU+IFRocmVhZFNwZWNpZmljQXNz ZW1ibGVyRGF0YTsKIAogICAgIEpTX0VYUE9SVF9QUklWQVRFIFRocmVhZFNwZWNpZmljQXNzZW1i bGVyRGF0YSYgdGhyZWFkU3BlY2lmaWNBc3NlbWJsZXJEYXRhKCk7Ci0gICAgdm9pZCBjbGVhckFz c2VtYmxlRGF0YVRocmVhZFNwZWNpZmljQ2FjaGUoKTsKIAogICAgIGNsYXNzIExpbmtCdWZmZXI7 CiAKQEAgLTIxMCwxMyArMjA5LDEzIEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAgICAgOiBt X3N0b3JhZ2UoKQogICAgICAgICAgICAgLCBtX2luZGV4KDApCiAgICAgICAgIHsKLSAgICAgICAg ICAgIGF1dG8mIHRocmVhZFNwZWNpZmljID0gZ2V0VGhyZWFkU3BlY2lmaWNBc3NlbWJsZXJEYXRh KCk7CisgICAgICAgICAgICBhdXRvJiB0aHJlYWRTcGVjaWZpYyA9IHRocmVhZFNwZWNpZmljQXNz ZW1ibGVyRGF0YSgpOwogICAgICAgICAgICAgbV9zdG9yYWdlLnRha2VCdWZmZXJJZkxhcmdlcihX VEZNb3ZlKCp0aHJlYWRTcGVjaWZpYykpOwogICAgICAgICB9CiAKICAgICAgICAgfkFzc2VtYmxl ckJ1ZmZlcigpCiAgICAgICAgIHsKLSAgICAgICAgICAgIGF1dG8mIHRocmVhZFNwZWNpZmljID0g Z2V0VGhyZWFkU3BlY2lmaWNBc3NlbWJsZXJEYXRhKCk7CisgICAgICAgICAgICBhdXRvJiB0aHJl YWRTcGVjaWZpYyA9IHRocmVhZFNwZWNpZmljQXNzZW1ibGVyRGF0YSgpOwogICAgICAgICAgICAg dGhyZWFkU3BlY2lmaWMtPnRha2VCdWZmZXJJZkxhcmdlcihXVEZNb3ZlKG1fc3RvcmFnZSkpOwog ICAgICAgICB9CiAKQEAgLTMzNCwxOCArMzMzLDYgQEAgbmFtZXNwYWNlIEpTQyB7CiAKIAogICAg IHByb3RlY3RlZDoKLSAgICAgICAgVGhyZWFkU3BlY2lmaWNBc3NlbWJsZXJEYXRhJiBnZXRUaHJl YWRTcGVjaWZpY0Fzc2VtYmxlckRhdGEoKQotICAgICAgICB7Ci0gICAgICAgICAgICBhdXRvJiB0 aHJlYWRTcGVjaWZpYyA9IHRocmVhZFNwZWNpZmljQXNzZW1ibGVyRGF0YSgpOwotCi0gICAgICAg ICAgICBpZiAoIXRocmVhZFNwZWNpZmljLmlzU2V0KCkpIHsKLSAgICAgICAgICAgICAgICB2b2lk KiBwdHIgPSBzdGF0aWNfY2FzdDxBc3NlbWJsZXJEYXRhKj4odGhyZWFkU3BlY2lmaWMpOwotICAg ICAgICAgICAgICAgIG5ldyAocHRyKSBBc3NlbWJsZXJEYXRhKCk7Ci0gICAgICAgICAgICB9Ci0K LSAgICAgICAgICAgIHJldHVybiB0aHJlYWRTcGVjaWZpYzsKLSAgICAgICAgfQotICAgICAgICAK ICAgICAgICAgdGVtcGxhdGU8dHlwZW5hbWUgSW50ZWdyYWxUeXBlPgogICAgICAgICB2b2lkIHB1 dEludGVncmFsKEludGVncmFsVHlwZSB2YWx1ZSkKICAgICAgICAgewpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2RmZy9ERkdXb3JrbGlzdC5jcHAJKHJldmlzaW9uIDI2MjM4MikKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHV29ya2xpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xNTgsNyArMTU4LDYgQEAgcHJpdmF0ZToKICAgICAgICAgCiAgICAgICAgIEFTU0VSVCghbV9w bGFuKTsKICAgICAgICAgCi0gICAgICAgIGNsZWFyQXNzZW1ibGVEYXRhVGhyZWFkU3BlY2lmaWND YWNoZSgpOwogICAgICAgICBtX2NvbXBpbGF0aW9uU2NvcGUgPSBudWxscHRyOwogICAgICAgICBt X3BsYW4gPSBudWxscHRyOwogICAgIH0KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUV29ya2xpc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv SklUV29ya2xpc3QuY3BwCShyZXZpc2lvbiAyNjIzODIpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaml0L0pJVFdvcmtsaXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ2LDExICsxNDYsNiBA QCBwcml2YXRlOgogICAgICAgICByZXR1cm4gV29ya1Jlc3VsdDo6Q29udGludWU7CiAgICAgfQog Ci0gICAgdm9pZCB0aHJlYWRJc1N0b3BwaW5nKGNvbnN0IEFic3RyYWN0TG9ja2VyJikgZmluYWwK LSAgICB7Ci0gICAgICAgIGNsZWFyQXNzZW1ibGVEYXRhVGhyZWFkU3BlY2lmaWNDYWNoZSgpOwot ICAgIH0KLQogICAgIEpJVFdvcmtsaXN0JiBtX3dvcmtsaXN0OwogICAgIFBsYW5zIG1fbXlQbGFu czsKIH07CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtTExJbnRHZW5lcmF0 b3IuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21MTElu dEdlbmVyYXRvci5jcHAJKHJldmlzaW9uIDI2MjM4MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS93YXNtL1dhc21MTEludEdlbmVyYXRvci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ0MSwxMyAr NDQxLDYgQEAgc3RhdGljIFRocmVhZFNwZWNpZmljPEJ1ZmZlcj4mIHRocmVhZFNwZQogICAgIHJl dHVybiAqdGhyZWFkU3BlY2lmaWNCdWZmZXJQdHI7CiB9CiAKLXZvaWQgY2xlYXJMTEludFRocmVh ZFNwZWNpZmljQ2FjaGUoKQotewotICAgIGF1dG8mIHRocmVhZFNwZWNpZmljID0gdGhyZWFkU3Bl Y2lmaWNCdWZmZXIoKTsKLSAgICBpZiAodGhyZWFkU3BlY2lmaWMuaXNTZXQoKSkKLSAgICAgICAg dGhyZWFkU3BlY2lmaWMtPmNsZWFyKCk7Ci19Ci0KIExMSW50R2VuZXJhdG9yOjpMTEludEdlbmVy YXRvcihjb25zdCBNb2R1bGVJbmZvcm1hdGlvbiYgaW5mbywgdW5zaWduZWQgZnVuY3Rpb25JbmRl eCwgY29uc3QgU2lnbmF0dXJlJikKICAgICA6IEJ5dGVjb2RlR2VuZXJhdG9yQmFzZShtYWtlVW5p cXVlPEZ1bmN0aW9uQ29kZUJsb2NrPihmdW5jdGlvbkluZGV4KSwgMCkKICAgICAsIG1faW5mbyhp bmZvKQpAQCAtNDU1LDEyICs0NDgsNiBAQCBMTEludEdlbmVyYXRvcjo6TExJbnRHZW5lcmF0b3Io Y29uc3QgTW9kCiB7CiAgICAgewogICAgICAgICBhdXRvJiB0aHJlYWRTcGVjaWZpYyA9IHRocmVh ZFNwZWNpZmljQnVmZmVyKCk7Ci0KLSAgICAgICAgaWYgKCF0aHJlYWRTcGVjaWZpYy5pc1NldCgp KSB7Ci0gICAgICAgICAgICB2b2lkKiBwdHIgPSBzdGF0aWNfY2FzdDxCdWZmZXIqPih0aHJlYWRT cGVjaWZpYyk7Ci0gICAgICAgICAgICBuZXcgKHB0cikgQnVmZmVyKCk7Ci0gICAgICAgIH0KLQog ICAgICAgICBCdWZmZXIgYnVmZmVyID0gV1RGTW92ZSgqdGhyZWFkU3BlY2lmaWMpOwogICAgICAg ICAqdGhyZWFkU3BlY2lmaWMgPSBCdWZmZXIoKTsKICAgICAgICAgbV93cml0ZXIuc2V0SW5zdHJ1 Y3Rpb25CdWZmZXIoV1RGTW92ZShidWZmZXIpKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS93YXNtL1dhc21MTEludEdlbmVyYXRvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS93YXNtL1dhc21MTEludEdlbmVyYXRvci5oCShyZXZpc2lvbiAyNjIzODIpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtTExJbnRHZW5lcmF0b3IuaAkod29ya2luZyBj b3B5KQpAQCAtMzUsOCArMzUsNiBAQCBjbGFzcyBGdW5jdGlvbkNvZGVCbG9jazsKIAogRXhwZWN0 ZWQ8c3RkOjp1bmlxdWVfcHRyPEZ1bmN0aW9uQ29kZUJsb2NrPiwgU3RyaW5nPiBwYXJzZUFuZENv bXBpbGVCeXRlY29kZShjb25zdCB1aW50OF90Kiwgc2l6ZV90LCBjb25zdCBTaWduYXR1cmUmLCBj b25zdCBNb2R1bGVJbmZvcm1hdGlvbiYsIHVpbnQzMl90IGZ1bmN0aW9uSW5kZXgpOwogCi12b2lk IGNsZWFyTExJbnRUaHJlYWRTcGVjaWZpY0NhY2hlKCk7Ci0KIH0gfSAvLyBuYW1lc3BhY2UgSlND OjpXYXNtCiAKICNlbmRpZiAvLyBFTkFCTEUoV0VCQVNTRU1CTFkpCkluZGV4OiBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvd2FzbS9XYXNtV29ya2xpc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS93YXNtL1dhc21Xb3JrbGlzdC5jcHAJKHJldmlzaW9uIDI2MjM4MikKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21Xb3JrbGlzdC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTExNywxMiArMTE3LDYgQEAgcHJpdmF0ZToKICAgICAgICAgcmV0dXJuIGNvbXBsZXRl KGhvbGRMb2NrKCp3b3JrbGlzdC5tX2xvY2spKTsKICAgICB9CiAKLSAgICB2b2lkIHRocmVhZElz U3RvcHBpbmcoY29uc3QgQWJzdHJhY3RMb2NrZXImKSBmaW5hbAotICAgIHsKLSAgICAgICAgY2xl YXJMTEludFRocmVhZFNwZWNpZmljQ2FjaGUoKTsKLSAgICAgICAgY2xlYXJBc3NlbWJsZURhdGFU aHJlYWRTcGVjaWZpY0NhY2hlKCk7Ci0gICAgfQotCiAgICAgY29uc3QgY2hhciogbmFtZSgpIGNv bnN0IGZpbmFsCiAgICAgewogICAgICAgICByZXR1cm4gIldhc20gV29ya2xpc3QgSGVscGVyIFRo cmVhZCI7Cg==