212603 2020-06-01 12:19:13 -0700 x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type. 2020-06-01 12:37:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1657997 0 mark.lam 2020-06-01 12:19:13 -0700 The current implementation mistakenly sets the address type to that of the value being loaded. 1657998 1 400746 mark.lam 2020-06-01 12:23:04 -0700 Created attachment 400746 proposed patch. 1658002 2 400746 ysuzuki 2020-06-01 12:35:17 -0700 Comment on attachment 400746 proposed patch. r=me too 1658003 3 mark.lam 2020-06-01 12:36:35 -0700 Thanks for the review. Landed in r262389: <http://trac.webkit.org/r262389>. 1658004 4 webkit-bug-importer 2020-06-01 12:37:18 -0700 <rdar://problem/63839299> 400746 2020-06-01 12:23:04 -0700 2020-06-01 12:34:13 -0700 proposed patch. bug-212603.patch text/plain 1732 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYyMzg4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDIwLTA2LTAxICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICB4 ODYucmIncyBMYWJlbFJlZmVyZW5jZS54ODZMb2FkT3BlcmFuZCgpJ3MgYWRkcmVzcyBvcGVyYW5k IHNob3VsZCBiZSBhIHBvaW50ZXIgdHlwZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIxMjYwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBjdXJyZW50IGltcGxlbWVudGF0aW9uIG1pc3Rha2VubHkg c2V0cyB0aGUgYWRkcmVzcyB0eXBlIHRvIHRoYXQgb2YgdGhlIHZhbHVlCisgICAgICAgIGJlaW5n IGxvYWRlZC4gIEkgZW5jb3VudGVyZWQgdGhpcyBpc3N1ZSB3aGVuIEkgd2FzIHRyeWluZyB0byBk byBhIGxvYWRiIGZyb20gYQorICAgICAgICBnbG9iYWwgYWRkcmVzcy4gIEJlY2F1c2Ugb2YgdGhp cyBidWcsIHRoZSBlbWl0dGVkIGNvZGUgd2FzIHRyeWluZyBkbyBhIGxvYWQgdXNpbmcKKyAgICAg ICAgJWFsICg4IGJ5dGUgcmVnaXN0ZXIpIGFzIHRoZSBwb2ludGVyIHRvIGxvYWQgZnJvbS4gIFdp dGggdGhpcyBmaXgsIGl0IG5vdyBsb2FkcworICAgICAgICBmcm9tICVyYXguCisKKyAgICAgICAg KiBvZmZsaW5lYXNtL3g4Ni5yYjoKKwogMjAyMC0wNi0wMSAgWXVzdWtlIFN1enVraSAgPHlzdXp1 a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIEpTVmFsdWU6OnRvVGhpcyBzaG91bGQgbm90 IHRocm93IGV4Y2VwdGlvbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v eDg2LnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4 Ni5yYgkocmV2aXNpb24gMjYyMzg4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVh c20veDg2LnJiCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotIyBDb3B5cmlnaHQgKEMp IDIwMTItMjAxOCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAo QykgMjAxMi0yMDIwIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgQ29weXJpZ2h0 IChDKSAyMDEzIERpZ2lhIFBsYy4gYW5kL29yIGl0cyBzdWJzaWRpYXJ5KC1pZXMpCiAjCiAjIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dApAQCAtNDQ3LDcgKzQ0Nyw3IEBAIGNsYXNzIExhYmVsUmVmZXJlbmNlCiAgICAgICAg IGVsc2UKICAgICAgICAgICAgICRhc20ucHV0cyAibGVhICN7ZHN0Lng4Nk9wZXJhbmQoOnB0cil9 LCAje2FzbUxhYmVsfSIKICAgICAgICAgZW5kCi0gICAgICAgICIje29mZnNldH0oI3tkc3QueDg2 T3BlcmFuZChraW5kKX0pIgorICAgICAgICAiI3tvZmZzZXR9KCN7ZHN0Lng4Nk9wZXJhbmQoOnB0 cil9KSIKICAgICBlbmQKIGVuZAogCg==