212594 2020-06-01 07:34:38 -0700 [ macOS ] REGRESSION(r262366): webgl/1.0.3/conformance/canvas/buffer-offscreen-test.html & webgl/2.0.0/conformance/canvas/buffer-offscreen-test.html are constant failures 2021-08-31 01:43:31 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229668 InRadar P2 Normal --- 1 jacob_uphoff dino cdumez dino eric.carlson esprehn+autocc ews-watchlist kangil.han webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1657898 0 jacob_uphoff 2020-06-01 07:34:38 -0700 webgl/2.0.0/conformance/canvas/buffer-offscreen-test.html webgl/1.0.3/conformance/canvas/buffer-offscreen-test.html These tests became constant failures after commit r262366 for all of macOS. History: https://results.webkit.org/?suite=layout-tests&suite=layout-tests&test=webgl%2F2.0.0%2Fconformance%2Fcanvas%2Fbuffer-offscreen-test.html&test=webgl%2F1.0.3%2Fconformance%2Fcanvas%2Fbuffer-offscreen-test.html Diffs: --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/1.0.3/conformance/canvas/buffer-offscreen-test-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/1.0.3/conformance/canvas/buffer-offscreen-test-actual.txt @@ -1,5 +1,14 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html -[ PASS ] All tests passed +[ 1: PASS ] gl1 != null is true +[ 2: PASS ] gl2 != null is true +[ 3: PASS ] gl1.getContextAttributes().preserveDrawingBuffer == false is true +[ 4: PASS ] gl2.getContextAttributes().preserveDrawingBuffer == false is true +[ 5: PASS ] cleared corner should be blue, stencil should be preserved +[ 6: PASS ] remainder of buffer should be cleared +[ 7: PASS ] cleared corner should be blue, stencil should be preserved +[ 8: FAIL ] at (0, 0) expected: 255,0,0,255 was 0,0,0,0 +[ 9: PASS ] successfullyParsed is true +[ FAIL ] 1 failures reported --- /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance/canvas/buffer-offscreen-test-expected.txt +++ /Volumes/Data/slave/catalina-release-tests-wk2/build/layout-test-results/webgl/2.0.0/conformance/canvas/buffer-offscreen-test-actual.txt @@ -1,5 +1,14 @@ This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL. Test: ../../resources/webgl_test_files/conformance/canvas/buffer-offscreen-test.html -[ PASS ] All tests passed +[ 1: PASS ] gl1 != null is true +[ 2: PASS ] gl2 != null is true +[ 3: PASS ] gl1.getContextAttributes().preserveDrawingBuffer == false is true +[ 4: PASS ] gl2.getContextAttributes().preserveDrawingBuffer == false is true +[ 5: PASS ] cleared corner should be blue, stencil should be preserved +[ 6: PASS ] remainder of buffer should be cleared +[ 7: PASS ] cleared corner should be blue, stencil should be preserved +[ 8: FAIL ] remainder of buffer should be un-cleared red at (0, 0) expected: 255,0,0,255 was 0,0,0,0 +[ 9: PASS ] successfullyParsed is true +[ FAIL ] 1 failures reported 1657899 1 webkit-bug-importer 2020-06-01 07:35:04 -0700 <rdar://problem/63828783> 1658125 2 ryanhaddad 2020-06-01 17:32:07 -0700 Marked tests as failing in r262400 1658496 3 dino 2020-06-02 16:25:07 -0700 It's quite confusing as to how I could have broken this. Maybe another case where we are setting the GL state temporarily for compositing and not restoring it? 1658498 4 dino 2020-06-02 16:26:20 -0700 Our visual result is correct. It's the content read from the in-progress draw that's wrong. 1658537 5 dino 2020-06-02 18:25:49 -0700 Hmmm.. I see an extra call to clear(COLOR_BUFFER_BIT | DEPTH_BUFFER_BIT) 1658542 6 dino 2020-06-02 18:31:51 -0700 Oh. I see. We shouldn't prepare the canvas if it isn't going to be displayed. We're effectively swapping the drawing buffer on a canvas that is never drawn, so when it is read back out it is cleared. 1658552 7 dino 2020-06-02 18:50:46 -0700 Now that I think of it, this whole area could do with some cleanup. We really only need a WebGLLayer when the owning canvas is put in the page. It's a bit weird that the GraphicsContextGL lets the WebGLLayer manage the IOSurface backbuffers. Instead it should just hand the current framebuffer surface to the layer. I don't want to make such a big change right now though. 1658563 8 dino 2020-06-02 19:03:39 -0700 This is slightly tricky since we indicate we need preparation as we touch GL, but we only know if we need to actually prepare at the end of the run loop. So I guess the Document::prepareCanvasesForDisplayIfNeeded has an even more correct name now. It should check if the canvas element is actually in its body before preparing. 1658573 9 400880 dino 2020-06-02 19:21:27 -0700 Created attachment 400880 Patch 1658755 10 400880 ap 2020-06-03 09:56:16 -0700 Comment on attachment 400880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400880&action=review > Source/WebCore/ChangeLog:3 > + [ macOS ] REGRESSION(r262366): webgl/1.0.3/conformance/canvas/buffer-offscreen-test.html & webgl/2.0.0/conformance/canvas/buffer-offscreen-test.html are constant failures Could you please unmark the tests in a single commit with the fix? 1658812 11 400880 dino 2020-06-03 11:38:30 -0700 Comment on attachment 400880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400880&action=review >> Source/WebCore/ChangeLog:3 >> + [ macOS ] REGRESSION(r262366): webgl/1.0.3/conformance/canvas/buffer-offscreen-test.html & webgl/2.0.0/conformance/canvas/buffer-offscreen-test.html are constant failures > > Could you please unmark the tests in a single commit with the fix? Yes, I should have thought of that. 1658820 12 dino 2020-06-03 11:49:29 -0700 Committed r262498: <https://trac.webkit.org/changeset/262498> 400880 2020-06-02 19:21:27 -0700 2020-06-02 19:28:20 -0700 Patch bug-212594-20200603122126.patch text/plain 2536 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZThhNzk0ZDkyNGE5Njdi MWFhMWM0MTMzYjA5MWVjMmRhNjRjZGQwMS4uOGQwM2JlM2UzMmUxZjhkNTFkZjcyMjMzZmMyMTRi YWJiMmEyYWNkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA2LTAyICBEZWFu IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBbIG1hY09TIF0gUkVHUkVTU0lP TihyMjYyMzY2KTogd2ViZ2wvMS4wLjMvY29uZm9ybWFuY2UvY2FudmFzL2J1ZmZlci1vZmZzY3Jl ZW4tdGVzdC5odG1sICYgd2ViZ2wvMi4wLjAvY29uZm9ybWFuY2UvY2FudmFzL2J1ZmZlci1vZmZz Y3JlZW4tdGVzdC5odG1sIGFyZSBjb25zdGFudCBmYWlsdXJlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNTk0CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS82MzgyODc4Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgY2hhbmdlIGluIHIyNjIzNjYgc3BsaXQgdGhlIE9wZW5HTCB3b3JrIHRvIHBy ZXBhcmUgYSBjYW52YXMgZm9yIHJlbmRlcmluZyBmcm9tIHRoZSBhY3R1YWwgcGFpbnRpbmcKKyAg ICAgICAgKG9yIGNvbXBvc2l0aW5nIGluIHRoaXMgY2FzZSkuIENhbnZhcyBlbGVtZW50cyB3ZXJl IGJlaW5nICJwcmVwYXJlZCIgYXQgdGhlIGVuZCBvZiB0aGUgSFRNTCBydW4gbG9vcAorICAgICAg ICBpZiB0aGV5J2QgZG9uZSBhbnl0aGluZyB0aGF0IHdvdWxkIGNoYW5nZSBwaXhlbHMuIFRoZSBw cm9ibGVtIGlzIHRoYXQgY2FudmFzIGVsZW1lbnRzIHRoYXQgYXJlIG5vdCBpbgorICAgICAgICB0 aGUgZG9jdW1lbnQgYm9keSBhcmUgbmV2ZXIgY29tcG9zaXRlZCwgYW5kIHRodXMgc2hvdWxkIG5l dmVyIGJlIHByZXBhcmVkLCBvdGhlcndpc2UgdGhleSB3aWxsIGNsZWFyCisgICAgICAgIHRoZWly IGRyYXdpbmcgYnVmZmVyLiBJbiBvdGhlciB3b3JkcywgYSBjYW52YXMgaW4gdGhpcyBzdGF0ZSBt dXN0IGtlZXAgdGhlIHNhbWUgYnVmZmVyIHRocm91Z2gKKyAgICAgICAgZWFjaCByZW5kZXJpbmcg ZnJhbWUuCisKKyAgICAgICAgVGhlIHNvbHV0aW9uIGlzIHRvIGNoZWNrIGlmIHRoZSBjYW52YXMg aXMgaW4gdGhlIHRyZWUgc2NvcGUgYXQgdGhlIHRpbWUgd2UgY29uc2lkZXIgcHJlcGFyaW5nCisg ICAgICAgIGl0IGZvciBkaXNwbGF5LgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpwcmVwYXJlQ2FudmFzZXNGb3JEaXNwbGF5SWZOZWVk ZWQpOgorCiAyMDIwLTA2LTAxICBUZXRzdWhhcnUgT2h6ZWtpICA8dGV0c3VoYXJ1Lm9oemVraUBn bWFpbC5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IFBhcmVudE5vZGUucHJvdG90eXBlLnJlcGxh Y2VDaGlsZHJlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBi L1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggZTMxMTkxNWVkMjIyNzk0NjJj MzJlMzE1YTIxZmUwNmQ5MmY3ZGU1Ni4uOTk1MzljNjZhN2NiNDkwZThhNjYyMjQ5YzhmZTQ3NDcy ZWFmYzI4YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCkBAIC04NTg3LDYgKzg1ODcsMTMgQEAg dm9pZCBEb2N1bWVudDo6cHJlcGFyZUNhbnZhc2VzRm9yRGlzcGxheUlmTmVlZGVkKCkKICAgICAv LyBTb21lIGNhbnZhcyBjb250ZXh0cyBuZWVkIHRvIGRvIHdvcmsgd2hlbiByZW5kZXJpbmcgaGFz IGZpbmlzaGVkIGJ1dAogICAgIC8vIGJlZm9yZSB0aGVpciBjb250ZW50IGlzIGNvbXBvc2l0ZWQu CiAgICAgZm9yIChhdXRvKiBjYW52YXMgOiBtX2NhbnZhc2VzTmVlZGluZ0Rpc3BsYXlQcmVwYXJh dGlvbikgeworICAgICAgICAvLyBIb3dldmVyLCBpZiB0aGV5IGFyZSBub3QgaW4gdGhlIGRvY3Vt ZW50IGJvZHksIHRoZW4gdGhleSB3b24ndAorICAgICAgICAvLyBiZSBjb21wb3NpdGVkIGFuZCB0 aHVzIGRvbid0IG5lZWQgcHJlcGFyYXRpb24uIFVuZm9ydHVuYXRlbHkgdGhleQorICAgICAgICAv LyBjYW4ndCB0ZWxsIGF0IHRoZSB0aW1lIHRoZXkgd2VyZSBhZGRlZCB0byB0aGUgbGlzdCwgc2lu Y2UgdGhleQorICAgICAgICAvLyBjb3VsZCBiZSBpbnNlcnRlZCBvciByZW1vdmVkIGZyb20gdGhl IGRvY3VtZW50IGJvZHkgYWZ0ZXJ3YXJkcy4KKyAgICAgICAgaWYgKCFjYW52YXMtPmlzSW5UcmVl U2NvcGUoKSkKKyAgICAgICAgICAgIGNvbnRpbnVlOworCiAgICAgICAgIGF1dG8gcmVmQ291bnRl ZENhbnZhcyA9IG1ha2VSZWZQdHIoY2FudmFzKTsKICAgICAgICAgcmVmQ291bnRlZENhbnZhcy0+ cHJlcGFyZUZvckRpc3BsYXkoKTsKICAgICB9Cg==