212593 2020-06-01 05:02:44 -0700 [GTK4] Wheel events are always handled by the main frame view 2020-06-01 05:55:57 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=211045 P2 Normal --- 212592 210100 1 cgarcia webkit-unassigned aperez berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1657872 0 cgarcia 2020-06-01 05:02:44 -0700 It's not possible scroll other scrollable areas with the mouse wheel. This is because we are using the given x, y delta in the scroll signal as the position. In GTK4 the scroll event doesn't include a position, so we have to use the last motion event. 1657873 1 400730 cgarcia 2020-06-01 05:06:28 -0700 Created attachment 400730 Patch 1657874 2 ews-watchlist 2020-06-01 05:07:01 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1657882 3 cgarcia 2020-06-01 05:55:57 -0700 Committed r262374: <https://trac.webkit.org/changeset/262374> 400730 2020-06-01 05:06:28 -0700 2020-06-01 05:43:49 -0700 Patch wkgtk4-scroll.diff text/plain 7297 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMGNmODA2MWYxYmM2Li4wMThlOWM1MGYyNzUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMjMgQEAKKzIwMjAtMDYtMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEs0XSBXaGVlbCBldmVudHMgYXJlIGFsd2F5cyBoYW5kbGVk IGJ5IHRoZSBtYWluIGZyYW1lIHZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxMjU5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEl0J3Mgbm90IHBvc3NpYmxlIHNjcm9sbCBvdGhlciBzY3JvbGxhYmxl IGFyZWFzIHdpdGggdGhlIG1vdXNlIHdoZWVsLiBUaGlzIGlzIGJlY2F1c2Ugd2UgYXJlIHVzaW5n IHRoZSBnaXZlbiB4LAorICAgICAgICB5IGRlbHRhIGluIHRoZSBzY3JvbGwgc2lnbmFsIGFzIHRo ZSBwb3NpdGlvbi4gSW4gR1RLNCB0aGUgc2Nyb2xsIGV2ZW50IGRvZXNuJ3QgaW5jbHVkZSBhIHBv c2l0aW9uLCBzbyB3ZSBoYXZlIHRvCisgICAgICAgIHVzZSB0aGUgbGFzdCBtb3Rpb24gZXZlbnQu CisKKyAgICAgICAgKiBTaGFyZWQvTmF0aXZlV2ViV2hlZWxFdmVudC5oOgorICAgICAgICAqIFNo YXJlZC9ndGsvTmF0aXZlV2ViV2hlZWxFdmVudEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5h dGl2ZVdlYldoZWVsRXZlbnQ6Ok5hdGl2ZVdlYldoZWVsRXZlbnQpOiBBZGQgd2hlZWxUaWNrcyBw YXJhbWV0ZXIuCisgICAgICAgICogU2hhcmVkL2d0ay9XZWJFdmVudEZhY3RvcnkuY3BwOgorICAg ICAgICAoV2ViS2l0OjpXZWJFdmVudEZhY3Rvcnk6OmNyZWF0ZVdlYldoZWVsRXZlbnQpOiBOZXcg Y3JlYXRlIGZ1bmN0aW9uIHRoYXQgcmVjZWl2ZXMgdGhlIHdoZWVsVGlja3MuCisgICAgICAgICog U2hhcmVkL2d0ay9XZWJFdmVudEZhY3RvcnkuaDoKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZVNjcm9s bCk6IFVzZSB0aGUgeCwgeSBwYXJhbWV0ZXJzIGFzIHRoZSBkZWx0YSBhbmQgdGFrZSB0aGUgcG9z aXRpb24gZnJvbSB0aGUgbGFzdCBtb3Rpb24gZXZlbnQuCisKIDIwMjAtMDYtMDEgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEs0XSBGaXgg cG9pbnRlciBsb2NrIGluIFgxMQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvTmF0 aXZlV2ViV2hlZWxFdmVudC5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvTmF0aXZlV2ViV2hlZWxF dmVudC5oCmluZGV4IGVhYzc2NjlkMDgwYS4uODRkYjA4M2NlZmU3IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9OYXRpdmVXZWJXaGVlbEV2ZW50LmgKKysrIGIvU291cmNlL1dlYktp dC9TaGFyZWQvTmF0aXZlV2ViV2hlZWxFdmVudC5oCkBAIC02MCw3ICs2MCw3IEBAIHB1YmxpYzoK ICAgICBOYXRpdmVXZWJXaGVlbEV2ZW50KGNvbnN0IE5hdGl2ZVdlYldoZWVsRXZlbnQmKTsKICAg ICBOYXRpdmVXZWJXaGVlbEV2ZW50KEdka0V2ZW50Kik7CiAgICAgTmF0aXZlV2ViV2hlZWxFdmVu dChHZGtFdmVudCosIFdlYldoZWVsRXZlbnQ6OlBoYXNlLCBXZWJXaGVlbEV2ZW50OjpQaGFzZSBt b21lbnR1bVBoYXNlKTsKLSAgICBOYXRpdmVXZWJXaGVlbEV2ZW50KEdka0V2ZW50KiwgY29uc3Qg V2ViQ29yZTo6SW50UG9pbnQmKTsKKyAgICBOYXRpdmVXZWJXaGVlbEV2ZW50KEdka0V2ZW50Kiwg Y29uc3QgV2ViQ29yZTo6SW50UG9pbnQmLCBjb25zdCBXZWJDb3JlOjpGbG9hdFNpemUmIHdoZWVs VGlja3MpOwogICAgIE5hdGl2ZVdlYldoZWVsRXZlbnQoY29uc3QgV2ViQ29yZTo6SW50UG9pbnQm IHBvc2l0aW9uLCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgZ2xvYmFsUG9zaXRpb24sIGNvbnN0 IFdlYkNvcmU6OkZsb2F0U2l6ZSYgZGVsdGEsIGNvbnN0IFdlYkNvcmU6OkZsb2F0U2l6ZSYgd2hl ZWxUaWNrcywgV2ViV2hlZWxFdmVudDo6UGhhc2UsIFdlYldoZWVsRXZlbnQ6OlBoYXNlIG1vbWVu dHVtUGhhc2UpOwogI2VsaWYgVVNFKExJQldQRSkKICAgICBOYXRpdmVXZWJXaGVlbEV2ZW50KHN0 cnVjdCB3cGVfaW5wdXRfYXhpc19ldmVudCosIGZsb2F0IGRldmljZVNjYWxlRmFjdG9yLCBXZWJX aGVlbEV2ZW50OjpQaGFzZSwgV2ViV2hlZWxFdmVudDo6UGhhc2UgbW9tZW50dW1QaGFzZSk7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9ndGsvTmF0aXZlV2ViV2hlZWxFdmVudEd0 ay5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9ndGsvTmF0aXZlV2ViV2hlZWxFdmVudEd0ay5j cHAKaW5kZXggM2I2MDU5NmQ1NWE5Li45OGY5ZjJiODI3OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvU2hhcmVkL2d0ay9OYXRpdmVXZWJXaGVlbEV2ZW50R3RrLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9ndGsvTmF0aXZlV2ViV2hlZWxFdmVudEd0ay5jcHAKQEAgLTQzLDggKzQz LDggQEAgTmF0aXZlV2ViV2hlZWxFdmVudDo6TmF0aXZlV2ViV2hlZWxFdmVudChHZGtFdmVudCog ZXZlbnQsIFdlYldoZWVsRXZlbnQ6OlBoYXNlIHAKIHsKIH0KIAotTmF0aXZlV2ViV2hlZWxFdmVu dDo6TmF0aXZlV2ViV2hlZWxFdmVudChHZGtFdmVudCogZXZlbnQsIGNvbnN0IFdlYkNvcmU6Oklu dFBvaW50JiBwb3NpdGlvbikKLSAgICA6IFdlYldoZWVsRXZlbnQoV2ViRXZlbnRGYWN0b3J5Ojpj cmVhdGVXZWJXaGVlbEV2ZW50KGV2ZW50LCBwb3NpdGlvbiwgcG9zaXRpb24sIFdlYldoZWVsRXZl bnQ6OlBoYXNlOjpQaGFzZUNoYW5nZWQsIFdlYldoZWVsRXZlbnQ6OlBoYXNlOjpQaGFzZU5vbmUp KQorTmF0aXZlV2ViV2hlZWxFdmVudDo6TmF0aXZlV2ViV2hlZWxFdmVudChHZGtFdmVudCogZXZl bnQsIGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBwb3NpdGlvbiwgY29uc3QgV2ViQ29yZTo6Rmxv YXRTaXplJiB3aGVlbFRpY2tzKQorICAgIDogV2ViV2hlZWxFdmVudChXZWJFdmVudEZhY3Rvcnk6 OmNyZWF0ZVdlYldoZWVsRXZlbnQoZXZlbnQsIHBvc2l0aW9uLCBwb3NpdGlvbiwgd2hlZWxUaWNr cywgV2ViV2hlZWxFdmVudDo6UGhhc2U6OlBoYXNlQ2hhbmdlZCwgV2ViV2hlZWxFdmVudDo6UGhh c2U6OlBoYXNlTm9uZSkpCiAgICAgLCBtX25hdGl2ZUV2ZW50KGdka19ldmVudF9jb3B5KGV2ZW50 KSkKIHsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL2d0ay9XZWJFdmVudEZh Y3RvcnkuY3BwIGIvU291cmNlL1dlYktpdC9TaGFyZWQvZ3RrL1dlYkV2ZW50RmFjdG9yeS5jcHAK aW5kZXggMTZiNGZiNjVmZmU0Li5iZWQ3ODZhNTMwMzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvU2hhcmVkL2d0ay9XZWJFdmVudEZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hh cmVkL2d0ay9XZWJFdmVudEZhY3RvcnkuY3BwCkBAIC0yNjIsMTYgKzI2MiwyMSBAQCBXZWJXaGVl bEV2ZW50IFdlYkV2ZW50RmFjdG9yeTo6Y3JlYXRlV2ViV2hlZWxFdmVudChjb25zdCBHZGtFdmVu dCogZXZlbnQsIGNvbnN0CiAgICAgICAgIH0KICAgICB9CiAKKyAgICByZXR1cm4gY3JlYXRlV2Vi V2hlZWxFdmVudChldmVudCwgcG9zaXRpb24sIGdsb2JhbFBvc2l0aW9uLCB3aGVlbFRpY2tzLnZh bHVlKCksIHBoYXNlLCBtb21lbnR1bVBoYXNlKTsKK30KKworV2ViV2hlZWxFdmVudCBXZWJFdmVu dEZhY3Rvcnk6OmNyZWF0ZVdlYldoZWVsRXZlbnQoY29uc3QgR2RrRXZlbnQqIGV2ZW50LCBjb25z dCBJbnRQb2ludCYgcG9zaXRpb24sIGNvbnN0IEludFBvaW50JiBnbG9iYWxQb3NpdGlvbiwgY29u c3QgRmxvYXRTaXplJiB3aGVlbFRpY2tzLCBXZWJXaGVlbEV2ZW50OjpQaGFzZSBwaGFzZSwgV2Vi V2hlZWxFdmVudDo6UGhhc2UgbW9tZW50dW1QaGFzZSkKK3sKICAgICAvLyBGSVhNRTogW0dUS10g QWRkIGEgc2V0dGluZyB0byBjaGFuZ2UgdGhlIHBpeGVscyBwZXIgbGluZSB1c2VkIGZvciBzY3Jv bGxpbmcKICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NTQ4 MjYKICAgICBmbG9hdCBzdGVwID0gc3RhdGljX2Nhc3Q8ZmxvYXQ+KFNjcm9sbGJhcjo6cGl4ZWxz UGVyTGluZVN0ZXAoKSk7Ci0gICAgRmxvYXRTaXplIGRlbHRhKHdoZWVsVGlja3MtPndpZHRoKCkg KiBzdGVwLCB3aGVlbFRpY2tzLT5oZWlnaHQoKSAqIHN0ZXApOworICAgIEZsb2F0U2l6ZSBkZWx0 YSh3aGVlbFRpY2tzLndpZHRoKCkgKiBzdGVwLCB3aGVlbFRpY2tzLmhlaWdodCgpICogc3RlcCk7 CiAKICAgICByZXR1cm4gV2ViV2hlZWxFdmVudChXZWJFdmVudDo6V2hlZWwsCiAgICAgICAgIHBv c2l0aW9uLAogICAgICAgICBnbG9iYWxQb3NpdGlvbiwKICAgICAgICAgZGVsdGEsCi0gICAgICAg IHdoZWVsVGlja3MudmFsdWUoKSwKKyAgICAgICAgd2hlZWxUaWNrcywKICAgICAgICAgcGhhc2Us CiAgICAgICAgIG1vbWVudHVtUGhhc2UsCiAgICAgICAgIFdlYldoZWVsRXZlbnQ6OlNjcm9sbEJ5 UGl4ZWxXaGVlbEV2ZW50LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvZ3RrL1dl YkV2ZW50RmFjdG9yeS5oIGIvU291cmNlL1dlYktpdC9TaGFyZWQvZ3RrL1dlYkV2ZW50RmFjdG9y eS5oCmluZGV4IGY4NjcyYjZmZDlmYi4uZTBlM2E2YTQ2NTgzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1NoYXJlZC9ndGsvV2ViRXZlbnRGYWN0b3J5LmgKKysrIGIvU291cmNlL1dlYktpdC9T aGFyZWQvZ3RrL1dlYkV2ZW50RmFjdG9yeS5oCkBAIC00NCw2ICs0NCw3IEBAIHB1YmxpYzoKICAg ICBzdGF0aWMgV2ViV2hlZWxFdmVudCBjcmVhdGVXZWJXaGVlbEV2ZW50KGNvbnN0IEdka0V2ZW50 Kik7CiAgICAgc3RhdGljIFdlYldoZWVsRXZlbnQgY3JlYXRlV2ViV2hlZWxFdmVudChjb25zdCBH ZGtFdmVudCosIFdlYldoZWVsRXZlbnQ6OlBoYXNlLCBXZWJXaGVlbEV2ZW50OjpQaGFzZSBtb21l bnR1bVBoYXNlKTsKICAgICBzdGF0aWMgV2ViV2hlZWxFdmVudCBjcmVhdGVXZWJXaGVlbEV2ZW50 KGNvbnN0IEdka0V2ZW50KiwgY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmLCBjb25zdCBXZWJDb3Jl OjpJbnRQb2ludCYsIFdlYldoZWVsRXZlbnQ6OlBoYXNlLCBXZWJXaGVlbEV2ZW50OjpQaGFzZSBt b21lbnR1bVBoYXNlKTsKKyAgICBzdGF0aWMgV2ViV2hlZWxFdmVudCBjcmVhdGVXZWJXaGVlbEV2 ZW50KGNvbnN0IEdka0V2ZW50KiwgY29uc3QgV2ViQ29yZTo6SW50UG9pbnQmLCBjb25zdCBXZWJD b3JlOjpJbnRQb2ludCYsIGNvbnN0IFdlYkNvcmU6OkZsb2F0U2l6ZSYgd2hlZWxUaWNrcywgV2Vi V2hlZWxFdmVudDo6UGhhc2UsIFdlYldoZWVsRXZlbnQ6OlBoYXNlIG1vbWVudHVtUGhhc2UpOwog ICAgIHN0YXRpYyBXZWJLZXlib2FyZEV2ZW50IGNyZWF0ZVdlYktleWJvYXJkRXZlbnQoY29uc3Qg R2RrRXZlbnQqLCBjb25zdCBTdHJpbmcmLCBib29sIGhhbmRsZWRCeUlucHV0TWV0aG9kLCBPcHRp b25hbDxWZWN0b3I8V2ViQ29yZTo6Q29tcG9zaXRpb25VbmRlcmxpbmU+PiYmLCBPcHRpb25hbDxF ZGl0aW5nUmFuZ2U+JiYsIFZlY3RvcjxTdHJpbmc+JiYgY29tbWFuZHMpOwogI2lmIEVOQUJMRShU T1VDSF9FVkVOVFMpCiAgICAgc3RhdGljIFdlYlRvdWNoRXZlbnQgY3JlYXRlV2ViVG91Y2hFdmVu dChjb25zdCBHZGtFdmVudCosIFZlY3RvcjxXZWJQbGF0Zm9ybVRvdWNoUG9pbnQ+JiYpOwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNl LmNwcAppbmRleCAxYmE3ZGU3YjNlZjUuLjcwMDYzODQyMjc2MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHAKQEAgLTEy NTYsMTMgKzEyNTYsMTkgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdFdlYlZpZXdCYXNlU2Nyb2xs RXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50U2Nyb2xsKgogI2VuZGlmCiAKICNpZiBV U0UoR1RLNCkKLXN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3QmFzZVNjcm9sbChXZWJLaXRX ZWJWaWV3QmFzZSogd2ViVmlld0Jhc2UsIGRvdWJsZSB4LCBkb3VibGUgeSwgR3RrRXZlbnRDb250 cm9sbGVyKiBjb250cm9sbGVyKQorc3RhdGljIGdib29sZWFuIHdlYmtpdFdlYlZpZXdCYXNlU2Ny b2xsKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwgZG91YmxlIGRlbHRhWCwgZG91Ymxl IGRlbHRhWSwgR3RrRXZlbnRDb250cm9sbGVyKiBjb250cm9sbGVyKQogewotICAgIGlmICh3ZWJW aWV3QmFzZS0+cHJpdi0+ZGlhbG9nKQorICAgIFdlYktpdFdlYlZpZXdCYXNlUHJpdmF0ZSogcHJp diA9IHdlYlZpZXdCYXNlLT5wcml2OworICAgIGlmIChwcml2LT5kaWFsb2cpCiAgICAgICAgIHJl dHVybiBHREtfRVZFTlRfUFJPUEFHQVRFOwogCi0gICAgLy8gRklYTUU6IGludmVydCBheGlzIGlu IGNhc2Ugb2YgU0hJRlQuCi0gICAgd2ViVmlld0Jhc2UtPnByaXYtPnBhZ2VQcm94eS0+aGFuZGxl V2hlZWxFdmVudChOYXRpdmVXZWJXaGVlbEV2ZW50KGd0a19ldmVudF9jb250cm9sbGVyX2dldF9j dXJyZW50X2V2ZW50KGNvbnRyb2xsZXIpLCB7IGNsYW1wVG9JbnRlZ2VyKHgpLCBjbGFtcFRvSW50 ZWdlcih5KSB9KSk7CisgICAgYXV0byogZXZlbnQgPSBndGtfZXZlbnRfY29udHJvbGxlcl9nZXRf Y3VycmVudF9ldmVudChjb250cm9sbGVyKTsKKworICAgIC8vIFNoaWZ0K1doZWVsIHNjcm9sbHMg aW4gdGhlIHBlcnBlbmRpY3VsYXIgZGlyZWN0aW9uLgorICAgIGlmIChnZGtfZXZlbnRfZ2V0X21v ZGlmaWVyX3N0YXRlKGV2ZW50KSAmIEdES19TSElGVF9NQVNLKQorICAgICAgICBzdGQ6OnN3YXAo ZGVsdGFYLCBkZWx0YVkpOworCisgICAgcHJpdi0+cGFnZVByb3h5LT5oYW5kbGVXaGVlbEV2ZW50 KE5hdGl2ZVdlYldoZWVsRXZlbnQoZXZlbnQsIHByaXYtPmxhc3RNb3Rpb25FdmVudCA/IEludFBv aW50KHByaXYtPmxhc3RNb3Rpb25FdmVudC0+cG9zaXRpb24pIDogSW50UG9pbnQoKSwgRmxvYXRT aXplKC1kZWx0YVgsIC1kZWx0YVkpKSk7CiAKICAgICByZXR1cm4gR0RLX0VWRU5UX1NUT1A7CiB9 Cg==