212592 2020-06-01 04:53:28 -0700 [GTK4] Fix pointer lock in X11 2020-06-01 05:27:48 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212314 Gtk P2 Normal --- 210100 212593 1 cgarcia webkit-unassigned aperez berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1657869 0 cgarcia 2020-06-01 04:53:28 -0700 I forgot to forward the motion events for X11 in gtk4. 1657870 1 400729 cgarcia 2020-06-01 04:57:25 -0700 Created attachment 400729 Patch 1657871 2 ews-watchlist 2020-06-01 04:57:58 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1657877 3 cgarcia 2020-06-01 05:27:48 -0700 Committed r262372: <https://trac.webkit.org/changeset/262372> 400729 2020-06-01 04:57:25 -0700 2020-06-01 05:25:15 -0700 Patch wkgtk4-pointer-lock-x11.diff text/plain 3096 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNGM0YTM3MjVjZWRkLi4wY2Y4MDYxZjFiYzYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTcgQEAKKzIwMjAtMDYtMDEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEs0XSBGaXggcG9pbnRlciBsb2NrIGluIFgxMQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNTkyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSSBmb3Jnb3QgdG8gZm9y d2FyZCB0aGUgbW90aW9uIGV2ZW50cyBmb3IgWDExIGluIEdUSzQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFzZS5jcHA6CisgICAgICAgIChNb3Rpb25FdmVu dDo6TW90aW9uRXZlbnQpOiBBZGQgYSBjb25zdHJ1Y3RvciB0aGF0IHJlY2VpdmVzIHRoZSBwb3Np dGlvbnMgYW5kIHN0YXRlLgorICAgICAgICAod2Via2l0V2ViVmlld0Jhc2VNb3Rpb24pOiBOb3Rp ZnkgdGhlIHBvaW50ZXIgbG9jayBtYW5hZ2VyIGFib3V0IHRoZSBldmVudC4gQWxzbyBzYXZlIHRo ZSBsYXN0IG1vdGlvbiBldmVudCBhbmQKKyAgICAgICAgY29tcHV0ZSB0aGUgbW92ZW1lbnQgZGVs dGEuCisKIDIwMjAtMDUtMzEgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHVEs0XSBNb25pdG9yIHJvb3Qgd2luZG93IHRvIHVwZGF0ZSBhY3Rp dml0eSBzdGF0ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3QmFzZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCAzZWE2ZWVmYTZlZDUuLjFiYTdkZTdiM2VmNSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3QmFz ZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHAKQEAgLTE3MywxMSArMTczLDEzIEBAIHN0cnVjdCBNb3Rpb25FdmVudCB7CiAgICAg ICAgICAgICB5Um9vdCA9IHJvb3RQb2ludC55KCk7CiAgICAgICAgIH0KIAotICAgICAgICBwb3Np dGlvbi5zZXRYKHgpOwotICAgICAgICBwb3NpdGlvbi5zZXRZKHkpOwotICAgICAgICBnbG9iYWxQ b3NpdGlvbi5zZXRYKHhSb290KTsKLSAgICAgICAgZ2xvYmFsUG9zaXRpb24uc2V0WSh5Um9vdCk7 CisgICAgICAgIE1vdGlvbkV2ZW50KEZsb2F0UG9pbnQoeCwgeSksIEZsb2F0UG9pbnQoeFJvb3Qs IHlSb290KSwgc3RhdGUpOworICAgIH0KIAorICAgIE1vdGlvbkV2ZW50KEZsb2F0UG9pbnQmJiBw b3NpdGlvbiwgRmxvYXRQb2ludCYmIGdsb2JhbFBvc2l0aW9uLCBHZGtNb2RpZmllclR5cGUgc3Rh dGUpCisgICAgICAgIDogcG9zaXRpb24oV1RGTW92ZShwb3NpdGlvbikpCisgICAgICAgICwgZ2xv YmFsUG9zaXRpb24oV1RGTW92ZShnbG9iYWxQb3NpdGlvbikpCisgICAgewogICAgICAgICBpZiAo c3RhdGUgJiBHREtfQ09OVFJPTF9NQVNLKQogICAgICAgICAgICAgbW9kaWZpZXJzLmFkZChXZWJF dmVudDo6TW9kaWZpZXI6OkNvbnRyb2xLZXkpOwogICAgICAgICBpZiAoc3RhdGUgJiBHREtfU0hJ RlRfTUFTSykKQEAgLTEzNzUsOSArMTM3NywyMyBAQCBzdGF0aWMgdm9pZCB3ZWJraXRXZWJWaWV3 QmFzZUVudGVyKFdlYktpdFdlYlZpZXdCYXNlKiB3ZWJWaWV3QmFzZSwgZG91YmxlIHgsIGRvdQog CiBzdGF0aWMgZ2Jvb2xlYW4gd2Via2l0V2ViVmlld0Jhc2VNb3Rpb24oV2ViS2l0V2ViVmlld0Jh c2UqIHdlYlZpZXdCYXNlLCBkb3VibGUgeCwgZG91YmxlIHksIEd0a0V2ZW50Q29udHJvbGxlciog Y29udHJvbGxlcikKIHsKLSAgICAvLyBGSVhNRTogRm9yd2FyZCBldmVudCB0byBkaWFsb2cuCi0g ICAgLy8gRklYTUU6IFBvaW50ZXIgbG9jay4KLSAgICB3ZWJWaWV3QmFzZS0+cHJpdi0+cGFnZVBy b3h5LT5oYW5kbGVNb3VzZUV2ZW50KE5hdGl2ZVdlYk1vdXNlRXZlbnQoZ3RrX2V2ZW50X2NvbnRy b2xsZXJfZ2V0X2N1cnJlbnRfZXZlbnQoY29udHJvbGxlciksIHsgY2xhbXBUb0ludGVnZXIoeCks IGNsYW1wVG9JbnRlZ2VyKHkpIH0sIDAsIFdURjo6bnVsbG9wdCkpOworICAgIFdlYktpdFdlYlZp ZXdCYXNlUHJpdmF0ZSogcHJpdiA9IHdlYlZpZXdCYXNlLT5wcml2OworICAgIGlmIChwcml2LT5k aWFsb2cpCisgICAgICAgIHJldHVybiBHREtfRVZFTlRfUFJPUEFHQVRFOworCisgICAgaWYgKHBy aXYtPnBvaW50ZXJMb2NrTWFuYWdlcikgeworICAgICAgICBwcml2LT5wb2ludGVyTG9ja01hbmFn ZXItPmRpZFJlY2VpdmVNb3Rpb25FdmVudChGbG9hdFBvaW50KHgsIHkpKTsKKyAgICAgICAgcmV0 dXJuIEdES19FVkVOVF9TVE9QOworICAgIH0KKworICAgIGF1dG8qIGV2ZW50ID0gZ3RrX2V2ZW50 X2NvbnRyb2xsZXJfZ2V0X2N1cnJlbnRfZXZlbnQoY29udHJvbGxlcik7CisgICAgT3B0aW9uYWw8 RmxvYXRTaXplPiBtb3ZlbWVudERlbHRhOworICAgIE1vdGlvbkV2ZW50IG1vdGlvbkV2ZW50KEZs b2F0UG9pbnQoeCwgeSksIEZsb2F0UG9pbnQoeCwgeSksIGdka19ldmVudF9nZXRfbW9kaWZpZXJf c3RhdGUoZXZlbnQpKTsKKyAgICBpZiAocHJpdi0+bGFzdE1vdGlvbkV2ZW50KQorICAgICAgICBt b3ZlbWVudERlbHRhID0gbW90aW9uRXZlbnQucG9zaXRpb24gLSBwcml2LT5sYXN0TW90aW9uRXZl bnQtPnBvc2l0aW9uOworICAgIHByaXYtPmxhc3RNb3Rpb25FdmVudCA9IFdURk1vdmUobW90aW9u RXZlbnQpOworCisgICAgd2ViVmlld0Jhc2UtPnByaXYtPnBhZ2VQcm94eS0+aGFuZGxlTW91c2VF dmVudChOYXRpdmVXZWJNb3VzZUV2ZW50KGV2ZW50LCB7IGNsYW1wVG9JbnRlZ2VyKHgpLCBjbGFt cFRvSW50ZWdlcih5KSB9LCAwLCBtb3ZlbWVudERlbHRhKSk7CiAKICAgICByZXR1cm4gR0RLX0VW RU5UX1BST1BBR0FURTsKIH0K