212587 2020-05-31 23:17:08 -0700 [Cocoa] Bug 212420 breaks XCBuild 2020-08-05 15:02:11 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=212542 InRadar P2 Normal --- 1 krollin krollin ap krollin webkit-bug-importer oldest_to_newest 1657834 0 krollin 2020-05-31 23:17:08 -0700 Bug 212420 breaks XCBuild. The problem is that the .xcfilelist for the generated unified sources is removed. This file is used not only to determine dependencies (something that was addressed by the addition of the UnifiedSourceBundlesTimeStamp.txt file), but also to notify XCBuild how and when generated files are created. Without this file, XCBuild doesn't know where the UnifiedSource*.* files are coming from and it fails when it tries to compile them. 1657835 1 webkit-bug-importer 2020-05-31 23:17:20 -0700 <rdar://problem/63818686> 1657892 2 darin 2020-06-01 07:17:04 -0700 How does this work for all the other derived sources? We should be able to fix this by making it the same as the rest. 1657907 3 darin 2020-06-01 08:08:39 -0700 Keith, I’m happy to fix this so that the file list contains the list of unified source files. If you can help me figure out the strategy, I’ll do it. 1657915 4 darin 2020-06-01 08:19:59 -0700 I’m having trouble getting used to the overall strategy here. Inelegant always having to regenerate the file lists in a separate pass every time we build. Seems like a recipe for slow builds to process all the dependencies twice, once to build and once to check/rebuild xcfilelist files. But given the strategy, seems like somehow I am going to have to get --generate-xcfilelists and --output-xcfilelist-path passed in to the generate-unified-sources.sh script so it can build the list of files. Then either communicate this directly to the Python generator class, or just add these files all as dependencies in make so that it will show up in the output of "make -d". Too bad I’ve never programmed in Ruby or Python before! 1657917 5 darin 2020-06-01 08:21:36 -0700 It would be fine to revert r262310 until we figure out a way to deal with this. 1658012 6 darin 2020-06-01 13:03:17 -0700 Keith, do you have a preference for what we do next? 1658014 7 darin 2020-06-01 13:03:49 -0700 I guess you assigned this bug to me, so you want me to fix it, but do you have a preferred approach? 1658094 8 krollin 2020-06-01 15:32:10 -0700 This is low priority for now, until we determine an approach. 1678099 9 krollin 2020-08-05 15:02:11 -0700 Bug 212420 has been addressed with a different approach. The larger issue -- that of having a separate pass to ensure that the .xcfilelist files are up-to-date -- is covered in Radar 48250806. Therefore, nothing more to do here.