212583 2020-05-31 10:17:39 -0700 REGRESSION[r260844]: [GTK][WPE] Inspector GResource no longer updated after WebInspectorUI file updates 2020-06-02 17:58:02 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 210942 1 pnormand webkit-unassigned annulen aperez bugs-noreply cgarcia chris.reid don.olmstead dpino ews-watchlist fujii gyuyoung.kim jmason mcatanzaro ryuan.choi sergio stephan.szabo oldest_to_newest 1657795 0 pnormand 2020-05-31 10:17:39 -0700 +++ This bug was initially created as a clone of Bug #210942 +++ Reproducer: 1. Full clean GTK build from scratch 2. Edit GraphicsTabContentView.js, change the tabIcon to Gear.svg 3. Update your build 4. Start Minibrowser, open WebInspector Expected result: The graphics tab uses the gear icon Current result: The graphics tab uses the graphics icon Workaround: to force an update of the GResource: find WebKitBuild/ -name InspectorGResourceBundle.xml -exec rm {} \; and then rebuild... I've tried to revert r260844, doesn't change anything... 1658484 1 400865 chris.reid 2020-06-02 16:10:18 -0700 Created attachment 400865 patch This seems to fix the problem, the dependency on the WebInspectorUI target wasn't enough to trigger rebuilds. I've also tried clean GTK builds to make sure this works. 1658524 2 ews-feeder 2020-06-02 17:58:00 -0700 Committed r262466: <https://trac.webkit.org/changeset/262466> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400865. 400865 2020-06-02 16:10:18 -0700 2020-06-02 17:58:01 -0700 patch 212583.diff text/plain 1522 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZTYwNTZiZmNjODQuLjY2NDQyMDFjNWYyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDIwLTA2LTAyICBDaHJpc3RvcGhlciBSZWlkICA8Y2hyaXMucmVpZEBzb255LmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OW3IyNjA4NDRdOiBbR1RLXVtXUEVdIEluc3BlY3RvciBH UmVzb3VyY2Ugbm8gbG9uZ2VyIHVwZGF0ZWQgYWZ0ZXIgV2ViSW5zcGVjdG9yVUkgZmlsZSB1cGRh dGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI1 ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg YSBjbWFrZSBkZXBlbmRlbmN5IG9uIGluc3BlY3RvciByZXNvdXJjZSBzdGFtcCBzbyB0aGUgR2xp YgorICAgICAgICBJbnNwZWN0b3IgcmVzb3VyY2VzIHJlYnVpbGQgd2hlbiB0aGUgc3RhbXAgaXMg dXBkYXRlZC4KKworICAgICAgICAqIEluc3BlY3RvckdSZXNvdXJjZXMuY21ha2U6CisKIDIwMjAt MDUtMjIgIEphbWVzIFNhdmFnZSAgPGphbWVzLnNhdmFnZUBhcHBsZS5jb20+CiAKICAgICAgICAg Q3JlYXRlIFN3aWZ0IG92ZXJsYXkgZm9yIFdlYktpdCBmcmFtZXdvcmsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvSW5zcGVjdG9yR1Jlc291cmNlcy5jbWFrZSBiL1NvdXJjZS9XZWJLaXQvSW5z cGVjdG9yR1Jlc291cmNlcy5jbWFrZQppbmRleCBjNDcxZWNkZjQ1NS4uNzdlZWU5OTE0YTYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvSW5zcGVjdG9yR1Jlc291cmNlcy5jbWFrZQorKysgYi9T b3VyY2UvV2ViS2l0L0luc3BlY3RvckdSZXNvdXJjZXMuY21ha2UKQEAgLTIsNiArMiw3IEBAIG1h Y3JvKFdFQktJVF9CVUlMRF9JTlNQRUNUT1JfR1JFU09VUkNFUyBfZGVyaXZlZF9zb3VyY2VzX2Rp cikKICAgICBhZGRfY3VzdG9tX2NvbW1hbmQoCiAgICAgICAgIE9VVFBVVCAke19kZXJpdmVkX3Nv dXJjZXNfZGlyfS9JbnNwZWN0b3JHUmVzb3VyY2VCdW5kbGUueG1sCiAgICAgICAgIERFUEVORFMg V2ViSW5zcGVjdG9yVUkKKyAgICAgICAgICAgICAgICAke0NNQUtFX0JJTkFSWV9ESVJ9L2luc3Bl Y3Rvci1yZXNvdXJjZXMuc3RhbXAKICAgICAgICAgICAgICAgICAke1RPT0xTX0RJUn0vZ2xpYi9n ZW5lcmF0ZS1pbnNwZWN0b3ItZ3Jlc291cmNlLW1hbmlmZXN0LnB5CiAgICAgICAgIENPTU1BTkQg JHtQWVRIT05fRVhFQ1VUQUJMRX0gJHtUT09MU19ESVJ9L2dsaWIvZ2VuZXJhdGUtaW5zcGVjdG9y LWdyZXNvdXJjZS1tYW5pZmVzdC5weSAtLWlucHV0PSR7X2Rlcml2ZWRfc291cmNlc19kaXJ9L0lu c3BlY3RvclJlc291cmNlcyAtLW91dHB1dD0ke19kZXJpdmVkX3NvdXJjZXNfZGlyfS9JbnNwZWN0 b3JHUmVzb3VyY2VCdW5kbGUueG1sCiAgICAgICAgIFZFUkJBVElNCg==