212577 2020-05-30 22:41:08 -0700 Rename Signal::BadAccess to Signal::AccessFault. 2020-05-30 22:56:18 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212575 1 mark.lam mark.lam benjamin cdumez cmarcelo ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1657742 0 mark.lam 2020-05-30 22:41:08 -0700 This is needed because GTK port's X11 has a #define for BadAccess (in include/X11/X.h): #define BadAccess 10 /* depending on context: - key/button already grabbed - attempt to free an illegal cmap entry - attempt to store into a read-only color map entry. - attempt to modify the access control list from other than the local host. */ As a result, this breaks the GTK build when wtf/Signals.h is #include'd. 1657743 1 400695 mark.lam 2020-05-30 22:47:43 -0700 Created attachment 400695 proposed patch. 1657744 2 400695 ysuzuki 2020-05-30 22:52:54 -0700 Comment on attachment 400695 proposed patch. r=me 1657745 3 mark.lam 2020-05-30 22:55:28 -0700 Thanks for the review. Landed in r262355: <http://trac.webkit.org/r262355>. 1657746 4 webkit-bug-importer 2020-05-30 22:56:18 -0700 <rdar://problem/63803124> 400695 2020-05-30 22:47:43 -0700 2020-05-30 22:52:54 -0700 proposed patch. bug-212577.patch text/plain 7079 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYyMzU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTA1LTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS ZW5hbWUgU2lnbmFsOjpCYWRBY2Nlc3MgdG8gU2lnbmFsOjpBY2Nlc3NGYXVsdC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjU3NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9WTVRyYXBz LmNwcDoKKyAgICAgICAgKiB3YXNtL1dhc21GYXVsdFNpZ25hbEhhbmRsZXIuY3BwOgorICAgICAg ICAoSlNDOjpXYXNtOjplbmFibGVGYXN0TWVtb3J5KToKKwogMjAyMC0wNS0zMCAgWXVzdWtlIFN1 enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIFtKU0NdIGZvci1pbiBzaG91bGQg YWxsb2NhdGUgbmV3IHRlbXBvcmFyeSByZWdpc3RlciBmb3IgYmFzZQpJbmRleDogU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAJKHJldmlzaW9uIDI2MjM1MSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1ZNVHJhcHMuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xOTksNyArMTk5LDcgQEAgcHVibGljOgogICAgIHsKICAgICAgICAgc3RhdGljIHN0ZDo6b25j ZV9mbGFnIG9uY2U7CiAgICAgICAgIHN0ZDo6Y2FsbF9vbmNlKG9uY2UsIFtdIHsKLSAgICAgICAg ICAgIGluc3RhbGxTaWduYWxIYW5kbGVyKFNpZ25hbDo6QmFkQWNjZXNzLCBbXSAoU2lnbmFsLCBT aWdJbmZvJiwgUGxhdGZvcm1SZWdpc3RlcnMmIHJlZ2lzdGVycykgLT4gU2lnbmFsQWN0aW9uIHsK KyAgICAgICAgICAgIGluc3RhbGxTaWduYWxIYW5kbGVyKFNpZ25hbDo6QWNjZXNzRmF1bHQsIFtd IChTaWduYWwsIFNpZ0luZm8mLCBQbGF0Zm9ybVJlZ2lzdGVycyYgcmVnaXN0ZXJzKSAtPiBTaWdu YWxBY3Rpb24gewogICAgICAgICAgICAgICAgIGF1dG8gc2lnbmFsQ29udGV4dCA9IFNpZ25hbENv bnRleHQ6OnRyeUNyZWF0ZShyZWdpc3RlcnMpOwogICAgICAgICAgICAgICAgIGlmICghc2lnbmFs Q29udGV4dCkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIFNpZ25hbEFjdGlvbjo6Tm90SGFu ZGxlZDsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21GYXVsdFNpZ25hbEhh bmRsZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21G YXVsdFNpZ25hbEhhbmRsZXIuY3BwCShyZXZpc2lvbiAyNjIzNTEpCisrKyBTb3VyY2UvSmF2YVNj cmlwdENvcmUvd2FzbS9XYXNtRmF1bHRTaWduYWxIYW5kbGVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTctMjAxOSBBcHBsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTctMjAyMCBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBp biBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRp b24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMK QEAgLTExMyw3ICsxMTMsNyBAQCB2b2lkIGVuYWJsZUZhc3RNZW1vcnkoKQogICAgICAgICBpZiAo IU9wdGlvbnM6OnVzZVdlYkFzc2VtYmx5RmFzdE1lbW9yeSgpKQogICAgICAgICAgICAgcmV0dXJu OwogCi0gICAgICAgIGluc3RhbGxTaWduYWxIYW5kbGVyKFNpZ25hbDo6QmFkQWNjZXNzLCBbXSAo U2lnbmFsIHNpZ25hbCwgU2lnSW5mbyYgc2lnSW5mbywgUGxhdGZvcm1SZWdpc3RlcnMmIHVjb250 ZXh0KSB7CisgICAgICAgIGluc3RhbGxTaWduYWxIYW5kbGVyKFNpZ25hbDo6QWNjZXNzRmF1bHQs IFtdIChTaWduYWwgc2lnbmFsLCBTaWdJbmZvJiBzaWdJbmZvLCBQbGF0Zm9ybVJlZ2lzdGVycyYg dWNvbnRleHQpIHsKICAgICAgICAgICAgIHJldHVybiB0cmFwSGFuZGxlcihzaWduYWwsIHNpZ0lu Zm8sIHVjb250ZXh0KTsKICAgICAgICAgfSk7CiAKSW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9n Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNjIzNTEpCisr KyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMyIEBACisy MDIwLTA1LTMwICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBSZW5h bWUgU2lnbmFsOjpCYWRBY2Nlc3MgdG8gU2lnbmFsOjpBY2Nlc3NGYXVsdC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjU3NworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgbmVlZGVkIGJlY2F1 c2UgR1RLIHBvcnQncyBYMTEgaGFzIGEgI2RlZmluZSBmb3IgQmFkQWNjZXNzIChpbiBpbmNsdWRl L1gxMS9YLmgpOgorCisgICAgICAgICAgICAjZGVmaW5lIEJhZEFjY2VzcyAgICAgMTAgICAgLyog ZGVwZW5kaW5nIG9uIGNvbnRleHQ6CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIC0ga2V5L2J1dHRvbiBhbHJlYWR5IGdyYWJiZWQKKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgLSBhdHRlbXB0IHRvIGZyZWUgYW4gaWxsZWdhbCAKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjbWFwIGVudHJ5IAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtIGF0dGVtcHQgdG8gc3RvcmUgaW50 byBhIHJlYWQtb25seSAKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBjb2xvciBtYXAgZW50cnkuCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIC0gYXR0ZW1wdCB0byBtb2RpZnkgdGhlIGFjY2VzcyBjb250cm9sCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGlzdCBmcm9tIG90aGVyIHRoYW4gdGhlIGxv Y2FsIGhvc3QuCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICovCisK KyAgICAgICAgQXMgYSByZXN1bHQsIHRoaXMgd291bGQgYnJlYWsgdGhlIEdUSyBidWlsZCB3aGVu IHd0Zi9TaWduYWxzLmggaXMgI2luY2x1ZGUnZC4KKworICAgICAgICAqIHd0Zi90aHJlYWRzL1Np Z25hbHMuY3BwOgorICAgICAgICAoV1RGOjpmcm9tTWFjaEV4Y2VwdGlvbik6CisgICAgICAgIChX VEY6OnRvTWFjaE1hc2spOgorICAgICAgICAoV1RGOjpqc2NTaWduYWxIYW5kbGVyKToKKyAgICAg ICAgKiB3dGYvdGhyZWFkcy9TaWduYWxzLmg6CisgICAgICAgIChXVEY6OnRvU3lzdGVtU2lnbmFs KToKKyAgICAgICAgKFdURjo6ZnJvbVN5c3RlbVNpZ25hbCk6CisKIDIwMjAtMDUtMjkgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVc2UgY29y cmVjdCBlbmNvZGluZyB3aGVuIGNvbnZlcnRpbmcgYSBXVEY6OlVSTCB0byBDRlVSTFJlZgpJbmRl eDogU291cmNlL1dURi93dGYvdGhyZWFkcy9TaWduYWxzLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwCShyZXZpc2lvbiAyNjIzNTEpCisrKyBTb3Vy Y2UvV1RGL3d0Zi90aHJlYWRzL1NpZ25hbHMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjUsNyAr MTI1LDcgQEAgdm9pZCBzdGFydE1hY2hFeGNlcHRpb25IYW5kbGVyVGhyZWFkKCkKIHN0YXRpYyBT aWduYWwgZnJvbU1hY2hFeGNlcHRpb24oZXhjZXB0aW9uX3R5cGVfdCB0eXBlKQogewogICAgIHN3 aXRjaCAodHlwZSkgewotICAgIGNhc2UgRVhDX0JBRF9BQ0NFU1M6IHJldHVybiBTaWduYWw6OkJh ZEFjY2VzczsKKyAgICBjYXNlIEVYQ19CQURfQUNDRVNTOiByZXR1cm4gU2lnbmFsOjpBY2Nlc3NG YXVsdDsKICAgICBjYXNlIEVYQ19CQURfSU5TVFJVQ1RJT046IHJldHVybiBTaWduYWw6OklsbDsK ICAgICBkZWZhdWx0OiBicmVhazsKICAgICB9CkBAIC0xMzUsNyArMTM1LDcgQEAgc3RhdGljIFNp Z25hbCBmcm9tTWFjaEV4Y2VwdGlvbihleGNlcHRpbwogc3RhdGljIGV4Y2VwdGlvbl9tYXNrX3Qg dG9NYWNoTWFzayhTaWduYWwgc2lnbmFsKQogewogICAgIHN3aXRjaCAoc2lnbmFsKSB7Ci0gICAg Y2FzZSBTaWduYWw6OkJhZEFjY2VzczogcmV0dXJuIEVYQ19NQVNLX0JBRF9BQ0NFU1M7CisgICAg Y2FzZSBTaWduYWw6OkFjY2Vzc0ZhdWx0OiByZXR1cm4gRVhDX01BU0tfQkFEX0FDQ0VTUzsKICAg ICBjYXNlIFNpZ25hbDo6SWxsOiByZXR1cm4gRVhDX01BU0tfQkFEX0lOU1RSVUNUSU9OOwogICAg IGRlZmF1bHQ6IGJyZWFrOwogICAgIH0KQEAgLTE5OSw3ICsxOTksNyBAQCBrZXJuX3JldHVybl90 IGNhdGNoX21hY2hfZXhjZXB0aW9uX3JhaXNlCiAjZW5kaWYKIAogICAgIFNpZ0luZm8gaW5mbzsK LSAgICBpZiAoc2lnbmFsID09IFNpZ25hbDo6QmFkQWNjZXNzKSB7CisgICAgaWYgKHNpZ25hbCA9 PSBTaWduYWw6OkFjY2Vzc0ZhdWx0KSB7CiAgICAgICAgIEFTU0VSVF9VTlVTRUQoZGF0YUNvdW50 LCBkYXRhQ291bnQgPT0gMik7CiAgICAgICAgIGluZm8uZmF1bHRpbmdBZGRyZXNzID0gcmVpbnRl cnByZXRfY2FzdDx2b2lkKj4oZXhjZXB0aW9uRGF0YVsxXSk7CiAjaWYgQ1BVKEFERFJFU1M2NCkK QEAgLTM0NCw3ICszNDQsNyBAQCB2b2lkIGpzY1NpZ25hbEhhbmRsZXIoaW50IHNpZywgc2lnaW5m b190CiAgICAgfQogCiAgICAgU2lnSW5mbyBzaWdJbmZvOwotICAgIGlmIChzaWduYWwgPT0gU2ln bmFsOjpCYWRBY2Nlc3MpCisgICAgaWYgKHNpZ25hbCA9PSBTaWduYWw6OkFjY2Vzc0ZhdWx0KQog ICAgICAgICBzaWdJbmZvLmZhdWx0aW5nQWRkcmVzcyA9IGluZm8tPnNpX2FkZHI7CiAKICAgICBQ bGF0Zm9ybVJlZ2lzdGVycyYgcmVnaXN0ZXJzID0gcmVnaXN0ZXJzRnJvbVVDb250ZXh0KHJlaW50 ZXJwcmV0X2Nhc3Q8dWNvbnRleHRfdCo+KHVjb250ZXh0KSk7CkluZGV4OiBTb3VyY2UvV1RGL3d0 Zi90aHJlYWRzL1NpZ25hbHMuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi90aHJlYWRz L1NpZ25hbHMuaAkocmV2aXNpb24gMjYyMzUxKQorKysgU291cmNlL1dURi93dGYvdGhyZWFkcy9T aWduYWxzLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ5LDE1ICs0OSwxNSBAQCBlbnVtIGNsYXNzIFNp Z25hbCB7CiAgICAgLy8gVGhlc2Ugc2lnbmFscyB3aWxsIG9ubHkgY2hhaW4gaWYgd2UgZG9uJ3Qg aGF2ZSBhIGhhbmRsZXIgdGhhdCBjYW4gcHJvY2VzcyB0aGVtLiBJZiB0aGVyZSBpcyBub3RoaW5n CiAgICAgLy8gdG8gY2hhaW4gdG8gd2UgcmVzdG9yZSB0aGUgZGVmYXVsdCBoYW5kbGVyIGFuZCBj cmFzaC4KICAgICBJbGwsCi0gICAgQmFkQWNjZXNzLCAvLyBGb3IgcG9zaXggdGhpcyBpcyBib3Ro IFNJR1NFR1YgYW5kIFNJR0JVUwotICAgIE51bWJlck9mU2lnbmFscyA9IEJhZEFjY2VzcyArIDIs IC8vIEJhZEFjY2VzcyBpcyByZWFsbHkgdHdvIHNpZ25hbHMuCisgICAgQWNjZXNzRmF1bHQsIC8v IEZvciBwb3NpeCB0aGlzIGlzIGJvdGggU0lHU0VHViBhbmQgU0lHQlVTCisgICAgTnVtYmVyT2ZT aWduYWxzID0gQWNjZXNzRmF1bHQgKyAyLCAvLyBBY2Nlc3NGYXVsdCBpcyByZWFsbHkgdHdvIHNp Z25hbHMuCiAgICAgVW5rbm93biA9IE51bWJlck9mU2lnbmFscwogfTsKIAogaW5saW5lIHN0ZDo6 dHVwbGU8aW50LCBPcHRpb25hbDxpbnQ+PiB0b1N5c3RlbVNpZ25hbChTaWduYWwgc2lnbmFsKQog ewogICAgIHN3aXRjaCAoc2lnbmFsKSB7Ci0gICAgY2FzZSBTaWduYWw6OkJhZEFjY2VzczogcmV0 dXJuIHN0ZDo6bWFrZV90dXBsZShTSUdTRUdWLCBTSUdCVVMpOworICAgIGNhc2UgU2lnbmFsOjpB Y2Nlc3NGYXVsdDogcmV0dXJuIHN0ZDo6bWFrZV90dXBsZShTSUdTRUdWLCBTSUdCVVMpOwogICAg IGNhc2UgU2lnbmFsOjpJbGw6IHJldHVybiBzdGQ6Om1ha2VfdHVwbGUoU0lHSUxMLCBXVEY6Om51 bGxvcHQpOwogICAgIGNhc2UgU2lnbmFsOjpVc3I6IHJldHVybiBzdGQ6Om1ha2VfdHVwbGUoU0lH SUxMLCBXVEY6Om51bGxvcHQpOwogICAgIGRlZmF1bHQ6IGJyZWFrOwpAQCAtNjgsOCArNjgsOCBA QCBpbmxpbmUgc3RkOjp0dXBsZTxpbnQsIE9wdGlvbmFsPGludD4+IHRvCiBpbmxpbmUgU2lnbmFs IGZyb21TeXN0ZW1TaWduYWwoaW50IHNpZ25hbCkKIHsKICAgICBzd2l0Y2ggKHNpZ25hbCkgewot ICAgIGNhc2UgU0lHU0VHVjogcmV0dXJuIFNpZ25hbDo6QmFkQWNjZXNzOwotICAgIGNhc2UgU0lH QlVTOiByZXR1cm4gU2lnbmFsOjpCYWRBY2Nlc3M7CisgICAgY2FzZSBTSUdTRUdWOiByZXR1cm4g U2lnbmFsOjpBY2Nlc3NGYXVsdDsKKyAgICBjYXNlIFNJR0JVUzogcmV0dXJuIFNpZ25hbDo6QWNj ZXNzRmF1bHQ7CiAgICAgY2FzZSBTSUdJTEw6IHJldHVybiBTaWduYWw6OklsbDsKICAgICBjYXNl IFNJR1VTUjI6IHJldHVybiBTaWduYWw6OlVzcjsKICAgICBkZWZhdWx0OiByZXR1cm4gU2lnbmFs OjpVbmtub3duOwo=