<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>212558</bug_id>
          
          <creation_ts>2020-05-29 18:14:58 -0700</creation_ts>
          <short_desc>Show patch IDs in the drop down menu under the Patch Diff Screen</short_desc>
          <delta_ts>2020-06-01 17:49:19 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Website</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="lingho@apple.com">lingho</reporter>
          <assigned_to name="lingho@apple.com">lingho</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>ap</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>jond</cc>
    
    <cc>lingcherd_ho</cc>
    
    <cc>lingho</cc>
    
    <cc>ryanhaddad</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1657542</commentid>
    <comment_count>0</comment_count>
    <who name="lingho@apple.com">lingho</who>
    <bug_when>2020-05-29 18:14:58 -0700</bug_when>
    <thetext>Under the Patch Diff screen, the drop down menu showing diff between patches:

&quot;Differences between [patch description] and this patch&quot;

only shows the names of the multiple uploads of the patch which usually stay the same. So, there is no way to pick an exact version of the patch.

Adding the patch id to the value so they would appear like this:

336203 - Patch
336205 - Patch
336207 - Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1657996</commentid>
    <comment_count>1</comment_count>
      <attachid>400745</attachid>
    <who name="Ling Ho">lingcherd_ho</who>
    <bug_when>2020-06-01 12:14:24 -0700</bug_when>
    <thetext>Created attachment 400745
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658136</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2020-06-01 17:48:25 -0700</bug_when>
    <thetext>Committed r262401: &lt;https://trac.webkit.org/changeset/262401&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 400745.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1658137</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-06-01 17:49:19 -0700</bug_when>
    <thetext>&lt;rdar://problem/63851809&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>400745</attachid>
            <date>2020-06-01 12:14:24 -0700</date>
            <delta_ts>2020-06-01 17:48:26 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-212558-20200601121424.patch</filename>
            <type>text/plain</type>
            <size>1523</size>
            <attacher name="Ling Ho">lingcherd_ho</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMzg4CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndl
YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpp
bmRleCBhMWJmYmE5MTk4ODRlYTBiODUzODZjM2Y1NmZmZDJiMTQyYzM4ZWIzLi4zNTRhNTUwZmIy
NDg4NWRhMTJlNTkwZDQzMTg4ZmNmZTg2NmYxYmIyIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdz
LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFu
Z2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMC0wNi0wMSAgTGluZyBIbyAgPGxpbmdob0BhcHBs
ZS5jb20+CisKKyAgICAgICAgU2hvdyBwYXRjaCBJRHMgaW4gdGhlIGRyb3AgZG93biBtZW51IHVu
ZGVyIHRoZSBQYXRjaCBEaWZmIFNjcmVlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgKiB0ZW1wbGF0ZS9lbi9kZWZhdWx0L2F0dGFjaG1lbnQvZGlmZi1o
ZWFkZXIuaHRtbC50bXBsOgorCiAyMDIwLTAzLTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWlu
QGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgc3RhdHVzLWJ1YmJsZSBpZnJhbWUgZnJvbSBv
bGQgRVdTCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvdGVtcGxhdGUvZW4v
ZGVmYXVsdC9hdHRhY2htZW50L2RpZmYtaGVhZGVyLmh0bWwudG1wbCBiL1dlYnNpdGVzL2J1Z3Mu
d2Via2l0Lm9yZy90ZW1wbGF0ZS9lbi9kZWZhdWx0L2F0dGFjaG1lbnQvZGlmZi1oZWFkZXIuaHRt
bC50bXBsCmluZGV4IDJiM2UwZDc1ZDhhZWQ0MjE4OWU2NzczZTQzN2VmOTk0MjJhNDFiZjkuLjg1
OWUzOGY2NDI3YjA2NTVmNTdkMzBhMTIzNWM5MzNkNzlmNWY4ZjYgMTAwNjQ0Ci0tLSBhL1dlYnNp
dGVzL2J1Z3Mud2Via2l0Lm9yZy90ZW1wbGF0ZS9lbi9kZWZhdWx0L2F0dGFjaG1lbnQvZGlmZi1o
ZWFkZXIuaHRtbC50bXBsCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy90ZW1wbGF0ZS9l
bi9kZWZhdWx0L2F0dGFjaG1lbnQvZGlmZi1oZWFkZXIuaHRtbC50bXBsCkBAIC03MSw3ICs3MSw3
IEBAIEludGVyZGlmZiBvZiAjWyUgb2xkaWQgJV0gYW5kICNbJSBuZXdpZCAlXSBmb3IgWyUgdGVy
bXMuYnVnICVdICNbJSBidWdpZCAlXQogICAgICAgWyUgRk9SRUFDSCBwYXRjaCA9IG90aGVyX3Bh
dGNoZXMgJV0KICAgICAgICAgPG9wdGlvbiB2YWx1ZT0iWyUgcGF0Y2guaWQgJV0iCiAgICAgICAg
IFslIElGIHBhdGNoLnNlbGVjdGVkICVdIHNlbGVjdGVkWyUgRU5EICVdCi0gICAgICAgID5bJSBw
YXRjaC5kZXNjIEZJTFRFUiBodG1sICVdPC9vcHRpb24+CisgICAgICAgID5bJSBwYXRjaC5pZCAl
XSAtIFslIHBhdGNoLmRlc2MgRklMVEVSIGh0bWwgJV08L29wdGlvbj4KICAgICAgIFslIEVORCAl
XQogICAgICAgPC9zZWxlY3Q+CiAgICAgICBhbmQgdGhpcyBwYXRjaAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>