21254 2008-09-30 14:10:59 -0700 Get rid of the update() method on ScrollView 2008-09-30 14:32:13 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 21083 1 hyatt hyatt oldest_to_newest 93429 0 hyatt 2008-09-30 14:10:59 -0700 Get rid of the update() method on ScrollView 93430 1 23954 hyatt 2008-09-30 14:11:49 -0700 Created attachment 23954 Patch 93432 2 23954 sam 2008-09-30 14:27:29 -0700 Comment on attachment 23954 Patch + * ChangeLog: This is not necessary. - // The repaint method asks the host window to repaint a rect in the window's coordinate space. The + // The repaint meth%od asks the host window to repaint a rect in the window's coordinate space. %-added erroneously. r=me 93433 3 hyatt 2008-09-30 14:32:13 -0700 Fixed in r37113-4. 23954 2008-09-30 14:11:49 -0700 2008-09-30 14:27:29 -0700 Patch patch.txt text/plain 7770 hyatt SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM3MTEx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsNDEgQEAKKzIwMDgtMDkt MzAgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHRoZSB1 cGRhdGUoKSBtZXRob2Qgb24gU2Nyb2xsVmlldy4gIFRoaXMgbWV0aG9kIHdhcyBvbmx5IGNhbGxl ZCBpbiBvbmUgcGxhY2UsIGFuZCBpdHMgcHVycG9zZQorICAgICAgICB3YXMgdG8gY2F1c2UgYSBk aXNwbGF5L2ZsdXNoIHRvIGhhcHBlbi4gIEhlcmUgaXMgYSBicmVha2Rvd24gb2YgdGhlIG1ldGhv ZCB1c2Ugb24gZWFjaCBwbGF0Zm9ybToKKyAgICAgICAgKDEpIE5vdCB1c2VkIG9uIE1hYworICAg ICAgICAoMikgVXNlZCBvbiBXaW5kb3dzCisgICAgICAgICgzKSBVc2VkIG9uIFF0LCBidXQgaW1w bGVtZW50ZWQgaW5jb3JyZWN0bHkgdG8gY2F1c2UgYSBmdWxsIHJlcGFpbnQgZm9yIG5vIHJlYXNv bi4KKyAgICAgICAgKDQpIFVzZWQgb24gR3RrLCBidXQgaW1wbGVtZW50ZWQgaW5jb3JyZWN0bHkg dG8gY2F1c2UgYSBmdWxsIHJlcGFpbnQgZm9yIG5vIHJlYXNvbi4KKyAgICAgICAgKDUpIFVzZWQg b24gd3gsIGJ1dCBwcm9iYWJseSBub3QgbmVlZGVkIChzaW5jZSB3eCBoYXMgcGxhdGZvcm0gd2lk Z2V0cyBsaWtlIE1hYykuCisgICAgICAgIAorICAgICAgICBUaGVyZSBpcyBub3cgYSBwYWludCBt ZXRob2Qgb24gSG9zdFdpbmRvdyB0aGF0IGRvZXMgYW4gaW1tZWRpYXRlIG1vZGUgcmVwYWludCBv ZiBhbiBlbXB0eSByZWN0IHRvCisgICAgICAgIGNhdXNlIHRoZSBkaXNwbGF5L2ZsdXNoIHRvIGhh cHBlbiBpZiBuZWVkZWQgKHRodXMgc2F2aW5nIGFuIGV4dHJhIG1ldGhvZCBvbiBDaHJvbWVDbGll bnQpLgorICAgICAgICBXaXRoIHRoZSBjaGFuZ2VzIHRvIHRoaXMgbWV0aG9kLCB0aGUgbmV3IGJl aGF2aW9yIGlzIGFzIGZvbGxvd3M6CisgICAgICAgICgxKSBOb3QgdXNlZCBvbiBNYWMKKyAgICAg ICAgKDIpIFVzZWQgb24gV2luZG93cworICAgICAgICAoMykgTm90aGluZyBoYXBwZW5zIG9uIFF0 LCBidXQgb25seSBiZWNhdXNlIHRoZXkgaGF2ZSBub3QgaW1wbGVtZW50ZWQgaW1tZWRpYXRlIG1v ZGUgdXBkYXRpbmcuCisgICAgICAgICg0KSBHdGsgbm93IGJlaGF2ZXMgbGlrZSBXaW5kb3dzIGFu ZCB3aWxsIHByb2Nlc3MgdXBkYXRlcyBidXQgbm90IGRvIGFueSBpbmNvcnJlY3QgYWRkaXRpb25h bCBpbnZhbGlkYXRpb24uCisgICAgICAgICg1KSBOb3RoaW5nIGhhcHBlbnMgb24gd3guCisgICAg ICAgIAorICAgICAgICBUaGlzIG1ldGhvZCB3YXMgb3JpZ2luYWxseSBhZGRlZCBmb3IgV2luZG93 cy4gSXQncyBub3QgY2xlYXIgdGhlIGRpc3BsYXkvZmx1c2ggaXMgcmVhbGx5IGV2ZW4gbmVjZXNz YXJ5IG9uIHRoZSBvdGhlcgorICAgICAgICBwbGF0Zm9ybXMuICBBdCB0aGUgdmVyeSBsZWFzdCBz dG9wcGluZyB1bm5lY2Vzc2FyeSBmdWxsIGludmFsaWRhdGlvbnMgb24gUXQvR3RrIGlzIGEgZ29v ZCB0aGluZy4gOikKKyAgICAgICAgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdBUk5JTkc6IE5PIFRFU1QgQ0FTRVMgQURERUQgT1IgQ0hBTkdFRAorCisg ICAgICAgICogQ2hhbmdlTG9nOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpEb2N1bWVudDo6aW1wbGljaXRDbG9zZSk6CisgICAgICAgICogcGxhdGZvcm0v SG9zdFdpbmRvdy5oOgorICAgICAgICAoV2ViQ29yZTo6SG9zdFdpbmRvdzo6cGFpbnQpOgorICAg ICAgICAqIHBsYXRmb3JtL1Njcm9sbFZpZXcuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2Ny b2xsVmlld0d0ay5jcHA6CisgICAgICAgICogcGxhdGZvcm0vbWFjL1Njcm9sbFZpZXdNYWMubW06 CisgICAgICAgICogcGxhdGZvcm0vcXQvU2Nyb2xsVmlld1F0LmNwcDoKKyAgICAgICAgKiBwbGF0 Zm9ybS93aW4vU2Nyb2xsVmlld1dpbi5jcHA6CisgICAgICAgICogcGxhdGZvcm0vd3gvU2Nyb2xs Vmlld1d4LmNwcDoKKwogMjAwOC0wOS0zMCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBs ZS5jb20+CiAKICAgICAgICAgRm9jdXMgdGhlIERPTSB0cmVlIGluIHRoZSBXZWIgSW5zcGVjdG9y IHdoZW4gYSBub2RlIGlzIGluc3BlY3RlZC4KSW5kZXg6IGRvbS9Eb2N1bWVudC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gZG9tL0RvY3VtZW50LmNwcAkocmV2aXNpb24gMzcwODYpCisrKyBkb20vRG9jdW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjIzLDEzICsxNjIzLDEzIEBAIHZvaWQgRG9jdW1l bnQ6OmltcGxpY2l0Q2xvc2UoKQogICAgICAgICAgICAgCiAgICAgICAgIC8vIFBhaW50IGltbWVk aWF0ZWx5IGFmdGVyIHRoZSBkb2N1bWVudCBpcyByZWFkeS4gIFdlIGRvIHRoaXMgdG8gZW5zdXJl IHRoYXQgYW55IHRpbWVycyBzZXQgYnkgdGhlCiAgICAgICAgIC8vIG9ubG9hZCBkb24ndCBoYXZl IGEgY2hhbmNlIHRvIGZpcmUgYmVmb3JlIHdlIHdvdWxkIGhhdmUgcGFpbnRlZC4gIFRvIGF2b2lk IG92ZXItZmx1c2hpbmcgd2Ugb25seQotICAgICAgICAvLyB3b3JyeSBhYm91dCB0aGlzIGZvciB0 aGUgdG9wLWxldmVsIGRvY3VtZW50LgotI2lmICFQTEFURk9STShNQUMpCi0gICAgICAgIC8vIEZJ WE1FOiBUaGlzIGNhdXNlcyBhIHRpbWluZyBpc3N1ZSB3aXRoIHRoZSBkaXNwYXRjaERpZEZpbmlz aExvYWQgZGVsZWdhdGUgY2FsbGJhY2suCisgICAgICAgIC8vIHdvcnJ5IGFib3V0IHRoaXMgZm9y IHRoZSB0b3AtbGV2ZWwgZG9jdW1lbnQuICBGb3IgcGxhdGZvcm1zIHRoYXQgdXNlIG5hdGl2ZSB3 aWRnZXRzIGZvciBTY3JvbGxWaWV3cywgdGhpcworICAgICAgICAvLyBjYWxsIGRvZXMgbm90aGlu ZyAoTWFjLCB3eCkuCisgICAgICAgIC8vIEZJWE1FOiBUaGlzIGNhdXNlcyBhIHRpbWluZyBpc3N1 ZSB3aXRoIHRoZSBkaXNwYXRjaERpZEZpbmlzaExvYWQgZGVsZWdhdGUgY2FsbGJhY2sgb24gTWFj LCBzbyB0aGluaworICAgICAgICAvLyBiZWZvcmUgZW5hYmxpbmcgaXQsIGV2ZW4gaWYgTWFjIGJl Y29tZXMgdmlld2xlc3MgbGF0ZXIuCiAgICAgICAgIC8vIFNlZSA8cmRhcjovL3Byb2JsZW0vNTA5 MjM2MT4KICAgICAgICAgaWYgKHZpZXcoKSAmJiAhb3duZXJFbGVtZW50KCkpCi0gICAgICAgICAg ICB2aWV3KCktPnVwZGF0ZSgpOwotI2VuZGlmCisgICAgICAgICAgICB2aWV3KCktPmhvc3RXaW5k b3coKS0+cGFpbnQoKTsKICAgICB9CiAKICNpZiBQTEFURk9STShNQUMpCkluZGV4OiBwbGF0Zm9y bS9Ib3N0V2luZG93LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0vSG9zdFdpbmRvdy5oCShyZXZp c2lvbiAzNzEwNSkKKysrIHBsYXRmb3JtL0hvc3RXaW5kb3cuaAkod29ya2luZyBjb3B5KQpAQCAt MjcsNiArMjcsNyBAQAogI2RlZmluZSBIb3N0V2luZG93X2gKIAogI2luY2x1ZGUgPHd0Zi9Ob25j b3B5YWJsZS5oPgorI2luY2x1ZGUgIkludFJlY3QuaCIKIAogbmFtZXNwYWNlIFdlYkNvcmUgewog CkBAIC0zNywxMCArMzgsMTEgQEAgcHVibGljOgogICAgIEhvc3RXaW5kb3coKSB7fQogICAgIHZp cnR1YWwgfkhvc3RXaW5kb3coKSB7fQogCi0gICAgLy8gVGhlIHJlcGFpbnQgbWV0aG9kIGFza3Mg dGhlIGhvc3Qgd2luZG93IHRvIHJlcGFpbnQgYSByZWN0IGluIHRoZSB3aW5kb3cncyBjb29yZGlu YXRlIHNwYWNlLiAgVGhlCisgICAgLy8gVGhlIHJlcGFpbnQgbWV0aCVvZCBhc2tzIHRoZSBob3N0 IHdpbmRvdyB0byByZXBhaW50IGEgcmVjdCBpbiB0aGUgd2luZG93J3MgY29vcmRpbmF0ZSBzcGFj ZS4gIFRoZQogICAgIC8vIGNvbnRlbnRDaGFuZ2VkIGJvb2xlYW4gaW5kaWNhdGVzIHdoZXRoZXIg b3Igbm90IHRoZSBXZWIgcGFnZSBjb250ZW50IGFjdHVhbGx5IGNoYW5nZWQgKG9yIGlmIGEgcmVw YWludAogICAgIC8vIG9mIHVuY2hhbmdlZCBjb250ZW50IGlzIGJlaW5nIHJlcXVlc3RlZCkuCiAg ICAgdmlydHVhbCB2b2lkIHJlcGFpbnQoY29uc3QgSW50UmVjdCYsIGJvb2wgY29udGVudENoYW5n ZWQsIGJvb2wgaW1tZWRpYXRlID0gZmFsc2UpID0gMDsKKyAgICB2b2lkIHBhaW50KCkgeyByZXBh aW50KEludFJlY3QoKSwgZmFsc2UsIHRydWUpOyB9CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCkluZGV4OiBwbGF0Zm9ybS9TY3JvbGxWaWV3LmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0v U2Nyb2xsVmlldy5oCShyZXZpc2lvbiAzNzEwNSkKKysrIHBsYXRmb3JtL1Njcm9sbFZpZXcuaAko d29ya2luZyBjb3B5KQpAQCAtMTg3LDggKzE4Nyw2IEBAIHB1YmxpYzoKIHByb3RlY3RlZDoKICAg ICB2aXJ0dWFsIHZvaWQgcmVwYWludENvbnRlbnRSZWN0YW5nbGUoY29uc3QgSW50UmVjdCYsIGJv b2wgbm93ID0gZmFsc2UpOwogICAgIHZvaWQgdXBkYXRlV2luZG93UmVjdChjb25zdCBJbnRSZWN0 JiwgYm9vbCBub3cgPSBmYWxzZSk7Ci1wdWJsaWM6Ci0gICAgdm9pZCB1cGRhdGUoKTsKIAogcHJp dmF0ZToKICAgICBSZWZQdHI8U2Nyb2xsYmFyPiBtX2hvcml6b250YWxTY3JvbGxiYXI7CkluZGV4 OiBwbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxhdGZvcm0v Z3RrL1Njcm9sbFZpZXdHdGsuY3BwCShyZXZpc2lvbiAzNzEwNSkKKysrIHBsYXRmb3JtL2d0ay9T Y3JvbGxWaWV3R3RrLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg1LDE3ICsyODUsNiBAQCB2b2lk IFNjcm9sbFZpZXc6OnNldEd0a0FkanVzdG1lbnRzKEd0a0FkCiAgICAgdXBkYXRlU2Nyb2xsYmFy cyhtX3Njcm9sbE9mZnNldCk7CiB9CiAKLXZvaWQgU2Nyb2xsVmlldzo6dXBkYXRlKCkKLXsKLSAg ICBBU1NFUlQoY29udGFpbmluZ1dpbmRvdygpKTsKLQotICAgIGlmICghY29udGFpbmluZ1dpbmRv dygpIHx8ICFHVEtfV0lER0VUX1JFQUxJWkVEKGNvbnRhaW5pbmdXaW5kb3coKSkpCi0gICAgICAg IHJldHVybjsKLQotICAgIEdka1JlY3RhbmdsZSByZWN0ID0gZnJhbWVSZWN0KCk7Ci0gICAgZ2Rr X3dpbmRvd19pbnZhbGlkYXRlX3JlY3QoR1RLX1dJREdFVChjb250YWluaW5nV2luZG93KCkpLT53 aW5kb3csICZyZWN0LCB0cnVlKTsKLX0KLQogdm9pZCBTY3JvbGxWaWV3OjpzZXRGcmFtZVJlY3Qo Y29uc3QgSW50UmVjdCYgbmV3R2VvbWV0cnkpCiB7CiAgICAgQVNTRVJUKGlzRnJhbWVWaWV3KCkp OwpJbmRleDogcGxhdGZvcm0vbWFjL1Njcm9sbFZpZXdNYWMubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxh dGZvcm0vbWFjL1Njcm9sbFZpZXdNYWMubW0JKHJldmlzaW9uIDM3MTA1KQorKysgcGxhdGZvcm0v bWFjL1Njcm9sbFZpZXdNYWMubW0JKHdvcmtpbmcgY29weSkKQEAgLTE4MiwxNyArMTgyLDYgQEAg dm9pZCBTY3JvbGxWaWV3OjpwbGF0Zm9ybVJlcGFpbnRDb250ZW50UgogICAgIEVORF9CTE9DS19P QkpDX0VYQ0VQVElPTlM7CiB9CiAKLXZvaWQgU2Nyb2xsVmlldzo6dXBkYXRlKCkKLXsKLSAgICBC RUdJTl9CTE9DS19PQkpDX0VYQ0VQVElPTlM7Ci0KLSAgICBOU1ZpZXcgKnZpZXcgPSBwbGF0Zm9y bVdpZGdldCgpOwotICAgIFtbdmlldyB3aW5kb3ddIGRpc3BsYXlJZk5lZWRlZF07Ci0gICAgW1t2 aWV3IHdpbmRvd10gZmx1c2hXaW5kb3dJZk5lZWRlZF07Ci0KLSAgICBFTkRfQkxPQ0tfT0JKQ19F WENFUFRJT05TOwotfQotCiAvLyAiQ29udGFpbmluZyBXaW5kb3ciIG1lYW5zIHRoZSBOU1dpbmRv dydzIGNvb3JkIHN5c3RlbSwgd2hpY2ggaXMgb3JpZ2luIGxvd2VyIGxlZnQKIAogSW50UmVjdCBT Y3JvbGxWaWV3Ojpjb250ZW50c1RvU2NyZWVuKGNvbnN0IEludFJlY3QmIHJlY3QpIGNvbnN0Cklu ZGV4OiBwbGF0Zm9ybS9xdC9TY3JvbGxWaWV3UXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBsYXRmb3Jt L3F0L1Njcm9sbFZpZXdRdC5jcHAJKHJldmlzaW9uIDM3MTExKQorKysgcGxhdGZvcm0vcXQvU2Ny b2xsVmlld1F0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTgwLDE2ICsxODAsNiBAQCBTY3JvbGxW aWV3Ojp+U2Nyb2xsVmlldygpCiAgICAgZGVsZXRlIG1fZGF0YTsKIH0KIAotdm9pZCBTY3JvbGxW aWV3Ojp1cGRhdGUoKQotewotICAgIFFXaWRnZXQqIG5hdGl2ZSA9IHBsYXRmb3JtV2lkZ2V0KCk7 Ci0gICAgaWYgKG5hdGl2ZSkgewotICAgICAgICBuYXRpdmUtPnVwZGF0ZSgpOwotICAgICAgICBy ZXR1cm47Ci0gICAgfQotICAgIHJlcGFpbnRDb250ZW50UmVjdGFuZ2xlKEludFJlY3QoMCwgMCwg d2lkdGgoKSwgaGVpZ2h0KCkpKTsKLX0KLQogdm9pZCBTY3JvbGxWaWV3OjpzZXRGcmFtZVJlY3Qo Y29uc3QgSW50UmVjdCYgbmV3R2VvbWV0cnkpCiB7CiAgICAgSW50UmVjdCBvbGRHZW9tZXRyeSA9 IGZyYW1lUmVjdCgpOwpJbmRleDogcGxhdGZvcm0vd2luL1Njcm9sbFZpZXdXaW4uY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIHBsYXRmb3JtL3dpbi9TY3JvbGxWaWV3V2luLmNwcAkocmV2aXNpb24gMzcxMDUp CisrKyBwbGF0Zm9ybS93aW4vU2Nyb2xsVmlld1dpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIx NSwxMSArMjE1LDYgQEAgdm9pZCBTY3JvbGxWaWV3Ojp1cGRhdGVXaW5kb3dSZWN0KGNvbnN0IAog ICAgICAgICA6OlVwZGF0ZVdpbmRvdyhjb250YWluaW5nV2luZG93SGFuZGxlKTsKIH0KIAotdm9p ZCBTY3JvbGxWaWV3Ojp1cGRhdGUoKQotewotICAgIDo6VXBkYXRlV2luZG93KGNvbnRhaW5pbmdX aW5kb3coKSk7Ci19Ci0KIHZvaWQgU2Nyb2xsVmlldzo6c2V0RnJhbWVSZWN0KGNvbnN0IEludFJl Y3QmIG5ld0dlb21ldHJ5KQogewogICAgIEludFJlY3Qgb2xkR2VvbWV0cnkgPSBmcmFtZVJlY3Qo KTsKSW5kZXg6IHBsYXRmb3JtL3d4L1Njcm9sbFZpZXdXeC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gcGxh dGZvcm0vd3gvU2Nyb2xsVmlld1d4LmNwcAkocmV2aXNpb24gMzcxMDUpCisrKyBwbGF0Zm9ybS93 eC9TY3JvbGxWaWV3V3guY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNTAsMTQgKzE1MCw2IEBAIHZv aWQgU2Nyb2xsVmlldzo6cGxhdGZvcm1SZXBhaW50Q29udGVudFIKICAgICB9CiB9CiAKLXZvaWQg U2Nyb2xsVmlldzo6dXBkYXRlKCkKLXsKLSAgICB3eFdpbmRvdyogd2luID0gcGxhdGZvcm1XaWRn ZXQoKTsKLSAgICBpZiAod2luKQotICAgICAgICB3aW4tPlVwZGF0ZSgpOwotfQotCi0KIEludFJl Y3QgU2Nyb2xsVmlldzo6cGxhdGZvcm1WaXNpYmxlQ29udGVudFJlY3QoYm9vbCBpbmNsdWRlU2Ny b2xsYmFycykgY29uc3QKIHsKICAgICAvLyBGSVhNRTogTmVlZCB0byBzdXBwb3J0IGluY2x1ZGVT Y3JvbGxiYXJzIG9wdGlvbi4K