212526 2020-05-29 08:08:31 -0700 Add a check for errors when computing a utf string in jsc shell's runInteractive(). 2020-05-29 09:01:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1657257 0 mark.lam 2020-05-29 08:08:31 -0700 <rdar://problem/63757892> 1657260 1 400582 mark.lam 2020-05-29 08:19:05 -0700 Created attachment 400582 proposed patch. 1657265 2 400584 mark.lam 2020-05-29 08:28:18 -0700 Created attachment 400584 proposed patch. 1657268 3 400584 msaboff 2020-05-29 08:33:10 -0700 Comment on attachment 400584 proposed patch. r=me 1657278 4 ews-feeder 2020-05-29 09:01:10 -0700 Committed r262296: <https://trac.webkit.org/changeset/262296> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400584. 400582 2020-05-29 08:19:05 -0700 2020-05-29 08:21:16 -0700 proposed patch. bug-212526.patch text/plain 1758 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYyMjk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTA1LTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgYSBjaGVjayBmb3IgZXJyb3JzIHdoZW4gY29tcHV0aW5nIGEgdXRmIHN0cmluZyBpbiBqc2Mg c2hlbGwncyBydW5JbnRlcmFjdGl2ZSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNTI2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82Mzc1Nzg5 Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpz Yy5jcHA6CisgICAgICAgIChydW5JbnRlcmFjdGl2ZSk6CisKIDIwMjAtMDUtMjggIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFkZCBt aXNzaW5nIGNvbmRpdGlvbiBndWFyZHMgd2hlbiBnZW5lcmF0aW5nIG9iamMgcHJvdG9jb2wgZmls ZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCShyZXZpc2lvbiAyNjIyOTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg2MSw3ICsyODYxLDE1 IEBAIHN0YXRpYyB2b2lkIHJ1bkludGVyYWN0aXZlKEdsb2JhbE9iamVjdCoKICAgICAgICAgQ1N0 cmluZyByZXN1bHQ7CiAgICAgICAgIGlmIChldmFsdWF0aW9uRXhjZXB0aW9uKSB7CiAgICAgICAg ICAgICBmcHV0cygiRXhjZXB0aW9uOiAiLCBzdGRvdXQpOwotICAgICAgICAgICAgcmVzdWx0ID0g ZXZhbHVhdGlvbkV4Y2VwdGlvbi0+dmFsdWUoKS50b1dURlN0cmluZyhnbG9iYWxPYmplY3QpLnV0 ZjgoKTsKKyAgICAgICAgICAgIGF1dG8gdmFsdWUgPSBldmFsdWF0aW9uRXhjZXB0aW9uLT52YWx1 ZSgpOworICAgICAgICAgICAgYXV0byB3dGZTdHJpbmcgPSB2YWx1ZS50b1dURlN0cmluZyhnbG9i YWxPYmplY3QpOworICAgICAgICAgICAgYXV0byB1dGY4ID0gd3RmU3RyaW5nLnRyeUdldFV0Zjgo KTsKKyAgICAgICAgICAgIGlmICh1dGY4KQorICAgICAgICAgICAgICAgIHJlc3VsdCA9IHV0Zjgu dmFsdWUoKTsKKyAgICAgICAgICAgIGVsc2UgaWYgKHV0ZjguZXJyb3IoKSA9PSBVVEY4Q29udmVy c2lvbkVycm9yOjpPdXRPZk1lbW9yeSkKKyAgICAgICAgICAgICAgICByZXN1bHQgPSAiT3V0T2ZN ZW1vcnkgd2hpbGUgcHJvY2Vzc2luZyBlcnJvciBzdHJpbmciOworICAgICAgICAgICAgZWxzZQor ICAgICAgICAgICAgICAgIHJlc3VsdCA9ICJFcnJvciB3aGlsZSBwcm9jZXNzaW5nIGVycm9yIHN0 cmluZyI7CiAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgcmVzdWx0ID0gcmV0dXJuVmFsdWUu dG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0KS51dGY4KCk7CiAgICAgICAgIGZ3cml0ZShyZXN1bHQu ZGF0YSgpLCBzaXplb2YoY2hhciksIHJlc3VsdC5sZW5ndGgoKSwgc3Rkb3V0KTsK 400584 2020-05-29 08:28:18 -0700 2020-05-29 09:01:10 -0700 proposed patch. bug-212526.patch text/plain 2022 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjYyMjk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIwLTA1LTI5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgYSBjaGVjayBmb3IgZXJyb3JzIHdoZW4gY29tcHV0aW5nIGEgdXRmIHN0cmluZyBpbiBqc2Mg c2hlbGwncyBydW5JbnRlcmFjdGl2ZSgpLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjEyNTI2CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS82Mzc1Nzg5 Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGpz Yy5jcHA6CisgICAgICAgIChydW5JbnRlcmFjdGl2ZSk6CisKIDIwMjAtMDUtMjggIERldmluIFJv dXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFkZCBt aXNzaW5nIGNvbmRpdGlvbiBndWFyZHMgd2hlbiBnZW5lcmF0aW5nIG9iamMgcHJvdG9jb2wgZmls ZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9qc2MuY3BwCShyZXZpc2lvbiAyNjIyOTMpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvanNjLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg1OCwxMiArMjg1OCwy MCBAQCBzdGF0aWMgdm9pZCBydW5JbnRlcmFjdGl2ZShHbG9iYWxPYmplY3QqCiAgICAgICAgIE5h a2VkUHRyPEV4Y2VwdGlvbj4gZXZhbHVhdGlvbkV4Y2VwdGlvbjsKICAgICAgICAgSlNWYWx1ZSBy ZXR1cm5WYWx1ZSA9IGV2YWx1YXRlKGdsb2JhbE9iamVjdCwganNjU291cmNlKGxpbmUsIHNvdXJj ZU9yaWdpbiwgc291cmNlT3JpZ2luLnN0cmluZygpKSwgSlNWYWx1ZSgpLCBldmFsdWF0aW9uRXhj ZXB0aW9uKTsKICNlbmRpZgotICAgICAgICBDU3RyaW5nIHJlc3VsdDsKKyAgICAgICAgRXhwZWN0 ZWQ8Q1N0cmluZywgVVRGOENvbnZlcnNpb25FcnJvcj4gdXRmODsKICAgICAgICAgaWYgKGV2YWx1 YXRpb25FeGNlcHRpb24pIHsKICAgICAgICAgICAgIGZwdXRzKCJFeGNlcHRpb246ICIsIHN0ZG91 dCk7Ci0gICAgICAgICAgICByZXN1bHQgPSBldmFsdWF0aW9uRXhjZXB0aW9uLT52YWx1ZSgpLnRv V1RGU3RyaW5nKGdsb2JhbE9iamVjdCkudXRmOCgpOworICAgICAgICAgICAgdXRmOCA9IGV2YWx1 YXRpb25FeGNlcHRpb24tPnZhbHVlKCkudG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0KS50cnlHZXRV dGY4KCk7CiAgICAgICAgIH0gZWxzZQotICAgICAgICAgICAgcmVzdWx0ID0gcmV0dXJuVmFsdWUu dG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0KS51dGY4KCk7CisgICAgICAgICAgICB1dGY4ID0gcmV0 dXJuVmFsdWUudG9XVEZTdHJpbmcoZ2xvYmFsT2JqZWN0KS50cnlHZXRVdGY4KCk7CisKKyAgICAg ICAgQ1N0cmluZyByZXN1bHQ7CisgICAgICAgIGlmICh1dGY4KQorICAgICAgICAgICAgcmVzdWx0 ID0gdXRmOC52YWx1ZSgpOworICAgICAgICBlbHNlIGlmICh1dGY4LmVycm9yKCkgPT0gVVRGOENv bnZlcnNpb25FcnJvcjo6T3V0T2ZNZW1vcnkpCisgICAgICAgICAgICByZXN1bHQgPSAiT3V0T2ZN ZW1vcnkgd2hpbGUgcHJvY2Vzc2luZyBzdHJpbmciOworICAgICAgICBlbHNlCisgICAgICAgICAg ICByZXN1bHQgPSAiRXJyb3Igd2hpbGUgcHJvY2Vzc2luZyBzdHJpbmciOwogICAgICAgICBmd3Jp dGUocmVzdWx0LmRhdGEoKSwgc2l6ZW9mKGNoYXIpLCByZXN1bHQubGVuZ3RoKCksIHN0ZG91dCk7 CiAgICAgICAgIHB1dGNoYXIoJ1xuJyk7CiAK