212516 2020-05-29 03:00:31 -0700 [WebXR] WebXRSystem::unregisterSimulatedXRDeviceForTesting() ASSERTs in m_immersiveDevices.contains(device) 2020-05-29 06:19:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 212513 1 svillar svillar dino svillar webkit-bug-importer youennf zan oldest_to_newest 1657192 0 svillar 2020-05-29 03:00:31 -0700 [WebXR] WebXRSystem::unregisterSimulatedXRDeviceForTesting() ASSERTs in m_immersiveDevices.contains(device) 1657193 1 400562 svillar 2020-05-29 03:04:58 -0700 Created attachment 400562 Patch 1657200 2 400562 zan 2020-05-29 03:24:10 -0700 Comment on attachment 400562 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400562&action=review > Source/WebCore/Modules/webxr/WebXRSystem.cpp:457 > + UNUSED_VARIABLE(removed); > + ASSERT(removed || m_inlineXRDevice == &device); Can be folded into ASSERT_UNUSED. 1657235 3 svillar 2020-05-29 06:18:13 -0700 Committed r262291: <https://trac.webkit.org/changeset/262291> 1657236 4 webkit-bug-importer 2020-05-29 06:19:17 -0700 <rdar://problem/63757315> 400562 2020-05-29 03:04:58 -0700 2020-05-29 03:24:10 -0700 Patch bug-212516-20200529120457.patch text/plain 3852 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMjgyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGM2NjY4YTZmM2EzYTNj Y2YyYzM4OWE1N2U5MmRiM2ZhMTcwODU1NS4uODVkZjZkYjQzOGEwYTdkNzU5OTdlZmRmNTk3NDli N2U4YWQyZDc0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIwLTA1LTI5ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXZWJYUl0g V2ViWFJTeXN0ZW06OnVucmVnaXN0ZXJTaW11bGF0ZWRYUkRldmljZUZvclRlc3RpbmcoKSBBU1NF UlRzIGluIG1faW1tZXJzaXZlRGV2aWNlcy5jb250YWlucyhkZXZpY2UpCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI1MTYKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgQVNTRVJUIHRoYXQgd2FzIGZh aWxpbmcgd2FzIHdyb25nLiBJdCB3YXMgYXNzdW1pbmcgdGhhdCBldmVyeSBzaW11bGF0ZWQgZGV2 aWNlIHNob3VsZCBiZSBwYXJ0IG9mIHRoZSBsaXN0CisgICAgICAgIG9mIGltbWVyc2l2ZSBkZXZp Y2VzLiBUaGF0J3Mgd3JvbmcsIGFzIGRldmljZXMgb25seSBzdXBwb3J0aW5nIGlubGluZSBzZXNz aW9ucyBhcmUgbm90IGluIHRoYXQgbGlzdC4KKworICAgICAgICBBcGFydCBmcm9tIHRoYXQsIGZh a2UgZGV2aWNlcyB3ZXJlIG5vdCByZW1vdmVkIGZyb20gdGhlIGxpc3Qgb2YgYXZhaWxhYmxlIGRl dmljZXMgaW4gV2ViWFJUZXN0IGFmdGVyCisgICAgICAgIGRpc2Nvbm5lY3RpbmcgdGhlbSBhbGwu IFRoYXQgY291bGQgcG90ZW50aWFsbHkgY2F1c2UgZmxha2luZXNzIGluIHRoZSB0ZXN0cy4KKwor ICAgICAgICBObyBuZXcgdGVzdCByZXF1aXJlZCBhcyB0aGUgY3VycmVudCB0ZXN0cyB3ZXJlIHBy b3Blcmx5IGRldGVjdGluZyB0aGUgaXNzdWUuCisKKyAgICAgICAgKiBNb2R1bGVzL3dlYnhyL1dl YlhSU3lzdGVtLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYlhSU3lzdGVtOjpyZWdpc3RlclNp bXVsYXRlZFhSRGV2aWNlRm9yVGVzdGluZyk6IFVzZSBYUlNlc3Npb25Nb2RlIGRpcmVjdGx5Lgor ICAgICAgICAoV2ViQ29yZTo6V2ViWFJTeXN0ZW06OnVucmVnaXN0ZXJTaW11bGF0ZWRYUkRldmlj ZUZvclRlc3RpbmcpOiBGaXhlZCB0aGUgQVNTRVJULiBBIHNpbXVsYXRlZCBkZXZpY2UKKyAgICAg ICAgbWlnaHQgbm90IGJlIGluIHRoZSBsaXN0IG9mIGltbWVyc2l2ZSBkZXZpY2VzIGlmIG9ubHkg c3VwcG9ydHMgaW5saW5lIHNlc3Npb25zLgorICAgICAgICAqIHRlc3RpbmcvV2ViWFJUZXN0LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OldlYlhSVGVzdDo6ZGlzY29ubmVjdEFsbERldmljZXMpOiBD bGVhciB0aGUgbGlzdCBvZiBkZXZpY2VzIGFmdGVyIGRpc2Nvbm5lY3RpbmcuCisKIDIwMjAtMDUt MjggIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgogCiAgICAgICAgIFtBcHBsZSBQYXld IEJ1dHRvbnMgcmVuZGVyIHdpdGggYSBjb3JuZXIgcmFkaXVzIG9mIFBLQXBwbGVQYXlCdXR0b25E ZWZhdWx0Q29ybmVyUmFkaXVzIGV2ZW4gd2hlbiBleHBsaWNpdGx5IHNwZWNpZnlpbmcgImJvcmRl ci1yYWRpdXM6IDBweCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2VieHIv V2ViWFJTeXN0ZW0uY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUlN5c3Rl bS5jcHAKaW5kZXggZjg4ZTI3NDk3MGE4MWY1MzljOTFiYmMwMGQ3NzdkNDg3OTNlOWMyMy4uMzlh YmEwZTgwYzA1YmM2MTYxZDE3MDNiYTNhYTg4NGZkYjIwNDI0YiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvTW9kdWxlcy93ZWJ4ci9XZWJYUlN5c3RlbS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJ4ci9XZWJYUlN5c3RlbS5jcHAKQEAgLTQzOSwxMSArNDM5LDExIEBAIHZv aWQgV2ViWFJTeXN0ZW06OnJlZ2lzdGVyU2ltdWxhdGVkWFJEZXZpY2VGb3JUZXN0aW5nKFBsYXRm b3JtWFI6OkRldmljZSYgZGV2aWNlCiAgICAgaWYgKCFSdW50aW1lRW5hYmxlZEZlYXR1cmVzOjpz aGFyZWRGZWF0dXJlcygpLndlYlhSRW5hYmxlZCgpKQogICAgICAgICByZXR1cm47CiAgICAgbV90 ZXN0aW5nRGV2aWNlcysrOwotICAgIGlmIChkZXZpY2Uuc3VwcG9ydHMoUGxhdGZvcm1YUjo6U2Vz c2lvbk1vZGU6OkltbWVyc2l2ZVZyKSB8fCBkZXZpY2Uuc3VwcG9ydHMoUGxhdGZvcm1YUjo6U2Vz c2lvbk1vZGU6OkltbWVyc2l2ZUFyKSkgeworICAgIGlmIChkZXZpY2Uuc3VwcG9ydHMoWFJTZXNz aW9uTW9kZTo6SW1tZXJzaXZlVnIpIHx8IGRldmljZS5zdXBwb3J0cyhYUlNlc3Npb25Nb2RlOjpJ bW1lcnNpdmVBcikpIHsKICAgICAgICAgbV9pbW1lcnNpdmVEZXZpY2VzLmFkZChkZXZpY2UpOwog ICAgICAgICBtX2FjdGl2ZUltbWVyc2l2ZURldmljZSA9IG1ha2VXZWFrUHRyKGRldmljZSk7CiAg ICAgfQotICAgIGlmIChkZXZpY2Uuc3VwcG9ydHMoUGxhdGZvcm1YUjo6U2Vzc2lvbk1vZGU6Oklu bGluZSkpCisgICAgaWYgKGRldmljZS5zdXBwb3J0cyhYUlNlc3Npb25Nb2RlOjpJbmxpbmUpKQog ICAgICAgICBtX2lubGluZVhSRGV2aWNlID0gbWFrZVdlYWtQdHIoZGV2aWNlKTsKIH0KIApAQCAt NDUxLDkgKzQ1MSwxMCBAQCB2b2lkIFdlYlhSU3lzdGVtOjp1bnJlZ2lzdGVyU2ltdWxhdGVkWFJE ZXZpY2VGb3JUZXN0aW5nKFBsYXRmb3JtWFI6OkRldmljZSYgZGV2aQogewogICAgIGlmICghUnVu dGltZUVuYWJsZWRGZWF0dXJlczo6c2hhcmVkRmVhdHVyZXMoKS53ZWJYUkVuYWJsZWQoKSkKICAg ICAgICAgcmV0dXJuOwotICAgIEFTU0VSVChtX2ltbWVyc2l2ZURldmljZXMuY29udGFpbnMoZGV2 aWNlKSk7CiAgICAgQVNTRVJUKG1fdGVzdGluZ0RldmljZXMpOwotICAgIG1faW1tZXJzaXZlRGV2 aWNlcy5yZW1vdmUoZGV2aWNlKTsKKyAgICBib29sIHJlbW92ZWQgPSBtX2ltbWVyc2l2ZURldmlj ZXMucmVtb3ZlKGRldmljZSk7CisgICAgVU5VU0VEX1ZBUklBQkxFKHJlbW92ZWQpOworICAgIEFT U0VSVChyZW1vdmVkIHx8IG1faW5saW5lWFJEZXZpY2UgPT0gJmRldmljZSk7CiAgICAgaWYgKG1f YWN0aXZlSW1tZXJzaXZlRGV2aWNlID09ICZkZXZpY2UpCiAgICAgICAgIG1fYWN0aXZlSW1tZXJz aXZlRGV2aWNlID0gbnVsbHB0cjsKICAgICBpZiAobV9pbmxpbmVYUkRldmljZSA9PSAmZGV2aWNl KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9XZWJYUlRlc3QuY3BwIGIvU291 cmNlL1dlYkNvcmUvdGVzdGluZy9XZWJYUlRlc3QuY3BwCmluZGV4IDIwYjJjYjVjMjA0ZTNlMmJm Y2YzZjMwZTc2NWM1NGYzZWE5ZWUzNmUuLmEyMDc5MThhZmZiNTliYmI4ZWNkZTk0MWE5ZDk2ZGI0 OGE5YWEzZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvV2ViWFJUZXN0LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL1dlYlhSVGVzdC5jcHAKQEAgLTExMSw2ICsx MTEsNyBAQCB2b2lkIFdlYlhSVGVzdDo6ZGlzY29ubmVjdEFsbERldmljZXMoRE9NUHJvbWlzZURl ZmVycmVkPHZvaWQ+JiYgcHJvbWlzZSkKIHsKICAgICBmb3IgKGF1dG8mIGRldmljZSA6IG1fZGV2 aWNlcykKICAgICAgICAgbV9jb250ZXh0LT51bnJlZ2lzdGVyU2ltdWxhdGVkWFJEZXZpY2VGb3JU ZXN0aW5nKGRldmljZS0+c2ltdWxhdGVkWFJEZXZpY2UoKSk7CisgICAgbV9kZXZpY2VzLmNsZWFy KCk7CiAgICAgcHJvbWlzZS5yZXNvbHZlKCk7CiB9CiAK