212515 2020-05-29 02:38:22 -0700 Adjust <link rel=stylesheet disabled> handling 2023-08-23 21:44:13 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified NEW https://bugs.webkit.org/show_bug.cgi?id=243540 https://bugs.webkit.org/show_bug.cgi?id=260642 BrowserCompat, InRadar, WPTImpact P2 Normal --- 1 annevk webkit-unassigned ahmad.saleem792 bfulgham cyb.ai.815 emilio mike ntim webkit-bug-importer oldest_to_newest 1657188 0 annevk 2020-05-29 02:38:22 -0700 See https://github.com/web-platform-tests/wpt/pull/22645 and https://github.com/whatwg/html/pull/4519. 1879857 1 webkit-bug-importer 2022-07-01 11:20:38 -0700 <rdar://problem/96304439> 1879858 2 bfulgham 2022-07-01 11:20:49 -0700 It looks like we fail a couple of these tests (though we pass most). Importing. 1960538 3 ahmad.saleem792 2023-06-08 06:31:26 -0700 We are only browser failing but just two tests: https://wpt.fyi/results/css/cssom?label=master&label=experimental&aligned=&q=cssom%2Fhtmllinkelement- 1973080 4 ahmad.saleem792 2023-08-23 13:47:04 -0700 Blink Commit - https://chromium-review.googlesource.com/c/chromium/src/+/2216701 1973171 5 mike 2023-08-23 19:09:29 -0700 (In reply to Ahmad Saleem from comment #3) > We are only browser failing but just two tests: > > https://wpt.fyi/results/css/ > cssom?label=master&label=experimental&aligned=&q=cssom%2Fhtmllinkelement- The patch in https://github.com/WebKit/WebKit/pull/17001 gets WebKit passing all those tests. But that patch isn’t a full implementation of the spec requirements in https://github.com/whatwg/html/pull/4519. I have a separate patch that implements the “explicitly enabled” boolean flag specified in https://github.com/whatwg/html/pull/4519 — but I don’t yet know how to test it, or if WebKit even needs it. I say that because HTMLLinkElement-disabled-003.html to HTMLLinkElement-disabled-007.html there all include some tests for the “explicitly enabled” requirements — but since WebKit is already passing all those tests, then it seems like either those tests aren’t correctly testing the “explicitly enabled” requirements, or else the WebKit implementation somehow already conforms to those requirements. 1973176 6 emilio 2023-08-23 20:34:16 -0700 The "explicitly enabled" boolean flag is implemented as m_disabledState == EnabledViaScript in WebKit. 1973183 7 mike 2023-08-23 21:01:01 -0700 (In reply to Emilio Cobos Álvarez (:emilio) from comment #6) > The "explicitly enabled" boolean flag is implemented as m_disabledState == > EnabledViaScript in WebKit. aha, I see now — thanks much 1973186 8 ntim 2023-08-23 21:44:13 -0700 Should this be duped to bug 260642?