21251 2008-09-30 13:09:01 -0700 Focus the DOM tree when a node is selected 2008-09-30 13:58:32 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 timothy timothy aroben kmccullough timothy oldest_to_newest 93412 0 timothy 2008-09-30 13:09:01 -0700 We should focus the DOM tree when a node is selected in the tree. So when the search field has focus the focus moves so the arrow keys work. This can happen when using the new find in page feature. 93414 1 23951 timothy 2008-09-30 13:15:17 -0700 Created attachment 23951 Proposed patch 93418 2 23951 ggaren 2008-09-30 13:35:01 -0700 Comment on attachment 23951 Proposed patch r=me 93425 3 timothy 2008-09-30 13:58:32 -0700 Landed in r37111. 23951 2008-09-30 13:15:17 -0700 2008-09-30 13:35:01 -0700 Proposed patch 0001--Focus-the-DOM-tree-in-the-Web-Inspector-when.patch text/plain 4150 timothy RnJvbSBlZWZmNjk2OGFhYTdmNTUwMGNiNDA0ZTM2YzYzNWNiYTJjYTMwNDQ4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUdWUsIDMwIFNlcCAyMDA4IDEzOjE0OjQ3IC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gICAg ICAgICBGb2N1cyB0aGUgRE9NIHRyZWUgaW4gdGhlIFdlYiBJbnNwZWN0b3Igd2hlbiBhIG5vZGUg aXMgaW5zcGVjdGVkLgogICAgICAgICBTbyB3aGVuIHRoZSBzZWFyY2ggZmllbGQgaGFzIGZvY3Vz LCB0aGUgZm9jdXMgbW92ZXMgdG8gdGhlIHRyZWUsCiAgICAgICAgIGFsbG93aW5nIHRoZSBhcnJv dyBrZXlzIHdvcmsuIFRoaXMgY2FuIGhhcHBlbiB3aGVuIHVzaW5nIHRoZSBuZXcKICAgICAgICAg ZmluZCBpbiBwYWdlIGZlYXR1cmUuCgogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMTI1MQoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K CiAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9FbGVtZW50c1BhbmVsLmpzOgogICAgICAgIChXZWJJ bnNwZWN0b3IuRWxlbWVudHNQYW5lbCk6IFNldCBjdXJyZW50Rm9jdXNFbGVtZW50IHRvCiAgICAg ICAgdGhlIG1haW4tcGFuZWxzIGVsZW1lbnQgaWYgdGhlIHBhbmVsIGlzIHZpc2libGUuCiAgICAg ICAgKFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZS51cGRhdGVCcmVhZGNydW1i KToKICAgICAgICBSZW1vdmUgYSBzZXQgb2YgY3VycmVudEZvY3VzRWxlbWVudCBzaW5jZSB0aGlz IG1vdmVkLgogICAgICAgICogcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzOgogICAgICAgIChX ZWJJbnNwZWN0b3Iuc2V0IGN1cnJlbnRGb2N1c0VsZW1lbnQpOiBBbHdheXMgZm9jdXMgdGhlIGVs ZW1lbnQuCiAgICAgICAgVGhpcyBlbnN1cmVzIHRoYXQgd2hlbiBmb2N1cyBjaGFuZ2VzIGluIHRo ZSBwYWdlIGFuZCB3ZSBkb24ndAogICAgICAgIGNhdGNoIGl0LCB3ZSB3aWxsIHN0aWxsIGZvY3Vz IHRoZSBlbGVtZW50cyBldmVuIGlmIHdlIHRoaW5rIGl0CiAgICAgICAgd2FzIGFscmVhZHkgZm9j dXNlZC4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIy ICsrKysrKysrKysrKysrKysrKysrKysKIFdlYkNvcmUvcGFnZS9pbnNwZWN0b3IvRWxlbWVudHNQ YW5lbC5qcyB8ICAgIDUgKysrLS0KIFdlYkNvcmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpz ICAgICB8ICAgIDYgKystLS0tCiAzIGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDYg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNjJjNjI3Li44OTJhZjUyIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5n ZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDA4LTA5LTMw ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAorICAgICAgICBGb2N1cyB0 aGUgRE9NIHRyZWUgaW4gdGhlIFdlYiBJbnNwZWN0b3Igd2hlbiBhIG5vZGUgaXMgaW5zcGVjdGVk LgorICAgICAgICBTbyB3aGVuIHRoZSBzZWFyY2ggZmllbGQgaGFzIGZvY3VzLCB0aGUgZm9jdXMg bW92ZXMgdG8gdGhlIHRyZWUsCisgICAgICAgIGFsbG93aW5nIHRoZSBhcnJvdyBrZXlzIHdvcmsu IFRoaXMgY2FuIGhhcHBlbiB3aGVuIHVzaW5nIHRoZSBuZXcKKyAgICAgICAgZmluZCBpbiBwYWdl IGZlYXR1cmUuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxMjUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwYWdlL2luc3BlY3Rvci9FbGVtZW50c1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkVsZW1lbnRzUGFuZWwpOiBTZXQgY3VycmVudEZvY3VzRWxlbWVudCB0bworICAgICAgICB0 aGUgbWFpbi1wYW5lbHMgZWxlbWVudCBpZiB0aGUgcGFuZWwgaXMgdmlzaWJsZS4KKyAgICAgICAg KFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZS51cGRhdGVCcmVhZGNydW1iKToK KyAgICAgICAgUmVtb3ZlIGEgc2V0IG9mIGN1cnJlbnRGb2N1c0VsZW1lbnQgc2luY2UgdGhpcyBt b3ZlZC4KKyAgICAgICAgKiBwYWdlL2luc3BlY3Rvci9pbnNwZWN0b3IuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3Iuc2V0IGN1cnJlbnRGb2N1c0VsZW1lbnQpOiBBbHdheXMgZm9jdXMgdGhlIGVs ZW1lbnQuCisgICAgICAgIFRoaXMgZW5zdXJlcyB0aGF0IHdoZW4gZm9jdXMgY2hhbmdlcyBpbiB0 aGUgcGFnZSBhbmQgd2UgZG9uJ3QKKyAgICAgICAgY2F0Y2ggaXQsIHdlIHdpbGwgc3RpbGwgZm9j dXMgdGhlIGVsZW1lbnRzIGV2ZW4gaWYgd2UgdGhpbmsgaXQKKyAgICAgICAgd2FzIGFscmVhZHkg Zm9jdXNlZC4KKworMjAwOC0wOS0zMCAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CisKICAgICAgICAgTWFrZSB0aGUgV2ViIEluc3BlY3RvcidzIHRvb2xiYXIgaWNvbnMgZGFy a2VyIHdoZW4gdGhlIG1vdXNlIGlzCiAgICAgICAgIHByZXNzZWQgb24gdGhlbS4gVGhpcyBtYXRj aGVzIHRoZSBzdGFuZGFyZCBOU1Rvb2xiYXIgbG9vay4KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w YWdlL2luc3BlY3Rvci9FbGVtZW50c1BhbmVsLmpzIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9F bGVtZW50c1BhbmVsLmpzCmluZGV4IDQ3MTA1YmMuLmY0NTk2ZjIgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGFnZS9pbnNwZWN0b3IvRWxlbWVudHNQYW5lbC5qcworKysgYi9XZWJDb3JlL3BhZ2UvaW5z cGVjdG9yL0VsZW1lbnRzUGFuZWwuanMKQEAgLTQ0LDYgKzQ0LDkgQEAgV2ViSW5zcGVjdG9yLkVs ZW1lbnRzUGFuZWwgPSBmdW5jdGlvbigpCiAKICAgICB0aGlzLnRyZWVPdXRsaW5lLmZvY3VzZWRO b2RlQ2hhbmdlZCA9IGZ1bmN0aW9uKGZvcmNlVXBkYXRlKQogICAgIHsKKyAgICAgICAgaWYgKHRo aXMucGFuZWwudmlzaWJsZSkKKyAgICAgICAgICAgIFdlYkluc3BlY3Rvci5jdXJyZW50Rm9jdXNF bGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm1haW4tcGFuZWxzIik7CisKICAgICAg ICAgdGhpcy5wYW5lbC51cGRhdGVCcmVhZGNydW1iKGZvcmNlVXBkYXRlKTsKIAogICAgICAgICBm b3IgKHZhciBwYW5lIGluIHRoaXMucGFuZWwuc2lkZWJhclBhbmVzKQpAQCAtNTcyLDggKzU3NSw2 IEBAIFdlYkluc3BlY3Rvci5FbGVtZW50c1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAg ICAgICBwYW5lbC5mb2N1c2VkRE9NTm9kZSA9IGNydW1iLnJlcHJlc2VudGVkT2JqZWN0OwogICAg ICAgICAgICAgfQogCi0gICAgICAgICAgICBXZWJJbnNwZWN0b3IuY3VycmVudEZvY3VzRWxlbWVu dCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJtYWluLXBhbmVscyIpOwotCiAgICAgICAgICAg ICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwogICAgICAgICB9CiAKZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGFnZS9pbnNwZWN0b3IvaW5zcGVjdG9yLmpzIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9p bnNwZWN0b3IuanMKaW5kZXggZTA5MjRiZi4uNzBiZjk3OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w YWdlL2luc3BlY3Rvci9pbnNwZWN0b3IuanMKKysrIGIvV2ViQ29yZS9wYWdlL2luc3BlY3Rvci9p bnNwZWN0b3IuanMKQEAgLTU2LDEwICs1Niw4IEBAIHZhciBXZWJJbnNwZWN0b3IgPSB7CiAKICAg ICBzZXQgY3VycmVudEZvY3VzRWxlbWVudCh4KQogICAgIHsKLSAgICAgICAgaWYgKCF4IHx8IHRo aXMuX2N1cnJlbnRGb2N1c0VsZW1lbnQgPT09IHgpCi0gICAgICAgICAgICByZXR1cm47Ci0KLSAg ICAgICAgdGhpcy5fcHJldmlvdXNGb2N1c0VsZW1lbnQgPSB0aGlzLl9jdXJyZW50Rm9jdXNFbGVt ZW50OworICAgICAgICBpZiAodGhpcy5fY3VycmVudEZvY3VzRWxlbWVudCAhPT0geCkKKyAgICAg ICAgICAgIHRoaXMuX3ByZXZpb3VzRm9jdXNFbGVtZW50ID0gdGhpcy5fY3VycmVudEZvY3VzRWxl bWVudDsKICAgICAgICAgdGhpcy5fY3VycmVudEZvY3VzRWxlbWVudCA9IHg7CiAKICAgICAgICAg aWYgKHRoaXMuX2N1cnJlbnRGb2N1c0VsZW1lbnQpIHsKLS0gCjEuNi4wLjIKCg==