212508 2020-05-28 19:22:20 -0700 Avoid unnecessary sync IPC messages when togging the callout bar for selections 2020-05-28 22:42:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1657125 0 megan_gardner 2020-05-28 19:22:20 -0700 Avoid unnessecary sync IPC messages when togging the callout bar for selections. 1657126 1 400537 megan_gardner 2020-05-28 19:26:29 -0700 Created attachment 400537 Patch 1657128 2 400537 wenson_hsieh 2020-05-28 19:29:19 -0700 Comment on attachment 400537 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400537&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2566 > + if (!_page->editorState().selectionIsRange) > + return NO; > + if ([self _pointIsInsideSelectionRect:point outBoundingRect:nil]) > + return YES; > + return NO; Nit - I would just write this `return [self _pointIsInsideSelectionRect:point outBoundingRect:nil];`. 1657129 3 400537 wenson_hsieh 2020-05-28 19:30:53 -0700 Comment on attachment 400537 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400537&action=review > Source/WebKit/ChangeLog:3 > + Avoid unnessecary sync IPC messages when togging the callout bar for selections. Nit - unnecessary 1657151 4 400547 megan_gardner 2020-05-28 22:07:16 -0700 Created attachment 400547 Patch for landing 1657158 5 ews-feeder 2020-05-28 22:41:06 -0700 Committed r262280: <https://trac.webkit.org/changeset/262280> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400547. 1657160 6 webkit-bug-importer 2020-05-28 22:42:14 -0700 <rdar://problem/63747401> 400537 2020-05-28 19:26:29 -0700 2020-05-28 22:07:14 -0700 Patch bug-212508-20200528192627.patch text/plain 3364 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdhYjVjYmM3ODBhNTM1Mzkw MGUyMmI2MmRkMDY1MzY5NjExY2ZlNWIuLmQ1MjQzZThjZjFmYzFkYzRlNzlkNDE1NDVjMTNlMzlh YjdmNDQ2MmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDUtMjggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB1bm5lc3Nl Y2FyeSBzeW5jIElQQyBtZXNzYWdlcyB3aGVuIHRvZ2dpbmcgdGhlIGNhbGxvdXQgYmFyIGZvciBz ZWxlY3Rpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEyNTA4CisKKyAgICAgICAgVGhlIGxvdXBlIGdlc3R1cmUgb25seSBuZWVkcyB0byBiZSBh Y3RpdmF0ZWQgYW5kIGV2YWx1YXRlZCBpZiB0aGUgdGFwIGlzIGluc2lkZQorICAgICAgICBhbiBl eGlzdGluZyBzZWxlY3Rpb25WaWV3LiBXZSBjYW4gZG8gdGhhdCB0ZXN0IGluIHRoZSBVSVByb2Nl c3Mgd2l0aG91dCByZXNvcnRpbmcgdG8gYSBzeW5jIElQQyBtZXNzYWdlLgorICAgICAgICBEb2lu ZyB0aGF0IGV2YWx1YXRpb24gbG9jYWxseSB3aWxsIGVsaW1pbmF0ZSB1bm5lc3NjYXJ5IGhhbmdz IGluIHRoZSBVSVByb2Nlc3MuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToK KyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfcG9pbnRJc0luc2lkZVNlbGVjdGlvblJlY3Q6b3V0 Qm91bmRpbmdSZWN0Ol0pOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9zaG91bGRUb2dnbGVT ZWxlY3Rpb25Db21tYW5kc0FmdGVyVGFwQXQ6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcg dGV4dEludGVyYWN0aW9uR2VzdHVyZTpzaG91bGRCZWdpbkF0UG9pbnQ6XSk6CisKIDIwMjAtMDUt MjggIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIHdhdGNo T1M6IFVwc3RyZWFtIFdLVGV4dElucHV0TGlzdFZpZXdDb250cm9sbGVyCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpp bmRleCAzMWVjY2JmNDUyOGNhNjI5Y2NkM2I5M2EyMjQ5MWRiZjRjNzI1NDUxLi5kMmVlODZjNmYz YmU2NDhhNjc2ZTAxZjc3ZTEwYTMyYjQyNGE0NTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTIzMjgs MTIgKzIzMjgsOCBAQCAtIChOU0FycmF5PE5TVmFsdWUgKj4gKilfdWlUZXh0U2VsZWN0aW9uUmVj dHMKICAgICByZXR1cm4gdGV4dFNlbGVjdGlvblJlY3RzOwogfQogCi0tIChCT09MKV9zaG91bGRU b2dnbGVTZWxlY3Rpb25Db21tYW5kc0FmdGVyVGFwQXQ6KENHUG9pbnQpcG9pbnQKKy0gKEJPT0wp X3BvaW50SXNJbnNpZGVTZWxlY3Rpb25SZWN0OihDR1BvaW50KXBvaW50IG91dEJvdW5kaW5nUmVj dDooV2ViQ29yZTo6RmxvYXRSZWN0ICopb3V0Qm91bmRpbmdSZWN0CiB7Ci0gICAgaWYgKF9sYXN0 U2VsZWN0aW9uRHJhd2luZ0luZm8uc2VsZWN0aW9uUmVjdHMuaXNFbXB0eSgpKQotICAgICAgICBy ZXR1cm4gTk87Ci0KLSAgICBXZWJDb3JlOjpGbG9hdFJlY3Qgc2VsZWN0aW9uQm91bmRpbmdSZWN0 OwogICAgIEJPT0wgcG9pbnRJc0luU2VsZWN0aW9uUmVjdCA9IE5POwogICAgIGZvciAoYXV0byYg cmVjdEluZm8gOiBfbGFzdFNlbGVjdGlvbkRyYXdpbmdJbmZvLnNlbGVjdGlvblJlY3RzKSB7CiAg ICAgICAgIGF1dG8gcmVjdCA9IHJlY3RJbmZvLnJlY3QoKTsKQEAgLTIzNDEsOSArMjMzNywxOSBA QCAtIChCT09MKV9zaG91bGRUb2dnbGVTZWxlY3Rpb25Db21tYW5kc0FmdGVyVGFwQXQ6KENHUG9p bnQpcG9pbnQKICAgICAgICAgICAgIGNvbnRpbnVlOwogCiAgICAgICAgIHBvaW50SXNJblNlbGVj dGlvblJlY3QgfD0gcmVjdC5jb250YWlucyhXZWJDb3JlOjpyb3VuZGVkSW50UG9pbnQocG9pbnQp KTsKLSAgICAgICAgc2VsZWN0aW9uQm91bmRpbmdSZWN0LnVuaXRlKHJlY3QpOworICAgICAgICBp ZiAob3V0Qm91bmRpbmdSZWN0KQorICAgICAgICAgICAgb3V0Qm91bmRpbmdSZWN0LT51bml0ZShy ZWN0KTsKICAgICB9CisgICAgcmV0dXJuIHBvaW50SXNJblNlbGVjdGlvblJlY3Q7Cit9CisKKy0g KEJPT0wpX3Nob3VsZFRvZ2dsZVNlbGVjdGlvbkNvbW1hbmRzQWZ0ZXJUYXBBdDooQ0dQb2ludClw b2ludAoreworICAgIGlmIChfbGFzdFNlbGVjdGlvbkRyYXdpbmdJbmZvLnNlbGVjdGlvblJlY3Rz LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIE5POwogCisgICAgV2ViQ29yZTo6RmxvYXRSZWN0 IHNlbGVjdGlvbkJvdW5kaW5nUmVjdDsKKyAgICBCT09MIHBvaW50SXNJblNlbGVjdGlvblJlY3Qg PSBbc2VsZiBfcG9pbnRJc0luc2lkZVNlbGVjdGlvblJlY3Q6cG9pbnQgb3V0Qm91bmRpbmdSZWN0 OiZzZWxlY3Rpb25Cb3VuZGluZ1JlY3RdOwogICAgIFdlYkNvcmU6OkZsb2F0UmVjdCB1bm9ic2N1 cmVkQ29udGVudFJlY3QgPSBzZWxmLnVub2JzY3VyZWRDb250ZW50UmVjdDsKICAgICBzZWxlY3Rp b25Cb3VuZGluZ1JlY3QuaW50ZXJzZWN0KHVub2JzY3VyZWRDb250ZW50UmVjdCk7CiAKQEAgLTI1 NTMsNyArMjU1OSwxMSBAQCAtIChCT09MKXRleHRJbnRlcmFjdGlvbkdlc3R1cmU6KFVJV0tHZXN0 dXJlVHlwZSlnZXN0dXJlIHNob3VsZEJlZ2luQXRQb2ludDooQ0dQbwogICAgICAgICAgICAgICAg IHJldHVybiBOTzsKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGRlZmF1bHQ6Ci0gICAgICAg ICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgaWYgKCFfcGFnZS0+ZWRpdG9yU3RhdGUo KS5zZWxlY3Rpb25Jc1JhbmdlKQorICAgICAgICAgICAgICAgICAgICByZXR1cm4gTk87CisgICAg ICAgICAgICAgICAgaWYgKFtzZWxmIF9wb2ludElzSW5zaWRlU2VsZWN0aW9uUmVjdDpwb2ludCBv dXRCb3VuZGluZ1JlY3Q6bmlsXSkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIFlFUzsKKyAg ICAgICAgICAgICAgICByZXR1cm4gTk87CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9 Cg== 400547 2020-05-28 22:07:16 -0700 2020-05-28 22:41:06 -0700 Patch for landing bug-212508-20200528220714.patch text/plain 3304 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDdhYjVjYmM3ODBhNTM1Mzkw MGUyMmI2MmRkMDY1MzY5NjExY2ZlNWIuLmZjYTkxMjFlNjQ3OGQwOWQ0MzY4ZDE1ZWY5YmJlOTcz NzJjNThmYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDUtMjggIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCB1bm5lY2Vz c2FyeSBzeW5jIElQQyBtZXNzYWdlcyB3aGVuIHRvZ2dpbmcgdGhlIGNhbGxvdXQgYmFyIGZvciBz ZWxlY3Rpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjEyNTA4CisKKyAgICAgICAgVGhlIGxvdXBlIGdlc3R1cmUgb25seSBuZWVkcyB0byBiZSBh Y3RpdmF0ZWQgYW5kIGV2YWx1YXRlZCBpZiB0aGUgdGFwIGlzIGluc2lkZQorICAgICAgICBhbiBl eGlzdGluZyBzZWxlY3Rpb25WaWV3LiBXZSBjYW4gZG8gdGhhdCB0ZXN0IGluIHRoZSBVSVByb2Nl c3Mgd2l0aG91dCByZXNvcnRpbmcgdG8gYSBzeW5jIElQQyBtZXNzYWdlLgorICAgICAgICBEb2lu ZyB0aGF0IGV2YWx1YXRpb24gbG9jYWxseSB3aWxsIGVsaW1pbmF0ZSB1bm5lY2Vzc2FyeSBoYW5n cyBpbiB0aGUgVUlQcm9jZXNzLgorCisgICAgICAgIFJldmlld2VkIGJ5IFdlbnNvbiBIc2llaC4K KworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgor ICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IF9wb2ludElzSW5zaWRlU2VsZWN0aW9uUmVjdDpvdXRC b3VuZGluZ1JlY3Q6XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3Nob3VsZFRvZ2dsZVNl bGVjdGlvbkNvbW1hbmRzQWZ0ZXJUYXBBdDpdKToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyB0 ZXh0SW50ZXJhY3Rpb25HZXN0dXJlOnNob3VsZEJlZ2luQXRQb2ludDpdKToKKwogMjAyMC0wNS0y OCAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgd2F0Y2hP UzogVXBzdHJlYW0gV0tUZXh0SW5wdXRMaXN0Vmlld0NvbnRyb2xsZXIKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmlu ZGV4IDMxZWNjYmY0NTI4Y2E2MjljY2QzYjkzYTIyNDkxZGJmNGM3MjU0NTEuLmEzNDRjZjVmYmQ2 MGE1NDY3NWZmZDI4MmZjZTAwNmFiY2M2OTg4ZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMjMyOCwx MiArMjMyOCw4IEBAIC0gKE5TQXJyYXk8TlNWYWx1ZSAqPiAqKV91aVRleHRTZWxlY3Rpb25SZWN0 cwogICAgIHJldHVybiB0ZXh0U2VsZWN0aW9uUmVjdHM7CiB9CiAKLS0gKEJPT0wpX3Nob3VsZFRv Z2dsZVNlbGVjdGlvbkNvbW1hbmRzQWZ0ZXJUYXBBdDooQ0dQb2ludClwb2ludAorLSAoQk9PTClf cG9pbnRJc0luc2lkZVNlbGVjdGlvblJlY3Q6KENHUG9pbnQpcG9pbnQgb3V0Qm91bmRpbmdSZWN0 OihXZWJDb3JlOjpGbG9hdFJlY3QgKilvdXRCb3VuZGluZ1JlY3QKIHsKLSAgICBpZiAoX2xhc3RT ZWxlY3Rpb25EcmF3aW5nSW5mby5zZWxlY3Rpb25SZWN0cy5pc0VtcHR5KCkpCi0gICAgICAgIHJl dHVybiBOTzsKLQotICAgIFdlYkNvcmU6OkZsb2F0UmVjdCBzZWxlY3Rpb25Cb3VuZGluZ1JlY3Q7 CiAgICAgQk9PTCBwb2ludElzSW5TZWxlY3Rpb25SZWN0ID0gTk87CiAgICAgZm9yIChhdXRvJiBy ZWN0SW5mbyA6IF9sYXN0U2VsZWN0aW9uRHJhd2luZ0luZm8uc2VsZWN0aW9uUmVjdHMpIHsKICAg ICAgICAgYXV0byByZWN0ID0gcmVjdEluZm8ucmVjdCgpOwpAQCAtMjM0MSw5ICsyMzM3LDE5IEBA IC0gKEJPT0wpX3Nob3VsZFRvZ2dsZVNlbGVjdGlvbkNvbW1hbmRzQWZ0ZXJUYXBBdDooQ0dQb2lu dClwb2ludAogICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgcG9pbnRJc0luU2VsZWN0 aW9uUmVjdCB8PSByZWN0LmNvbnRhaW5zKFdlYkNvcmU6OnJvdW5kZWRJbnRQb2ludChwb2ludCkp OwotICAgICAgICBzZWxlY3Rpb25Cb3VuZGluZ1JlY3QudW5pdGUocmVjdCk7CisgICAgICAgIGlm IChvdXRCb3VuZGluZ1JlY3QpCisgICAgICAgICAgICBvdXRCb3VuZGluZ1JlY3QtPnVuaXRlKHJl Y3QpOwogICAgIH0KKyAgICByZXR1cm4gcG9pbnRJc0luU2VsZWN0aW9uUmVjdDsKK30KIAorLSAo Qk9PTClfc2hvdWxkVG9nZ2xlU2VsZWN0aW9uQ29tbWFuZHNBZnRlclRhcEF0OihDR1BvaW50KXBv aW50Cit7CisgICAgaWYgKF9sYXN0U2VsZWN0aW9uRHJhd2luZ0luZm8uc2VsZWN0aW9uUmVjdHMu aXNFbXB0eSgpKQorICAgICAgICByZXR1cm4gTk87CisKKyAgICBXZWJDb3JlOjpGbG9hdFJlY3Qg c2VsZWN0aW9uQm91bmRpbmdSZWN0OworICAgIEJPT0wgcG9pbnRJc0luU2VsZWN0aW9uUmVjdCA9 IFtzZWxmIF9wb2ludElzSW5zaWRlU2VsZWN0aW9uUmVjdDpwb2ludCBvdXRCb3VuZGluZ1JlY3Q6 JnNlbGVjdGlvbkJvdW5kaW5nUmVjdF07CiAgICAgV2ViQ29yZTo6RmxvYXRSZWN0IHVub2JzY3Vy ZWRDb250ZW50UmVjdCA9IHNlbGYudW5vYnNjdXJlZENvbnRlbnRSZWN0OwogICAgIHNlbGVjdGlv bkJvdW5kaW5nUmVjdC5pbnRlcnNlY3QodW5vYnNjdXJlZENvbnRlbnRSZWN0KTsKIApAQCAtMjU1 Myw3ICsyNTU5LDkgQEAgLSAoQk9PTCl0ZXh0SW50ZXJhY3Rpb25HZXN0dXJlOihVSVdLR2VzdHVy ZVR5cGUpZ2VzdHVyZSBzaG91bGRCZWdpbkF0UG9pbnQ6KENHUG8KICAgICAgICAgICAgICAgICBy ZXR1cm4gTk87CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBkZWZhdWx0OgotICAgICAgICAg ICAgICAgIGJyZWFrOworICAgICAgICAgICAgICAgIGlmICghX3BhZ2UtPmVkaXRvclN0YXRlKCku c2VsZWN0aW9uSXNSYW5nZSkKKyAgICAgICAgICAgICAgICAgICAgcmV0dXJuIE5POworICAgICAg ICAgICAgICAgIHJldHVybiBbc2VsZiBfcG9pbnRJc0luc2lkZVNlbGVjdGlvblJlY3Q6cG9pbnQg b3V0Qm91bmRpbmdSZWN0Om5pbF07CiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9Cg==