212473 2020-05-28 09:53:26 -0700 Implement named item condition for images 2020-05-31 03:41:22 -0700 1 1 1 Unclassified WebKit New Bugs Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rbuis rbuis cdumez changseok ews-watchlist gyuyoung.kim mjs webkit-bug-importer oldest_to_newest 1656891 0 rbuis 2020-05-28 09:53:26 -0700 Implement named item condition for images, not only should we check there are both an id and a name attribute, but also that the name attribute is non-empty: https://html.spec.whatwg.org/multipage/dom.html#dom-document-nameditem-filter 1656899 1 400473 rbuis 2020-05-28 09:57:56 -0700 Created attachment 400473 Patch 1657764 2 400473 mjs 2020-05-31 03:12:35 -0700 Comment on attachment 400473 Patch r=me 1657766 3 ews-feeder 2020-05-31 03:40:17 -0700 Committed r262360: <https://trac.webkit.org/changeset/262360> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400473. 1657767 4 webkit-bug-importer 2020-05-31 03:41:22 -0700 <rdar://problem/63805627> 400473 2020-05-28 09:57:56 -0700 2020-05-31 03:40:18 -0700 Patch bug-212473-20200528185754.patch text/plain 5434 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmRjZjFmMWU2MjI4NmM0 MjVmZDc2ZDY2YWVlOGZiMDBmNWRiZjExYy4uZTlkNGVhOTI1MjA2MTI5ZTIyMGQxNDcyMTJiOGFj NDVlNGRhNmIzMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTA1LTI4ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IG5hbWVkIGl0ZW0g Y29uZGl0aW9uIGZvciBpbWFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIxMjQ3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEltcGxlbWVudCBuYW1lZCBpdGVtIGNvbmRpdGlvbiBmb3IgaW1hZ2VzLCBu b3Qgb25seSBzaG91bGQgd2UKKyAgICAgICAgY2hlY2sgdGhlcmUgYXJlIGJvdGggYW4gaWQgYW5k IGEgbmFtZSBhdHRyaWJ1dGUsIGJ1dCBhbHNvIHRoYXQKKyAgICAgICAgdGhlIG5hbWUgYXR0cmli dXRlIGlzIG5vbi1lbXB0eSBbMV0uCisKKyAgICAgICAgQmVoYXZpb3IgbWF0Y2hlcyBDaHJvbWUg YW5kIEZpcmVmb3guCisKKyAgICAgICAgWzFdIGh0dHBzOi8vaHRtbC5zcGVjLndoYXR3Zy5vcmcv bXVsdGlwYWdlL2RvbS5odG1sI2RvbS1kb2N1bWVudC1uYW1lZGl0ZW0tZmlsdGVyCisKKyAgICAg ICAgVGVzdDogaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9kb2N1bWVu dHMvZG9tLXRyZWUtYWNjZXNzb3JzL25hbWVkaXRlbS0wNi5odG1sCisKKyAgICAgICAgKiBodG1s L0hUTUxOYW1lQ29sbGVjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudE5hbWVD b2xsZWN0aW9uOjplbGVtZW50TWF0Y2hlc0lmSWRBdHRyaWJ1dGVNYXRjaCk6CisKIDIwMjAtMDUt MjcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQuIEZpeCBidWlsZCB3YXJuaW5nIHdpdGggR1RLNApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MTmFtZUNvbGxlY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUv aHRtbC9IVE1MTmFtZUNvbGxlY3Rpb24uY3BwCmluZGV4IGFjYzFkYWM3ZjFhOGNhYmFjYTI5Zjdm MjRjZWMwNzAwZTIzOGFjMjguLmZlMWJmNDQ2YWFhNTU5NmJjYTFjYmExM2M0MDI0N2EzNWUzNjc4 NzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE5hbWVDb2xsZWN0aW9uLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxOYW1lQ29sbGVjdGlvbi5jcHAKQEAgLTY4 LDcgKzY4LDcgQEAgYm9vbCBEb2N1bWVudE5hbWVDb2xsZWN0aW9uOjplbGVtZW50TWF0Y2hlc0lm SWRBdHRyaWJ1dGVNYXRjaChjb25zdCBFbGVtZW50JiBlbGUKICAgICAvLyBGSVhNRTogV2UgbmVl ZCB0byBmaXggSFRNTEltYWdlRWxlbWVudCB0byB1cGRhdGUgdGhlIGhhc2ggbWFwIGZvciB1cyB3 aGVuIHRoZSBuYW1lIGF0dHJpYnV0ZSBpcyByZW1vdmVkLgogICAgIHJldHVybiBpc09iamVjdEVs ZW1lbnRGb3JEb2N1bWVudE5hbWVDb2xsZWN0aW9uKGVsZW1lbnQpCiAgICAgICAgIHx8IGlzPEhU TUxBcHBsZXRFbGVtZW50PihlbGVtZW50KQotICAgICAgICB8fCAoaXM8SFRNTEltYWdlRWxlbWVu dD4oZWxlbWVudCkgJiYgZWxlbWVudC5oYXNOYW1lKCkpOworICAgICAgICB8fCAoaXM8SFRNTElt YWdlRWxlbWVudD4oZWxlbWVudCkgJiYgZWxlbWVudC5oYXNOYW1lKCkgJiYgIWVsZW1lbnQuZ2V0 TmFtZUF0dHJpYnV0ZSgpLmlzRW1wdHkoKSk7CiB9CiAKIGJvb2wgRG9jdW1lbnROYW1lQ29sbGVj dGlvbjo6ZWxlbWVudE1hdGNoZXNJZk5hbWVBdHRyaWJ1dGVNYXRjaChjb25zdCBFbGVtZW50JiBl bGVtZW50KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCmluZGV4IDZjMWVlYzE0MjBmNzMzZDU5YmE0NWQ2YjExOWYwYmRjYzJhNDM1NWEu LjgxZWJhN2ZlYzAyMWI2MTg1ZGQ4YjJiYWNjMWFmZjUxMTA1YmY1M2EgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAyMC0wNS0yOCAgUm9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgorCisgICAg ICAgIEltcGxlbWVudCBuYW1lZCBpdGVtIGNvbmRpdGlvbiBmb3IgaW1hZ2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMTI0NzMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGVzdCBleHBlY3Rh dGlvbi4KKworICAgICAgICAqIGZhc3QvZG9tL0hUTUxEb2N1bWVudC9kb2N1bWVudC1zcGVjaWFs LXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0OgorCiAyMDIwLTA1LTE5ICBTZXJnaW8gVmlsbGFyIFNl bmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXZWJYUl0gSW1wbGVtZW50IFhS U2Vzc2lvbjo6cmVxdWVzdEFuaW1hdGlvbkZyYW1lKCkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdl TG9nCmluZGV4IGY1NTg1ODk5ZWVhZDBjZjM5ZGIxMWFjMGYwZDFkODY4MmZlYTc0MTkuLjdjNjBm ZWMwZmZiOTI2ODZkNDdiZmE0ZGNmMjhiNzcyNjcxMjZlOTggMTAwNjQ0Ci0tLSBhL0xheW91dFRl c3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNj L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTA1LTI4ICBSb2IgQnVpcyAgPHJidWlz QGlnYWxpYS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IG5hbWVkIGl0ZW0gY29uZGl0aW9uIGZv ciBpbWFnZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIxMjQ3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFVwZGF0ZSBpbXByb3ZlZCB0ZXN0IGV4cGVjdGF0aW9uLgorCisgICAgICAgICogd2ViLXBsYXRm b3JtLXRlc3RzL2h0bWwvZG9tL2RvY3VtZW50cy9kb20tdHJlZS1hY2Nlc3NvcnMvbmFtZWRpdGVt LTA2LWV4cGVjdGVkLnR4dDoKKwogMjAyMC0wNS0xOSAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2 aWxsYXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV2ViWFJdIEltcGxlbWVudCBYUlNlc3Npb246 OnJlcXVlc3RBbmltYXRpb25GcmFtZSgpCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Rv bS9IVE1MRG9jdW1lbnQvZG9jdW1lbnQtc3BlY2lhbC1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dCBi L0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC9kb2N1bWVudC1zcGVjaWFsLXByb3Bl cnRpZXMtZXhwZWN0ZWQudHh0CmluZGV4IGUzZmY5OTkyYWRiYTkyYzE2MTBjMGI4NzViZmE2ZGYx YmNlZTVjMWUuLmNiY2E1MmJlNDUzMWUxOGRjZDI1YTlhOTE2ZDQ1MDgwNzcxMzRlMjQgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxEb2N1bWVudC9kb2N1bWVudC1zcGVjaWFs LXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxE b2N1bWVudC9kb2N1bWVudC1zcGVjaWFsLXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0CkBAIC0xMSw3 ICsxMSw3IEBAIEltYWdlIGJ5IGlkICh1bmlxdWUpOiB1bmRlZmluZWQKIEltYWdlIGJ5IGlkICht dWx0aXBsZSk6IHVuZGVmaW5lZAogSW1hZ2UgYnkgaWQvbmFtZSBtaXhlZDogY29sbGVjdGlvbigy KSBJTUcobmFtZSkgSU1HKG5hbWUpCiBJbWFnZSBieSBpZCwgbmFtZSBwcmVzZW50ICh1bmlxdWUp OiBzaW5nbGUgSU1HKGlkLG5hbWUpCi1JbWFnZSBieSBpZCwgZW1wdHkgbmFtZSBwcmVzZW50ICh1 bmlxdWUpOiBzaW5nbGUgSU1HKGlkKQorSW1hZ2UgYnkgaWQsIGVtcHR5IG5hbWUgcHJlc2VudCAo dW5pcXVlKTogdW5kZWZpbmVkCiBJbWFnZSBieSBpZCwgbmFtZSBwcmVzZW50IChtdWx0aXBsZSk6 IGNvbGxlY3Rpb24oMikgSU1HKGlkLG5hbWUpIElNRyhpZCxuYW1lKQogSW1hZ2UgYnkgbmFtZSwg aWQgcHJlc2VudCAodW5pcXVlKTogc2luZ2xlIElNRyhpZCxuYW1lKQogCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvZG9tL2RvY3Vt ZW50cy9kb20tdHJlZS1hY2Nlc3NvcnMvbmFtZWRpdGVtLTA2LWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vZG9jdW1lbnRz L2RvbS10cmVlLWFjY2Vzc29ycy9uYW1lZGl0ZW0tMDYtZXhwZWN0ZWQudHh0CmluZGV4IDZkNTYy MWI2OWJhNGUzNDY1ZjM5OTgxMDM2MWMzYTU5ODQzMjRlYmQuLjMzMGM1NzM3MWE3MzRlYzM0ZmFm MDlkM2JlYzNmZDQ0YWUxNjJlMTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vZG9jdW1lbnRzL2RvbS10cmVlLWFjY2Vzc29y cy9uYW1lZGl0ZW0tMDYtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vZG9jdW1lbnRzL2RvbS10cmVlLWFjY2Vzc29y cy9uYW1lZGl0ZW0tMDYtZXhwZWN0ZWQudHh0CkBAIC0yLDcgKzIsNyBAQAogUEFTUyBJZiB0aGVy ZSBpcyBvbmUgaW1nLCBpdCBzaG91bGQgYmUgcmV0dXJuZWQgKG5hbWUpIAogUEFTUyBJZiB0aGVy ZSBhcmUgdHdvIGltZ3MsIGEgY29sbGVjdGlvbiBzaG91bGQgYmUgcmV0dXJuZWQuIChuYW1lKSAK IFBBU1MgSWYgdGhlcmUgaXMgb25lIGltZywgaXQgc2hvdWxkIG5vdCBiZSByZXR1cm5lZCAoaWQp IAotRkFJTCBJZiB0aGVyZSBhcmUgdHdvIGltZ3MsIG5vdGhpbmcgc2hvdWxkIGJlIHJldHVybmVk LiAoaWQpIGFzc2VydF9mYWxzZTogInRlc3Q0IiBpbiBkb2N1bWVudCBzaG91bGQgYmUgZmFsc2Ug ZXhwZWN0ZWQgZmFsc2UgZ290IHRydWUKK1BBU1MgSWYgdGhlcmUgYXJlIHR3byBpbWdzLCBub3Ro aW5nIHNob3VsZCBiZSByZXR1cm5lZC4gKGlkKSAKIFBBU1MgSWYgdGhlcmUgYXJlIHR3byBpbWdz LCB0aGUgb25lIHdpdGggYSBuYW1lIHNob3VsZCBiZSByZXR1cm5lZC4gKG5hbWUgYW5kIGlkKSAK IFBBU1MgSWYgdGhlcmUgYXJlIHR3byBpbWdzLCB0aGUgb25lIHdpdGggYSBuYW1lIHNob3VsZCBi ZSByZXR1cm5lZC4gKGlkIGFuZCBuYW1lKSAKIFBBU1MgQSBuYW1lIHNob3VsZCBhZmZlY3QgZ2V0 dGluZyBhbiBpbWcgYnkgaWQgCg==