212468 2020-05-28 07:51:21 -0700 Web Inspector: generate_cpp_protocol_types_header.py:294: SyntaxWarning: "is" with a literal. Did you mean "=="? 2020-05-28 08:32:24 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mcatanzaro mcatanzaro bburg ews-watchlist hi joepeck keith_miller mark.lam mcatanzaro msaboff saam timothy tzagallo webkit-bug-importer oldest_to_newest 1656848 0 mcatanzaro 2020-05-28 07:51:21 -0700 I just noticed this build warning with python 3.8.3, not sure if it's new or if I've just never noticed before: [155/1729] Generating ../../DerivedSou...spector/InspectorBackendCommands.js.in /home/mcatanzaro/Projects/WebKit/Source/JavaScriptCore/inspector/scripts/codegen/generate_cpp_protocol_types_header.py:294: SyntaxWarning: "is" with a literal. Did you mean "=="? if line.startswith(('#', '/*', '*/', '//')) or len(line) is 0: Fix is trivial. 1656849 1 400457 mcatanzaro 2020-05-28 07:52:12 -0700 Created attachment 400457 Patch 1656850 2 ews-watchlist 2020-05-28 07:53:16 -0700 This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`) 1656860 3 ews-feeder 2020-05-28 08:31:09 -0700 Committed r262243: <https://trac.webkit.org/changeset/262243> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400457. 1656861 4 webkit-bug-importer 2020-05-28 08:32:24 -0700 <rdar://problem/63719116> 400457 2020-05-28 07:52:12 -0700 2020-05-28 08:31:09 -0700 Patch bug-212468-20200528095211.patch text/plain 1744 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMjM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 Nzc2YmJhZDIyODFkZTJmYjlmZDc4MGIwZjc5MDllZjgwNWI1ZDJlLi4zMjAwNjUxZWNhNjY2Mjhl MGM1NDU2YWNlZTQ4YWRlMDYxYWVhOGJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMC0wNS0yOCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGdu b21lLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBnZW5lcmF0ZV9jcHBfcHJvdG9jb2xf dHlwZXNfaGVhZGVyLnB5OjI5NDogU3ludGF4V2FybmluZzogImlzIiB3aXRoIGEgbGl0ZXJhbC4g RGlkIHlvdSBtZWFuICI9PSI/CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMTI0NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBVc2UgIj09IiBpbnN0ZWFkIG9mICJpcyIgdG8gY29tcGFyZSBhZ2FpbnN0IDAu CisKKyAgICAgICAgKiBpbnNwZWN0b3Ivc2NyaXB0cy9jb2RlZ2VuL2dlbmVyYXRlX2NwcF9wcm90 b2NvbF90eXBlc19oZWFkZXIucHk6CisKIDIwMjAtMDUtMjggIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIEdhcmRlbmluZzogQWRkIGFuIGFzc2VydE5vRXhjZXB0aW9u KCkgdG8gcGxhY2F0ZSB0aGUgZXhjZXB0aW9uIGNoZWNrZXIgYW5kIGdyZWVuIHRoZSBib3RzLgpk aWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVn ZW4vZ2VuZXJhdGVfY3BwX3Byb3RvY29sX3R5cGVzX2hlYWRlci5weSBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9pbnNwZWN0b3Ivc2NyaXB0cy9jb2RlZ2VuL2dlbmVyYXRlX2NwcF9wcm90b2NvbF90 eXBlc19oZWFkZXIucHkKaW5kZXggOTlmNjAxYTdkOTIzN2UzYzc5MzlmMDhlNmIzNjc4NzM2ZjA2 YWJiYi4uMmJiZDQyZDY3YTc5ZjI0MGFmMGU5MmY3YWQzOTU5N2I0NjgxZmQ0MiAxMDA3NTUKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rvci9zY3JpcHRzL2NvZGVnZW4vZ2VuZXJh dGVfY3BwX3Byb3RvY29sX3R5cGVzX2hlYWRlci5weQorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvaW5zcGVjdG9yL3NjcmlwdHMvY29kZWdlbi9nZW5lcmF0ZV9jcHBfcHJvdG9jb2xfdHlwZXNf aGVhZGVyLnB5CkBAIC0yOTEsNyArMjkxLDcgQEAgY2xhc3MgQ3BwUHJvdG9jb2xUeXBlc0hlYWRl ckdlbmVyYXRvcihDcHBHZW5lcmF0b3IpOgogCiAgICAgZGVmIF9nZW5lcmF0ZV9zdHJ1Y3RfZm9y X2Fub255bW91c19lbnVtX21lbWJlcihzZWxmLCBlbnVtX21lbWJlcik6CiAgICAgICAgIGRlZiBh cHBseV9pbmRlbnRhdGlvbihsaW5lKToKLSAgICAgICAgICAgIGlmIGxpbmUuc3RhcnRzd2l0aCgo JyMnLCAnLyonLCAnKi8nLCAnLy8nKSkgb3IgbGVuKGxpbmUpIGlzIDA6CisgICAgICAgICAgICBp ZiBsaW5lLnN0YXJ0c3dpdGgoKCcjJywgJy8qJywgJyovJywgJy8vJykpIG9yIGxlbihsaW5lKSA9 PSAwOgogICAgICAgICAgICAgICAgIHJldHVybiBsaW5lCiAgICAgICAgICAgICBlbHNlOgogICAg ICAgICAgICAgICAgIHJldHVybiAnICAgICcgKyBsaW5lCg==