212463 2020-05-28 05:28:04 -0700 Add .editorconfig 2020-06-04 11:02:22 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=212763 InRadar P2 Normal --- 1 yoshiaki.jitsukawa yoshiaki.jitsukawa darin don.olmstead fujii mark.lam webkit-bug-importer ysuzuki oldest_to_newest 1656816 0 yoshiaki.jitsukawa 2020-05-28 05:28:04 -0700 Add .editorconfig mainly for Visual Studio. 1656818 1 400446 yoshiaki.jitsukawa 2020-05-28 05:37:26 -0700 Created attachment 400446 Patch 1656973 2 400498 yoshiaki.jitsukawa 2020-05-28 13:05:27 -0700 Created attachment 400498 Patch 1656976 3 yoshiaki.jitsukawa 2020-05-28 13:07:06 -0700 Removed "root" in order to honor parent .editorconfig user may be using. 1658187 4 yoshiaki.jitsukawa 2020-06-02 00:42:36 -0700 Thanks for the review! 1658189 5 ews-feeder 2020-06-02 00:44:52 -0700 Committed r262408: <https://trac.webkit.org/changeset/262408> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400498. 1658190 6 webkit-bug-importer 2020-06-02 00:45:18 -0700 <rdar://problem/63863651> 1659085 7 400498 mark.lam 2020-06-04 07:05:58 -0700 Comment on attachment 400498 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=400498&action=review > .editorconfig:8 > +trim_trailing_whitespace = true Why this? As a result of this change, it's forcing my editor (bbedit) to trim trailing whitespaces in a file every time I save. That makes for a lot of unrelated changes on every patch. Is this really necessary? 1659134 8 ysuzuki 2020-06-04 09:57:30 -0700 (In reply to Mark Lam from comment #7) > Comment on attachment 400498 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=400498&action=review > > > .editorconfig:8 > > +trim_trailing_whitespace = true > > Why this? As a result of this change, it's forcing my editor (bbedit) to > trim trailing whitespaces in a file every time I save. That makes for a lot > of unrelated changes on every patch. Is this really necessary? Yeah, I think we should remove this line from .editorconfig. I'm working around this issue by adding let g:EditorConfig_disable_rules = ['trim_trailing_whitespace'] to my .vimrc :P 400446 2020-05-28 05:37:26 -0700 2020-05-28 13:05:23 -0700 Patch bug-212463-20200528213724.patch text/plain 1497 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMjI1CmRpZmYgLS1naXQgYS8uZWRpdG9yY29uZmlnIGIv LmVkaXRvcmNvbmZpZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wNTcwZDA4MzlhZTE2ZTE0ODQ0OTQwNzY0YTA2ZDI3 MjZiNzQ2ZThjCi0tLSAvZGV2L251bGwKKysrIGIvLmVkaXRvcmNvbmZpZwpAQCAtMCwwICsxLDI2 IEBACisjIEVkaXRvciBjb25maWd1cmF0aW9uLCBzZWUgaHR0cDovL2VkaXRvcmNvbmZpZy5vcmcK KworIyB0b3AtbW9zdCBFZGl0b3JDb25maWcgZmlsZQorcm9vdCA9IHRydWUKKworWyoue2MsY3Bw LGh9XQoraW5kZW50X3N0eWxlID0gc3BhY2UKK2luZGVudF9zaXplID0gNAordGFiX3dpZHRoID0g NAorZW5kX29mX2xpbmUgPSBsZgordHJpbV90cmFpbGluZ193aGl0ZXNwYWNlID0gdHJ1ZQoraW5z ZXJ0X2ZpbmFsX25ld2xpbmUgPSB0cnVlCisKK1t7Q01ha2VMaXN0cy50eHQsKi5jbWFrZX1dCitp bmRlbnRfc3R5bGUgPSBzcGFjZQorZW5kX29mX2xpbmUgPSBsZgordHJpbV90cmFpbGluZ193aGl0 ZXNwYWNlID0gdHJ1ZQoraW5zZXJ0X2ZpbmFsX25ld2xpbmUgPSB0cnVlCisKK1suZWRpdG9yY29u ZmlnXQoraW5kZW50X3N0eWxlID0gc3BhY2UKK2luZGVudF9zaXplID0gNAordGFiX3dpZHRoID0g NAorZW5kX29mX2xpbmUgPSBsZgordHJpbV90cmFpbGluZ193aGl0ZXNwYWNlID0gdHJ1ZQoraW5z ZXJ0X2ZpbmFsX25ld2xpbmUgPSB0cnVlCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VM b2cKaW5kZXggMWYyZWFhYmM2NzE3ZWE1MWMwNjIxMWQ3NGFkZDAwM2UzMzgyZmJhMy4uOTI2MDAx MDA2YWYzOWFlMGI5ZWFhMmViMzc2MTE5NThkOGQ2NzhhOSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9n CisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA1LTI4ICBZb3NoaWFraSBK SVRTVUtBV0EgIDx5b3NoaWFraS5qaXRzdWthd2FAc29ueS5jb20+CisKKyAgICAgICAgQWRkIC5l ZGl0b3Jjb25maWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIxMjQ2MworCisgICAgICAgIEFkZCAuZWRpdG9yY29uZmlnIGZvciBWaXN1YWwgU3R1ZGlv LgorICAgICAgICAKKyAgICAgICAgSW5pdGFsbHkgZm9sbG93aW5nIGZpbGUgdHlwZXMgYXJlIHN1 cHBvcnRlZDoKKyAgICAgICAgICAtIC5oLy5jLy5jcHAKKyAgICAgICAgICAtIENNYWtlRmlsZWxp c3QudHh0Ly5jbWFrZQorICAgICAgICAgIC0gLmVkaXRvcmNvbmZpZyBpdHNlbGYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIC5lZGl0b3Jjb25maWc6 IEFkZGVkLgorCiAyMDIwLTA1LTI3ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFVwZGF0ZSBNb2JpbGVNaW5pQnJvd3NlciBwcm9qZWN0IHNldHRpbmdzIHRv IGN1cnJlbnQgWGNvZGUK 400498 2020-05-28 13:05:27 -0700 2020-06-02 00:44:53 -0700 Patch bug-212463-20200529050526.patch text/plain 1452 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMjI1CmRpZmYgLS1naXQgYS8uZWRpdG9yY29uZmlnIGIv LmVkaXRvcmNvbmZpZwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44YzkzYzdhZWM0ZTVlNjBlNmM2Y2IyYzg3YjBlYzNh MTY4N2EzMmQyCi0tLSAvZGV2L251bGwKKysrIGIvLmVkaXRvcmNvbmZpZwpAQCAtMCwwICsxLDIz IEBACisjIEVkaXRvciBjb25maWd1cmF0aW9uLCBzZWUgaHR0cDovL2VkaXRvcmNvbmZpZy5vcmcK KworWyoue2MsY3BwLGh9XQoraW5kZW50X3N0eWxlID0gc3BhY2UKK2luZGVudF9zaXplID0gNAor dGFiX3dpZHRoID0gNAorZW5kX29mX2xpbmUgPSBsZgordHJpbV90cmFpbGluZ193aGl0ZXNwYWNl ID0gdHJ1ZQoraW5zZXJ0X2ZpbmFsX25ld2xpbmUgPSB0cnVlCisKK1t7Q01ha2VMaXN0cy50eHQs Ki5jbWFrZX1dCitpbmRlbnRfc3R5bGUgPSBzcGFjZQorZW5kX29mX2xpbmUgPSBsZgordHJpbV90 cmFpbGluZ193aGl0ZXNwYWNlID0gdHJ1ZQoraW5zZXJ0X2ZpbmFsX25ld2xpbmUgPSB0cnVlCisK K1suZWRpdG9yY29uZmlnXQoraW5kZW50X3N0eWxlID0gc3BhY2UKK2luZGVudF9zaXplID0gNAor dGFiX3dpZHRoID0gNAorZW5kX29mX2xpbmUgPSBsZgordHJpbV90cmFpbGluZ193aGl0ZXNwYWNl ID0gdHJ1ZQoraW5zZXJ0X2ZpbmFsX25ld2xpbmUgPSB0cnVlCmRpZmYgLS1naXQgYS9DaGFuZ2VM b2cgYi9DaGFuZ2VMb2cKaW5kZXggMWYyZWFhYmM2NzE3ZWE1MWMwNjIxMWQ3NGFkZDAwM2UzMzgy ZmJhMy4uOTI2MDAxMDA2YWYzOWFlMGI5ZWFhMmViMzc2MTE5NThkOGQ2NzhhOSAxMDA2NDQKLS0t IGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTA1LTI4 ICBZb3NoaWFraSBKSVRTVUtBV0EgIDx5b3NoaWFraS5qaXRzdWthd2FAc29ueS5jb20+CisKKyAg ICAgICAgQWRkIC5lZGl0b3Jjb25maWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIxMjQ2MworCisgICAgICAgIEFkZCAuZWRpdG9yY29uZmlnIGZvciBW aXN1YWwgU3R1ZGlvLgorICAgICAgICAKKyAgICAgICAgSW5pdGFsbHkgZm9sbG93aW5nIGZpbGUg dHlwZXMgYXJlIHN1cHBvcnRlZDoKKyAgICAgICAgICAtIC5oLy5jLy5jcHAKKyAgICAgICAgICAt IENNYWtlRmlsZWxpc3QudHh0Ly5jbWFrZQorICAgICAgICAgIC0gLmVkaXRvcmNvbmZpZyBpdHNl bGYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIC5l ZGl0b3Jjb25maWc6IEFkZGVkLgorCiAyMDIwLTA1LTI3ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVwZGF0ZSBNb2JpbGVNaW5pQnJvd3NlciBwcm9qZWN0 IHNldHRpbmdzIHRvIGN1cnJlbnQgWGNvZGUK