212453 2020-05-27 19:19:07 -0700 [GTK] Gamepad events do not occur in the flatpak shell. 2022-09-17 13:38:41 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Linux RESOLVED FIXED https://github.com/flatpak/flatpak/issues/7 P2 Normal --- 133847 1 changseok aperez aperez bugs-noreply bugzilla clopez mcatanzaro pgriffis pnormand oldest_to_newest 1656735 0 changseok 2020-05-27 19:19:07 -0700 After the gtk port moved to flatpak SDK, any signal from gamepads is not detected by webkit. Perhaps, sandbox of flatpak shell involved but it is not sure. https://github.com/flatpak/flatpak/issues/7 1656793 1 pnormand 2020-05-28 02:15:19 -0700 Maybe Patrick could help here? 1657284 2 pnormand 2020-05-29 09:25:38 -0700 ChangSeok, can you check if patching the bubblewrap launcher like in https://bugs.webkit.org/show_bug.cgi?id=212524 would help? 1657285 3 pnormand 2020-05-29 09:27:39 -0700 Ah sorry, it might not help. If I understand the CMake option for this, the launcher is disabled when we build from the SDK: if (CMAKE_SYSTEM_NAME MATCHES "Linux" AND NOT EXISTS "/.flatpak-info") WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BUBBLEWRAP_SANDBOX PUBLIC ON) else () WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BUBBLEWRAP_SANDBOX PUBLIC OFF) endif () 1657484 4 changseok 2020-05-29 16:05:57 -0700 (In reply to Philippe Normand from comment #3) > Ah sorry, it might not help. If I understand the CMake option for this, the > launcher is disabled when we build from the SDK: > > if (CMAKE_SYSTEM_NAME MATCHES "Linux" AND NOT EXISTS "/.flatpak-info") > WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BUBBLEWRAP_SANDBOX PUBLIC ON) > else () > WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BUBBLEWRAP_SANDBOX PUBLIC OFF) > endif () You are right. The SDK based webkit build disables ENABLE_BUBBLEWRAP_SANDBOX. I tried to forcedly enable it in flatpak shell but I couldn't since bwrap is not available in the shell. 1699344 5 aperez 2020-10-19 11:54:53 -0700 The following merge request makes libmanette usable inside Flatpak: https://gitlab.gnome.org/aplazas/libmanette/-/merge_requests/19 The library needs to be built passing “-Dgudev=disabled” to Meson, and libmanette will fall back to using “GFileMonitor” on ”/dev/input/*” to find supported devices, which works inside the Flatpak sandbox if the application has been configured with “--device=all”, but I suspect that “--filesystem=/dev/input:ro” might work. 1699378 6 aperez 2020-10-19 12:44:04 -0700 (In reply to Adrian Perez from comment #5) > The following merge request makes libmanette usable inside Flatpak: > > https://gitlab.gnome.org/aplazas/libmanette/-/merge_requests/19 > > The library needs to be built passing “-Dgudev=disabled” to Meson, and > libmanette will fall back to using “GFileMonitor” on ”/dev/input/*” to > find supported devices, which works inside the Flatpak sandbox if the > application has been configured with “--device=all”, but I suspect that > “--filesystem=/dev/input:ro” might work. It turns out that we already have “--device=all” somewhere, checked with: % webkit-flatpak -c grep devices /.flatpak-info devices=dri;all; % So for *development* the only moving part missing is compiling libmanette with “-Dgudev=disabled” and then game pads should work in the MiniBrowser for development 🙌️ 1699380 7 411777 aperez 2020-10-19 12:48:26 -0700 Created attachment 411777 Patch 1699667 8 ews-feeder 2020-10-20 03:53:43 -0700 Committed r268721: <https://trac.webkit.org/changeset/268721> All reviewed patches have been landed. Closing bug and clearing flags on attachment 411777. 411777 2020-10-19 12:48:26 -0700 2020-10-20 03:53:44 -0700 Patch bug-212453-20201019224824.patch text/plain 1590 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjY4Njc0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTY0NWRmNjlmZjVlN2U1ZDdkMTE3YmQxZGJlMjM5NDUw N2M0NGY0NS4uNDNiNzdhMGMwMjdkNThjOGZkN2Y5N2I5MjQ0ODA0ZWI2YzNlMzQ4ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIwLTEwLTE5ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW0dUS10gR2FtZXBhZCBldmVudHMgZG8gbm90IG9jY3VyIGluIHRoZSBm bGF0cGFrIHNoZWxsLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjEyNDUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSWYgdGhlIHN1cHBvcnQgZm9yIGd1ZGV2IGlzIGRpc2FibGVkIGluIGxpYm1hbmV0dGUs IGl0IGZhbGxzIGJhY2sgdG8gbW9uaXRvcmluZyB0aGUKKyAgICAgICAgZmlsZXMgdW5kZXIgL2Rl di9pbnB1dCBieSBpdHNlbGYgd2l0aG91dCB0cnlpbmcgdG8gdXNlIHVkZXYgYXQgYWxsLiBUaGlz IHdvcmtzIGZpbmUKKyAgICAgICAgYmVjYXVzZSB0aGUgRmxhdHBhayBTREsgZW52aXJvbm1lbnQg aGFzIGFjY2VzcyB0byBhbGwgb2YgL2Rldi4KKworICAgICAgICAqIGJ1aWxkc3RyZWFtL2VsZW1l bnRzL3Nkay9saWJtYW5ldHRlLmJzdDogUGFzcyAtRGd1ZGV2PWRpc2FibGVkIHRvIE1lc29uLCBh bmQgcmVtb3ZlCisgICAgICAgIHRoZSBsaWJndWRldiBkZXBlbmRlbmN5IGZyb20gdGhlIGVsZW1l bnQuCisKIDIwMjAtMTAtMTkgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtidWlsZC53ZWJraXQub3JnXSBVc2UgZmVhdHVyZSBmbGFnIHRvIHN1cHBvcnQg QnVpbGRib3QgMiBjb2RlCmRpZmYgLS1naXQgYS9Ub29scy9idWlsZHN0cmVhbS9lbGVtZW50cy9z ZGsvbGlibWFuZXR0ZS5ic3QgYi9Ub29scy9idWlsZHN0cmVhbS9lbGVtZW50cy9zZGsvbGlibWFu ZXR0ZS5ic3QKaW5kZXggYmVjOWEwNDZmMTllNGI1ZTY1YjNmZTU5YjBiMTAzZDcxYWU3NmQwMS4u MjlkNmIzNTY4YWNkZTFjZTllMDc4YjQ5NDU3ZjJhNzMxNjliN2RmMiAxMDA2NDQKLS0tIGEvVG9v bHMvYnVpbGRzdHJlYW0vZWxlbWVudHMvc2RrL2xpYm1hbmV0dGUuYnN0CisrKyBiL1Rvb2xzL2J1 aWxkc3RyZWFtL2VsZW1lbnRzL3Nkay9saWJtYW5ldHRlLmJzdApAQCAtMTEsMTAgKzExLDkgQEAg YnVpbGQtZGVwZW5kczoKIGRlcGVuZHM6CiAtIHNkay9nbGliLmJzdAogLSBmcmVlZGVza3RvcC1z ZGsuYnN0OmJvb3RzdHJhcC1pbXBvcnQuYnN0Ci0tIGZyZWVkZXNrdG9wLXNkay5ic3Q6Y29tcG9u ZW50cy9saWJndWRldi5ic3QKLS0gZnJlZWRlc2t0b3Atc2RrLmJzdDpjb21wb25lbnRzL2xpYmV2 ZGV2LmJzdAogCiB2YXJpYWJsZXM6CiAgIG1lc29uLWxvY2FsOiA+LQogICAgIC1EdmFwaT1mYWxz ZQogICAgIC1EaW50cm9zcGVjdGlvbj1mYWxzZQorICAgIC1EZ3VkZXY9ZGlzYWJsZWQK