212450 2020-05-27 17:54:07 -0700 [WebInspectorUI] Inconsistent check for WI.ImageUtilities.supportsCanvasPathDebugging 2020-05-27 18:35:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yoshiaki.jitsukawa yoshiaki.jitsukawa don.olmstead ews-watchlist hi inspector-bugzilla-changes ross.kirsling webkit-bug-importer oldest_to_newest 1656705 0 yoshiaki.jitsukawa 2020-05-27 17:54:07 -0700 In RecordContentView.js _updateCanvasPath() should not be called if CanvasPathDebugging is not supported otherwise _updateCanvasPath() tries to access _showPathButtonNavigationItem, which is created only if CanvasPathDebugging is supported, but fails and raises an exception. 1656709 1 400414 yoshiaki.jitsukawa 2020-05-27 18:03:52 -0700 Created attachment 400414 Patch 1656711 2 400414 hi 2020-05-27 18:09:59 -0700 Comment on attachment 400414 Patch r=me, good catch! 1656713 3 yoshiaki.jitsukawa 2020-05-27 18:19:01 -0700 (In reply to Devin Rousso from comment #2) > Comment on attachment 400414 [details] > Patch > > r=me, good catch! Thank you for the prompt review :) 1656719 4 ews-feeder 2020-05-27 18:34:35 -0700 Committed r262230: <https://trac.webkit.org/changeset/262230> All reviewed patches have been landed. Closing bug and clearing flags on attachment 400414. 1656720 5 webkit-bug-importer 2020-05-27 18:35:15 -0700 <rdar://problem/63699679> 400414 2020-05-27 18:03:52 -0700 2020-05-27 18:34:36 -0700 Patch bug-212450-20200528100351.patch text/plain 2158 yoshiaki.jitsukawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjYyMjI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAx YjJkYWE1MTY5NWQxYzEyYjEwYTQ3YzYyNTg0ZDgwYWJjMTQ0ZjM5Li4zYWE4OTAxOTI3MmM3NWU0 MDIzYzQ4MDVmOTYyZWM3ODhjMDIwNGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMC0wNS0yOCAgWW9zaGlha2kgSklUU1VLQVdBICA8eW9zaGlha2kuaml0 c3VrYXdhQHNvbnkuY29tPgorCisgICAgICAgIFtXZWJJbnNwZWN0b3JVSV0gSW5jb25zaXN0ZW50 IGNoZWNrIGZvciBXSS5JbWFnZVV0aWxpdGllcy5zdXBwb3J0c0NhbnZhc1BhdGhEZWJ1Z2dpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxMjQ1MAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIFJlY29y ZENvbnRlbnRWaWV3LmpzIF91cGRhdGVDYW52YXNQYXRoKCkgc2hvdWxkIG5vdCBiZSBjYWxsZWQg aWYgQ2FudmFzUGF0aERlYnVnZ2luZworICAgICAgICBpcyBub3Qgc3VwcG9ydGVkIG90aGVyd2lz ZSBfdXBkYXRlQ2FudmFzUGF0aCgpIHRyaWVzIHRvIGFjY2VzcyBfc2hvd1BhdGhCdXR0b25OYXZp Z2F0aW9uSXRlbSwKKyAgICAgICAgd2hpY2ggaXMgY3JlYXRlZCBvbmx5IGlmIENhbnZhc1BhdGhE ZWJ1Z2dpbmcgaXMgc3VwcG9ydGVkLCBidXQgZmFpbHMgYW5kIHJhaXNlcyBhbiBleGNlcHRpb24u CisgICAgICAgIAorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvUmVjb3JkaW5nQ29udGVu dFZpZXcuanM6CisgICAgICAgIENoZWNrIGlmIFdJLkltYWdlVXRpbGl0aWVzLnN1cHBvcnRzQ2Fu dmFzUGF0aERlYnVnZ2luZygpIGJlZm9yZQorICAgICAgICBjYWxsaW5nIF91cGRhdGVDYW52YXNQ YXRoKCkKKwogMjAyMC0wNS0yNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogcmVwbGFjZSBgZmVhdHVyZUd1YXJkYCBhbmQgYGF2YWls YWJpbGl0eWAgd2l0aCBhIGNvbWJpbmVkIGBjb25kaXRpb25gIHRoYXQgYWNjZXB0cyBhbnkgbWFj cm8KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1JlY29yZGluZ0NvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUmVjb3JkaW5nQ29udGVudFZpZXcuanMKaW5kZXggYmZlMDMzZTE1MGYwOThl MWEzMWRmYjMzZTBiMTBiODRmZWM0NzEwZi4uNDAyMDA5MDljMTdjM2NjNmVhM2QwZjhhYzY1MzI0 NTkyOWZhMzVjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvUmVjb3JkaW5nQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVjb3JkaW5nQ29udGVudFZpZXcuanMKQEAgLTEyOCw3 ICsxMjgsNyBAQCBXSS5SZWNvcmRpbmdDb250ZW50VmlldyA9IGNsYXNzIFJlY29yZGluZ0NvbnRl bnRWaWV3IGV4dGVuZHMgV0kuQ29udGVudFZpZXcKICAgICAgICAgbGV0IGlzQ2FudmFzV2ViR0wg PSB0aGlzLnJlcHJlc2VudGVkT2JqZWN0LnR5cGUgPT09IFdJLlJlY29yZGluZy5UeXBlLkNhbnZh c1dlYkdMOwogICAgICAgICBsZXQgaXNDYW52YXNXZWJHTDIgPSB0aGlzLnJlcHJlc2VudGVkT2Jq ZWN0LnR5cGUgPT09IFdJLlJlY29yZGluZy5UeXBlLkNhbnZhc1dlYkdMMjsKICAgICAgICAgaWYg KGlzQ2FudmFzMkQgfHwgaXNDYW52YXNCaXRtYXBSZW5kZXJlciB8fCBpc0NhbnZhc1dlYkdMIHx8 IGlzQ2FudmFzV2ViR0wyKSB7Ci0gICAgICAgICAgICBpZiAoaXNDYW52YXMyRCkKKyAgICAgICAg ICAgIGlmIChpc0NhbnZhczJEICYmIFdJLkltYWdlVXRpbGl0aWVzLnN1cHBvcnRzQ2FudmFzUGF0 aERlYnVnZ2luZygpKQogICAgICAgICAgICAgICAgIHRoaXMuX3VwZGF0ZUNhbnZhc1BhdGgoKTsK ICAgICAgICAgICAgIHRoaXMuX3VwZGF0ZUltYWdlR3JpZCgpOwogICAgICAgICB9Cg==